@dxos/react-ui-editor 0.3.10 → 0.3.11-main.0ac3ef5

package/src/extensions/comments.ts

@@ -0,0 +1,325 @@
+//
+// Copyright 2023 DXOS.org
+//
+
+import { type Extension, StateEffect, StateField } from '@codemirror/state';
+import { hoverTooltip, keymap, type Command, Decoration, EditorView, type Rect } from '@codemirror/view';
+import sortBy from 'lodash.sortby';
+
+import { debounce } from '@dxos/async';
+import { invariant } from '@dxos/invariant';
+import { log } from '@dxos/log';
+import { nonNullable } from '@dxos/util';
+
+import { Cursor } from './cursor';
+import { type CommentRange, type EditorModel, type Range } from '../hooks';
+import { getToken } from '../styles';
+import { callbackWrapper } from '../util';
+
+// TODO(burdon): Handle delete, cut, copy, and paste (separately) text that includes comment range.
+// TODO(burdon): Consider breaking into separate plugin (since not standalone)? Like mermaid?
+
+// TODO(burdon): Reconcile with theme.
+const styles = EditorView.baseTheme({
+  '& .cm-comment': {
+    backgroundColor: getToken('extend.colors.yellow.50'),
+  },
+  '& .cm-comment-active': {
+    backgroundColor: getToken('extend.colors.yellow.100'),
+  },
+});
+
+const marks = {
+  highlight: Decoration.mark({ class: 'cm-comment' }),
+  highlightActive: Decoration.mark({ class: 'cm-comment-active' }),
+};
+
+// TODO(burdon): Should this be part of state?
+type CommentSelected = {
+  active?: string;
+  closest?: string;
+};
+
+// TODO(burdon): Rename.
+type ExtendedCommentRange = Range &
+  CommentRange & {
+    // TODO(burdon): Not part of state; just required for callback.
+    location?: Rect | null;
+  };
+
+export type CommentsState = CommentSelected & {
+  ranges: ExtendedCommentRange[];
+};
+
+export const setFocus = (view: EditorView, thread: string) => {
+  const range = view.state.field(commentsStateField).ranges.find((range) => range.id === thread);
+  if (!range) {
+    return;
+  }
+
+  view.dispatch({
+    effects: setSelection.of({ active: thread }),
+    selection: { anchor: range.from },
+    scrollIntoView: true,
+  });
+};
+
+export const setCommentRange = StateEffect.define<{ model: EditorModel; comments: CommentRange[] }>();
+
+export const setSelection = StateEffect.define<CommentSelected>();
+
+const setCommentState = StateEffect.define<CommentsState>();
+
+/**
+ * State field (reducer) that tracks comment ranges.
+ * The ranges are tracked as codemirror ranges (i.e., not relative YJS/Automerge positions), and
+ * therefore must be updated when the document changes.
+ */
+const commentsStateField = StateField.define<CommentsState>({
+  create: () => ({ ranges: [] }),
+  update: (value, tr) => {
+    const cursorConverter = tr.state.facet(Cursor.converter);
+
+    for (const effect of tr.effects) {
+      // Update selection.
+      if (effect.is(setSelection)) {
+        return { ...value, ...effect.value };
+      }
+
+      // Update range from store.
+      if (effect.is(setCommentRange)) {
+        const { comments } = effect.value;
+        const ranges: ExtendedCommentRange[] = comments
+          .map((comment) => {
+            const range = Cursor.getRangeFromCursor(cursorConverter, comment.cursor);
+            return range && { ...comment, ...range };
+          })
+          .filter(nonNullable);
+
+        return { ...value, ranges };
+      }
+
+      // Update entire state.
+      if (effect.is(setCommentState)) {
+        return effect.value;
+      }
+    }
+
+    return value;
+  },
+});
+
+/**
+ * Decorate ranges.
+ */
+const highlightDecorations = EditorView.decorations.compute([commentsStateField], (state) => {
+  const { active, ranges } = state.field(commentsStateField);
+  const decorations =
+    sortBy(ranges ?? [], (range) => range.from)
+      ?.flatMap((selection) => {
+        // TODO(burdon): Invalid range (e.g., deleted).
+        if (selection.from === selection.to) {
+          return undefined;
+        }
+
+        const range = { from: selection.from, to: selection.to };
+        if (selection.id === active) {
+          return marks.highlightActive.range(range.from, range.to);
+        } else {
+          return marks.highlight.range(range.from, range.to);
+        }
+      })
+      .filter(nonNullable) ?? [];
+
+  return Decoration.set(decorations);
+});
+
+export type CommentsOptions = {
+  key?: string;
+  footnote?: boolean;
+  /**
+   * Called to create a new thread and return the thread id.
+   */
+  onCreate?: (cursor: string, location?: Rect | null) => string | undefined;
+  /**
+   * Called to notify which thread is currently closest to the cursor.
+   */
+  onSelect?: (state: CommentsState) => void;
+  /**
+   * Called to render tooltip.
+   */
+  onHover?: (el: Element, shortcut: string) => void;
+};
+
+/**
+ * Comment threads.
+ * 1). Updates the EditorModel to store relative selections for a set of comments threads.
+ *     Since the selections are relative, they do not need to be updated when the document is edited.
+ * 2). Implements a StateField to track absolute selections corresponding to the comments (i.e., when the document is edited).
+ * 3). Creates decoration marks to apply classes to each selection.
+ * 4). Tracks the current cursor position to:
+ *     a). Update the decoration to show if the cursor is within a current selection.
+ *     b). Calls a handler to indicate which is the closest selection (e.g., to update the thread sidebar).
+ * 5). Optionally, inserts a markdown footnote when creating a comment thread.
+ * 6). Optionally, implements a hoverTooltip to show hints when creating a selection range.
+ */
+export const comments = (options: CommentsOptions = {}): Extension => {
+  const { key: shortcut = "meta-'" } = options;
+
+  const handleSelect = debounce((state: CommentsState) => options.onSelect?.(state), 200);
+
+  /**
+   * Create comment thread action.
+   */
+  const createCommentThread: Command = (view) => {
+    const cursorConverter = view.state.facet(Cursor.converter);
+
+    invariant(options.onCreate);
+    const { head, from, to } = view.state.selection.main;
+    if (from === to) {
+      return false;
+    }
+
+    const cursor = Cursor.getCursorFromRange(cursorConverter, { from, to });
+    if (cursor) {
+      // Create thread via callback.
+      const id = callbackWrapper(options.onCreate)(cursor, view.coordsAtPos(from));
+      if (id) {
+        // Update range.
+        view.dispatch({
+          effects: setSelection.of({ active: id }),
+          selection: { anchor: from },
+        });
+
+        // Insert footnote.
+        if (options.footnote) {
+          const tag = `[^${id}]`;
+          view.dispatch({
+            changes: { from: head, insert: tag },
+            selection: { anchor: head + tag.length },
+          });
+        }
+
+        return true;
+      }
+    }
+
+    return false;
+  };
+
+  return [
+    commentsStateField,
+    highlightDecorations,
+    styles,
+
+    //
+    // Keymap.
+    //
+    options.onCreate
+      ? keymap.of([
+          {
+            key: shortcut,
+            run: callbackWrapper(createCommentThread),
+          },
+        ])
+      : [],
+
+    //
+    // Hover tooltip (for key shortcut hints, etc.)
+    // TODO(burdon): Factor out to generic hints extension for current selection/line.
+    //
+    options.onHover
+      ? hoverTooltip(
+          (view, pos) => {
+            const selection = view.state.selection.main;
+            if (selection && pos >= selection.from && pos <= selection.to) {
+              return {
+                pos: selection.from,
+                end: selection.to,
+                above: true,
+                create: () => {
+                  // TODO(burdon): Dispatch to react callback to render (or use SSR)?
+                  const el = document.createElement('div');
+                  options.onHover?.(el, shortcut);
+                  return { dom: el, offset: { x: 0, y: 8 } };
+                },
+              };
+            }
+
+            return null;
+          },
+          { hideOnChange: true, hoverTime: 1000 },
+        )
+      : [],
+
+    //
+    // Monitor cursor movement and text updates.
+    // TODO(burdon): Is there a better (finer grained) way to do this?
+    //
+    EditorView.updateListener.of(({ view, state, changes }) => {
+      const cursorConverter = view.state.facet(Cursor.converter);
+
+      //
+      // Test if need to recompute indexed range if document changes before the end of the range.
+      //
+      {
+        let mod = false;
+        const { active, ranges } = state.field(commentsStateField);
+        changes.iterChanges((from, to, from2, to2) => {
+          ranges.forEach((range) => {
+            if (from2 === to2) {
+              const newRange = Cursor.getRangeFromCursor(cursorConverter, range.cursor);
+              if (!newRange || newRange.to - newRange.from === 0) {
+                // TODO(burdon): Delete range if empty.
+                log.info('deleted comment', { thread: range.id });
+              }
+            }
+
+            if (from <= range.to) {
+              const newRange = Cursor.getRangeFromCursor(cursorConverter, range.cursor);
+              Object.assign(range, newRange);
+              mod = true;
+            }
+          });
+        });
+
+        if (mod) {
+          view.dispatch({ effects: setCommentState.of({ active, ranges }) });
+        }
+      }
+
+      //
+      // Track the current selection.
+      //
+      {
+        const { head } = state.selection.main;
+
+        let min = Infinity;
+        const { active, closest, ranges } = state.field(commentsStateField);
+        const selected: CommentSelected = { active: undefined, closest: undefined };
+        ranges.forEach((comment) => {
+          const d = Math.min(Math.abs(head - comment.from), Math.abs(head - comment.to));
+          if (head >= comment.from && head <= comment.to) {
+            selected.active = comment.id;
+          }
+          if (d < min) {
+            selected.closest = comment.id;
+            min = d;
+          }
+        });
+
+        // TODO(burdon): Fire debounced callback if range selected (to show hint).
+
+        if (selected.active !== active || selected.closest !== closest) {
+          view.dispatch({ effects: setSelection.of(selected) });
+
+          // Update callback.
+          handleSelect({
+            ...selected,
+            ranges: ranges.map((range) => ({ ...range, location: view.coordsAtPos(range.from) })),
+          });
+        }
+      }
+    }),
+  ];
+};

package/src/extensions/cursor.ts

@@ -0,0 +1,46 @@
+//
+// Copyright 2024 DXOS.org
+//
+
+import { Facet } from '@codemirror/state';
+
+import type { Range } from '../hooks';
+
+/**
+ * Converts indexes into the text document into stable peer-independent cursors.
+ *
+ * See:
+ *  - https://automerge.org/automerge/api-docs/js/functions/next.getCursor.html
+ *  - https://github.com/yjs/yjs?tab=readme-ov-file#relative-positions
+ *
+ * @param {assoc} number Negative values will associate the cursor with the previous character
+ *                       while positive - with the next one.
+ */
+export interface CursorConverter {
+  toCursor(position: number, assoc?: -1 | 1 | undefined): string;
+  fromCursor(cursor: string): number;
+}
+
+const defaultCursorConverter: CursorConverter = {
+  toCursor: (position) => position.toString(),
+  fromCursor: (cursor) => parseInt(cursor),
+};
+
+export class Cursor {
+  static readonly converter = Facet.define<CursorConverter, CursorConverter>({
+    combine: (providers) => providers[0] ?? defaultCursorConverter,
+  });
+
+  static readonly getCursorFromRange = (cursorConverter: CursorConverter, range: Range) => {
+    const from = cursorConverter.toCursor(range.from);
+    const to = cursorConverter.toCursor(range.to, -1);
+    return [from, to].join(':');
+  };
+
+  static readonly getRangeFromCursor = (cursorConverter: CursorConverter, cursor: string) => {
+    const parts = cursor.split(':');
+    const from = cursorConverter.fromCursor(parts[0]);
+    const to = cursorConverter.fromCursor(parts[1]);
+    return from !== undefined && to !== undefined ? { from, to } : undefined;
+  };
+}

package/src/extensions/hr.ts

@@ -0,0 +1,73 @@
+//
+// Copyright 2023 DXOS.org
+//
+
+import {
+  Decoration,
+  type DecorationSet,
+  EditorView,
+  MatchDecorator,
+  ViewPlugin,
+  type ViewUpdate,
+  WidgetType,
+} from '@codemirror/view';
+
+import { getToken } from '../styles';
+
+// TODO(burdon): Reconcile with theme.
+const styles = EditorView.baseTheme({
+  '& .cm-hr': {
+    // TODO(burdon): ???
+    // Note that block-level decorations should not have vertical margins,
+    borderBottom: `1px solid ${getToken('extend.colors.neutral.200')}`,
+  },
+});
+
+class HorizontalRuleWidget extends WidgetType {
+  constructor(readonly _pos: number) {
+    super();
+  }
+
+  override eq(other: this) {
+    return this._pos === (other as any as HorizontalRuleWidget)._pos;
+  }
+
+  override toDOM(view: EditorView) {
+    // TODO(burdon): Create <hr> element? Does this clash with markdown parser?
+    const el = document.createElement('div');
+    el.className = 'cm-hr';
+    return el;
+  }
+}
+
+const placeholderMatcher = new MatchDecorator({
+  regexp: /^---$/g,
+  decoration: (match, view, pos) =>
+    Decoration.replace({
+      widget: new HorizontalRuleWidget(pos),
+    }),
+});
+
+export const hr = () => [
+  styles,
+  ViewPlugin.fromClass(
+    class {
+      rules: DecorationSet;
+      constructor(view: EditorView) {
+        this.rules = placeholderMatcher.createDeco(view);
+      }
+
+      update(update: ViewUpdate) {
+        this.rules = placeholderMatcher.updateDeco(update, this.rules);
+      }
+    },
+    {
+      decorations: (instance) => instance.rules,
+      // TODO(burdon): Is this really atomic (cursor can move into ---).
+      provide: (plugin) =>
+        EditorView.atomicRanges.of((view) => {
+          return view.plugin(plugin)?.rules || Decoration.none;
+        }),
+    },
+  ),
+];

package/src/extensions/image.ts

@@ -0,0 +1,87 @@
+//
+// Copyright 2023 DXOS.org
+//
+
+import { syntaxTree } from '@codemirror/language';
+import { type EditorState, type Extension, StateField, type Transaction, type Range } from '@codemirror/state';
+import { Decoration, type DecorationSet, EditorView, WidgetType } from '@codemirror/view';
+
+export type ImageOptions = {};
+
+export const image = (options: ImageOptions = {}): Extension => {
+  return StateField.define<DecorationSet>({
+    create: (state) => {
+      return Decoration.set(buildDecorations(0, state.doc.length, state));
+    },
+    update: (value: DecorationSet, tr: Transaction) => {
+      if (!tr.docChanged && !tr.selection) {
+        return value;
+      }
+      // Find range of changes and cursor changes.
+      const cursor = tr.state.selection.main.head;
+      const oldCursor = tr.changes.mapPos(tr.startState.selection.main.head);
+      let from = Math.min(cursor, oldCursor);
+      let to = Math.max(cursor, oldCursor);
+      tr.changes.iterChangedRanges((fromA, toA, fromB, toB) => {
+        from = Math.min(from, fromB);
+        to = Math.max(to, toB);
+      });
+      // Expand to cover lines
+      from = tr.state.doc.lineAt(from).from;
+      to = tr.state.doc.lineAt(to).to;
+      return value.map(tr.changes).update({
+        filterFrom: from,
+        filterTo: to,
+        filter: () => false,
+        add: buildDecorations(from, to, tr.state),
+      });
+    },
+    provide: (field) => EditorView.decorations.from(field),
+  });
+};
+
+const buildDecorations = (from: number, to: number, state: EditorState) => {
+  const decorations: Range<Decoration>[] = [];
+  const cursor = state.selection.main.head;
+
+  syntaxTree(state).iterate({
+    enter: (node) => {
+      if (node.name === 'Image') {
+        const urlNode = node.node.getChild('URL');
+        if (urlNode) {
+          const hide = state.readOnly || cursor < node.from || cursor > node.to;
+          const url = state.sliceDoc(urlNode.from, urlNode.to);
+          decorations.push(
+            Decoration.replace({
+              block: true, // Prevent cursor from entering.
+              widget: new ImageWidget(url),
+            }).range(hide ? node.from : node.to, node.to),
+          );
+        }
+      }
+    },
+    from,
+    to,
+  });
+
+  return decorations;
+};
+
+class ImageWidget extends WidgetType {
+  constructor(readonly _url: string) {
+    super();
+  }
+
+  override eq(other: this) {
+    return this._url === (other as any as ImageWidget)._url;
+  }
+
+  override toDOM(view: EditorView) {
+    const img = document.createElement('img');
+    img.setAttribute('src', this._url);
+    img.setAttribute('class', 'cm-image');
+    // Images are hidden until successfully loaded to avoid flickering effects.
+    img.onload = () => img.classList.add('cm-loaded-image');
+    return img;
+  }
+}

package/src/{components/TextEditor/extensions → extensions}/index.ts

@@ -3,12 +3,14 @@
 //
 
 export * from './autocomplete';
+export * from './automerge';
+export * from './awareness';
 export * from './basic';
 export * from './blast';
 export * from './code';
-export * from './demo';
 export * from './comments';
-export * from './highlight';
+export * from './cursor';
+export * from './hr';
 export * from './image';
 export * from './link';
 export * from './listener';
@@ -16,4 +18,5 @@ export * from './markdown';
 export * from './mention';
 export * from './table';
 export * from './tasklist';
-export * from './tooltip';
+export * from './typewriter';
+export * from './yjs';