@dxos/react-ui-chat 0.8.4-main.5ea62a8 → 0.8.4-main.66e292d

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dxos/react-ui-chat",
-  "version": "0.8.4-main.5ea62a8",
+  "version": "0.8.4-main.66e292d",
   "description": "Chat components.",
   "homepage": "https://dxos.org",
   "bugs": "https://github.com/dxos/dxos/issues",
@@ -24,50 +24,51 @@
     "src"
   ],
   "dependencies": {
-    "@codemirror/autocomplete": "^6.18.1",
-    "@codemirror/language": "^6.10.3",
-    "@codemirror/search": "^6.5.6",
-    "@codemirror/state": "^6.4.1",
-    "@codemirror/view": "^6.34.1",
+    "@codemirror/autocomplete": "^6.19.0",
+    "@codemirror/language": "^6.11.3",
+    "@codemirror/search": "^6.5.11",
+    "@codemirror/state": "^6.5.2",
+    "@codemirror/view": "^6.38.4",
+    "@fluentui/react-tabster": "^9.24.2",
     "@preact-signals/safe-react": "^0.9.0",
-    "@preact/signals-core": "^1.9.0",
+    "@preact/signals-core": "^1.12.1",
     "@radix-ui/react-accordion": "1.2.3",
     "@radix-ui/react-context": "1.1.1",
-    "@dxos/async": "0.8.4-main.5ea62a8",
-    "@dxos/debug": "0.8.4-main.5ea62a8",
-    "@dxos/invariant": "0.8.4-main.5ea62a8",
-    "@dxos/log": "0.8.4-main.5ea62a8",
-    "@dxos/live-object": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-components": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-dnd": "0.8.4-main.5ea62a8",
-    "@dxos/echo-schema": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-sfx": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-editor": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-syntax-highlighter": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-text-tooltip": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-theme": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-types": "0.8.4-main.5ea62a8",
-    "@dxos/util": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui": "0.8.4-main.5ea62a8"
+    "@dxos/async": "0.8.4-main.66e292d",
+    "@dxos/debug": "0.8.4-main.66e292d",
+    "@dxos/echo": "0.8.4-main.66e292d",
+    "@dxos/invariant": "0.8.4-main.66e292d",
+    "@dxos/live-object": "0.8.4-main.66e292d",
+    "@dxos/log": "0.8.4-main.66e292d",
+    "@dxos/react-ui-dnd": "0.8.4-main.66e292d",
+    "@dxos/react-ui-components": "0.8.4-main.66e292d",
+    "@dxos/react-ui": "0.8.4-main.66e292d",
+    "@dxos/react-ui-sfx": "0.8.4-main.66e292d",
+    "@dxos/react-ui-text-tooltip": "0.8.4-main.66e292d",
+    "@dxos/react-ui-theme": "0.8.4-main.66e292d",
+    "@dxos/react-ui-editor": "0.8.4-main.66e292d",
+    "@dxos/util": "0.8.4-main.66e292d",
+    "@dxos/react-ui-syntax-highlighter": "0.8.4-main.66e292d",
+    "@dxos/react-ui-types": "0.8.4-main.66e292d"
   },
   "devDependencies": {
-    "@types/react": "~18.2.0",
-    "@types/react-dom": "~18.2.0",
-    "effect": "3.17.7",
-    "react": "~18.2.0",
-    "react-dom": "~18.2.0",
-    "vite": "7.1.1",
-    "@dxos/echo": "0.8.4-main.5ea62a8",
-    "@dxos/random": "0.8.4-main.5ea62a8",
-    "@dxos/storybook-utils": "0.8.4-main.5ea62a8",
-    "@dxos/react-client": "0.8.4-main.5ea62a8"
+    "@types/react": "~19.2.2",
+    "@types/react-dom": "~19.2.2",
+    "effect": "3.18.3",
+    "react": "~19.2.0",
+    "react-dom": "~19.2.0",
+    "vite": "7.1.9",
+    "@dxos/echo": "0.8.4-main.66e292d",
+    "@dxos/random": "0.8.4-main.66e292d",
+    "@dxos/react-client": "0.8.4-main.66e292d",
+    "@dxos/storybook-utils": "0.8.4-main.66e292d"
   },
   "peerDependencies": {
     "effect": "^3.13.3",
-    "react": "~18.2.0",
-    "react-dom": "~18.2.0",
-    "@dxos/react-ui": "0.8.4-main.5ea62a8",
-    "@dxos/react-ui-theme": "0.8.4-main.5ea62a8"
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0",
+    "@dxos/react-ui": "0.8.4-main.66e292d",
+    "@dxos/react-ui-theme": "0.8.4-main.66e292d"
   },
   "publishConfig": {
     "access": "public"

package/src/components/ChatDialog/ChatDialog.stories.tsx

@@ -2,13 +2,11 @@
 // Copyright 2025 DXOS.org
 //
 
-import '@dxos-theme';
-
 import { type Meta, type StoryObj } from '@storybook/react-vite';
 import React, { useState } from 'react';
 
 import { Input, Toolbar } from '@dxos/react-ui';
-import { withLayout, withTheme } from '@dxos/storybook-utils';
+import { withLayout, withTheme } from '@dxos/react-ui/testing';
 
 import { translations } from '../../translations';
 
@@ -44,7 +42,7 @@ const meta = {
               </div>
             ))}
           </ChatDialog.Content>
-          <ChatDialog.Footer classNames='px-2 items-center'>
+          <ChatDialog.Footer classNames='pli-2 items-center'>
             <Input.Root>
               <Input.TextInput classNames='border-none' placeholder='Test' />
             </Input.Root>
@@ -53,7 +51,7 @@ const meta = {
       </>
     );
   },
-  decorators: [withTheme, withLayout({ fullscreen: true, classNames: 'flex flex-col' })],
+  decorators: [withTheme, withLayout({ container: 'column' })],
   parameters: {
     translations,
   },

package/src/components/ChatDialog/ChatDialog.tsx

@@ -14,7 +14,7 @@ const preventDefault = (event: Event) => event.preventDefault();
 // TODO(burdon): Factor out.
 const Endcap = ({ children }: PropsWithChildren) => {
   return (
-    <div className='grid w-[var(--rail-action)] h-[var(--rail-action)] items-center justify-center'>{children}</div>
+    <div className='grid is-[var(--rail-action)] bs-[var(--rail-action)] items-center justify-center'>{children}</div>
   );
 };
 
@@ -47,15 +47,15 @@ type ChatDialogRootProps = PropsWithChildren<{
 
 const ChatDialogRoot = ({
   children,
-  open: _open = false,
-  expanded: _expanded = false,
+  open: openParam = false,
+  expanded: expandedParam = false,
   onOpenChange,
   onExpandedChange,
   onEscape,
 }: ChatDialogRootProps) => {
   const [size, setSize] = useState<Size>('min-content');
-  const [open, setOpen] = useControlledState<boolean>(_open, onOpenChange);
-  const [expanded, setExpanded] = useControlledState<boolean>(_expanded, onExpandedChange);
+  const [open, setOpen] = useControlledState<boolean>(openParam, onOpenChange);
+  const [expanded, setExpanded] = useControlledState<boolean>(expandedParam, onExpandedChange);
 
   // NOTE: We set the min size to 5rem (80px), and the header and prompt bar to 40px (i.e., the rail-size) each.
   // The dialog has no vertical padding and has box-content so that when closed it collapses to the size of the header and prompt bar.
@@ -108,7 +108,7 @@ const ChatDialogHeader = ({ classNames, title }: ChatDialogHeaderProps) => {
         </Dialog.Close>
       </Endcap>
       <Dialog.Title
-        classNames='flex w-full justify-center text-sm text-subdued select-none cursor-pointer'
+        classNames='flex is-full justify-center text-sm text-subdued select-none cursor-pointer'
         onClick={() => setExpanded((expanded) => !expanded)}
       >
         {title}
@@ -144,7 +144,7 @@ const ChatDialogContent = ({ children, classNames }: ChatDialogContentProps) =>
   return (
     <div
       className={mx(
-        'flex flex-col overflow-y-auto border-t border-b border-subduedSeparator',
+        'flex flex-col overflow-y-auto border-t border-be border-subduedSeparator',
         'transition-[block-size] ease-in-out duration-0 [&:not([data-dx-resizing="true"])]:duration-200',
         classNames,
       )}

package/src/components/ChatEditor/ChatEditor.stories.tsx

@@ -2,12 +2,10 @@
 // Copyright 2025 DXOS.org
 //
 
-import '@dxos-theme';
-
 import { type Meta, type StoryObj } from '@storybook/react-vite';
 
 import { log } from '@dxos/log';
-import { withTheme } from '@dxos/storybook-utils';
+import { withTheme } from '@dxos/react-ui/testing';
 
 import { translations } from '../../translations';
 
@@ -26,7 +24,7 @@ const meta = {
 
 export default meta;
 
-const classNames = 'w-[20rem] p-2 border border-separator';
+const classNames = 'is-[20rem] p-2 border border-separator';
 
 type Story = StoryObj<typeof meta>;
 
@@ -36,31 +34,33 @@ export const Default: Story = {
   },
 };
 
+// TODO(burdon): Restore and reconcile with suggest/typeahead.
 export const WithSuggestions: Story = {
   args: {
     classNames,
     onSubmit: (text) => {
       log('onSubmit', { text });
     },
-    onSuggest: (text) => {
-      const trimmed = text.trim().toLowerCase();
-      if (trimmed.length < 2) {
-        return [];
-      }
+    // onSuggest: (text) => {
+    //   const trimmed = text.trim().toLowerCase();
+    //   if (trimmed.length < 2) {
+    //     return [];
+    //   }
 
-      const suggestions = [
-        'Create a kanban board',
-        'Create a new project',
-        'Find flights to Tokyo',
-        "Let's play chess",
-        'Show me Paris on a map',
-      ];
+    //   const suggestions = [
+    //     'Create a kanban board',
+    //     'Create a new project',
+    //     'Find flights to Tokyo',
+    //     "Let's play chess",
+    //     'Show me Paris on a map',
+    //   ];
 
-      return suggestions.filter((s) => s.toLowerCase().startsWith(text));
-    },
+    //   return suggestions.filter((s) => s.toLowerCase().startsWith(text));
+    // },
   },
 };
 
+// TODO(burdon): Replace.
 const references: ReferenceData[] = [
   {
     uri: 'dxn:echo:@:AAAAAAAA',

package/src/components/ChatEditor/ChatEditor.tsx

@@ -3,86 +3,57 @@
 //
 
 import { type Extension } from '@codemirror/state';
-import React, { forwardRef, useImperativeHandle } from 'react';
+import React, { forwardRef, useMemo } from 'react';
 
 import { type ThemedClassName, useThemeContext } from '@dxos/react-ui';
 import {
   type BasicExtensionsOptions,
+  Editor,
+  type EditorController,
+  type SubmitOptions,
   type UseTextEditorProps,
   createBasicExtensions,
   createThemeExtensions,
-  useTextEditor,
+  submit,
 } from '@dxos/react-ui-editor';
-import { mx } from '@dxos/react-ui-theme';
-import { isNonNullable } from '@dxos/util';
+import { isTruthy } from '@dxos/util';
 
-import { type AutocompleteOptions, autocomplete } from './autocomplete';
-import { type ReferencesOptions, references as referencesExtension } from './references';
+import { type ReferencesOptions } from './references';
 
-export interface ChatEditorController {
-  focus(): void;
-  getText(): string;
-  setText(text: string): void;
-}
+export interface ChatEditorController extends EditorController {}
 
 export type ChatEditorProps = ThemedClassName<
   {
     extensions?: Extension;
     references?: ReferencesOptions;
-  } & AutocompleteOptions &
+  } & (SubmitOptions &
     Pick<UseTextEditorProps, 'id' | 'autoFocus'> &
-    Pick<BasicExtensionsOptions, 'lineWrapping' | 'placeholder'>
+    Pick<BasicExtensionsOptions, 'lineWrapping' | 'placeholder'>)
 >;
 
-export const ChatEditor = forwardRef<ChatEditorController, ChatEditorProps>(
-  (
-    { classNames, extensions, references, autoFocus, lineWrapping = false, placeholder, onSubmit, onSuggest, onCancel },
-    forwardRef,
-  ) => {
-    const { themeMode } = useThemeContext();
+export const useChatExtensions = ({ extensions, lineWrapping = false, placeholder, onSubmit }: ChatEditorProps) => {
+  const { themeMode } = useThemeContext();
+  return useMemo<Extension[]>(
+    () =>
+      [
+        createThemeExtensions({ themeMode }),
+        createBasicExtensions({ bracketMatching: false, lineWrapping, placeholder }),
+        submit({ onSubmit }),
+        extensions,
+      ].filter(isTruthy),
+    [themeMode, extensions, onSubmit],
+  );
+};
 
-    const { parentRef, view } = useTextEditor(
-      () => ({
-        debug: true,
-        autoFocus,
-        extensions: [
-          createThemeExtensions({ themeMode }),
-          autocomplete({ onSubmit, onSuggest, onCancel }),
-          references ? referencesExtension({ provider: references.provider }) : [],
-          createBasicExtensions({
-            bracketMatching: false,
-            lineWrapping,
-            placeholder,
-          }),
-          extensions,
-        ].filter(isNonNullable),
-      }),
-      [themeMode, extensions, onSubmit, onSuggest, onCancel],
+export const ChatEditor = forwardRef<ChatEditorController, ChatEditorProps>(
+  ({ classNames, autoFocus, extensions: extensionsParam, lineWrapping = false, placeholder, onSubmit }, forwardRef) => {
+    const extensions = useChatExtensions({ extensions: extensionsParam, lineWrapping, placeholder, onSubmit });
+
+    // TODO(burdon): Popover.
+    return (
+      <Editor.Root ref={forwardRef}>
+        <Editor.Content classNames={classNames} autoFocus={autoFocus} extensions={extensions} />
+      </Editor.Root>
     );
-
-    // Expose editor view.
-    useImperativeHandle(forwardRef, () => {
-      return {
-        focus: () => {
-          view?.focus();
-        },
-        getText: () => view?.state.doc.toString() ?? '',
-        setText: (text: string) => {
-          view?.dispatch({
-            changes: {
-              from: 0,
-              to: view.state.doc.length,
-              insert: text,
-            },
-            selection: {
-              anchor: text.length,
-              head: text.length,
-            },
-          });
-        },
-      };
-    }, [view, onSubmit]);
-
-    return <div ref={parentRef} className={mx('is-full', classNames)} />;
   },
 );

package/src/components/ChatEditor/references.ts

@@ -19,10 +19,14 @@ import { invariant } from '@dxos/invariant';
 
 // TODO(dmaretskyi): Consider adding details renderer for when you hover over the reference.
 export type ReferenceData = {
-  uri: string;
+  uri: string; // TODO(burdon): Rename dxn.
   label: string;
 };
 
+/**
+ * @deprecated
+ */
+// TODO(burdon): Remove.
 export interface ReferencesProvider {
   getReferences({ query }: { query: string }): Promise<ReferenceData[]>;
   resolveReference({ uri }: { uri: string }): Promise<ReferenceData | null>;
@@ -45,7 +49,9 @@ export type ReferencesOptions = {
 
 /**
  * Lookup object references.
+ * @deprecated
  */
+// TODO(burdon): Remove.
 export const references = ({ provider, triggerCharacter = '@', debug = false }: ReferencesOptions): Extension => {
   invariant(triggerCharacter.length === 1);
 
@@ -103,7 +109,7 @@ export const references = ({ provider, triggerCharacter = '@', debug = false }:
     },
     {
       decorations: (v) => v.decorations,
-      provide: (plugin) => [
+      provide: () => [
         EditorView.atomicRanges.of(
           (view): DecorationSet => view.plugin(decorationField)?.decorations ?? RangeSet.empty,
         ),
@@ -158,18 +164,18 @@ class ReferenceWidget extends WidgetType {
     super();
   }
 
-  override toDOM(): HTMLSpanElement {
-    const span = document.createElement('span');
-    span.textContent = `@ ${this.data.label}`;
-    span.className = 'cm-reference-pill';
-    return span;
+  override ignoreEvent() {
+    return true;
   }
 
-  override eq(other: ReferenceWidget): boolean {
-    return other.data.uri === this.data.uri;
+  override eq(other: this) {
+    return this.data.uri === other.data.uri;
   }
 
-  override ignoreEvent(): boolean {
-    return true;
+  override toDOM() {
+    const span = document.createElement('span');
+    span.textContent = `@${this.data.label}`;
+    span.className = 'cm-reference-pill';
+    return span;
   }
 }

package/dist/types/src/components/ChatEditor/autocomplete.d.ts

@@ -1,26 +0,0 @@
-import { type Extension } from '@codemirror/state';
-export type AutocompleteOptions = {
-    fireIfEmpty?: boolean;
-    /**
-     * Callback triggered when Enter is pressed.
-     * @param text The current text in the editor
-     * @returns true if the editor should reset the document.
-     */
-    onSubmit?: (text: string) => boolean | void;
-    /**
-     * Function that returns a list of suggestions based on the current text.
-     * @param text The current text before the cursor
-     * @returns Array of suggestion strings
-     */
-    onSuggest?: (text: string) => string[];
-    /**
-     * ESC pressed.
-     */
-    onCancel?: () => void;
-};
-/**
- * Creates an autocomplete extension that shows inline suggestions.
- * Pressing Tab will complete the suggestion.
- */
-export declare const autocomplete: ({ fireIfEmpty, onSubmit, onSuggest, onCancel }: AutocompleteOptions) => Extension;
-//# sourceMappingURL=autocomplete.d.ts.map

package/dist/types/src/components/ChatEditor/autocomplete.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"autocomplete.d.ts","sourceRoot":"","sources":["../../../../../src/components/ChatEditor/autocomplete.ts"],"names":[],"mappings":"AAIA,OAAO,EAAE,KAAK,SAAS,EAAQ,MAAM,mBAAmB,CAAC;AAWzD,MAAM,MAAM,mBAAmB,GAAG;IAChC,WAAW,CAAC,EAAE,OAAO,CAAC;IAEtB;;;;OAIG;IACH,QAAQ,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,OAAO,GAAG,IAAI,CAAC;IAE5C;;;;OAIG;IACH,SAAS,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,EAAE,CAAC;IAEvC;;OAEG;IACH,QAAQ,CAAC,EAAE,MAAM,IAAI,CAAC;CACvB,CAAC;AAEF;;;GAGG;AAEH,eAAO,MAAM,YAAY,GAAI,gDAAgD,mBAAmB,KAAG,SA+JlG,CAAC"}

package/src/components/ChatEditor/autocomplete.ts

@@ -1,220 +0,0 @@
-//
-// Copyright 2025 DXOS.org
-//
-
-import { type Extension, Prec } from '@codemirror/state';
-import {
-  Decoration,
-  type DecorationSet,
-  EditorView,
-  ViewPlugin,
-  type ViewUpdate,
-  WidgetType,
-  keymap,
-} from '@codemirror/view';
-
-export type AutocompleteOptions = {
-  fireIfEmpty?: boolean;
-
-  /**
-   * Callback triggered when Enter is pressed.
-   * @param text The current text in the editor
-   * @returns true if the editor should reset the document.
-   */
-  onSubmit?: (text: string) => boolean | void;
-
-  /**
-   * Function that returns a list of suggestions based on the current text.
-   * @param text The current text before the cursor
-   * @returns Array of suggestion strings
-   */
-  onSuggest?: (text: string) => string[];
-
-  /**
-   * ESC pressed.
-   */
-  onCancel?: () => void;
-};
-
-/**
- * Creates an autocomplete extension that shows inline suggestions.
- * Pressing Tab will complete the suggestion.
- */
-// TODO(burdon): Move to react-ui-editor.
-export const autocomplete = ({ fireIfEmpty, onSubmit, onSuggest, onCancel }: AutocompleteOptions): Extension => {
-  const suggest = ViewPlugin.fromClass(
-    class {
-      _decorations: DecorationSet;
-      _currentSuggestion: string | null = null;
-
-      constructor(view: EditorView) {
-        this._decorations = this.computeDecorations(view);
-      }
-
-      update(update: ViewUpdate) {
-        if (update.docChanged || update.selectionSet) {
-          this._decorations = this.computeDecorations(update.view);
-        }
-      }
-
-      private computeDecorations(view: EditorView): DecorationSet {
-        const text = view.state.doc.toString();
-        const suggestions = onSuggest?.(text) ?? [];
-        if (!suggestions.length) {
-          this._currentSuggestion = null;
-          return Decoration.none;
-        }
-
-        // Get the first suggestion.
-        this._currentSuggestion = suggestions[0];
-        const suffix = this._currentSuggestion.slice(text.length);
-        if (!suffix) {
-          return Decoration.none;
-        }
-
-        // Always show ghost text at the end of the document.
-        return Decoration.set([
-          Decoration.widget({
-            widget: new InlineSuggestionWidget(suffix),
-            side: 1,
-          }).range(view.state.doc.length),
-        ]);
-      }
-
-      completeSuggestion(view: EditorView): boolean {
-        if (!this._currentSuggestion) {
-          return false;
-        }
-
-        const text = view.state.doc.toString();
-        const suffix = this._currentSuggestion.slice(text.length);
-        if (!suffix) {
-          return false;
-        }
-
-        view.dispatch({
-          changes: {
-            from: view.state.doc.length,
-            insert: suffix,
-          },
-          selection: {
-            anchor: view.state.doc.length + suffix.length,
-          },
-        });
-
-        return true;
-      }
-    },
-    {
-      decorations: (v) => v._decorations,
-    },
-  );
-
-  return [
-    suggest,
-    EditorView.theme({
-      '.cm-inline-suggestion': {
-        opacity: 0.4,
-      },
-    }),
-
-    Prec.highest(
-      keymap.of([
-        {
-          key: 'Tab',
-          preventDefault: true,
-          run: (view) => {
-            const plugin = view.plugin(suggest);
-            return plugin?.completeSuggestion(view) ?? false;
-          },
-        },
-        {
-          key: 'ArrowRight',
-          preventDefault: true,
-          run: (view) => {
-            // Only complete if cursor is at the end
-            if (view.state.selection.main.head !== view.state.doc.length) {
-              return false;
-            }
-
-            const plugin = view.plugin(suggest);
-            return plugin?.completeSuggestion(view) ?? false;
-          },
-        },
-        {
-          key: 'Enter',
-          preventDefault: true,
-          run: (view) => {
-            const text = view.state.doc.toString().trim();
-            if (onSubmit && (fireIfEmpty || text.length > 0)) {
-              const reset = onSubmit(text);
-
-              // Clear the document after calling onEnter.
-              if (reset) {
-                view.dispatch({
-                  changes: {
-                    from: 0,
-                    to: view.state.doc.length,
-                    insert: '',
-                  },
-                });
-              }
-            }
-
-            return true;
-          },
-        },
-        {
-          key: 'Shift-Enter',
-          preventDefault: true,
-          run: (view) => {
-            view.dispatch({
-              changes: {
-                from: view.state.selection.main.head,
-                insert: '\n',
-              },
-              selection: {
-                anchor: view.state.selection.main.head + 1,
-                head: view.state.selection.main.head + 1,
-              },
-            });
-            return true;
-          },
-        },
-        {
-          key: 'Escape',
-          preventDefault: true,
-          run: (view) => {
-            // Clear the entire document.
-            view.dispatch({
-              changes: {
-                from: 0,
-                to: view.state.doc.length,
-                insert: '',
-              },
-            });
-            onCancel?.();
-            return true;
-          },
-        },
-      ]),
-    ),
-  ];
-};
-
-class InlineSuggestionWidget extends WidgetType {
-  constructor(private suffix: string) {
-    super();
-  }
-
-  override toDOM(): HTMLSpanElement {
-    const span = document.createElement('span');
-    span.textContent = this.suffix;
-    span.className = 'cm-inline-suggestion';
-    return span;
-  }
-
-  override eq(other: InlineSuggestionWidget): boolean {
-    return other.suffix === this.suffix;
-  }
-}