@dxos/react-ui-calendar 0.8.4-main.fcfe5033a5 → 0.8.4-staging.60fe92afc8

package/src/components/Calendar/Calendar.tsx

@@ -3,9 +3,11 @@
 //
 
 import { createContext } from '@radix-ui/react-context';
-import { type Day, addDays, differenceInWeeks, format, startOfDay, startOfWeek } from 'date-fns';
+import { type Day, addDays, format, startOfDay, startOfWeek } from 'date-fns';
 import React, {
   type Dispatch,
+  type KeyboardEvent as ReactKeyboardEvent,
+  type PointerEvent as ReactPointerEvent,
   type PropsWithChildren,
   type SetStateAction,
   forwardRef,
@@ -21,16 +23,64 @@ import { List, type ListProps, type ListRowRenderer } from 'react-virtualized';
 
 import { Event } from '@dxos/async';
 import { IconButton, useTranslation } from '@dxos/react-ui';
-import { composable, composableProps, mx } from '@dxos/ui-theme';
+import { composable, composableProps } from '@dxos/react-ui';
+import { mx } from '@dxos/ui-theme';
 
-import { translationKey } from '../../translations';
-import { getDate, isSameDay } from './util';
+import { translationKey } from '#translations';
+
+import { getDate, getRowIndex, isSameDay } from './util';
 
 const maxRows = 50 * 100;
 const start = new Date('1970-01-01');
-const size = 48;
+const size = 40;
 const defaultWidth = 7 * size;
 
+// Auto-scroll while dragging near a vertical edge.
+const EDGE_SCROLL_ZONE = 32; // px
+const EDGE_SCROLL_MAX_SPEED = 12; // px per frame
+
+//
+// Range
+//
+
+/**
+ * Inclusive date range. `from <= to`. Both endpoints are anchored at the
+ * start of their day; callers should not rely on time-of-day precision.
+ */
+export type Range = {
+  from: Date;
+  to: Date;
+};
+
+/** Normalize an ordered pair of dates into a Range (start-of-day, from <= to). */
+const makeRange = (a: Date, b: Date): Range => {
+  const dayA = startOfDay(a);
+  const dayB = startOfDay(b);
+  return dayA <= dayB ? { from: dayA, to: dayB } : { from: dayB, to: dayA };
+};
+
+/** Inclusive day-level membership check. */
+const isInRange = (date: Date, range: Range | undefined): boolean => {
+  if (!range) {
+    return false;
+  }
+  const day = startOfDay(date).getTime();
+  return day >= range.from.getTime() && day <= range.to.getTime();
+};
+
+/** Resolve a DOM element back to the Date its cell represents. */
+const cellDate = (el: Element | null): Date | undefined => {
+  let current: Element | null = el;
+  while (current && current !== document.body) {
+    const iso = current.getAttribute?.('data-date');
+    if (iso) {
+      return new Date(iso);
+    }
+    current = current.parentElement;
+  }
+  return undefined;
+};
+
 //
 // Context
 //
@@ -47,6 +97,12 @@ type CalendarContextValue = {
   setIndex: Dispatch<SetStateAction<number | undefined>>;
   selected: Date | undefined;
   setSelected: Dispatch<SetStateAction<Date | undefined>>;
+  /** Committed date range, set by the most recent drag or shift+arrow selection. */
+  range: Range | undefined;
+  setRange: Dispatch<SetStateAction<Range | undefined>>;
+  /** Live drag preview; non-undefined only while the user is dragging. */
+  pendingRange: Range | undefined;
+  setPendingRange: Dispatch<SetStateAction<Range | undefined>>;
 };
 
 const [CalendarContextProvider, useCalendarContext] = createContext<CalendarContextValue>('Calendar');
@@ -70,6 +126,8 @@ const CalendarRoot = forwardRef<CalendarController, CalendarRootProps>(
     const event = useMemo(() => new Event<CalendarEvent>(), []);
     const [selected, setSelected] = useState<Date | undefined>();
     const [index, setIndex] = useState<number | undefined>();
+    const [range, setRange] = useState<Range | undefined>();
+    const [pendingRange, setPendingRange] = useState<Range | undefined>();
 
     useImperativeHandle(
       forwardedRef,
@@ -89,6 +147,10 @@ const CalendarRoot = forwardRef<CalendarController, CalendarRootProps>(
         setIndex={setIndex}
         selected={selected}
         setSelected={setSelected}
+        range={range}
+        setRange={setRange}
+        pendingRange={pendingRange}
+        setPendingRange={setPendingRange}
       >
         {children}
       </CalendarContextProvider>
@@ -143,8 +205,6 @@ CalendarToolbar.displayName = CALENDAR_TOOLBAR_NAME;
 
 //
 // Grid
-// TODO(burdon): Key nav.
-// TODO(burdon): Drag range.
 //
 
 const CALENDAR_GRID_NAME = 'CalendarGrid';
@@ -153,15 +213,30 @@ type CalendarGridProps = {
   rows?: number;
   /** Dates to highlight on the grid. Each date that appears in this array receives a border indicator. */
   dates?: Date[];
+  /**
+   * Date the grid scrolls into view on mount, and whenever this value changes.
+   * Defaults to today. Pass a stable (memoized) Date so the grid does not
+   * re-scroll on every render.
+   */
+  initialDate?: Date;
+  /** Fired when a user selects a single date (click or arrow key). */
   onSelect?: (event: { date: Date }) => void;
+  /**
+   * Fired when a user commits a multi-day range, either by a drag gesture or
+   * by shift+arrow extension. The range is normalized: `from <= to`, both at
+   * start-of-day. Not fired for single-day selections (use {@link onSelect}).
+   */
+  onSelectRange?: (event: { range: Range }) => void;
 };
 
 const CalendarGrid = composable<HTMLDivElement, CalendarGridProps>(
-  ({ classNames, rows, dates = [], onSelect, ...props }, forwardedRef) => {
-    const { weekStartsOn, event, setIndex, selected, setSelected } = useCalendarContext(CALENDAR_GRID_NAME);
+  ({ classNames, rows, dates = [], initialDate, onSelect, onSelectRange, ...props }, forwardedRef) => {
+    const { weekStartsOn, event, setIndex, selected, setSelected, range, setRange, pendingRange, setPendingRange } =
+      useCalendarContext(CALENDAR_GRID_NAME);
     const { ref: containerRef, width = 0, height = 0 } = useResizeDetector();
     const maxHeight = rows ? rows * size : undefined;
     const listRef = useRef<List>(null);
+    const gridRef = useRef<HTMLDivElement>(null);
     const today = useMemo(() => new Date(), []);
 
     // Build a set of ISO date strings (YYYY-MM-DD) for O(1) per-cell lookup.
@@ -171,15 +246,15 @@ const CalendarGrid = composable<HTMLDivElement, CalendarGridProps>(
 
     const [initialized, setInitialized] = useState(false);
     useEffect(() => {
-      const index = differenceInWeeks(today, start);
+      const index = getRowIndex(start, initialDate ?? today, weekStartsOn);
       listRef.current?.scrollToRow(index);
-    }, [initialized, start, today]);
+    }, [initialized, start, today, initialDate, weekStartsOn]);
 
     useEffect(() => {
       return event.on((event) => {
         switch (event.type) {
           case 'scroll': {
-            const index = differenceInWeeks(event.date, start);
+            const index = getRowIndex(start, event.date, weekStartsOn);
             listRef.current?.scrollToRow(index);
             break;
           }
@@ -195,32 +270,312 @@ const CalendarGrid = composable<HTMLDivElement, CalendarGridProps>(
       });
     }, []);
 
-    // TODO(burdon): Get info by range.
+    //
+    // Selection refs.
+    //
+    // `anchorRef` is the immovable end of a range gesture (pointerdown date or
+    // initial day when shift+arrow starts). `focusRef` is the moving end
+    // (pointer-under-cursor during drag, or the cursor after each shift+arrow).
+    // Both refs are kept in sync across mouse drag and keyboard nav so that
+    // the user can fluidly mix gestures (e.g., drag a range, then shift+arrow
+    // to fine-tune).
+    //
+    const anchorRef = useRef<Date | undefined>(undefined);
+    const focusRef = useRef<Date | undefined>(undefined);
+    const draggingRef = useRef(false);
+
+    // Pointer tracking for edge-scroll while dragging.
+    const pointerXRef = useRef<number>(0);
+    const pointerYRef = useRef<number>(0);
+    const scrollTopRef = useRef(0);
+    const scrollRafRef = useRef<number | undefined>(undefined);
+
+    // Scroll the target date into view only if it's outside the visible window.
+    // Horizontal moves (left/right within the same week) leave the row index
+    // unchanged and are a no-op.
+    const scrollIntoView = useCallback(
+      (date: Date) => {
+        const targetRow = getRowIndex(start, date, weekStartsOn);
+        const visibleHeight = maxHeight ?? height;
+        if (!visibleHeight) {
+          return;
+        }
+        // Rows fully inside the viewport. Use ceil/floor (not floor of scrollTop) so a partially
+        // visible row at either edge counts as "not fully visible" even when scrollTop is not a
+        // multiple of the row height (which it isn't after a bottom-aligned scroll).
+        const firstFullyVisibleRow = Math.ceil(scrollTopRef.current / size);
+        const lastFullyVisibleRow = Math.floor((scrollTopRef.current + visibleHeight) / size) - 1;
+        if (targetRow < firstFullyVisibleRow) {
+          // Align the top edge of the target row with the top edge of the viewport.
+          listRef.current?.scrollToPosition(targetRow * size);
+        } else if (targetRow > lastFullyVisibleRow) {
+          // Align the bottom edge of the target row with the bottom edge of the viewport (using the
+          // full visible height, not a row-rounded height, so the row sits flush against the edge).
+          listRef.current?.scrollToPosition(Math.max(0, (targetRow + 1) * size - visibleHeight));
+        }
+      },
+      [height, maxHeight, weekStartsOn],
+    );
+
+    const updateRangeFromAnchor = useCallback(
+      (focus: Date, fireRange = false) => {
+        const anchor = anchorRef.current;
+        if (!anchor) {
+          return;
+        }
+        focusRef.current = focus;
+        if (isSameDay(anchor, focus)) {
+          setRange(undefined);
+          setSelected(anchor);
+        } else {
+          setSelected(undefined);
+          const committed = makeRange(anchor, focus);
+          setRange(committed);
+          if (fireRange) {
+            onSelectRange?.({ range: committed });
+          }
+        }
+      },
+      [onSelectRange, setRange, setSelected],
+    );
+
+    //
+    // Drag-to-select range.
+    //
+    // `prevSelectedRef` snapshots the single-day selection that was active
+    // when the gesture began. A click on the *same* already-selected day
+    // toggles the selection off on pointerup; a click on any other day (or
+    // when no day was selected) just sets the new selection.
+    //
+    const prevSelectedRef = useRef<Date | undefined>(undefined);
+
+    const handleDayPointerDown = useCallback(
+      (date: Date, ev: ReactPointerEvent<HTMLDivElement>) => {
+        ev.preventDefault();
+        prevSelectedRef.current = selected;
+        anchorRef.current = date;
+        focusRef.current = date;
+        draggingRef.current = true;
+        // Immediate visual feedback: render the single-select ring on the anchor day.
+        setRange(undefined);
+        setPendingRange(undefined);
+        setSelected(date);
+        // Focus the grid so subsequent keyboard nav works.
+        gridRef.current?.focus({ preventScroll: true });
+      },
+      [selected, setPendingRange, setRange, setSelected],
+    );
 
-    const handleDaySelect = useCallback(
+    const handleDayPointerEnter = useCallback(
       (date: Date) => {
-        setSelected((current) => (isSameDay(date, current) ? undefined : date));
-        onSelect?.({ date });
+        if (!draggingRef.current) {
+          return;
+        }
+        const anchor = anchorRef.current;
+        if (!anchor) {
+          return;
+        }
+        focusRef.current = date;
+        // Always render a pending range while dragging — even a single-day range
+        // (when the pointer is on the anchor cell or returns to it). Otherwise
+        // the anchor cell would appear empty mid-drag.
+        setSelected(undefined);
+        setPendingRange(makeRange(anchor, date));
       },
-      [onSelect],
+      [setPendingRange, setSelected],
     );
 
+    const handleDayPointerUp = useCallback(
+      (date: Date) => {
+        const anchor = anchorRef.current;
+        const wasDragging = draggingRef.current;
+        draggingRef.current = false;
+        setPendingRange(undefined);
+        if (!wasDragging || !anchor) {
+          return;
+        }
+        focusRef.current = date;
+        if (isSameDay(anchor, date)) {
+          // Single click — toggle off if clicking the previously-selected day,
+          // otherwise set as selected. (pointerenter may have cleared the ring
+          // mid-drag to show a 1-day pending-range fill; restore here.)
+          if (prevSelectedRef.current && isSameDay(prevSelectedRef.current, date)) {
+            setSelected(undefined);
+            anchorRef.current = undefined;
+            focusRef.current = undefined;
+            return;
+          }
+          setSelected(anchor);
+          onSelect?.({ date });
+          return;
+        }
+        // Drag commit — `selected` was already cleared by pointerenter.
+        const committed = makeRange(anchor, date);
+        setRange(committed);
+        onSelectRange?.({ range: committed });
+      },
+      [onSelect, onSelectRange, setPendingRange, setRange, setSelected],
+    );
+
+    // Cancel drag if the pointer is released outside the grid.
+    useEffect(() => {
+      const cancel = () => {
+        if (draggingRef.current) {
+          draggingRef.current = false;
+          setPendingRange(undefined);
+        }
+      };
+      window.addEventListener('pointerup', cancel);
+      window.addEventListener('pointercancel', cancel);
+      return () => {
+        window.removeEventListener('pointerup', cancel);
+        window.removeEventListener('pointercancel', cancel);
+      };
+    }, [setPendingRange]);
+
+    //
+    // Edge auto-scroll while dragging near top/bottom of the grid viewport.
+    //
+    const tickEdgeScroll = useCallback(() => {
+      scrollRafRef.current = undefined;
+      if (!draggingRef.current) {
+        return;
+      }
+      const rect = containerRef.current?.getBoundingClientRect();
+      if (!rect) {
+        return;
+      }
+      const y = pointerYRef.current;
+      let delta = 0;
+      if (y < rect.top + EDGE_SCROLL_ZONE) {
+        delta = -EDGE_SCROLL_MAX_SPEED * Math.min(1, Math.max(0, (rect.top + EDGE_SCROLL_ZONE - y) / EDGE_SCROLL_ZONE));
+      } else if (y > rect.bottom - EDGE_SCROLL_ZONE) {
+        delta =
+          EDGE_SCROLL_MAX_SPEED * Math.min(1, Math.max(0, (y - (rect.bottom - EDGE_SCROLL_ZONE)) / EDGE_SCROLL_ZONE));
+      }
+      if (delta !== 0) {
+        const newScroll = Math.max(0, scrollTopRef.current + delta);
+        listRef.current?.scrollToPosition(newScroll);
+        // After scroll, the cell under the (stationary) pointer changes.
+        // Look up the new cell and update the pending range accordingly.
+        const date = cellDate(document.elementFromPoint(pointerXRef.current, y));
+        const anchor = anchorRef.current;
+        if (date && anchor) {
+          focusRef.current = date;
+          if (isSameDay(anchor, date)) {
+            setPendingRange(undefined);
+            setSelected(anchor);
+          } else {
+            setSelected(undefined);
+            setPendingRange(makeRange(anchor, date));
+          }
+        }
+        scrollRafRef.current = requestAnimationFrame(tickEdgeScroll);
+      }
+    }, [containerRef, setPendingRange, setSelected]);
+
+    useEffect(() => {
+      const handleMove = (ev: PointerEvent) => {
+        if (!draggingRef.current) {
+          return;
+        }
+        pointerXRef.current = ev.clientX;
+        pointerYRef.current = ev.clientY;
+        if (scrollRafRef.current === undefined) {
+          scrollRafRef.current = requestAnimationFrame(tickEdgeScroll);
+        }
+      };
+      window.addEventListener('pointermove', handleMove);
+      return () => {
+        window.removeEventListener('pointermove', handleMove);
+        if (scrollRafRef.current !== undefined) {
+          cancelAnimationFrame(scrollRafRef.current);
+          scrollRafRef.current = undefined;
+        }
+      };
+    }, [tickEdgeScroll]);
+
+    //
+    // Keyboard nav: arrow keys move single selection; shift+arrow expands range.
+    //
+    const handleKeyDown = useCallback(
+      (ev: ReactKeyboardEvent<HTMLDivElement>) => {
+        let dx = 0;
+        switch (ev.key) {
+          case 'ArrowLeft':
+            dx = -1;
+            break;
+          case 'ArrowRight':
+            dx = 1;
+            break;
+          case 'ArrowUp':
+            dx = -7;
+            break;
+          case 'ArrowDown':
+            dx = 7;
+            break;
+          default:
+            return;
+        }
+        ev.preventDefault();
+
+        if (ev.shiftKey) {
+          // Bootstrap anchor/focus from current state if needed.
+          let anchor = anchorRef.current;
+          let focus = focusRef.current;
+          if (!anchor) {
+            // No prior gesture — seed from current selected/range/today.
+            if (selected) {
+              anchor = startOfDay(selected);
+              focus = anchor;
+            } else if (range) {
+              anchor = range.from;
+              focus = range.to;
+            } else {
+              anchor = startOfDay(today);
+              focus = anchor;
+            }
+            anchorRef.current = anchor;
+            focusRef.current = focus;
+          }
+          const newFocus = addDays(focus ?? anchor, dx);
+          updateRangeFromAnchor(newFocus, true);
+          scrollIntoView(newFocus);
+        } else {
+          // Plain arrow — move single selection; clear any range gesture state.
+          const current = selected ?? focusRef.current ?? anchorRef.current ?? today;
+          const next = addDays(startOfDay(current), dx);
+          anchorRef.current = next;
+          focusRef.current = next;
+          setRange(undefined);
+          setPendingRange(undefined);
+          setSelected(next);
+          onSelect?.({ date: next });
+          scrollIntoView(next);
+        }
+      },
+      [onSelect, range, scrollIntoView, selected, setPendingRange, setRange, setSelected, today, updateRangeFromAnchor],
+    );
+
+    const activeRange = pendingRange ?? range;
+
     const handleScroll = useCallback<NonNullable<ListProps['onScroll']>>((info) => {
+      scrollTopRef.current = info.scrollTop;
       setIndex(Math.round(info.scrollTop / size));
     }, []);
 
     const rowRenderer = useCallback<ListRowRenderer>(
       ({ key, index, style }) => {
-        const getBgColor = (date: Date) => date.getMonth() % 2 === 0 && 'bg-modal-surface';
+        // Zebra-stripe alternating months with a subtle neutral overlay over the grid surface, so
+        // the banding is independent of (and robust to) surface-token retuning.
+        const getBgColor = (date: Date) => (date.getMonth() % 2 === 0 ? 'bg-group-surface' : 'bg-group-alt-surface');
+
         return (
-          <div key={key} role='none' style={style} className='grid'>
-            <div
-              role='none'
-              className='grid grid-cols-7 bg-input-surface'
-              style={{ gridTemplateColumns: `repeat(7, ${size}px)` }}
-            >
+          <div key={key} style={style} className='grid'>
+            <div className='grid grid-cols-7 bg-input-surface' style={{ gridTemplateColumns: `repeat(7, ${size}px)` }}>
               {Array.from({ length: 7 }).map((_, i) => {
                 const date = getDate(start, index, i, weekStartsOn);
+                const inRange = isInRange(date, activeRange);
                 const border = isSameDay(date, selected)
                   ? 'border-primary-500'
                   : isSameDay(date, today)
@@ -232,15 +587,21 @@ const CalendarGrid = composable<HTMLDivElement, CalendarGridProps>(
                 return (
                   <div
                     key={i}
-                    role='none'
-                    className={mx('relative flex justify-center items-center cursor-pointer', getBgColor(date))}
-                    onClick={() => handleDaySelect(date)}
+                    data-date={startOfDay(date).toISOString()}
+                    className={mx(
+                      'relative flex justify-center items-center cursor-pointer select-none',
+                      getBgColor(date),
+                    )}
+                    onPointerDown={(ev) => handleDayPointerDown(date, ev)}
+                    onPointerEnter={() => handleDayPointerEnter(date)}
+                    onPointerUp={() => handleDayPointerUp(date)}
                   >
-                    <span className='text-description'>{date.getDate()}</span>
+                    {inRange && <div className='absolute inset-0 bg-primary-500/20' />}
+                    <span className='relative text-description text-sm'>{date.getDate()}</span>
                     {!border && date.getDate() === 1 && (
                       <span className='absolute top-0 text-xs text-description'>{format(date, 'MMM')}</span>
                     )}
-                    {border && <div role='none' className={mx('absolute inset-1 border-2 rounded-full', border)} />}
+                    {border && <div className={mx('absolute inset-1 border-2 rounded-full', border)} />}
                   </div>
                 );
               })}
@@ -248,28 +609,37 @@ const CalendarGrid = composable<HTMLDivElement, CalendarGridProps>(
           </div>
         );
       },
-      [handleDaySelect, hasDate, selected, weekStartsOn],
+      [activeRange, handleDayPointerDown, handleDayPointerEnter, handleDayPointerUp, hasDate, selected, weekStartsOn],
     );
 
     return (
       <div
         {...composableProps(props, {
           role: 'none',
-          classNames: ['flex flex-col h-full w-full justify-center overflow-hidden', classNames],
+          classNames: ['flex flex-col h-full w-full justify-center overflow-hidden outline-hidden', classNames],
         })}
-        ref={forwardedRef}
+        ref={(node: HTMLDivElement | null) => {
+          gridRef.current = node;
+          if (typeof forwardedRef === 'function') {
+            forwardedRef(node);
+          } else if (forwardedRef) {
+            (forwardedRef as React.MutableRefObject<HTMLDivElement | null>).current = node;
+          }
+        }}
+        tabIndex={0}
+        onKeyDown={handleKeyDown}
       >
         {/* Day of week labels */}
-        <div role='none' className='grid w-full grid-cols-7' style={{ width: defaultWidth }}>
+        <div className='grid w-full grid-cols-7' style={{ width: defaultWidth }}>
           {days.map((date, i) => (
-            <div key={i} role='none' className='flex justify-center p-2 text-sm font-thin'>
+            <div key={i} className='flex justify-center p-2 text-sm font-thin'>
               {date}
             </div>
           ))}
         </div>
 
         {/* Grid */}
-        <div role='none' className='flex flex-col h-full w-full justify-center overflow-hidden' ref={containerRef}>
+        <div className='flex flex-col h-full w-full justify-center overflow-hidden' ref={containerRef}>
           <List
             ref={listRef}
             role='none'

package/src/components/Calendar/util.ts

@@ -2,7 +2,7 @@
 // Copyright 2025 DXOS.org
 //
 
-import { type Day } from 'date-fns';
+import { type Day, differenceInCalendarDays } from 'date-fns';
 
 export const getDate = (start: Date, weekNumber: number, dayOfWeek: number, weekStartsOn: Day): Date => {
   const result = new Date(start);
@@ -12,6 +12,24 @@ export const getDate = (start: Date, weekNumber: number, dayOfWeek: number, week
   return result;
 };
 
+/**
+ * Inverse of {@link getDate}: returns the row index for a given date, matching
+ * the grid layout (which respects `weekStartsOn`).
+ *
+ * Uses `differenceInCalendarDays` (DST-safe) — naive ms subtraction silently
+ * loses an hour each DST transition, which accumulates over decades and
+ * eventually shifts the row boundary by one day. `differenceInWeeks` is also
+ * unsuitable because it computes raw 7-day chunks anchored at the start
+ * date's weekday rather than the grid's `weekStartsOn` column.
+ */
+export const getRowIndex = (start: Date, date: Date, weekStartsOn: Day): number => {
+  const startDayOfWeek = start.getDay();
+  const adjustedStartDay = (startDayOfWeek === 0 ? 7 : startDayOfWeek) - weekStartsOn;
+  const row0Start = new Date(start);
+  row0Start.setDate(start.getDate() - adjustedStartDay);
+  return Math.floor(differenceInCalendarDays(date, row0Start) / 7);
+};
+
 export const isSameDay = (date1: Date, date2: Date | undefined): boolean => {
   return (
     !!date2 &&