@dxos/plugin-space 0.9.1-main.c7dcc2e112 → 0.9.1-staging.ee54ba693a

package/src/capabilities/react-surface.tsx

@@ -7,40 +7,43 @@ import * as Option from 'effect/Option';
 import React, { type ComponentProps, useCallback } from 'react';
 
 import { Capabilities, Capability } from '@dxos/app-framework';
-import { Surface, useAtomCapability, useOperationInvoker } from '@dxos/app-framework/ui';
+import { Surface, useAtomCapability, useOperationInvoker, useSettingsState } from '@dxos/app-framework/ui';
 import { AppAnnotation } from '@dxos/app-toolkit';
 import { AppSurface, useActiveSpace, useTypeOptions } from '@dxos/app-toolkit/ui';
-import { Annotation, Collection, Database, Entity, Obj, Type } from '@dxos/echo';
+import { Annotation, Collection, Database, Obj, Type } from '@dxos/echo';
 import { SchemaEx } from '@dxos/effect';
 import { type Space, SpaceState, getSpace, isSpace, useSpaces } from '@dxos/react-client/echo';
 import { Input } from '@dxos/react-ui';
 import { type FormFieldRendererProps, SelectField } from '@dxos/react-ui-form';
 import { HuePicker, IconPicker } from '@dxos/react-ui-pickers';
 import { ViewAnnotation } from '@dxos/schema';
+import { Position } from '@dxos/util';
 
-import { SpaceSettings } from '#components';
 import {
   CollectionArticle,
   CollectionSection,
   CreateObjectDialog,
   CreateSpaceDialog,
+  DefaultProperties,
   ImportSpaceDialog,
   InlineSyncStatus,
   JoinDialog,
   MembersContainer,
   MenuFooter,
   ObjectCardStack,
-  ObjectProperties,
   RecordArticle,
   RelatedArticle,
   RenamePopover,
+  type RenameSubject,
   SchemaContainer,
   SmallPresenceLive,
   SpaceHomeArticle,
   SpaceHomeRecent,
   SpacePresence,
+  SpaceSettings,
   SpaceSettingsContainer,
   SyncStatus,
+  TypeCollectionArticle,
   ViewEditor,
 } from '#containers';
 import { meta } from '#meta';
@@ -48,9 +51,10 @@ import { SpaceOperation } from '#operations';
 import {
   HueAnnotationId,
   IconAnnotationId,
+  Settings,
+  SPACE_HOME_NODE_TYPE,
   SpaceCapabilities,
   SpaceHomeContent,
-  SPACE_HOME_NODE_TYPE,
   type TypeInputOptions,
   TypeInputOptionsAnnotationId,
 } from '#types';
@@ -84,26 +88,48 @@ export default Capability.makeModule(
       }),
       Surface.create({
         id: 'collectionFallback',
-        position: 'last',
+        position: Position.last,
         filter: AppSurface.object(AppSurface.Article, Collection.Collection),
         component: ({ data }) => <CollectionArticle attendableId={data.attendableId} subject={data.subject} />,
       }),
       Surface.create({
         id: 'recordArticle',
-        position: 'last',
+        position: Position.last,
         filter: AppSurface.subject(AppSurface.Article, Obj.isObject),
         component: ({ data }) => <RecordArticle subject={data.subject} />,
       }),
+      Surface.create({
+        id: 'typeCollection',
+        filter: AppSurface.subject(AppSurface.Article, Type.isType),
+        component: ({ data, role }) => {
+          const space = isSpace(data.properties?.space) ? data.properties.space : undefined;
+          if (!space) {
+            return null;
+          }
+
+          return (
+            <TypeCollectionArticle
+              role={role}
+              space={space}
+              typeUri={Type.getURI(data.subject)}
+              attendableId={data.attendableId}
+            />
+          );
+        },
+      }),
       Surface.create({
         id: 'pluginSettings',
         filter: AppSurface.settings(AppSurface.Article, meta.profile.key),
-        component: () => {
+        component: ({ data: { subject } }) => {
           const spaces = useSpaces();
           const { invokePromise } = useOperationInvoker();
+          const { settings, updateSettings } = useSettingsState<Settings.Settings>(subject.atom);
           return (
             <SpaceSettings
               spaces={spaces}
               onOpenSpaceSettings={(space: Space) => invokePromise(SpaceOperation.OpenSettings, { space })}
+              settings={settings}
+              onSettingsChange={updateSettings}
             />
           );
         },
@@ -114,7 +140,7 @@ export default Capability.makeModule(
           AppSurface.literal(AppSurface.Article, 'settings'),
           AppSurface.companion(AppSurface.Article),
         ),
-        component: ({ ref, data, role }) => <ObjectProperties role={role} subject={data.companionTo} ref={ref} />,
+        component: ({ ref, data, role }) => <DefaultProperties role={role} subject={data.companionTo} ref={ref} />,
       }),
       Surface.create({
         id: 'companion.related',
@@ -138,7 +164,7 @@ export default Capability.makeModule(
       }),
       Surface.create({
         id: 'spaceSettingsMembers',
-        position: 'first',
+        position: Position.first,
         filter: AppSurface.literal(AppSurface.Article, `${meta.profile.key}.members`),
         component: () => {
           const space = useActiveSpace();
@@ -305,7 +331,7 @@ export default Capability.makeModule(
       }),
       Surface.create({
         id: RENAME_POPOVER,
-        filter: AppSurface.component<Space | Entity.Unknown>(AppSurface.Popover, RENAME_POPOVER),
+        filter: AppSurface.component<RenameSubject>(AppSurface.Popover, RENAME_POPOVER),
         component: ({ data }) => <RenamePopover subject={data.props} />,
       }),
       Surface.create({
@@ -324,7 +350,7 @@ export default Capability.makeModule(
       // TODO(wittjosiah): Attention glyph for non-echo items should be handled elsewhere.
       Surface.create({
         id: 'navtreePresenceFallback',
-        position: 'last',
+        position: Position.last,
         filter: Surface.makeFilter(AppSurface.NavtreeItemEnd),
         component: ({ data }) => <SmallPresenceLive id={data.id} open={data.open} />,
       }),
@@ -336,7 +362,7 @@ export default Capability.makeModule(
       }),
       Surface.create({
         id: 'navbarPresence',
-        position: 'first',
+        position: Position.first,
         filter: AppSurface.subject(
           AppSurface.NavbarEnd,
           (value): value is Space | Obj.Unknown => isSpace(value) || Obj.isObject(value),

package/src/capabilities/spaces-ready.ts

@@ -12,7 +12,7 @@ import { SubscriptionList } from '@dxos/async';
 import { Annotation, Collection, Filter, Obj, Type } from '@dxos/echo';
 import { SPACE_ID_LENGTH, parseId } from '@dxos/keys';
 import { log } from '@dxos/log';
-import { MigrationVersionAnnotation, Migrations } from '@dxos/migrations';
+import { Migrations, MigrationVersionAnnotation } from '@dxos/migrations';
 import { AttentionCapabilities } from '@dxos/plugin-attention';
 import { ClientCapabilities } from '@dxos/plugin-client';
 import { Graph } from '@dxos/plugin-graph';

package/src/components/ForeignKeys/ForeignKeys.tsx

@@ -5,7 +5,8 @@
 import React, { useCallback } from 'react';
 
 import { type Key } from '@dxos/echo';
-import { IconButton, List, ListItem, useTranslation } from '@dxos/react-ui';
+import { IconButton, useTranslation } from '@dxos/react-ui';
+import { Listbox } from '@dxos/react-ui-list';
 
 import { meta } from '#meta';
 
@@ -17,11 +18,13 @@ export type ForeignKeysProps = {
 // TODO(wittjosiah): This is a clone of `TokenManager`. Consider a form variant for arrays of read-only objects.
 export const ForeignKeys = ({ keys, onDelete }: ForeignKeysProps) => {
   return (
-    <List classNames='flex flex-col gap-2'>
-      {keys.map((key) => (
-        <KeyItem key={key.id} forignKey={key} onDelete={onDelete} />
-      ))}
-    </List>
+    <Listbox.Root>
+      <Listbox.Content classNames='gap-2'>
+        {keys.map((key) => (
+          <KeyItem key={key.id} forignKey={key} onDelete={onDelete} />
+        ))}
+      </Listbox.Content>
+    </Listbox.Root>
   );
 };
 
@@ -38,20 +41,18 @@ const KeyItem = ({ forignKey, onDelete }: KeyItemProps) => {
   }, [forignKey, onDelete]);
 
   return (
-    <ListItem.Root classNames='px-2'>
-      <ListItem.Heading classNames='flex flex-col grow truncate'>
+    <Listbox.Item id={forignKey.id} classNames='px-2 gap-2'>
+      <div className='flex flex-col grow truncate'>
         <div>{forignKey.source}</div>
         <div className='text-description text-sm truncate'>{forignKey.id}</div>
-      </ListItem.Heading>
-      <ListItem.Endcap>
-        <IconButton
-          iconOnly
-          icon='ph--x--regular'
-          variant='ghost'
-          label={t('delete-key.button')}
-          onClick={handleDelete}
-        />
-      </ListItem.Endcap>
-    </ListItem.Root>
+      </div>
+      <IconButton
+        iconOnly
+        icon='ph--x--regular'
+        variant='ghost'
+        label={t('delete-key.button')}
+        onClick={handleDelete}
+      />
+    </Listbox.Item>
   );
 };

package/src/components/index.ts

@@ -2,11 +2,11 @@
 // Copyright 2023 DXOS.org
 //
 
-import { type ComponentType, lazy } from 'react';
-
 export * from './AwaitingObject';
 export * from './CreateObjectPanel';
 export * from './ForeignKeys';
 export * from './SyncStatus';
 
-export const SpaceSettings: ComponentType<any> = lazy(() => import('./SpaceSettings'));
+// TODO(wittjosiah): Remove.
+export { RENAME_POPOVER } from '../constants';
+export type { RenameCallback, RenameSubject } from '../containers/RenamePopover';

package/src/containers/CreateObjectDialog/CreateObjectDialog.stories.tsx

@@ -13,7 +13,7 @@ import { type Space } from '@dxos/react-client/echo';
 import { Dialog } from '@dxos/react-ui';
 import { withLayout, withTheme } from '@dxos/react-ui/testing';
 
-import { type CreateObjectOption, type Metadata, CreateObjectPanel } from '#components';
+import { type CreateObjectOption, CreateObjectPanel, type Metadata } from '#components';
 import { translations } from '#translations';
 
 const mockOptions: CreateObjectOption[] = [

package/src/containers/CreateObjectDialog/CreateObjectDialog.tsx

@@ -18,7 +18,7 @@ import { invariant } from '@dxos/invariant';
 import { useClient } from '@dxos/react-client';
 import { useQuery, useSpaces } from '@dxos/react-client/echo';
 import { Dialog, toLocalizedString, useTranslation } from '@dxos/react-ui';
-import { ViewAnnotation } from '@dxos/schema';
+import { CollectionItemAnnotation, ViewAnnotation } from '@dxos/schema';
 
 import { makeCreateObjectEntryForDatabaseType } from '#capabilities';
 import { type CreateObjectOption, CreateObjectPanel, type CreateObjectPanelProps } from '#components';
@@ -126,10 +126,35 @@ export const CreateObjectDialog = ({
     return set;
   }, [typeByTypename]);
 
+  // Types eligible to live inside a collection: collections themselves, plus types carrying
+  // CollectionItemAnnotation. Used to filter the create dialog when targeting a collection.
+  const collectionItemTypenames = useMemo(() => {
+    const set = new Set<string>();
+    const collectionTypename = Type.getTypename(Collection.Collection);
+    for (const [name, type] of typeByTypename) {
+      if (
+        name === collectionTypename ||
+        CollectionItemAnnotation.get(Type.getSchema(type)).pipe(Option.getOrElse(() => false))
+      ) {
+        set.add(name);
+      }
+    }
+    return set;
+  }, [typeByTypename]);
+
+  // When creating into a collection, offer only collection-eligible types (mirrors the `views` filter).
+  const collectionTarget = Collection.isCollection(target);
+
   const options = useMemo<CreateObjectOption[]>(
     () =>
       createObjectEntries
-        .filter((entry) => (views === true ? viewTypenames.has(entry.id) : true))
+        .filter((entry) =>
+          views === true
+            ? viewTypenames.has(entry.id)
+            : collectionTarget
+              ? collectionItemTypenames.has(entry.id)
+              : true,
+        )
         .map((entry) => {
           const type = typeByTypename.get(entry.id);
           const schema = type && Type.getSchema(type);
@@ -146,7 +171,17 @@ export const CreateObjectDialog = ({
             description: isDatabase ? spaceLabel : undefined,
           };
         }),
-    [createObjectEntries, views, viewTypenames, typeByTypename, t, pluginNameByEntryId, spaceLabel],
+    [
+      createObjectEntries,
+      views,
+      viewTypenames,
+      collectionTarget,
+      collectionItemTypenames,
+      typeByTypename,
+      t,
+      pluginNameByEntryId,
+      spaceLabel,
+    ],
   );
 
   const handleCreateObject = useCallback<NonNullable<CreateObjectPanelProps['onCreateObject']>>(

package/src/containers/DefaultProperties/DefaultProperties.tsx

@@ -0,0 +1,69 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import * as Effect from 'effect/Effect';
+import React, { forwardRef, useCallback, useMemo } from 'react';
+
+import { Capability } from '@dxos/app-framework';
+import { Surface, useCapabilities, useOperationInvoker, usePluginManager } from '@dxos/app-framework/ui';
+import { AppSurface } from '@dxos/app-toolkit/ui';
+import { Operation } from '@dxos/compute';
+import { type Database, type Obj } from '@dxos/echo';
+import { Panel, Toolbar } from '@dxos/react-ui';
+import { type CreateEntryOverride, ObjectProperties } from '@dxos/react-ui-form';
+
+import { SpaceCapabilities } from '#types';
+
+export type DefaultPropertiesProps = AppSurface.ObjectPropertiesProps<Obj.Unknown>;
+
+/**
+ * Generic object-properties companion rendered for any object: a schema-driven {@link ObjectProperties}
+ * form plus the `object-properties` surface, so plugins whose properties are plain editable fields need
+ * not register a bespoke surface (mirrors `DefaultSettings` for plugin settings).
+ */
+export const DefaultProperties = forwardRef<HTMLDivElement, DefaultPropertiesProps>(
+  ({ role, subject: object }, forwardedRef) => {
+    const manager = usePluginManager();
+    const operationInvoker = useOperationInvoker();
+    const createEntries = useCapabilities(SpaceCapabilities.CreateObjectEntry);
+    const data = useMemo<AppSurface.ObjectPropertiesData>(() => ({ subject: object }), [object]);
+
+    const resolveCreateEntry = useCallback(
+      (typename: string): CreateEntryOverride | undefined => {
+        const entry = createEntries.find((createEntry) => createEntry.id === typename);
+        if (!entry?.inputSchema && !entry?.createObject) {
+          return undefined;
+        }
+        return {
+          inputSchema: entry.inputSchema,
+          createObject: async (values: any, db: Database.Database): Promise<Obj.Unknown> => {
+            const result = await entry
+              .createObject(values, { db, target: db })
+              .pipe(
+                Effect.provideService(Capability.Service, manager.capabilities),
+                Effect.provideService(Operation.Service, operationInvoker),
+                Effect.runPromise,
+              );
+            return result.object;
+          },
+        };
+      },
+      [createEntries, manager, operationInvoker],
+    );
+
+    return (
+      <Panel.Root role={role} ref={forwardedRef}>
+        <Panel.Toolbar>
+          <Toolbar.Root className='dx-document' />
+        </Panel.Toolbar>
+        <Panel.Content>
+          <ObjectProperties object={object} resolveCreateEntry={resolveCreateEntry}>
+            {/* TODO(burdon): Ambiguous naming since providers only replace parts; can't update Toolbar, etc. Consider DefaultSettings pattern. */}
+            <Surface.Surface type={AppSurface.ObjectProperties} data={data} />
+          </ObjectProperties>
+        </Panel.Content>
+      </Panel.Root>
+    );
+  },
+);

package/src/containers/DefaultProperties/index.ts

@@ -0,0 +1,5 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+export { DefaultProperties as default } from './DefaultProperties';

package/src/containers/JoinDialog/JoinDialog.tsx

@@ -6,9 +6,7 @@ import React, { useCallback } from 'react';
 
 import { useOperationInvoker } from '@dxos/app-framework/ui';
 import { LayoutOperation, Paths } from '@dxos/app-toolkit';
-import { useAppGraph } from '@dxos/app-toolkit/ui';
 import { Trigger } from '@dxos/async';
-import { Graph } from '@dxos/plugin-graph';
 import { ObservabilityOperation } from '@dxos/plugin-observability';
 import { useClient } from '@dxos/react-client';
 import { type Space } from '@dxos/react-client/echo';
@@ -28,7 +26,6 @@ export type JoinDialogProps = JoinPanelProps & {
 export const JoinDialog = ({ navigableCollections, onDone, ...props }: JoinDialogProps) => {
   const { invokePromise } = useOperationInvoker();
   const client = useClient();
-  const { graph } = useAppGraph();
   const { t } = useTranslation(meta.profile.key);
 
   const handleDone = useCallback(
@@ -61,23 +58,13 @@ export const JoinDialog = ({ navigableCollections, onDone, ...props }: JoinDialo
         space = await trigger.wait();
       }
 
-      await invokePromise(LayoutOperation.SwitchWorkspace, { subject: Paths.getSpacePath(space.id) });
-
-      const target = result?.target;
-      if (target) {
-        // Wait before navigating to the target node.
-        // If the target has not yet replicated, this will trigger a loading toast.
-        await Graph.waitForPath(graph, { target }).catch(() => {});
-        await Promise.all([
-          invokePromise(LayoutOperation.Open, { subject: [target] }),
-          invokePromise(LayoutOperation.Expose, { subject: target }),
-        ]);
-      } else {
-        await invokePromise(LayoutOperation.Open, {
-          subject: [Paths.getSpaceHomePath(space.id)],
-          workspace: Paths.getSpacePath(space.id),
-        });
-      }
+      // TODO(wittjosiah): `result.target` is ignored so acceptance navigates to the space home
+      // immediately; revisit how to incorporate the target once immediate navigation is settled.
+      await invokePromise(LayoutOperation.Open, {
+        subject: [Paths.getSpaceHomePath(space.id)],
+        workspace: Paths.getSpacePath(space.id),
+        navigation: 'immediate',
+      });
 
       onDone?.(result);
 
@@ -90,7 +77,7 @@ export const JoinDialog = ({ navigableCollections, onDone, ...props }: JoinDialo
         });
       }
     },
-    [invokePromise, client, graph, navigableCollections, onDone],
+    [invokePromise, client, navigableCollections, onDone],
   );
 
   // TODO(burdon): Move JoinHeading into Dialog.Heading.

package/src/containers/MembersContainer/MembersContainer.tsx

@@ -15,7 +15,7 @@ import { useConfig } from '@dxos/react-client';
 import { useSpaceInvitations } from '@dxos/react-client/echo';
 import { type CancellableInvitationObservable, Invitation, InvitationEncoder } from '@dxos/react-client/invitations';
 import { Button, Clipboard, Icon, useId, useTranslation } from '@dxos/react-ui';
-import { Settings } from '@dxos/react-ui-form';
+import { Form } from '@dxos/react-ui-form';
 import {
   type ActionMenuItem,
   AuthCode,
@@ -123,38 +123,42 @@ export const MembersContainer = ({ space, createInvitationUrl }: MembersContaine
 
   return (
     <Clipboard.Provider>
-      <Settings.Viewport>
-        <Settings.Section title={t('members-verbose.label')} description={t('members.description')}>
-          <Settings.Panel>
-            <div role='group' className='min-w-0'>
-              <h3 className='text-lg mb-2'>{t('members.label')}</h3>
-              <SpaceMemberList spaceKey={space.key} includeSelf />
-            </div>
-            <div role='group' className='min-w-0'>
-              <h3 className='text-lg mb-2'>{t('invitations.label')}</h3>
-              {selectedInvitation && <InvitationSection {...selectedInvitation} onBack={handleBack} />}
-              {!selectedInvitation && (
-                <>
-                  <p className='text-description mb-2'>{t('space-invitation.description')}</p>
-                  <InvitationList
-                    className='mb-2'
-                    send={handleSend}
-                    invitations={visibleInvitations ?? []}
-                    onClickRemove={(invitation) => invitation.cancel()}
-                    createInvitationUrl={createInvitationUrl}
-                  />
-                  <BifurcatedAction
-                    actions={inviteActions}
-                    activeAction={activeAction}
-                    onChangeActiveAction={setActiveAction as Dispatch<SetStateAction<string>>}
-                    data-testid='membersContainer.createInvitation'
-                  />
-                </>
-              )}
-            </div>
-          </Settings.Panel>
-        </Settings.Section>
-      </Settings.Viewport>
+      <Form.Root variant='settings'>
+        <Form.Viewport scroll>
+          <Form.Content>
+            <Form.Section title={t('members-verbose.label')} description={t('members.description')}>
+              <Form.Group>
+                <div role='group' className='min-w-0'>
+                  <h3 className='text-lg mb-2'>{t('members.label')}</h3>
+                  <SpaceMemberList spaceKey={space.key} includeSelf />
+                </div>
+                <div role='group' className='min-w-0'>
+                  <h3 className='text-lg mb-2'>{t('invitations.label')}</h3>
+                  {selectedInvitation && <InvitationSection {...selectedInvitation} onBack={handleBack} />}
+                  {!selectedInvitation && (
+                    <>
+                      <p className='text-description mb-2'>{t('space-invitation.description')}</p>
+                      <InvitationList
+                        className='mb-2'
+                        send={handleSend}
+                        invitations={visibleInvitations ?? []}
+                        onClickRemove={(invitation) => invitation.cancel()}
+                        createInvitationUrl={createInvitationUrl}
+                      />
+                      <BifurcatedAction
+                        actions={inviteActions}
+                        activeAction={activeAction}
+                        onChangeActiveAction={setActiveAction as Dispatch<SetStateAction<string>>}
+                        data-testid='membersContainer.createInvitation'
+                      />
+                    </>
+                  )}
+                </div>
+              </Form.Group>
+            </Form.Section>
+          </Form.Content>
+        </Form.Viewport>
+      </Form.Root>
     </Clipboard.Provider>
   );
 };

package/src/containers/RelatedArticle/RelatedArticle.tsx

@@ -14,7 +14,6 @@ import { Menu } from '@dxos/react-ui-menu';
 import { useRelatedObjects } from '#hooks';
 import { meta } from '#meta';
 
-// TODO(burdon): Companion type.
 export type RelatedArticleProps = Pick<
   AppSurface.ObjectArticleProps<Obj.Unknown, {}, Obj.Unknown>,
   'role' | 'companionTo'
@@ -31,7 +30,7 @@ export const RelatedArticle = ({ role, companionTo }: RelatedArticleProps) => {
           <Toolbar.Root />
         </Panel.Toolbar>
         <Panel.Content asChild>
-          <Masonry.Content classNames='p-2' centered>
+          <Masonry.Content centered>
             <Masonry.Viewport items={items} />
           </Masonry.Content>
         </Panel.Content>

package/src/containers/RenamePopover/RenamePopover.tsx

@@ -13,13 +13,23 @@ import { Input, useTranslation } from '@dxos/react-ui';
 
 import { meta } from '#meta';
 
-export type RenameSubject = Space | Entity.Unknown;
+export type RenameCallback = { initialValue: string; onRename: (name: string) => void };
+export type RenameSubject = Space | Entity.Unknown | RenameCallback;
 
-const getName = (subject: RenameSubject): string =>
-  (isSpace(subject) ? subject.properties.name : Entity.getLabel(subject)) ?? '';
+const isRenameCallback = (subject: RenameSubject): subject is RenameCallback =>
+  typeof (subject as RenameCallback).onRename === 'function';
+
+const getName = (subject: RenameSubject): string => {
+  if (isRenameCallback(subject)) {
+    return subject.initialValue;
+  }
+  return (isSpace(subject) ? subject.properties.name : Entity.getLabel(subject)) ?? '';
+};
 
 const setName = (subject: RenameSubject, name: string): void => {
-  if (isSpace(subject)) {
+  if (isRenameCallback(subject)) {
+    subject.onRename(name);
+  } else if (isSpace(subject)) {
     Obj.update(subject.properties, (properties) => {
       properties.name = name;
     });
@@ -30,12 +40,15 @@ const setName = (subject: RenameSubject, name: string): void => {
 
 export type RenamePopoverProps = { subject: RenameSubject };
 
+// TODO(wittjosiah): Move RenamePopover, RenameSubject, RenameCallback, and RENAME_POPOVER to @dxos/app-toolkit
+//   so any plugin can use the rename popover without depending on plugin-space.
+
 /**
  * Inline rename popover anchored to a navtree row. Commits on Enter or when dismissed; Escape cancels.
  */
 export const RenamePopover = ({ subject }: RenamePopoverProps) => {
   const { t } = useTranslation(meta.profile.key);
-  const space = isSpace(subject);
+  const space = !isRenameCallback(subject) && isSpace(subject);
   const { invokePromise } = useOperationInvoker();
   const [name, setNameState] = useState(() => getName(subject));
 

package/src/containers/RenamePopover/index.ts

@@ -3,4 +3,4 @@
 //
 
 export { RenamePopover as default } from './RenamePopover';
-export type { RenamePopoverProps, RenameSubject } from './RenamePopover';
+export type { RenameCallback, RenamePopoverProps, RenameSubject } from './RenamePopover';