@dxos/plugin-space 0.8.3-main.672df60 → 0.8.3-staging.0fa589b

package/src/capabilities/react-surface.tsx

@@ -3,26 +3,27 @@
 //
 
 import { type Schema } from 'effect';
-import React, { useCallback } from 'react';
+import React, { useCallback, useMemo } from 'react';
 
-import { Capabilities, contributes, createSurface, Surface, useCapability, useLayout } from '@dxos/app-framework';
-import { isInstanceOf } from '@dxos/echo-schema';
+import {
+  Capabilities,
+  contributes,
+  createSurface,
+  Surface,
+  useCapabilities,
+  useCapability,
+  useLayout,
+} from '@dxos/app-framework';
+import { Obj, Type } from '@dxos/echo';
 import { findAnnotation } from '@dxos/effect';
 import { SettingsStore } from '@dxos/local-storage';
-import {
-  getSpace,
-  isEchoObject,
-  isLiveObject,
-  isSpace,
-  parseId,
-  SpaceState,
-  useSpace,
-  type AnyLiveObject,
-  type Space,
-} from '@dxos/react-client/echo';
-import { Input } from '@dxos/react-ui';
-import { type InputProps } from '@dxos/react-ui-form';
+import { ClientCapabilities } from '@dxos/plugin-client';
+import { useClient } from '@dxos/react-client';
+import { getSpace, isLiveObject, isSpace, parseId, SpaceState, useSpace, type Space } from '@dxos/react-client/echo';
+import { Input, useTranslation } from '@dxos/react-ui';
+import { type InputProps, SelectInput } from '@dxos/react-ui-form';
 import { HuePicker, IconPicker } from '@dxos/react-ui-pickers';
+import { DataType, type TypenameAnnotation, TypenameAnnotationId } from '@dxos/schema';
 import { type JoinPanelProps } from '@dxos/shell/react';
 
 import { SpaceCapabilities } from './capabilities';
@@ -52,12 +53,14 @@ import {
   type CreateObjectDialogProps,
 } from '../components';
 import { SPACE_PLUGIN } from '../meta';
-import { CollectionType, HueAnnotationId, IconAnnotationId, type SpaceSettingsProps } from '../types';
+import { HueAnnotationId, IconAnnotationId, type SpaceSettingsProps } from '../types';
 
 type ReactSurfaceOptions = {
   createInvitationUrl: (invitationCode: string) => string;
 };
 
+const OMIT = [Type.getTypename(DataType.Collection), Type.getTypename(DataType.QueryCollection)];
+
 export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
   contributes(Capabilities.ReactSurface, [
     createSurface({
@@ -68,7 +71,10 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
         isSpace(data.subject) && data.subject.state.get() === SpaceState.SPACE_READY,
       component: ({ data, role, ...rest }) => (
         <Surface
-          data={{ id: data.subject.id, subject: data.subject.properties[CollectionType.typename]?.target }}
+          data={{
+            id: data.subject.id,
+            subject: data.subject.properties[Type.getTypename(DataType.Collection)]?.target,
+          }}
           role={role}
           {...rest}
         />
@@ -78,7 +84,7 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
       id: `${SPACE_PLUGIN}/collection-fallback`,
       role: 'article',
       position: 'fallback',
-      filter: (data): data is { subject: CollectionType } => isInstanceOf(CollectionType, data.subject),
+      filter: (data): data is { subject: DataType.Collection } => Obj.instanceOf(DataType.Collection, data.subject),
       component: ({ data }) => <CollectionMain collection={data.subject} />,
     }),
     createSurface({
@@ -91,8 +97,7 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
     createSurface({
       id: `${SPACE_PLUGIN}/companion/object-settings`,
       role: 'article',
-      filter: (data): data is { companionTo: AnyLiveObject<any> } =>
-        isEchoObject(data.companionTo) && data.subject === 'settings',
+      filter: (data): data is { companionTo: Obj.Any } => Obj.isObject(data.companionTo) && data.subject === 'settings',
       component: ({ data, role }) => <ObjectSettingsContainer object={data.companionTo} role={role} />,
     }),
     createSurface({
@@ -197,6 +202,78 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
         );
       },
     }),
+    createSurface({
+      id: `${SPACE_PLUGIN}/typename-form-input`,
+      role: 'form-input',
+      filter: (
+        data,
+      ): data is { prop: string; schema: Schema.Schema<any>; target: Space | DataType.Collection | undefined } => {
+        if (data.prop !== 'typename') {
+          return false;
+        }
+
+        const annotation = findAnnotation((data.schema as Schema.Schema.All).ast, TypenameAnnotationId);
+        return !!annotation;
+      },
+      component: ({ data: { schema, target }, ...inputProps }) => {
+        const { t } = useTranslation();
+        const client = useClient();
+        const props = inputProps as any as InputProps;
+        const space = isSpace(target) ? target : getSpace(target);
+        if (!space) {
+          return null;
+        }
+
+        const annotation = findAnnotation<TypenameAnnotation[]>(schema.ast, TypenameAnnotationId)!;
+
+        const schemaWhitelists = useCapabilities(ClientCapabilities.SchemaWhiteList);
+        const whitelistedTypenames = useMemo(
+          () => new Set(schemaWhitelists.flatMap((typeArray) => typeArray.map((type) => type.typename))),
+          [schemaWhitelists],
+        );
+
+        const objectForms = useCapabilities(SpaceCapabilities.ObjectForm);
+        const objectFormTypenames = useMemo(
+          () =>
+            new Set(
+              objectForms
+                .map((form) => Type.getTypename(form.objectSchema))
+                // TODO(wittjosiah): Remove.
+                .filter((typename) => !OMIT.includes(typename)),
+            ),
+          [objectForms],
+        );
+
+        const fixed = client.graph.schemaRegistry.schemas.filter((schema) => {
+          const limitedStatic =
+            annotation.includes('limited-static') && whitelistedTypenames.has(Type.getTypename(schema));
+          const objectForm = annotation.includes('object-form') && objectFormTypenames.has(Type.getTypename(schema));
+          return annotation.includes('static') || limitedStatic || objectForm;
+        });
+        const dynamic = space?.db.schemaRegistry.query().runSync();
+        const typenames = Array.from(
+          new Set<string>([
+            ...(annotation.includes('limited-static') ||
+            annotation.includes('static') ||
+            annotation.includes('object-form')
+              ? fixed.map((schema) => Type.getTypename(schema))
+              : []),
+            ...(annotation.includes('dynamic') ? dynamic.map((schema) => schema.typename) : []),
+          ]),
+        ).sort();
+
+        const options = useMemo(
+          () =>
+            typenames.map((typename) => ({
+              value: typename,
+              label: t('typename label', { ns: typename, defaultValue: typename }),
+            })),
+          [t, typenames],
+        );
+
+        return <SelectInput {...props} options={options} />;
+      },
+    }),
     createSurface({
       id: POPOVER_RENAME_SPACE,
       role: 'popover',
@@ -206,21 +283,21 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
     createSurface({
       id: POPOVER_RENAME_OBJECT,
       role: 'popover',
-      filter: (data): data is { props: AnyLiveObject<any> } =>
+      filter: (data): data is { props: Obj.Any } =>
         data.component === POPOVER_RENAME_OBJECT && isLiveObject(data.props),
       component: ({ data }) => <PopoverRenameObject object={data.props} />,
     }),
     createSurface({
       id: `${SPACE_PLUGIN}/menu-footer`,
       role: 'menu-footer',
-      filter: (data): data is { subject: AnyLiveObject<any> } => isEchoObject(data.subject),
+      filter: (data): data is { subject: Obj.Any } => Obj.isObject(data.subject),
       component: ({ data }) => <MenuFooter object={data.subject} />,
     }),
     createSurface({
       id: `${SPACE_PLUGIN}/navtree-presence`,
       role: 'navtree-item-end',
-      filter: (data): data is { id: string; subject: AnyLiveObject<any>; open?: boolean } =>
-        typeof data.id === 'string' && isEchoObject(data.subject),
+      filter: (data): data is { id: string; subject: Obj.Any; open?: boolean } =>
+        typeof data.id === 'string' && Obj.isObject(data.subject),
       component: ({ data }) => {
         // TODO(wittjosiah): Doesn't need to be mutable but readonly type messes with ComplexMap.
         const state = useCapability(SpaceCapabilities.MutableState);
@@ -246,13 +323,12 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
       id: `${SPACE_PLUGIN}/navbar-presence`,
       role: 'navbar-end',
       position: 'hoist',
-      filter: (data): data is { subject: Space | AnyLiveObject<any> } =>
-        isSpace(data.subject) || isEchoObject(data.subject),
+      filter: (data): data is { subject: Space | Obj.Any } => isSpace(data.subject) || Obj.isObject(data.subject),
       component: ({ data }) => {
         const space = isSpace(data.subject) ? data.subject : getSpace(data.subject);
         const object = isSpace(data.subject)
           ? data.subject.state.get() === SpaceState.SPACE_READY
-            ? (space?.properties[CollectionType.typename]?.target as CollectionType)
+            ? (space?.properties[Type.getTypename(DataType.Collection)]?.target as DataType.Collection)
             : undefined
           : data.subject;
 
@@ -262,7 +338,7 @@ export default ({ createInvitationUrl }: ReactSurfaceOptions) =>
     createSurface({
       id: `${SPACE_PLUGIN}/collection-section`,
       role: 'section',
-      filter: (data): data is { subject: CollectionType } => isInstanceOf(CollectionType, data.subject),
+      filter: (data): data is { subject: DataType.Collection } => Obj.instanceOf(DataType.Collection, data.subject),
       component: ({ data }) => <CollectionSection collection={data.subject} />,
     }),
     createSurface({

package/src/capabilities/schema-tools.ts

@@ -7,7 +7,8 @@ import { Schema, SchemaAST } from 'effect';
 import { createTool, ToolResult } from '@dxos/ai';
 import { Capabilities, contributes, type PromiseIntentDispatcher } from '@dxos/app-framework';
 import { type Space } from '@dxos/client/echo';
-import { FormatEnum, FormatEnums, SelectOptionSchema, GeoPoint, toJsonSchema } from '@dxos/echo-schema';
+import { Type } from '@dxos/echo';
+import { FormatEnum, FormatEnums, SelectOptionSchema } from '@dxos/echo-schema';
 import { invariant } from '@dxos/invariant';
 import { hues } from '@dxos/react-ui-theme';
 import { getSchemaFromPropertyDefinitions } from '@dxos/schema';
@@ -32,7 +33,7 @@ export const TypeNameSchema = Schema.String.pipe(
 );
 
 const formatDescription = `The format of the property. Additional information:
-  ${FormatEnum.GeoPoint}: ${JSON.stringify(toJsonSchema(GeoPoint))}
+  ${FormatEnum.GeoPoint}: ${JSON.stringify(Type.toJsonSchema(Type.Format.GeoPoint))}
   This tuple is GeoJSON. You must specify \`${FormatEnum.GeoPoint}\` as [Longitude, Latitude]`;
 
 // TODO(ZaymonFC): All properties are default optional, but maybe we should allow for required properties.

package/src/capabilities/settings.ts

@@ -5,7 +5,7 @@
 import { Capabilities, contributes } from '@dxos/app-framework';
 import { live } from '@dxos/live-object';
 
-import { SPACE_PLUGIN } from '../meta';
+import { meta } from '../meta';
 import { type SpaceSettingsProps, SpaceSettingsSchema } from '../types';
 
 export default () => {
@@ -13,5 +13,9 @@ export default () => {
     showHidden: false,
   });
 
-  return contributes(Capabilities.Settings, { schema: SpaceSettingsSchema, prefix: SPACE_PLUGIN, value: settings });
+  return contributes(Capabilities.Settings, {
+    prefix: meta.id,
+    schema: SpaceSettingsSchema,
+    value: settings,
+  });
 };

package/src/capabilities/spaces-ready.ts

@@ -4,18 +4,17 @@
 
 import { Option } from 'effect';
 
-import { contributes, createIntent, type PluginContext, Capabilities, LayoutAction } from '@dxos/app-framework';
+import { contributes, createIntent, Capabilities, LayoutAction, type PluginContext } from '@dxos/app-framework';
 import { SubscriptionList } from '@dxos/async';
-import { Expando } from '@dxos/echo-schema';
+import { Filter, Obj, Type } from '@dxos/echo';
 import { scheduledEffect } from '@dxos/echo-signals/core';
-import { live } from '@dxos/live-object';
 import { log } from '@dxos/log';
 import { AttentionCapabilities } from '@dxos/plugin-attention';
 import { ClientCapabilities } from '@dxos/plugin-client';
 import { DeckCapabilities } from '@dxos/plugin-deck';
 import { EdgeReplicationSetting } from '@dxos/protocols/proto/dxos/echo/metadata';
 import { PublicKey } from '@dxos/react-client';
-import { Filter, FQ_ID_LENGTH, parseFullyQualifiedId, SpaceState } from '@dxos/react-client/echo';
+import { FQ_ID_LENGTH, parseFullyQualifiedId, SpaceState } from '@dxos/react-client/echo';
 import { ComplexMap, reduceGroupBy } from '@dxos/util';
 
 import { SpaceCapabilities } from './capabilities';
@@ -32,7 +31,7 @@ export default async (context: PluginContext) => {
   const { dispatchPromise: dispatch } = context.getCapability(Capabilities.IntentDispatcher);
   const { graph } = context.getCapability(Capabilities.AppGraph);
   const layout = context.getCapability(Capabilities.Layout);
-  const deck = context.getCapability(DeckCapabilities.DeckState);
+  const deck = context.getCapabilities(DeckCapabilities.DeckState)[0];
   const attention = context.getCapability(AttentionCapabilities.Attention);
   const state = context.getCapability(SpaceCapabilities.MutableState);
   const client = context.getCapability(ClientCapabilities.Client);
@@ -40,7 +39,7 @@ export default async (context: PluginContext) => {
   const defaultSpace = client.spaces.default;
   await defaultSpace.waitUntilReady();
 
-  if (deck.activeDeck === 'default') {
+  if (deck?.activeDeck === 'default') {
     await dispatch(createIntent(LayoutAction.SwitchWorkspace, { part: 'workspace', subject: defaultSpace.id }));
   }
 
@@ -51,11 +50,11 @@ export default async (context: PluginContext) => {
 
   const {
     objects: [spacesOrder],
-  } = await defaultSpace.db.query(Filter.type(Expando, { key: SHARED })).run();
+  } = await defaultSpace.db.query(Filter.type(Type.Expando, { key: SHARED })).run();
   if (!spacesOrder) {
     // TODO(wittjosiah): Cannot be a Folder because Spaces are not TypedObjects so can't be saved in the database.
     //  Instead, we store order as an array of space ids.
-    defaultSpace.db.add(live({ key: SHARED, order: [] }));
+    defaultSpace.db.add(Obj.make(Type.Expando, { key: SHARED, order: [] }));
   }
 
   // Await missing objects.

package/src/components/CollectionMain.tsx

@@ -6,11 +6,11 @@ import React from 'react';
 
 import { useTranslation } from '@dxos/react-ui';
 import { baseSurface, descriptionMessage, mx } from '@dxos/react-ui-theme';
+import { type DataType } from '@dxos/schema';
 
 import { SPACE_PLUGIN } from '../meta';
-import type { CollectionType } from '../types';
 
-export const CollectionMain = ({ collection }: { collection: CollectionType }) => {
+export const CollectionMain = ({ collection }: { collection: DataType.Collection }) => {
   const { t } = useTranslation(SPACE_PLUGIN);
 
   return (
@@ -21,7 +21,7 @@ export const CollectionMain = ({ collection }: { collection: CollectionType }) =
     >
       <p
         role='alert'
-        className={mx(descriptionMessage, 'rounded-lg p-8 font-normal text-lg max-is-[24rem] break-words')}
+        className={mx(descriptionMessage, 'rounded-md p-8 font-normal text-lg max-is-[24rem] break-words')}
       >
         {collection.name ?? t('unnamed collection label')}
       </p>

package/src/components/CollectionSection.tsx

@@ -5,11 +5,11 @@
 import React from 'react';
 
 import { useTranslation } from '@dxos/react-ui';
+import { type DataType } from '@dxos/schema';
 
 import { SPACE_PLUGIN } from '../meta';
-import type { CollectionType } from '../types';
 
-export const CollectionSection = ({ collection }: { collection: CollectionType }) => {
+export const CollectionSection = ({ collection }: { collection: DataType.Collection }) => {
   const { t } = useTranslation(SPACE_PLUGIN);
   // TODO(wittjosiah): Better placeholder.
   return (

package/src/components/CreateDialog/CreateObjectDialog.stories.tsx

@@ -7,15 +7,16 @@ import '@dxos-theme';
 import { type Meta, type StoryObj } from '@storybook/react';
 import React, { useEffect } from 'react';
 
-import { live, Filter, useQuery, useSpace } from '@dxos/react-client/echo';
+import { Filter, Obj, Type } from '@dxos/echo';
+import { useQuery, useSpace } from '@dxos/react-client/echo';
 import { withClientProvider } from '@dxos/react-client/testing';
 import { Dialog } from '@dxos/react-ui';
+import { DataType } from '@dxos/schema';
 import { osTranslations } from '@dxos/shell/react';
 import { withLayout, withTheme } from '@dxos/storybook-utils';
 
 import { CreateObjectDialog, type CreateObjectDialogProps } from './CreateObjectDialog';
 import translations from '../../translations';
-import { CollectionType } from '../../types';
 
 const Story = (args: CreateObjectDialogProps) => {
   return (
@@ -33,7 +34,7 @@ const meta: Meta<typeof CreateObjectDialog> = {
   component: CreateObjectDialog,
   render: Story,
   decorators: [
-    withClientProvider({ createIdentity: true, createSpace: true, types: [CollectionType] }),
+    withClientProvider({ createIdentity: true, createSpace: true, types: [DataType.Collection] }),
     withTheme,
     withLayout(),
   ],
@@ -48,7 +49,7 @@ export default meta;
 export const Default: StoryObj<typeof CreateObjectDialog> = {};
 
 export const Typename: StoryObj<typeof CreateObjectDialog> = {
-  args: { typename: CollectionType.typename },
+  args: { typename: Type.getTypename(DataType.Collection) },
 };
 
 export const TargetSpace: StoryObj<typeof CreateObjectDialog> = {
@@ -66,11 +67,11 @@ export const TargetSpace: StoryObj<typeof CreateObjectDialog> = {
 export const TargetCollection: StoryObj<typeof CreateObjectDialog> = {
   render: (args) => {
     const space = useSpace();
-    const [collection] = useQuery(space, Filter.type(CollectionType));
+    const [collection] = useQuery(space, Filter.type(DataType.Collection));
 
     useEffect(() => {
       if (space) {
-        space.db.add(live(CollectionType, { name: 'My Collection', objects: [], views: {} }));
+        space.db.add(Obj.make(DataType.Collection, { name: 'My Collection', objects: [] }));
       }
     }, [space]);
 

package/src/components/CreateDialog/CreateObjectDialog.tsx

@@ -3,36 +3,40 @@
 //
 
 import { pipe } from 'effect';
-import React, { useCallback, useRef } from 'react';
+import React, { useCallback, useRef, useState } from 'react';
 
 import {
   Capabilities,
+  LayoutAction,
   chain,
   createIntent,
-  LayoutAction,
   useCapabilities,
   useIntentDispatcher,
   usePluginManager,
 } from '@dxos/app-framework';
+import { Query, Type, type Obj } from '@dxos/echo';
 import { invariant } from '@dxos/invariant';
 import { useClient } from '@dxos/react-client';
-import { getSpace, isLiveObject, isSpace, type Live, useSpaces } from '@dxos/react-client/echo';
+import { getSpace, isLiveObject, isSpace, type Space, useQuery, useSpaces } from '@dxos/react-client/echo';
 import { Button, Dialog, Icon, useTranslation } from '@dxos/react-ui';
+import { cardDialogContent, cardDialogHeader } from '@dxos/react-ui-stack';
+import { DataType } from '@dxos/schema';
+import { isNonNullable } from '@dxos/util';
 
 import { CreateObjectPanel, type CreateObjectPanelProps } from './CreateObjectPanel';
 import { SpaceCapabilities } from '../../capabilities';
 import { SPACE_PLUGIN } from '../../meta';
-import { type ObjectForm, SpaceAction } from '../../types';
+import { SpaceAction } from '../../types';
 
 export const CREATE_OBJECT_DIALOG = `${SPACE_PLUGIN}/CreateObjectDialog`;
 
 export type CreateObjectDialogProps = Pick<CreateObjectPanelProps, 'target' | 'typename' | 'name'> & {
-  shouldNavigate?: (object: Live<any>) => boolean;
+  shouldNavigate?: (object: Obj.Any) => boolean;
 };
 
 export const CreateObjectDialog = ({
-  target,
-  typename,
+  target: initialTarget,
+  typename: initialTypename,
   name,
   shouldNavigate: _shouldNavigate,
 }: CreateObjectDialogProps) => {
@@ -43,23 +47,20 @@ export const CreateObjectDialog = ({
   const spaces = useSpaces();
   const { dispatchPromise: dispatch } = useIntentDispatcher();
   const forms = useCapabilities(SpaceCapabilities.ObjectForm);
+  const [target, setTarget] = useState<Space | DataType.Collection | undefined>(initialTarget);
+  const [typename, setTypename] = useState<string | undefined>(initialTypename);
+  const space = isSpace(target) ? target : getSpace(target);
+  const queryCollections = useQuery(space, Query.type(DataType.QueryCollection));
+  const hiddenTypenames = queryCollections.map((collection) => collection.query.typename).filter(isNonNullable);
 
-  const resolve = useCallback(
-    (typename: string) =>
+  const resolve = useCallback<NonNullable<CreateObjectPanelProps['resolve']>>(
+    (typename) =>
       manager.context.getCapabilities(Capabilities.Metadata).find(({ id }) => id === typename)?.metadata ?? {},
     [manager],
   );
 
-  const handleCreateObject = useCallback(
-    async ({
-      form,
-      target,
-      data = {},
-    }: {
-      form: ObjectForm;
-      target: CreateObjectPanelProps['target'];
-      data?: Record<string, any>;
-    }) => {
+  const handleCreateObject = useCallback<NonNullable<CreateObjectPanelProps['onCreateObject']>>(
+    async ({ form, data = {} }) => {
       if (!target) {
         // TODO(wittjosiah): UI feedback.
         return;
@@ -73,7 +74,9 @@ export const CreateObjectDialog = ({
       const result = await dispatch(form.getIntent(data, { space }));
       const object = result.data?.object;
       if (isLiveObject(object)) {
-        const addObjectIntent = createIntent(SpaceAction.AddObject, { target, object, hidden: form.hidden });
+        // TODO(wittjosiah): Selection in navtree isn't working as expected when hidden typenames evals to true.
+        const hidden = form.hidden || hiddenTypenames.includes(Type.getTypename(form.objectSchema));
+        const addObjectIntent = createIntent(SpaceAction.AddObject, { target, object, hidden });
         const shouldNavigate = _shouldNavigate ?? (() => true);
         if (shouldNavigate(object)) {
           await dispatch(pipe(addObjectIntent, chain(LayoutAction.Open, { part: 'main' })));
@@ -82,15 +85,17 @@ export const CreateObjectDialog = ({
         }
       }
     },
-    [dispatch, resolve],
+    [dispatch, target, resolve, hiddenTypenames, _shouldNavigate],
   );
 
   return (
     // TODO(wittjosiah): The tablist dialog pattern is copied from @dxos/plugin-manager.
     //  Consider factoring it out to the tabs package.
-    <Dialog.Content classNames='p-0 bs-content max-bs-full md:max-is-[40rem] overflow-hidden'>
-      <div role='none' className='flex justify-between pbs-2 pis-2 pie-2 @md:pbs-4 @md:pis-4 @md:pie-4'>
-        <Dialog.Title>{t('create object dialog title')}</Dialog.Title>
+    <Dialog.Content classNames={cardDialogContent}>
+      <div role='none' className={cardDialogHeader}>
+        <Dialog.Title>
+          {t('create object dialog title', { object: t('typename label', { ns: typename, defaultValue: 'Item' }) })}
+        </Dialog.Title>
         <Dialog.Close asChild>
           <Button ref={closeRef} density='fine' variant='ghost' autoFocus>
             <Icon icon='ph--x--regular' size={4} />
@@ -99,7 +104,6 @@ export const CreateObjectDialog = ({
       </div>
 
       <CreateObjectPanel
-        classNames='p-4'
         forms={forms}
         spaces={spaces}
         target={target}
@@ -107,6 +111,8 @@ export const CreateObjectDialog = ({
         name={name}
         defaultSpaceId={client.spaces.default.id}
         resolve={resolve}
+        onTargetChange={setTarget}
+        onTypenameChange={setTypename}
         onCreateObject={handleCreateObject}
       />
     </Dialog.Content>