@dxos/plugin-assistant 0.8.4-main.dedc0f3 → 0.8.4-main.dfabb4ec29

package/src/components/ChatThread/testing/thread-widgets.md

@@ -0,0 +1,79 @@
+<prompt>Analyze this codebase and suggest improvements.</prompt>
+
+<reasoning>
+The user wants a comprehensive analysis of their codebase. I should examine the project structure, identify key patterns, and look for areas that could be improved. Let me start by reviewing the main source files and dependencies.
+</reasoning>
+
+I'll start by examining the project structure and key files.
+
+<toolCall id="toolu_01ABC123analyze" />
+
+<summary>Analyzed 42 files across 8 packages. Found 3 areas for improvement.</summary>
+
+Here's what I found after reviewing the codebase:
+
+## Architecture
+
+The project follows a modular plugin architecture with clear separation of concerns. Each plugin manages its own state and communicates through a shared event bus.
+
+## Suggested Improvements
+
+1. **Type Safety** — Several utility functions use `any` types that could be narrowed. This would catch bugs at compile time rather than runtime.
+
+2. **Error Handling** — The API layer could benefit from structured error types using discriminated unions instead of thrown exceptions.
+
+3. **Performance** — The subscription handlers in the data layer create new closures on every update. Memoizing these would reduce GC pressure.
+
+<reference ref="dxn:echo:@:123e4567-e89b-12d3-a456-426614174000">ProjectConfig</reference>
+
+Would you like me to dive deeper into any of these areas?
+
+<select>
+<option>Improve type safety</option>
+<option>Refactor error handling</option>
+<option>Optimize performance</option>
+</select>
+
+<suggestion>Show me the specific files that need type improvements</suggestion>
+
+<suggestion>Generate a refactoring plan as a document</suggestion>
+
+<stats>3 tool uses · 12.4k tokens · 18.2s</stats>
+
+<prompt>Improve type safety</prompt>
+
+<reasoning>
+The user chose to focus on type safety improvements. I should identify the specific files and patterns where `any` types are used unnecessarily and propose concrete fixes with before/after examples.
+</reasoning>
+
+Let me find all the locations where type safety can be improved.
+
+<toolCall id="toolu_01DEF456typescan" />
+
+<summary>Scanned 42 files. Found 17 instances of unnecessary `any` usage across 6 modules.</summary>
+
+Here are the key changes I recommend:
+
+### `src/utils/transform.ts`
+
+The `transform` function currently accepts `any` for its input parameter. We can use a generic constraint instead:
+
+```typescript
+// Before
+const transform = (input: any) => { ... }
+
+// After
+const transform = <T extends Record<string, unknown>>(input: T) => { ... }
+```
+
+### `src/handlers/events.ts`
+
+The event handler map uses `any` for callback types. A mapped type would preserve type information:
+
+```typescript
+type EventHandlers = {
+  [K in keyof EventMap]: (event: EventMap[K]) => void;
+};
+```
+
+<stats>1 tool use · 8.7k tokens · 12.1s</stats>

package/src/components/ChatThread/tool-widget-state.test.ts

@@ -0,0 +1,34 @@
+//
+// Copyright 2026 DXOS.org
+//
+
+import { describe, expect, test } from 'vitest';
+
+import { createMessage } from '#testing';
+
+import { rehydrateToolWidgetsFromMessages } from './tool-widget-state';
+
+describe('rehydrateToolWidgetsFromMessages', () => {
+  test('replays toolCall then toolResult in order', () => {
+    const calls: Array<{ id: string; kind: 'object' | 'function' }> = [];
+    const sink = {
+      updateWidget: (id: string, value: unknown) => {
+        calls.push({ id, kind: typeof value === 'function' ? 'function' : 'object' });
+      },
+    };
+
+    const messages = [
+      createMessage('assistant', [
+        { _tag: 'toolCall', toolCallId: 't1', name: 'foo', input: '{}', providerExecuted: false },
+        { _tag: 'toolResult', toolCallId: 't1', name: 'foo', result: '{}', providerExecuted: false },
+      ]),
+    ];
+
+    rehydrateToolWidgetsFromMessages(sink, messages);
+
+    expect(calls).toEqual([
+      { id: 't1', kind: 'object' },
+      { id: 't1', kind: 'function' },
+    ]);
+  });
+});

package/src/components/ChatThread/tool-widget-state.ts

@@ -0,0 +1,48 @@
+//
+// Copyright 2026 DXOS.org
+//
+
+import { type ContentBlock, type Message } from '@dxos/types';
+import { type StateDispatch } from '@dxos/ui-editor';
+
+/**
+ * Minimal surface used to push tool call / result blocks into {@link MarkdownStreamController} widget state.
+ */
+export type ToolWidgetStateSink = {
+  updateWidget<T>(id: string, value: StateDispatch<T>): void;
+};
+
+/**
+ * Mirrors tool-related branches of {@link blockToMarkdown} so widget props stay in sync with message blocks.
+ */
+export const applyToolBlockToWidgetState = (context: ToolWidgetStateSink, block: ContentBlock.Any): void => {
+  switch (block._tag) {
+    case 'toolCall': {
+      context.updateWidget<{ blocks: ContentBlock.Any[] }>(block.toolCallId, {
+        blocks: [block],
+      });
+      break;
+    }
+    case 'toolResult': {
+      context.updateWidget<{ blocks: ContentBlock.Any[] }>(block.toolCallId, ({ blocks = [] } = { blocks: [] }) => ({
+        blocks: [...blocks, block],
+      }));
+      break;
+    }
+    default: {
+      break;
+    }
+  }
+};
+
+/**
+ * Re-applies tool widget state after a full document replace (e.g. {@link MarkdownStreamController.setContent}),
+ * which clears accumulated widget props via `xmlTagResetEffect`.
+ */
+export const rehydrateToolWidgetsFromMessages = (context: ToolWidgetStateSink, messages: Message.Message[]): void => {
+  for (const message of messages) {
+    for (const block of message.blocks) {
+      applyToolBlockToWidgetState(context, block);
+    }
+  }
+};

package/src/components/ChatThread/widgets/FallbackWidget.tsx

@@ -0,0 +1,26 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import React from 'react';
+
+import { TogglePanel } from '@dxos/react-ui-components';
+import { JsonHighlighter } from '@dxos/react-ui-syntax-highlighter';
+import { type XmlWidgetProps } from '@dxos/ui-editor';
+
+import { type MessageThreadContext } from '../sync';
+
+export const FallbackWidget = ({ _tag, ...props }: XmlWidgetProps<MessageThreadContext>) => {
+  return (
+    <TogglePanel.Root>
+      <TogglePanel.Header classNames='bg-group-surface'>{_tag}</TogglePanel.Header>
+      <TogglePanel.Content classNames='bg-modal-surface'>
+        <TogglePanel.Viewport>
+          <JsonHighlighter classNames='p-2! text-sm' data={props} />
+        </TogglePanel.Viewport>
+      </TogglePanel.Content>
+    </TogglePanel.Root>
+  );
+};
+
+FallbackWidget.displayName = 'Fallback';

package/src/components/ChatThread/widgets/ReasoningWidget.stories.tsx

@@ -0,0 +1,68 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { type Meta, type StoryObj } from '@storybook/react-vite';
+import React, { useEffect, useRef } from 'react';
+
+import { withLayout, withTheme } from '@dxos/react-ui/testing';
+
+import { ReasoningWidget } from './ReasoningWidget';
+
+export type DefaultStoryProps = {
+  text: string;
+};
+
+// TODO(burdon): Generalize factory for DOM widgets.
+const DefaultStory = ({ text }: DefaultStoryProps) => {
+  const hostRef = useRef<HTMLDivElement>(null);
+  useEffect(() => {
+    const host = hostRef.current;
+    if (!host) {
+      return;
+    }
+
+    host.replaceChildren();
+    const widget = new ReasoningWidget(text, 0);
+    const dom = widget.toDOM();
+    host.appendChild(dom);
+    widget.updateDOM(dom);
+    return () => {
+      widget.destroy(dom);
+      host.replaceChildren();
+    };
+  }, [text]);
+
+  return <div ref={hostRef} />;
+};
+
+const meta = {
+  title: 'plugins/plugin-assistant/components/ChatWidgets/ReasoningWidget',
+  component: DefaultStory,
+  decorators: [withTheme(), withLayout({ layout: 'column' })],
+  parameters: {
+    layout: 'fullscreen',
+  },
+} satisfies Meta<typeof DefaultStory>;
+
+export default meta;
+
+type Story = StoryObj<typeof meta>;
+
+export const Default: Story = {
+  args: {
+    text: 'The user is asking about nested flex layouts and overflow. I should mention min-height 0 and grid track sizing.',
+  },
+};
+
+export const LongText: Story = {
+  args: {
+    text: [
+      'Step 1: Identify the scroll container and ensure it participates in a definite height chain.',
+      'Step 2: Apply min-h-0 to flex children that should shrink and scroll.',
+      'Step 3: Prefer overflow-y-auto on the leaf viewport, not on every ancestor.',
+      'Step 4: Use min-h-0 on the scroll container to ensure it participates in a definite height chain.',
+      'Step 5: Use min-w-0 on the scroll container to ensure it participates in a definite width chain.',
+    ].join('\n\n'),
+  },
+};

package/src/components/ChatThread/widgets/ReasoningWidget.ts

@@ -0,0 +1,133 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { WidgetType } from '@codemirror/view';
+
+import { Domino } from '@dxos/ui';
+
+import { styles } from './defaults';
+
+/**
+ * Props used to derive a stable key for a reasoning block across CodeMirror widget rebuilds.
+ * CodeMirror does not assign persistent IDs to widgets; streaming re-runs the factory each tick.
+ */
+export type ReasoningWidgetBlockIdProps = {
+  id?: string;
+  range?: { from: number; to: number };
+};
+
+/**
+ * AI reasoning widget.
+ */
+export class ReasoningWidget extends WidgetType {
+  readonly #pos: string;
+  /** The timer id last registered for this instance (may differ from the map if superseded). */
+  #ownedTimerId: ReturnType<typeof setTimeout> | null = null;
+
+  constructor(
+    private readonly text: string,
+    pos: string | number | undefined,
+  ) {
+    super();
+    this.#pos = pos === undefined || pos === '' ? 'reasoning' : String(pos);
+  }
+
+  override eq(other: this) {
+    return this.text === other.text && this.#pos === other.#pos;
+  }
+
+  override toDOM() {
+    return Domino.of('div')
+      .classNames(styles.padding)
+      .append(
+        Domino.of('div')
+          .classNames('relative overflow-hidden p-px', styles.border)
+          .attributes({ 'data-trail-container': '' })
+          .append(
+            Domino.of('div')
+              .classNames('relative z-10 bg-base-surface rounded-sm text-sm text-subdued py-1')
+              .append(
+                Domino.of('div')
+                  .classNames('px-2 max-h-[5lh] overflow-y-auto dx-scrollbar-thin')
+                  .text(this.text)
+                  .attributes({ 'data-reasoning-text': '' }),
+              ),
+            Domino.of('div').attributes({ 'data-id': this.#pos }),
+          ),
+      ).root;
+  }
+
+  override updateDOM(dom: HTMLElement) {
+    // Update only the text leaf; `dom` may be wrapped in an outer shell, and the trail host is a
+    // sibling of the text node inside the bordered container — setting `textContent` on the wrong
+    // ancestor would remove `[data-id]`.
+    dom.querySelector<HTMLElement>('[data-reasoning-text]')?.replaceChildren(this.text);
+
+    // Recreate trail host if it was removed by a prior timeout (streaming paused > TRAIL_REMOVAL_DELAY_MS).
+    const container = dom.querySelector<HTMLElement>('[data-trail-container]');
+    let trailHost = container?.querySelector<HTMLElement>('[data-id]');
+    if (container && !trailHost) {
+      trailHost = Domino.of('div').attributes({ 'data-id': this.#pos }).root;
+      container.append(trailHost);
+    }
+    if (trailHost?.childElementCount === 0) {
+      trailHost.append(...createTrailLayers());
+    }
+
+    this.#scheduleTrailRemoval(dom);
+    return true;
+  }
+
+  override destroy(_dom: HTMLElement) {
+    this.#clearOwnedTrailTimer();
+  }
+
+  #scheduleTrailRemoval(dom: HTMLElement) {
+    const previous = trailRemovalTimers.get(this.#pos);
+    if (previous !== undefined) {
+      clearTimeout(previous);
+    }
+
+    const timerId = setTimeout(() => {
+      if (trailRemovalTimers.get(this.#pos) !== timerId) {
+        return;
+      }
+      trailRemovalTimers.delete(this.#pos);
+      this.#ownedTimerId = null;
+      dom.querySelector<HTMLElement>('[data-id]')?.remove();
+    }, TRAIL_REMOVAL_DELAY_MS);
+
+    trailRemovalTimers.set(this.#pos, timerId);
+    this.#ownedTimerId = timerId;
+  }
+
+  #clearOwnedTrailTimer() {
+    const active = trailRemovalTimers.get(this.#pos);
+    if (active !== undefined && active === this.#ownedTimerId) {
+      clearTimeout(active);
+      trailRemovalTimers.delete(this.#pos);
+    }
+    this.#ownedTimerId = null;
+  }
+}
+
+const trail = [
+  'absolute z-0 aspect-[2/1] w-16',
+  'bg-[radial-gradient(at_100%_50%,_theme(colors.green.700),_transparent_80%)]',
+  '[offset-anchor:100%_50%] [offset-path:border-box]',
+];
+
+/** Delay after the last content update before hiding the trail. */
+const TRAIL_REMOVAL_DELAY_MS = 1_000;
+
+/**
+ * One pending removal timer per logical block. Streaming creates a new widget instance each tick;
+ * `destroy` may run after the next instance has already scheduled, so we must not clear a newer timer.
+ */
+const trailRemovalTimers = new Map<string, ReturnType<typeof setTimeout>>();
+
+const createTrailLayers = (): [HTMLElement, HTMLElement] => [
+  Domino.of('div').classNames(...trail, 'animate-trail').root,
+  Domino.of('div').classNames(...trail, 'animate-trail-offset').root,
+];

package/src/components/ChatThread/widgets/ReferenceWidget.ts

@@ -0,0 +1,33 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { WidgetType } from '@codemirror/view';
+
+import { Domino } from '@dxos/ui';
+
+import { styles } from './defaults';
+
+export class ReferenceWidget extends WidgetType {
+  constructor(
+    private text: string,
+    private dxn: string,
+  ) {
+    super();
+  }
+
+  override eq(other: this) {
+    return this.dxn === other.dxn;
+  }
+
+  override toDOM() {
+    return Domino.of('div')
+      .classNames(styles.padding)
+      .append(
+        Domino.of('dx-anchor' as any)
+          .classNames('dx-tag--anchor')
+          .attributes({ dxn: this.dxn })
+          .text(this.text),
+      ).root;
+  }
+}

package/src/components/ChatThread/widgets/SelectWidget.ts

@@ -0,0 +1,39 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { WidgetType } from '@codemirror/view';
+
+import { Domino } from '@dxos/ui';
+
+import { styles } from './defaults';
+
+/**
+ * Simple prompt widget.
+ */
+export class SelectWidget extends WidgetType {
+  constructor(private options: string[]) {
+    super();
+  }
+
+  override eq(other: this) {
+    return JSON.stringify(this.options) === JSON.stringify(other.options);
+  }
+
+  /**
+   * NOTE: Container must set var based on user's identity.
+   */
+  override toDOM() {
+    return Domino.of('div')
+      .attributes({ role: 'group' })
+      .classNames(styles.padding, 'flex flex-wrap gap-1')
+      .append(
+        ...this.options.map((option) =>
+          Domino.of('button')
+            .classNames('dx-button inline-block max-w-[100cqi]')
+            .attributes({ 'data-action': 'submit', 'data-value': option, 'data-density': 'fine' })
+            .text(option),
+        ),
+      ).root;
+  }
+}

package/src/components/ChatThread/widgets/StatsWidget.ts

@@ -0,0 +1,31 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { WidgetType } from '@codemirror/view';
+
+import { Domino } from '@dxos/ui';
+
+import { styles } from './defaults';
+
+/**
+ * Simple stats widget.
+ */
+export class StatsWidget extends WidgetType {
+  constructor(private text: string) {
+    super();
+  }
+
+  override eq(other: this) {
+    return this.text === other.text;
+  }
+
+  override toDOM() {
+    return Domino.of('div').classNames(styles.padding, 'text-sm text-placeholder').text(this.text).root;
+  }
+
+  override updateDOM(dom: HTMLElement) {
+    dom.textContent = this.text;
+    return true;
+  }
+}

package/src/components/ChatThread/widgets/StatusWidget.ts

@@ -0,0 +1,53 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { WidgetType } from '@codemirror/view';
+
+import { Domino } from '@dxos/ui';
+
+import { styles } from './defaults';
+
+/**
+ * AI status widget.
+ */
+export class StatusWidget extends WidgetType {
+  constructor(private readonly text: string) {
+    super();
+  }
+
+  override eq(other: this) {
+    return this.text === other.text;
+  }
+
+  override toDOM() {
+    return Domino.of('div')
+      .classNames(styles.padding)
+      .append(
+        Domino.of('div')
+          .classNames('relative overflow-hidden rounded-sm')
+          .append(
+            Domino.of('div')
+              .classNames('grid grid-cols-[24px_1fr] gap-x-0.5 gap-y-0 items-start px-0.5 py-0.5 text-placeholder')
+              .append(
+                Domino.of('div')
+                  .classNames('flex h-5 w-full shrink-0 items-center justify-center self-start')
+                  .append(Domino.of('span').classNames('block size-1.5 shrink-0 rounded-full bg-current opacity-45')),
+                Domino.of('div')
+                  .classNames('relative min-w-0')
+                  .append(
+                    Domino.of('div')
+                      .classNames('relative z-10 rounded-sm text-sm leading-5')
+                      .attributes({ 'data-status-text': '' })
+                      .text(this.text),
+                  ),
+              ),
+          ),
+      ).root;
+  }
+
+  override updateDOM(dom: HTMLElement) {
+    dom.querySelector<HTMLElement>('[data-status-text]')?.replaceChildren(this.text);
+    return true;
+  }
+}

package/src/components/ChatThread/widgets/SuggestionWidget.ts

@@ -0,0 +1,41 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { WidgetType } from '@codemirror/view';
+
+import { Domino, mx } from '@dxos/ui';
+
+/**
+ * Simple prompt widget.
+ */
+export class SuggestionWidget extends WidgetType {
+  constructor(private text: string) {
+    super();
+  }
+
+  override eq(other: this) {
+    return this.text === other.text;
+  }
+
+  override toDOM() {
+    // NOTE: Container must have `dx-inline-size-container` (or `dx-size-container`) to support cqi.
+    return Domino.of('span')
+      .classNames(mx('inline-flex max-w-[calc(100cqi-8px)] my-1 pe-2 overflow-hidden'))
+      .append(
+        Domino.of('button')
+          .attributes({
+            'data-action': 'submit',
+            'data-density': 'fine',
+            'data-value': this.text,
+          })
+          .classNames(mx('dx-button gap-2 w-full overflow-hidden'))
+          .append(
+            Domino.of('dx-icon' as any).attributes({
+              icon: 'ph--lightning--regular',
+            }),
+            Domino.of('span').classNames('flex-1 truncate min-w-0').text(this.text),
+          ),
+      ).root;
+  }
+}

package/src/components/ChatThread/widgets/SummaryWidget.tsx

@@ -0,0 +1,27 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import React from 'react';
+
+import { useTranslation } from '@dxos/react-ui';
+import { TogglePanel } from '@dxos/react-ui-components';
+import { type XmlWidgetProps } from '@dxos/ui-editor';
+
+import { meta } from '#meta';
+
+import { MessageThreadContext } from '../sync';
+import { styles } from './defaults';
+
+export const SummaryWidget = ({ children }: XmlWidgetProps<MessageThreadContext>) => {
+  const { t } = useTranslation(meta.id);
+
+  return (
+    <TogglePanel.Root classNames={styles.border}>
+      <TogglePanel.Header classNames='text-sm bg-group-surface'>{t('summary.label')}</TogglePanel.Header>
+      <TogglePanel.Content>
+        <div className='p-1 text-sm text-subdued'>{children}</div>
+      </TogglePanel.Content>
+    </TogglePanel.Root>
+  );
+};

package/src/components/ChatThread/widgets/ToolWidget.stories.tsx

@@ -0,0 +1,55 @@
+//
+// Copyright 2025 DXOS.org
+//
+
+import { type Meta, type StoryObj } from '@storybook/react-vite';
+
+import { withLayout, withTheme } from '@dxos/react-ui/testing';
+import { type ContentBlock } from '@dxos/types';
+
+import { translations } from '#translations';
+
+import { ToolWidget, type ToolWidgetProps } from './ToolWidget';
+
+const baseWidgetProps = {
+  _tag: 'toolCall',
+  range: { from: 0, to: 1 },
+} satisfies Pick<ToolWidgetProps, '_tag' | 'range'>;
+
+const toolCallAndResult: ContentBlock.Any[] = [
+  {
+    _tag: 'toolCall',
+    toolCallId: 'tc-story-1',
+    name: 'example_tool',
+    input: JSON.stringify({ query: 'status', limit: 10 }),
+    providerExecuted: false,
+  },
+  {
+    _tag: 'toolResult',
+    toolCallId: 'tc-story-1',
+    name: 'example_tool',
+    result: JSON.stringify({ ok: true, rows: [{ id: 1 }, { id: 2 }] }),
+    providerExecuted: false,
+  },
+];
+
+const meta = {
+  title: 'plugins/plugin-assistant/components/ChatWidgets/ToolWidget',
+  component: ToolWidget,
+  decorators: [withTheme(), withLayout({ layout: 'column' })],
+  parameters: {
+    layout: 'fullscreen',
+    translations,
+  },
+} satisfies Meta<typeof ToolWidget>;
+
+export default meta;
+
+type Story = StoryObj<typeof meta>;
+
+export const Default: Story = {
+  args: {
+    ...baseWidgetProps,
+    blocks: toolCallAndResult,
+  },
+};