@dxos/plugin-assistant 0.8.4-main.ae835ea → 0.8.4-main.bcb3aa67d6

package/src/processor/processor.ts

@@ -2,16 +2,14 @@
 // Copyright 2025 DXOS.org
 //
 
-import { Registry, Rx } from '@effect-rx/rx-react';
-import * as Cause from 'effect/Cause';
+import { Atom, Registry } from '@effect-atom/atom-react';
 import * as Effect from 'effect/Effect';
-import * as Exit from 'effect/Exit';
 import * as Fiber from 'effect/Fiber';
 import * as Option from 'effect/Option';
-import * as Runtime from 'effect/Runtime';
+import * as Stream from 'effect/Stream';
 
 import {
-  AiService,
+  type AiService,
   DEFAULT_EDGE_MODEL,
   type ModelName,
   type ModelRegistry,
@@ -19,52 +17,61 @@ import {
   type ToolResolverService,
 } from '@dxos/ai';
 import {
+  AiContextService,
   type AiConversation,
-  type AiConversationRunParams,
-  ArtifactDiffResolver,
-  GenerationObserver,
   createSystemPrompt,
+  formatSystemPrompt,
+  AgentService,
+  PartialBlock,
 } from '@dxos/assistant';
+import { type Chat } from '@dxos/assistant-toolkit';
 import { type Blueprint } from '@dxos/blueprints';
-import { Obj } from '@dxos/echo';
-import { throwCause } from '@dxos/effect';
+import { type Database, Feed, Obj, Ref } from '@dxos/echo';
 import {
+  Trace,
   type CredentialsService,
-  type DatabaseService,
   type FunctionInvocationService,
   type QueueService,
   type TracingService,
 } from '@dxos/functions';
+import { runAndForwardErrors } from '@dxos/effect';
 import { log } from '@dxos/log';
-import { type ContentBlock, DataType } from '@dxos/schema';
-
-import { type Assistant } from '../types';
+import { Message } from '@dxos/types';
 
 import { updateName } from './update-name';
+import type { AutomationCapabilities } from '@dxos/plugin-automation/types';
 
+/**
+ * @deprecated Services type for the old direct-conversation processor path.
+ * Retained for backward compatibility with CLI and update-name.
+ */
 export type AiChatServices =
   | CredentialsService
-  | DatabaseService
+  | Database.Service
   | QueueService
   | FunctionInvocationService
   | AiService.AiService
   | ToolExecutionService
   | ToolResolverService
-  | TracingService;
+  | TracingService
+  | Trace.TraceService;
 
 export type AiChatProcessorOptions = {
   model?: ModelName;
   modelRegistry?: ModelRegistry;
   blueprintRegistry?: Blueprint.Registry;
   observableRegistry?: Registry.Registry;
-  extensions?: ToolContextExtensions;
-} & Pick<AiConversationRunParams, 'system'>;
+  /**
+   * For tracing.
+   */
+  chat?: Ref.Ref<Chat.Chat>;
+  system?: string;
+};
 
 const defaultOptions: Partial<AiChatProcessorOptions> = {
   model: DEFAULT_EDGE_MODEL,
 };
 
-// TODO(burdon): Retry, timeout?
 export type AiRequestOptions = {};
 
 export type AiRequest = {
@@ -74,55 +81,45 @@ export type AiRequest = {
 
 /**
  * Handles interactions with the AI service.
- * Handles streaming responses from the conversation.
+ * Uses AgentService to spawn a process-backed agent and subscribes to ephemeral trace events for streaming.
  */
 export class AiChatProcessor {
-  private readonly _rx: Registry.Registry;
+  readonly #registry: Registry.Registry;
 
-  /** External observer. */
-  private readonly _observer: GenerationObserver;
+  /** Pending messages (finalized, non-streaming). */
+  readonly #pending = Atom.make<Message.Message[]>([]);
 
-  /** Currently active request fiber. */
-  private _fiber: Fiber.Fiber<void, any> | undefined;
+  /** Currently streaming messages (from ephemeral trace events). */
+  readonly #streaming = Atom.make<Message.Message[]>([]);
 
-  /** Last request (for retries). */
-  private _lastRequest: AiRequest | undefined;
+  /** Set of message IDs that have been finalized (non-pending delivered via ephemeral). */
+  readonly #finalizedIds = new Set<string>();
 
-  /** Pending messages (incl. the current user request). */
-  private readonly _pending = Rx.make<DataType.Message[]>([]);
+  /** Currently active request fiber. */
+  #requestFiber: Fiber.RuntimeFiber<void, unknown> | undefined;
 
-  /** Currently streaming message (from the AI service). */
-  private readonly _streaming = Rx.make<Option.Option<DataType.Message>>(Option.none());
+  /** Last request (for retries). */
+  #lastRequest: AiRequest | undefined;
 
   /** Streaming state. */
-  public readonly streaming = Rx.make<boolean>((get) => Option.isSome(get(this._streaming)));
+  public readonly streaming = Atom.make<boolean>((get) => get(this.#streaming).length > 0);
 
   /** Active state. */
-  public readonly active = Rx.make(false);
+  public readonly active = Atom.make(false);
 
   /** Array of Messages (incl. the current message being streamed). */
-  public readonly messages = Rx.make<DataType.Message[]>((get) =>
-    Option.match(get(this._streaming), {
-      onNone: () => get(this._pending),
-      onSome: (streaming) => [...get(this._pending), streaming],
-    }),
-  );
+  public readonly messages = Atom.make<Message.Message[]>((get) => [...get(this.#pending), ...get(this.#streaming)]);
 
   /** Last error. */
-  public readonly error = Rx.make<Option.Option<Error>>(Option.none());
+  public readonly error = Atom.make<Option.Option<Error>>(Option.none());
 
   constructor(
     private readonly _conversation: AiConversation,
-    // TODO(dmaretskyi): Replace this with effect's ManagedRuntime wrapping this layer.
-    private readonly _services: () => Promise<Runtime.Runtime<AiChatServices>>,
+    private readonly _runtime: AutomationCapabilities.ComputeRuntime,
+    private readonly _feed: Feed.Feed,
     private readonly _options: AiChatProcessorOptions = defaultOptions,
   ) {
-    // Initialize registries and defaults before using in other logic.
-    this._rx = this._options.observableRegistry ?? Registry.make();
-    this._observer = GenerationObserver.make({
-      onBlock: this._onBlock,
-      onMessage: this._onMessage,
-    });
+    this.#registry = this._options.observableRegistry ?? Registry.make();
     if (this._options.model && !this._options.system) {
       const capabilities = this._options.modelRegistry?.getCapabilities(this._options.model) ?? {};
       this._options.system = createSystemPrompt(capabilities);
@@ -141,54 +138,84 @@ export class AiChatProcessor {
     return this._options.blueprintRegistry;
   }
 
+  get system(): string {
+    return this._options.system ?? '';
+  }
+
+  async getTools(): Promise<Record<string, any>> {
+    return this._runtime.runPromise(this._conversation.getTools());
+  }
+
+  async getSystemPrompt(): Promise<string> {
+    return this._runtime.runPromise(
+      Effect.gen(this, function* () {
+        const blueprints = this.context.getBlueprints();
+        const objects = this.context.getObjects();
+        return yield* formatSystemPrompt({ system: this._options.system, blueprints, objects });
+      }).pipe(Effect.provideService(AiContextService, { binder: this.context }), Effect.orDie),
+    );
+  }
+
   /**
-   * Initiates a new request.
+   * Initiates a new request via AgentService.
    */
-  async request(requestParam: AiRequest): Promise<void> {
-    if (this._fiber) {
+  async request(requestProp: AiRequest): Promise<void> {
+    if (this.#requestFiber) {
       await this.cancel();
     }
 
     try {
-      this._lastRequest = requestParam;
-      this._rx.set(this.error, Option.none());
-      this._rx.set(this.active, true);
-
-      // Create request.
-      const request = this._conversation.createRequest({
-        system: this._options.system,
-        prompt: requestParam.message,
-        observer: this._observer,
-      });
-
-      const runtime = await this._services();
+      this.#lastRequest = requestProp;
+      this.#registry.set(this.error, Option.none());
+      this.#registry.set(this.active, true);
+
+      const effect = Effect.gen(this, function* () {
+        const session = yield* AgentService.getSession(this._feed);
+
+        const ephemeralStream = session.subscribeEphemeral();
+        yield* ephemeralStream.pipe(
+          Stream.runForEach((message) =>
+            Effect.sync(() => {
+              for (const event of message.events) {
+                if (Trace.isOfType(PartialBlock, event)) {
+                  this.#handleEphemeralMessage(event.data);
+                }
+              }
+            }),
+          ),
+          Effect.fork,
+        );
 
-      // Create fiber.
-      this._fiber = request.pipe(
-        Effect.provide(AiService.model(this._options.model ?? DEFAULT_EDGE_MODEL)),
+        log('chat processor submitting prompt', { length: requestProp.message.length });
+        yield* session.submitPrompt(requestProp.message);
+        log('chat processor submitPrompt returned, waiting for agent', {});
+        yield* session.waitForCompletion();
+        log.info('session complete');
 
-        // TODO(dmaretskyi): Move ArtifactDiffResolver upstream.
-        Effect.provideService(ArtifactDiffResolver, this._artifactDiffResolver),
+        this.#flushStreaming();
+      });
 
-        Effect.asVoid,
-        Runtime.runFork(runtime), // Runs in the background.
-      );
+      this.#requestFiber = this._runtime.runFork(effect);
 
-      // Execute request.
-      const response = await this._fiber.pipe(Fiber.join, Effect.runPromiseExit);
-      if (!Exit.isSuccess(response) && !Cause.isInterruptedOnly(response.cause)) {
-        throwCause(response.cause);
+      try {
+        await this._runtime.runPromise(Fiber.join(this.#requestFiber));
+      } catch (err: any) {
+        if (err._tag === 'InterruptedException' || err.message?.includes('interrupted')) {
+          return;
+        }
+        throw err;
       }
 
-      this._rx.set(this.error, Option.none());
-      this._lastRequest = undefined;
-      this._fiber = undefined;
-    } catch (error) {
-      log.error('request failed', { error });
-      this._rx.set(this.error, Option.some(new Error('AI service error', { cause: error })));
+      this.#registry.set(this.error, Option.none());
+      this.#lastRequest = undefined;
+      this.#requestFiber = undefined;
+    } catch (err) {
+      log.error('request failed', { error: err });
+      this.#registry.set(this.error, Option.some(new Error('AI service error', { cause: err })));
     } finally {
-      this._fiber = undefined;
-      this._rx.set(this.active, false);
+      log.info('setting active to false');
+      this.#registry.set(this.active, false);
+      this.#requestFiber = undefined;
     }
   }
 
@@ -196,82 +223,84 @@ export class AiChatProcessor {
    * Cancels the current request.
    */
   async cancel(): Promise<void> {
-    await Effect.runPromise(
+    await runAndForwardErrors(
       Effect.gen(this, function* () {
-        if (this._fiber) {
-          yield* this._fiber.pipe(Fiber.interrupt);
+        if (this.#requestFiber) {
+          yield* Fiber.interrupt(this.#requestFiber);
         }
       }),
     );
 
-    this._fiber = undefined;
-    this._rx.set(this.active, false);
+    this.#requestFiber = undefined;
+    this.#registry.set(this.active, false);
   }
 
   /**
    * Retry last failed request.
    */
   async retry(): Promise<void> {
-    if (this._lastRequest) {
-      return this.request(this._lastRequest);
+    if (this.#lastRequest) {
+      return this.request(this.#lastRequest);
     }
   }
 
   /**
    * Update the current chat's name.
    */
-  async updateName(chat: Assistant.Chat): Promise<void> {
-    const runtime = await this._services();
+  async updateName(chat: Chat.Chat): Promise<void> {
+    const runtime = await this._runtime.runPromise(Effect.runtime<any>());
     await updateName(runtime, this._conversation, chat, this._options.model);
   }
 
-  // TODO(burdon): Fix/factor out.
-  private _artifactDiffResolver: ArtifactDiffResolver.Service = {
-    resolve: async (_artifacts) => {
-      const versions = new Map();
-      // await Promise.all(
-      //   artifacts.map(async (artifact) => {
-      //     const {
-      //       objects: [object],
-      //     } = await space.db.query(Filter.ids(artifact.id)).run();
-      //     if (!object) {
-      //       return;
-      //     }
-
-      //     versions.set(artifact.id, {
-      //       version: getVersion(object),
-      //       diff: `Current state: ${JSON.stringify(object)}`,
-      //     });
-      //   }),
-      // );
-
-      return versions;
-    },
-  };
-
-  private _onMessage = Effect.fn(
-    function* (this: AiChatProcessor, message: DataType.Message) {
-      this._rx.set(this._streaming, Option.none());
-      this._rx.update(this._pending, (pending) => [...pending, message]);
-    }.bind(this),
-  );
-
-  private _onBlock = Effect.fn(
-    function* (this: AiChatProcessor, block: ContentBlock.Any) {
-      this._rx.update(this._streaming, (streaming) => {
-        const blocks = streaming.pipe(
-          Option.map((streaming) => streaming.blocks.filter((b) => !b.pending)),
-          Option.getOrElse(() => []),
-        );
+  /**
+   * Handles an ephemeral message from the agent process.
+   * Both pending and completed blocks arrive here. Completed blocks are deduped
+   * against messages already written to the feed queue to handle the race between
+   * ephemeral delivery and feed replication.
+   */
+  #handleEphemeralMessage(event: Trace.PayloadType<typeof PartialBlock>) {
+    const isPending = event.block.pending;
+    const message = Obj.make(Message.Message, {
+      id: event.messageId,
+      created: new Date().toISOString(),
+      sender: { role: event.role },
+      blocks: [event.block],
+    });
 
-        return Option.some(
-          Obj.make(DataType.Message, {
-            created: new Date().toISOString(),
-            sender: { role: 'assistant' },
-            blocks: [...blocks, block],
-          }),
-        );
+    if (isPending) {
+      if (this.#finalizedIds.has(event.messageId)) {
+        return;
+      }
+      this.#registry.update(this.#streaming, (streaming) => {
+        const idx = streaming.findIndex((existing) => existing.id === event.messageId);
+        if (idx >= 0) {
+          const updated = [...streaming];
+          updated[idx] = message;
+          return updated;
+        }
+        return [...streaming, message];
+      });
+    } else {
+      this.#finalizedIds.add(event.messageId);
+      this.#registry.update(this.#streaming, (streaming) => streaming.filter((existing) => existing.id !== message.id));
+      this.#registry.update(this.#pending, (pending) => {
+        if (pending.some((existing) => existing.id === message.id)) {
+          return pending;
+        }
+        return [...pending, message];
       });
-    }.bind(this),
-  );
+    }
+  }
+
+  /**
+   * Move remaining streaming messages to pending (called when agent completes).
+   */
+  #flushStreaming() {
+    const remaining = this.#registry.get(this.#streaming);
+    if (remaining.length > 0) {
+      this.#registry.update(this.#pending, (pending) => [...pending, ...remaining]);
+      this.#registry.set(this.#streaming, []);
+    }
+    this.#finalizedIds.clear();
+  }
 }

package/src/processor/update-name.ts

@@ -9,11 +9,11 @@ import * as Runtime from 'effect/Runtime';
 
 import { AiService, DEFAULT_EDGE_MODEL, type ModelName } from '@dxos/ai';
 import { type AiConversation, AiSession } from '@dxos/assistant';
+import { type Chat } from '@dxos/assistant-toolkit';
+import { Obj } from '@dxos/echo';
 import { throwCause } from '@dxos/effect';
 import { trim } from '@dxos/util';
 
-import { type Assistant } from '../types';
-
 import { type AiChatServices } from './processor';
 
 /**
@@ -23,8 +23,7 @@ import { type AiChatServices } from './processor';
 export const updateName = async (
   runtime: Runtime.Runtime<AiChatServices>,
   conversation: AiConversation,
-  chat: Assistant.Chat,
-  // TODO(burdon): Use simpler model.
+  chat: Chat.Chat,
   model: ModelName = DEFAULT_EDGE_MODEL,
 ): Promise<void> => {
   const history = await conversation.getHistory();
@@ -44,7 +43,9 @@ export const updateName = async (
       const message = messages.find((message) => message.sender.role === 'assistant');
       const title = message?.blocks.find((block) => block._tag === 'text')?.text;
       if (title) {
-        chat.name = title;
+        Obj.change(chat, (obj) => {
+          obj.name = title;
+        });
       }
     }),
     Runtime.runFork(runtime), // Run in the background.

package/src/queue-logger.ts

@@ -5,14 +5,10 @@
 import { type Queue, Ref, type Space, getSpace } from '@dxos/client/echo';
 import { type Sequence, type SequenceEvent, type SequenceLogger } from '@dxos/conductor';
 import { DXN, Key, Obj } from '@dxos/echo';
-import {
-  InvocationOutcome,
-  InvocationTraceEndEvent,
-  type InvocationTraceEvent,
-  InvocationTraceEventType,
-  InvocationTraceStartEvent,
-  TraceEvent,
-} from '@dxos/functions';
+import { InvocationTraceEndEvent, InvocationTraceEventType, InvocationTraceStartEvent } from '@dxos/functions-runtime';
+import { TraceEvent } from '@dxos/functions-runtime';
+import { InvocationOutcome } from '@dxos/functions-runtime';
+import { type InvocationTraceEvent } from '@dxos/functions-runtime';
 import { invariant } from '@dxos/invariant';
 import { QueueSubspaceTags } from '@dxos/keys';
 
@@ -27,7 +23,10 @@ export class QueueLogger implements SequenceLogger {
     let dxn = this._space.properties.invocationTraceQueue?.dxn;
     if (!dxn) {
       dxn = DXN.fromQueue(QueueSubspaceTags.TRACE, this._space.id, Key.ObjectId.random());
-      this._space.properties.invocationTraceQueue = Ref.fromDXN(dxn);
+      const newDxn = dxn;
+      Obj.change(this._space.properties, (obj) => {
+        obj.invocationTraceQueue = Ref.fromDXN(newDxn);
+      });
     }
     this._invocationTraceQueue = this._space.queues.get(dxn);
   }

package/src/testing/test-generator.ts

@@ -5,21 +5,22 @@
 import * as Effect from 'effect/Effect';
 
 import { Obj } from '@dxos/echo';
-import { ContextQueueService, DatabaseService } from '@dxos/functions';
+import { Database } from '@dxos/echo';
+import { ContextQueueService } from '@dxos/functions';
 import { faker } from '@dxos/random';
 import { renderObjectLink } from '@dxos/react-ui-components';
-import { type ContentBlock, DataType } from '@dxos/schema';
+import { type Actor, type ContentBlock, Message, Organization } from '@dxos/types';
 import { trim } from '@dxos/util';
 
-export const createMessage = (role: DataType.ActorRole, blocks: ContentBlock.Any[]): DataType.Message => {
-  return Obj.make(DataType.Message, {
+export const createMessage = (role: Actor.Role, blocks: ContentBlock.Any[]): Message.Message => {
+  return Obj.make(Message.Message, {
     created: new Date().toISOString(),
     sender: { role },
     blocks,
   });
 };
 
-export type MessageGenerator = Effect.Effect<void, never, DatabaseService | ContextQueueService>;
+export type MessageGenerator = Effect.Effect<void, never, Database.Service | ContextQueueService>;
 
 export const createMessageGenerator = (): MessageGenerator[] => [
   Effect.gen(function* () {
@@ -70,9 +71,9 @@ export const createMessageGenerator = (): MessageGenerator[] => [
               [
                 faker.lorem.paragraph(),
                 '',
-                ...Array.from({ length: faker.number.int({ min: 3, max: 5 }) }).map(
-                  (_, idx) => `${idx + 1}. ${faker.lorem.paragraph()}`,
-                ),
+                ...Array.from({
+                  length: faker.number.int({ min: 3, max: 5 }),
+                }).map((_, idx) => `${idx + 1}. ${faker.lorem.paragraph()}`),
               ].join('\n') + '\n',
           },
         ]),
@@ -145,11 +146,11 @@ export const createMessageGenerator = (): MessageGenerator[] => [
 
   Effect.gen(function* () {
     const { queue } = yield* ContextQueueService;
-    const { db } = yield* DatabaseService;
-    const obj1 = db.add(Obj.make(DataType.Organization, { name: 'DXOS' }));
-    // const obj2 = db.add(Obj.make(DataType.Person, { fullName: 'Alice' }));
-    // const obj3 = db.add(Obj.make(DataType.Person, { fullName: 'Bob' }));
-    // const obj4 = db.add(Obj.make(DataType.Person, { fullName: 'Charlie' }));
+    const { db } = yield* Database.Service;
+    const obj1 = db.add(Obj.make(Organization.Organization, { name: 'DXOS' }));
+    // const obj2 = db.add(Obj.make(Person.Person, { fullName: 'Alice' }));
+    // const obj3 = db.add(Obj.make(Person.Person, { fullName: 'Bob' }));
+    // const obj4 = db.add(Obj.make(Person.Person, { fullName: 'Charlie' }));
     yield* Effect.promise(() =>
       queue.append([
         createMessage('assistant', [

package/src/testing/test-sequence.ts

@@ -9,16 +9,16 @@ export const RESEARCH_SEQUENCE_DEFINITION: SequenceDefinition = {
   steps: [
     {
       instructions: 'Research information and entities related to the selected objects.',
-      tools: [ToolId.make('search/web_search')],
+      tools: [ToolId.make('search/web-search')],
     },
     {
       instructions:
         'Based on your research find matching entires that are already in the graph. Do exaustive research.',
-      tools: [ToolId.make('search/local_search')],
+      tools: [ToolId.make('search/local-search')],
     },
     {
       instructions: 'Add researched data to the graph. Make connections to existing objects.',
-      tools: [ToolId.make('search/local_search'), ToolId.make('graph/writer')],
+      tools: [ToolId.make('search/local-search'), ToolId.make('graph/writer')],
     },
   ],
 };

package/src/testing/test-services.ts

@@ -2,9 +2,11 @@
 // Copyright 2025 DXOS.org
 //
 
-import { Obj } from '@dxos/echo';
+import { Obj, type Type } from '@dxos/echo';
 
-import { type ApiAuthorization, type BaseServiceRegistry, ServiceType, categoryIcons } from '../types';
+import { type ApiAuthorization, type BaseServiceRegistry, ServiceType, categoryIcons } from '#types';
+
+const ServiceTypeSchema = ServiceType as unknown as Type.AnyObj;
 
 export class MockServiceRegistry implements BaseServiceRegistry {
   async queryServices(): Promise<ServiceType[]> {
@@ -48,7 +50,7 @@ const VISUAL_CROSSING_CREDENTIALS: ApiAuthorization = {
 //  - e.g., https://github.com/konfig-sdks/openapi-examples/blob/main/xkcd/openapi.yaml
 
 const TEST_SERVICES: ServiceType[] = [
-  Obj.make(ServiceType, {
+  Obj.make(ServiceTypeSchema, {
     serviceId: 'amadeus.com/service/FlightSearch',
     name: 'Amadeus Flight Search',
     description: 'Search for local and international flights.',
@@ -62,7 +64,7 @@ const TEST_SERVICES: ServiceType[] = [
     ],
   }),
 
-  Obj.make(ServiceType, {
+  Obj.make(ServiceTypeSchema, {
     serviceId: 'amadeus.com/service/HotelSearch',
     name: 'Amadeus Hotel Search',
     description: 'Search for local and international hotels.',
@@ -76,7 +78,7 @@ const TEST_SERVICES: ServiceType[] = [
     ],
   }),
 
-  Obj.make(ServiceType, {
+  Obj.make(ServiceTypeSchema, {
     serviceId: 'visualcrossing.com/service/Weather',
     name: 'Visual Crossing Weather',
     description: 'Search for global weather forecasts.',
@@ -91,7 +93,7 @@ const TEST_SERVICES: ServiceType[] = [
   }),
 
   // TODO(burdon): Needs auth.
-  Obj.make(ServiceType, {
+  Obj.make(ServiceTypeSchema, {
     serviceId: 'abstractapi.com/service/GeoLocation',
     name: 'Abstract GeoLocation',
     description: 'Get the location of any IP address.',
@@ -109,7 +111,7 @@ const TEST_SERVICES: ServiceType[] = [
   //
 
   ...Array.from({ length: 20 }, (_, i) =>
-    Obj.make(ServiceType, {
+    Obj.make(ServiceTypeSchema, {
       serviceId: `example.com/service/test-${i}`,
       name: `Test ${i}`,
       description: `Test ${i}`,