@dxos/keys 0.9.0 → 0.9.1-main.c7dcc2e112

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dxos/keys",
-  "version": "0.9.0",
+  "version": "0.9.1-main.c7dcc2e112",
   "description": "Key utils and definitions.",
   "homepage": "https://dxos.org",
   "bugs": "https://github.com/dxos/dxos/issues",
@@ -27,9 +27,9 @@
   ],
   "dependencies": {
     "ulidx": "^2.3.0",
-    "@dxos/debug": "0.9.0",
-    "@dxos/node-std": "0.9.0",
-    "@dxos/invariant": "0.9.0"
+    "@dxos/invariant": "0.9.1-main.c7dcc2e112",
+    "@dxos/debug": "0.9.1-main.c7dcc2e112",
+    "@dxos/node-std": "0.9.1-main.c7dcc2e112"
   },
   "devDependencies": {
     "base32-decode": "^1.0.0",

package/src/DXN.test.ts

@@ -23,6 +23,40 @@ describe('DXN.isDXN', () => {
   });
 });
 
+describe('DXN.Name', () => {
+  test('accepts valid NSIDs — no type errors', () => {
+    // Three-segment minimum (first + middle + final), all camelCase.
+    DXN.make('a.b.c');
+    // Multi-segment, all camelCase.
+    DXN.make('org.dxos.type.calendar');
+    // Hyphen is allowed in a MIDDLE segment.
+    DXN.make('org.dxos.app-framework.event.startup');
+    // Versioned form.
+    DXN.make('org.dxos.type.calendar', '1.0.0');
+  });
+
+  test('rejects invalid NSIDs — compile-time type errors', () => {
+    // Wrapped in a never-called arrow so the invalid calls are type-checked but
+    // never executed at runtime. If Name unexpectedly starts accepting any
+    // of these, the @ts-expect-error directive itself becomes a build error
+    // ("Unused '@ts-expect-error' directive"), causing the CI check to fail.
+    void (() => {
+      // No dots — single segment.
+      // @ts-expect-error
+      DXN.make('unknown');
+      // Hyphen in the FINAL segment.
+      // @ts-expect-error
+      DXN.make('com.example.type.registry-entry');
+      // Hyphen in the final segment, versioned.
+      // @ts-expect-error
+      DXN.make('com.example.type.registry-entry', '0.1.0');
+      // Common mistake: kebab-case activation event name.
+      // @ts-expect-error
+      DXN.make('org.dxos.app-framework.event.setup-react-surface');
+    });
+  });
+});
+
 describe('DXN.make', () => {
   test('produces unversioned DXN', ({ expect }) => {
     expect(DXN.make('org.dxos.type.calendar')).toBe('dxn:org.dxos.type.calendar');
@@ -32,9 +66,12 @@ describe('DXN.make', () => {
     expect(DXN.make('org.dxos.type.calendar', '1.0.0')).toBe('dxn:org.dxos.type.calendar:1.0.0');
   });
 
-  test('throws on invalid NSID', ({ expect }) => {
+  test('throws on invalid NSID at runtime', ({ expect }) => {
+    // @ts-expect-error intentionally invalid NSIDs — verifying runtime throws
     expect(() => DXN.make('not-a-valid-nsid')).toThrow();
+    // @ts-expect-error
     expect(() => DXN.make('com.example.type.registry-entry')).toThrow();
+    // @ts-expect-error
     expect(() => DXN.make('com.example.type.registry-entry', '0.1.0')).toThrow();
   });
 });

package/src/DXN.ts

@@ -30,6 +30,33 @@ const DXN_SPEC_REGEXP =
  */
 export type DXN = URI.URI & { readonly __DXN: unique symbol };
 
+/**
+ * Compile-time validation for NSID strings (the `dxn:` prefix is absent here).
+ *
+ * Checks two rules expressible with template literal types:
+ * - Must contain at least one dot (multi-segment).
+ * - Final segment (after the last dot) must not contain a hyphen.
+ *
+ * TypeScript template literal inference is non-greedy: `${string}.${infer Rest}`
+ * always splits at the first dot. The type recurses until `Rest` has no more dots,
+ * at which point it is the true final segment and is checked for hyphens.
+ *
+ * Broad `string` passes through unchanged so that template-literal call sites
+ * whose prefix segment is `string` are not rejected — those are validated at
+ * runtime by the regex inside `parse`.
+ */
+export type Name<T extends string> = [string] extends [T]
+  ? string
+  : T extends `${string}.${infer Rest}`
+    ? Rest extends `${string}.${string}`
+      ? [Name<Rest>] extends [never]
+        ? never
+        : T
+      : Rest extends `${string}-${string}`
+        ? never
+        : T
+    : never;
+
 /**
  * Cheap prefix check — does not validate the full DXN grammar.
  * Sufficient for narrowing a URI to a DXN.
@@ -40,11 +67,19 @@ export const isDXN = (value: unknown): value is DXN => typeof value === 'string'
  * Constructs a DXN from an NSID (and optional version). Throws if the result
  * is not a valid DXN. Use `tryMake` for non-throwing string parsing.
  *
+ * Static NSID strings are validated at compile time via {@link Name}:
+ * the final segment must be camelCase (no hyphens). Template-literal strings
+ * with a runtime prefix are accepted here but still validated at runtime.
+ *
  * @example make('org.dxos.type.calendar') → 'dxn:org.dxos.type.calendar'
  * @example make('org.dxos.type.calendar', '1.0.0') → 'dxn:org.dxos.type.calendar:1.0.0'
  */
-export const make = (nsid: string, version?: string): DXN =>
-  parse(version != null ? `dxn:${nsid}:${version}` : `dxn:${nsid}`);
+export const make: {
+  <T extends string>(
+    nsid: [Name<T>] extends [never] ? `Invalid NSID "${T}": final segment must be camelCase (no hyphens)` : T,
+    version?: string,
+  ): DXN;
+} = (nsid: string, version?: string): DXN => parse(version != null ? `dxn:${nsid}:${version}` : `dxn:${nsid}`);
 
 /**
  * Parses a full DXN string. Returns undefined on failure.