@dxos/eslint-plugin-rules 0.6.13 → 0.6.14-main.2b6a0f3

package/index.js

@@ -6,5 +6,6 @@ module.exports = {
   rules: {
     comment: require('./rules/comment'),
     header: require('./rules/header'),
+    'no-empty-promise-catch': require('./rules/no-empty-promise-catch'),
   },
 };

package/package.json

@@ -1,10 +1,11 @@
 {
   "name": "@dxos/eslint-plugin-rules",
-  "version": "0.6.13",
+  "version": "0.6.14-main.2b6a0f3",
   "homepage": "https://dxos.org",
   "bugs": "https://github.com/dxos/dxos/issues",
   "license": "MIT",
   "author": "info@dxos.org",
+  "sideEffects": false,
   "main": "index.js",
   "publishConfig": {
     "access": "public"

package/rules/comment.js

@@ -152,7 +152,7 @@ module.exports = {
         return true;
       }
 
-      // 6. Check TODO format.
+      // 6. Check "TODO" format.
       const containsTodo = TODO_PATTERN.test(comment.value);
       const startsWithTodo = TODO_START_PATTERN.test(comment.value);
       const isTodoFormatted = FORMATTED_TODO_PATTERN.test(comment.value);

package/rules/no-empty-promise-catch.js

@@ -0,0 +1,35 @@
+//
+// Copyright 2024 DXOS.org
+//
+
+'use strict';
+
+const isCatchCallSite = (expression) =>
+  expression.type === 'CallExpression' &&
+  expression.callee.type === 'MemberExpression' &&
+  expression.callee.property.name === 'catch';
+
+module.exports = {
+  meta: {
+    type: 'problem',
+    fixable: 'code',
+    docs: {
+      description: 'Enforces passing an error handler to promise .catch().',
+    },
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (isCatchCallSite(node) && node.arguments.length === 0) {
+          context.report({
+            node,
+            message: 'Handler argument required. `undefined` handlers lead to unhandled rejections.',
+            fix: (fixer) => {
+              return fixer.insertTextAfter(context.sourceCode.getTokenAfter(node.callee), '() => {}');
+            },
+          });
+        }
+      },
+    };
+  },
+};