@dxos/edge-client 0.8.4-main.bc674ce → 0.8.4-main.bcb3aa67d6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dxos/edge-client",
-  "version": "0.8.4-main.bc674ce",
+  "version": "0.8.4-main.bcb3aa67d6",
   "description": "EDGE Client",
   "homepage": "https://dxos.org",
   "bugs": "https://github.com/dxos/dxos/issues",
@@ -16,20 +16,17 @@
     ".": {
       "source": "./src/index.ts",
       "types": "./dist/types/src/index.d.ts",
-      "browser": "./dist/lib/browser/index.mjs",
-      "node": "./dist/lib/node-esm/index.mjs"
+      "default": "./dist/lib/neutral/index.mjs"
     },
     "./muxer": {
       "source": "./src/edge-ws-muxer.ts",
       "types": "./dist/types/src/edge-ws-muxer.d.ts",
-      "browser": "./dist/lib/browser/edge-ws-muxer.mjs",
-      "node": "./dist/lib/node-esm/edge-ws-muxer.mjs"
+      "default": "./dist/lib/neutral/edge-ws-muxer.mjs"
     },
     "./testing": {
       "source": "./src/testing/index.ts",
       "types": "./dist/types/src/testing/index.d.ts",
-      "browser": "./dist/lib/browser/testing/index.mjs",
-      "node": "./dist/lib/node-esm/testing/index.mjs"
+      "default": "./dist/lib/neutral/testing/index.mjs"
     }
   },
   "types": "dist/types/src/index.d.ts",
@@ -46,28 +43,30 @@
     "README.md"
   ],
   "dependencies": {
-    "@effect/platform": "0.93.6",
+    "@effect/platform": "0.94.4",
+    "@opentelemetry/api": "^1.9.0",
     "isomorphic-ws": "^5.0.0",
-    "ws": "^8.14.2",
-    "@dxos/async": "0.8.4-main.bc674ce",
-    "@dxos/context": "0.8.4-main.bc674ce",
-    "@dxos/credentials": "0.8.4-main.bc674ce",
-    "@dxos/crypto": "0.8.4-main.bc674ce",
-    "@dxos/effect": "0.8.4-main.bc674ce",
-    "@dxos/invariant": "0.8.4-main.bc674ce",
-    "@dxos/keyring": "0.8.4-main.bc674ce",
-    "@dxos/log": "0.8.4-main.bc674ce",
-    "@dxos/keys": "0.8.4-main.bc674ce",
-    "@dxos/debug": "0.8.4-main.bc674ce",
-    "@dxos/node-std": "0.8.4-main.bc674ce",
-    "@dxos/protocols": "0.8.4-main.bc674ce",
-    "@dxos/util": "0.8.4-main.bc674ce"
+    "ws": "^8.17.1",
+    "@dxos/async": "0.8.4-main.bcb3aa67d6",
+    "@dxos/context": "0.8.4-main.bcb3aa67d6",
+    "@dxos/credentials": "0.8.4-main.bcb3aa67d6",
+    "@dxos/crypto": "0.8.4-main.bcb3aa67d6",
+    "@dxos/effect": "0.8.4-main.bcb3aa67d6",
+    "@dxos/invariant": "0.8.4-main.bcb3aa67d6",
+    "@dxos/debug": "0.8.4-main.bcb3aa67d6",
+    "@dxos/keyring": "0.8.4-main.bcb3aa67d6",
+    "@dxos/keys": "0.8.4-main.bcb3aa67d6",
+    "@dxos/log": "0.8.4-main.bcb3aa67d6",
+    "@dxos/protocols": "0.8.4-main.bcb3aa67d6",
+    "@dxos/node-std": "0.8.4-main.bcb3aa67d6",
+    "@dxos/tracing": "0.8.4-main.bcb3aa67d6",
+    "@dxos/util": "0.8.4-main.bcb3aa67d6"
   },
   "devDependencies": {
-    "@dxos/test-utils": "0.8.4-main.bc674ce"
+    "@dxos/test-utils": "0.8.4-main.bcb3aa67d6"
   },
   "peerDependencies": {
-    "effect": "3.19.11"
+    "effect": "3.20.0"
   },
   "publishConfig": {
     "access": "public"

package/src/edge-client.test.ts

@@ -5,6 +5,7 @@
 import { describe, expect, onTestFinished, test } from 'vitest';
 
 import { Trigger } from '@dxos/async';
+import { Context } from '@dxos/context';
 import { Keyring } from '@dxos/keyring';
 import { TextMessageSchema } from '@dxos/protocols/buf/dxos/edge/messenger_pb';
 import { EdgeStatus } from '@dxos/protocols/proto/dxos/client/services';
@@ -25,13 +26,13 @@ describe('EdgeClient', () => {
     onTestFinished(cleanup);
 
     const { client, reconnectTrigger } = await openNewClient(endpoint);
-    await client.send(textMessage('Hello world 1'));
+    await client.send(Context.default(), textMessage('Hello world 1'));
     expect(client.isOpen).is.true;
 
     reconnectTrigger.reset();
     await closeConnection();
     await reconnectTrigger.wait();
-    await expect(client.send(textMessage('Hello world 2'))).resolves.not.toThrow();
+    await expect(client.send(Context.default(), textMessage('Hello world 2'))).resolves.not.toThrow();
   });
 
   test('isConnected', async () => {
@@ -59,13 +60,13 @@ describe('EdgeClient', () => {
     onTestFinished(cleanup);
 
     const { client, reconnectTrigger } = await openNewClient(endpoint);
-    await client.send(textMessage('Hello world 1'));
+    await client.send(Context.default(), textMessage('Hello world 1'));
     expect(client.isOpen).is.true;
 
     reconnectTrigger.reset();
     client.setIdentity(await createEphemeralEdgeIdentity());
     await reconnectTrigger.wait();
-    await expect(client.send(textMessage('Hello world 2'))).resolves.not.toThrow();
+    await expect(client.send(Context.default(), textMessage('Hello world 2'))).resolves.not.toThrow();
   });
 
   test('send blocks until connection becomes ready', async () => {
@@ -75,7 +76,7 @@ describe('EdgeClient', () => {
 
     const { client } = await openNewClient(endpoint);
     setTimeout(() => admitConnection.wake(), 20);
-    await client.send(textMessage('Hello world 1'));
+    await client.send(Context.default(), textMessage('Hello world 1'));
     await expect.poll(() => messageSink.length).toBe(1);
   });
 
@@ -86,11 +87,13 @@ describe('EdgeClient', () => {
 
     const { client } = await openNewClient(endpoint);
     setTimeout(async () => client.setIdentity(await createEphemeralEdgeIdentity()));
-    await expect(client.send(textMessage('Hello world 1'))).rejects.toThrow(EdgeIdentityChangedError);
+    await expect(client.send(Context.default(), textMessage('Hello world 1'))).rejects.toThrow(
+      EdgeIdentityChangedError,
+    );
 
     // Test recovers.
     setTimeout(() => admitConnection.wake(), 20);
-    await client.send(textMessage('Hello world 1'));
+    await client.send(Context.default(), textMessage('Hello world 1'));
     await expect.poll(() => messageSink.length).toBe(1);
   });
 
@@ -101,7 +104,9 @@ describe('EdgeClient', () => {
 
     const { client } = await openNewClient(endpoint);
     setTimeout(() => client.close());
-    await expect(client.send(textMessage('Hello world 1'))).rejects.toThrow(EdgeConnectionClosedError);
+    await expect(client.send(Context.default(), textMessage('Hello world 1'))).rejects.toThrow(
+      EdgeConnectionClosedError,
+    );
   });
 
   test('onReconnect trigger', async () => {
@@ -129,12 +134,12 @@ describe('EdgeClient', () => {
     onTestFinished(cleanup);
 
     const { client, identity: oldIdentity } = await openNewClient(endpoint);
-    await client.send(textMessage('Hello world 1', oldIdentity));
+    await client.send(Context.default(), textMessage('Hello world 1', oldIdentity));
     expect(client.isOpen).is.true;
 
     const newIdentity = await createEphemeralEdgeIdentity();
     client.setIdentity(newIdentity);
-    await client.send(textMessage('Hello world 2', newIdentity));
+    await client.send(Context.default(), textMessage('Hello world 2', newIdentity));
     await expect.poll(() => messageSourceLog.length).toBe(2);
     expect(messageSourceLog.map((m) => m.peerKey)).toStrictEqual([oldIdentity.peerKey, newIdentity.peerKey]);
   });
@@ -147,7 +152,7 @@ describe('EdgeClient', () => {
 
     const client = new EdgeClient(identity, { socketEndpoint: process.env.EDGE_ENDPOINT! });
     await openAndClose(client);
-    await client.send(textMessage('Hello world 1'));
+    await client.send(Context.default(), textMessage('Hello world 1'));
     expect(client.isOpen).is.true;
   });
 

package/src/edge-client.ts

@@ -2,6 +2,8 @@
 // Copyright 2024 DXOS.org
 //
 
+import { type Context as OtelContext, propagation } from '@opentelemetry/api';
+
 import {
   Event,
   PersistentLifecycle,
@@ -10,11 +12,12 @@ import {
   scheduleMicroTask,
   scheduleTaskInterval,
 } from '@dxos/async';
+import { Context } from '@dxos/context';
 import { type Lifecycle, Resource } from '@dxos/context';
 import { log, logInfo } from '@dxos/log';
 import { type Message } from '@dxos/protocols/buf/dxos/edge/messenger_pb';
 import { EdgeStatus } from '@dxos/protocols/proto/dxos/client/services';
-
+import { TRACE_PROCESSOR, TRACE_SPAN_ATTRIBUTE } from '@dxos/tracing';
 import { protocol } from './defs';
 import { type EdgeIdentity, handleAuthChallenge } from './edge-identity';
 import { EdgeWsConnection } from './edge-ws-connection';
@@ -45,7 +48,7 @@ export interface EdgeConnection extends Required<Lifecycle> {
   get isOpen(): boolean;
   get status(): EdgeStatus;
   setIdentity(identity: EdgeIdentity): void;
-  send(message: Message): Promise<void>;
+  send(ctx: Context, message: Message): Promise<void>;
   onMessage(listener: MessageListener): () => void;
   onReconnected(listener: ReconnectListener): () => void;
 }
@@ -126,7 +129,7 @@ export class EdgeClient extends Resource implements EdgeConnection {
    * Send message.
    * NOTE: The message is guaranteed to be delivered but the service must respond with a message to confirm processing.
    */
-  public async send(message: Message) {
+  public async send(ctx: Context, message: Message) {
     if (this._ready.state !== TriggerState.RESOLVED) {
       log('waiting for websocket');
       await this._ready.wait({ timeout: this._config.timeout ?? DEFAULT_TIMEOUT });
@@ -143,6 +146,25 @@ export class EdgeClient extends Resource implements EdgeConnection {
       throw new EdgeIdentityChangedError();
     }
 
+    // Same W3C Trace Context flow as EdgeHttpClient.getTraceHeaders: resolve OTEL context from the
+    // DXOS span id, then propagation.inject into a carrier. Here the carrier is the protobuf field
+    // (WebSocket cannot set HTTP headers on the browser API).
+    const spanId = ctx.getAttribute(TRACE_SPAN_ATTRIBUTE);
+    const otlpContext =
+      typeof spanId === 'number'
+        ? (TRACE_PROCESSOR.remoteTracing.getSpanContext(spanId) as OtelContext | undefined)
+        : undefined;
+
+    if (otlpContext) {
+      const activeSpan: Record<string, string> = {};
+      propagation.inject(otlpContext, activeSpan);
+      message.traceContext = {
+        $typeName: 'dxos.edge.messenger.TraceContext',
+        traceparent: activeSpan.traceparent,
+        tracestate: activeSpan.tracestate,
+      };
+    }
+
     this._currentConnection.send(message);
   }
 

package/src/edge-http-client.test.ts

@@ -16,7 +16,8 @@ describe.skipIf(process.env.CI)('EdgeHttpClient', () => {
     const identity = await createEphemeralEdgeIdentity();
     client.setIdentity(identity);
 
-    const result = await client.getStatus();
+    const { Context } = await import('@dxos/context');
+    const result = await client.getStatus(Context.default());
     expect(result).toBeDefined();
   });
 });