@dxos/echo-atom 0.8.4-main.1068cf700f → 0.8.4-main.2244d791bb

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dxos/echo-atom",
-  "version": "0.8.4-main.1068cf700f",
+  "version": "0.8.4-main.2244d791bb",
   "description": "Effect Atom wrappers for ECHO objects with explicit subscriptions.",
   "homepage": "https://dxos.org",
   "bugs": "https://github.com/dxos/dxos/issues",
@@ -30,16 +30,16 @@
   "dependencies": {
     "@effect-atom/atom": "^0.5.1",
     "lodash.isequal": "^4.5.0",
-    "@dxos/echo-db": "0.8.4-main.1068cf700f",
-    "@dxos/echo": "0.8.4-main.1068cf700f",
-    "@dxos/util": "0.8.4-main.1068cf700f",
-    "@dxos/invariant": "0.8.4-main.1068cf700f"
+    "@dxos/echo": "0.8.4-main.2244d791bb",
+    "@dxos/echo-db": "0.8.4-main.2244d791bb",
+    "@dxos/invariant": "0.8.4-main.2244d791bb",
+    "@dxos/util": "0.8.4-main.2244d791bb"
   },
   "devDependencies": {
     "@types/lodash.isequal": "^4.5.0",
     "effect": "3.19.16",
-    "@dxos/random": "0.8.4-main.1068cf700f",
-    "@dxos/test-utils": "0.8.4-main.1068cf700f"
+    "@dxos/test-utils": "0.8.4-main.2244d791bb",
+    "@dxos/random": "0.8.4-main.2244d791bb"
   },
   "peerDependencies": {
     "effect": "3.19.16"

package/src/atom.ts

@@ -7,7 +7,6 @@ import * as Result from '@effect-atom/atom/Result';
 import * as Effect from 'effect/Effect';
 import * as Function from 'effect/Function';
 import * as Option from 'effect/Option';
-import isEqual from 'lodash.isequal';
 
 import { Obj, Ref } from '@dxos/echo';
 import { assertArgument } from '@dxos/invariant';
@@ -84,7 +83,7 @@ const propertyFamily = Atom.family(<T extends Obj.Unknown>(obj: T) =>
 
       const unsubscribe = Obj.subscribe(obj, () => {
         const newValue = obj[key];
-        if (!isEqual(previousSnapshot, newValue)) {
+        if (previousSnapshot !== newValue) {
           previousSnapshot = snapshotForComparison(newValue);
           // Return a snapshot copy so React sees a new reference.
           get.setSelf(snapshotForComparison(newValue));

package/src/reactivity.test.ts

@@ -8,6 +8,7 @@ import { describe, expect, test } from 'vitest';
 import { Obj } from '@dxos/echo';
 import { TestSchema } from '@dxos/echo/testing';
 import { createObject } from '@dxos/echo-db';
+import { arrayMove } from '@dxos/util';
 
 import * as AtomObj from './atom';
 
@@ -203,4 +204,30 @@ describe('Echo Atom - Reactivity', () => {
 
     unsubscribe();
   });
+
+  test('property atom for array property updates when array is reordered in place', () => {
+    // Verifies that makeProperty(obj, 'columns')-style atoms subscribe to in-place
+    // array mutations (e.g. arrayMove), so UI stays in sync after column reorder.
+    const obj = createObject(Obj.make(TestSchema.Example, { stringArray: ['a', 'b', 'c'] }));
+
+    const registry = Registry.make();
+    const atom = AtomObj.makeProperty(obj, 'stringArray');
+
+    const initial = registry.get(atom);
+    expect(initial).toEqual(['a', 'b', 'c']);
+
+    let updateCount = 0;
+    registry.subscribe(atom, () => {
+      updateCount++;
+    });
+
+    // Reorder in place (e.g. move first to last).
+    Obj.change(obj, (obj) => {
+      arrayMove(obj.stringArray!, 0, 2);
+    });
+
+    expect(updateCount).toBe(1);
+    const afterReorder = registry.get(atom);
+    expect(afterReorder).toEqual(['b', 'c', 'a']);
+  });
 });