@dxos/client-services 0.6.13-main.ed424a1 → 0.6.13

package/src/packlets/services/service-context.ts

@@ -2,20 +2,13 @@
 // Copyright 2022 DXOS.org
 //
 
-import { Mutex, Trigger } from '@dxos/async';
+import { Trigger } from '@dxos/async';
 import { Context, Resource } from '@dxos/context';
 import { getCredentialAssertion, type CredentialProcessor } from '@dxos/credentials';
-import { failUndefined, warnAfterTimeout } from '@dxos/debug';
-import {
-  EchoEdgeReplicator,
-  EchoHost,
-  MeshEchoReplicator,
-  MetadataStore,
-  SpaceManager,
-  valueEncoding,
-} from '@dxos/echo-pipeline';
-import { createChainEdgeIdentity, createEphemeralEdgeIdentity } from '@dxos/edge-client';
-import type { EdgeHttpClient, EdgeConnection, EdgeIdentity } from '@dxos/edge-client';
+import { failUndefined } from '@dxos/debug';
+import { EchoEdgeReplicator, EchoHost } from '@dxos/echo-db';
+import { MeshEchoReplicator, MetadataStore, SpaceManager, valueEncoding } from '@dxos/echo-pipeline';
+import type { EdgeConnection } from '@dxos/edge-client';
 import { FeedFactory, FeedStore } from '@dxos/feed-store';
 import { invariant } from '@dxos/invariant';
 import { Keyring } from '@dxos/keyring';
@@ -30,20 +23,19 @@ import { type Runtime } from '@dxos/protocols/proto/dxos/config';
 import type { FeedMessage } from '@dxos/protocols/proto/dxos/echo/feed';
 import { type Credential, type ProfileDocument } from '@dxos/protocols/proto/dxos/halo/credentials';
 import { type Storage } from '@dxos/random-access-storage';
+import type { TeleportParams } from '@dxos/teleport';
 import { BlobStore } from '@dxos/teleport-extension-object-sync';
 import { trace as Trace } from '@dxos/tracing';
 import { safeInstanceof } from '@dxos/util';
 
-import { EdgeAgentManager } from '../agents';
 import {
   IdentityManager,
   type CreateIdentityOptions,
-  type IdentityManagerParams,
+  type IdentityManagerRuntimeParams,
   type JoinIdentityParams,
 } from '../identity';
 import {
   DeviceInvitationProtocol,
-  type InvitationConnectionParams,
   InvitationsHandler,
   InvitationsManager,
   SpaceInvitationProtocol,
@@ -51,12 +43,9 @@ import {
 } from '../invitations';
 import { DataSpaceManager, type DataSpaceManagerRuntimeParams, type SigningContext } from '../spaces';
 
-export type ServiceContextRuntimeParams = Pick<
-  IdentityManagerParams,
-  'devicePresenceOfflineTimeout' | 'devicePresenceAnnounceInterval'
-> &
+export type ServiceContextRuntimeParams = IdentityManagerRuntimeParams &
   DataSpaceManagerRuntimeParams & {
-    invitationConnectionDefaultParams?: InvitationConnectionParams;
+    invitationConnectionDefaultParams?: Partial<TeleportParams>;
     disableP2pReplication?: boolean;
   };
 /**
@@ -67,8 +56,6 @@ export type ServiceContextRuntimeParams = Pick<
 @safeInstanceof('dxos.client-services.ServiceContext')
 @Trace.resource()
 export class ServiceContext extends Resource {
-  private readonly _edgeIdentityUpdateMutex = new Mutex();
-
   public readonly initialized = new Trigger();
   public readonly metadataStore: MetadataStore;
   public readonly blobStore: BlobStore;
@@ -84,7 +71,6 @@ export class ServiceContext extends Resource {
 
   // Initialized after identity is initialized.
   public dataSpaceManager?: DataSpaceManager;
-  public edgeAgentManager?: EdgeAgentManager;
 
   private readonly _handlerFactories = new Map<
     Invitation.Kind,
@@ -101,7 +87,6 @@ export class ServiceContext extends Resource {
     public readonly networkManager: SwarmNetworkManager,
     public readonly signalManager: SignalManager,
     private readonly _edgeConnection: EdgeConnection | undefined,
-    private readonly _edgeHttpClient: EdgeHttpClient | undefined,
     public readonly _runtimeParams?: ServiceContextRuntimeParams,
     private readonly _edgeFeatures?: Runtime.Client.EdgeFeatures,
   ) {
@@ -131,16 +116,32 @@ export class ServiceContext extends Resource {
       disableP2pReplication: this._runtimeParams?.disableP2pReplication,
     });
 
-    this.identityManager = new IdentityManager({
-      metadataStore: this.metadataStore,
-      keyring: this.keyring,
-      feedStore: this.feedStore,
-      spaceManager: this.spaceManager,
-      devicePresenceOfflineTimeout: this._runtimeParams?.devicePresenceOfflineTimeout,
-      devicePresenceAnnounceInterval: this._runtimeParams?.devicePresenceAnnounceInterval,
-      edgeConnection: this._edgeConnection,
-      edgeFeatures: this._edgeFeatures,
-    });
+    this.identityManager = new IdentityManager(
+      this.metadataStore,
+      this.keyring,
+      this.feedStore,
+      this.spaceManager,
+      this._runtimeParams as IdentityManagerRuntimeParams,
+      {
+        onIdentityConstruction: (identity) => {
+          if (this._edgeConnection) {
+            log.info('Setting identity on edge connection', {
+              identity: identity.identityKey.toHex(),
+              oldIdentity: this._edgeConnection.identityKey,
+              swarms: this.networkManager.topics,
+            });
+            this._edgeConnection.setIdentity({
+              peerKey: identity.deviceKey.toHex(),
+              identityKey: identity.identityKey.toHex(),
+            });
+            this.networkManager.setPeerInfo({
+              identityKey: identity.identityKey.toHex(),
+              peerKey: identity.deviceKey.toHex(),
+            });
+          }
+        },
+      },
+    );
 
     this.echoHost = new EchoHost({ kv: this.level });
 
@@ -148,7 +149,6 @@ export class ServiceContext extends Resource {
 
     this.invitations = new InvitationsHandler(
       this.networkManager, //
-      this._edgeHttpClient,
       _runtimeParams?.invitationConnectionDefaultParams,
     );
     this.invitationsManager = new InvitationsManager(
@@ -185,11 +185,6 @@ export class ServiceContext extends Resource {
 
     log('opening...');
     log.trace('dxos.sdk.service-context.open', trace.begin({ id: this._instanceId }));
-
-    await this.identityManager.open(ctx);
-
-    await this._setNetworkIdentity();
-
     await this._edgeConnection?.open();
     await this.signalManager.open();
     await this.networkManager.open();
@@ -205,9 +200,9 @@ export class ServiceContext extends Resource {
 
     await this.metadataStore.load();
     await this.spaceManager.open();
+    await this.identityManager.open(ctx);
 
     if (this.identityManager.identity) {
-      await this.identityManager.identity.joinNetwork();
       await this._initialize(ctx);
     }
 
@@ -224,7 +219,6 @@ export class ServiceContext extends Resource {
       await this.identityManager.identity.space.spaceState.removeCredentialProcessor(this._deviceSpaceSync);
     }
     await this.dataSpaceManager?.close();
-    await this.edgeAgentManager?.close();
     await this.identityManager.close();
     await this.spaceManager.close();
     await this.feedStore.close();
@@ -240,8 +234,6 @@ export class ServiceContext extends Resource {
 
   async createIdentity(params: CreateIdentityOptions = {}) {
     const identity = await this.identityManager.createIdentity(params);
-    await this._setNetworkIdentity();
-    await identity.joinNetwork();
     await this._initialize(new Context());
     return identity;
   }
@@ -263,10 +255,7 @@ export class ServiceContext extends Resource {
   }
 
   private async _acceptIdentity(params: JoinIdentityParams) {
-    const { identity, identityRecord } = await this.identityManager.prepareIdentity(params);
-    await this._setNetworkIdentity({ deviceCredential: params.authorizedDeviceCredential! });
-    await identity.joinNetwork();
-    await this.identityManager.acceptIdentity(identity, identityRecord, params.deviceProfile);
+    const identity = await this.identityManager.acceptIdentity(params);
     await this._initialize(new Context());
     return identity;
   }
@@ -303,7 +292,6 @@ export class ServiceContext extends Resource {
       echoHost: this.echoHost,
       invitationsManager: this.invitationsManager,
       edgeConnection: this._edgeConnection,
-      edgeHttpClient: this._edgeHttpClient,
       echoEdgeReplicator: this._echoEdgeReplicator,
       meshReplicator: this._meshReplicator,
       runtimeParams: this._runtimeParams as DataSpaceManagerRuntimeParams,
@@ -311,14 +299,6 @@ export class ServiceContext extends Resource {
     });
     await this.dataSpaceManager.open();
 
-    this.edgeAgentManager = new EdgeAgentManager(
-      this._edgeFeatures,
-      this._edgeHttpClient,
-      this.dataSpaceManager,
-      identity,
-    );
-    await this.edgeAgentManager.open();
-
     this._handlerFactories.set(Invitation.Kind.SPACE, (invitation) => {
       invariant(this.dataSpaceManager, 'dataSpaceManager not initialized yet');
       return new SpaceInvitationProtocol(this.dataSpaceManager, signingContext, this.keyring, invitation.spaceKey);
@@ -358,51 +338,4 @@ export class ServiceContext extends Resource {
 
     await identity.space.spaceState.addCredentialProcessor(this._deviceSpaceSync);
   }
-
-  private async _setNetworkIdentity(params?: { deviceCredential: Credential }) {
-    using _ = await this._edgeIdentityUpdateMutex.acquire();
-
-    let edgeIdentity: EdgeIdentity;
-    const identity = this.identityManager.identity;
-    if (identity) {
-      log.info('Setting identity on edge connection', {
-        identity: identity.identityKey.toHex(),
-        swarms: this.networkManager.topics,
-      });
-      if (params?.deviceCredential) {
-        edgeIdentity = await createChainEdgeIdentity(
-          identity.signer,
-          identity.identityKey,
-          identity.deviceKey,
-          { credential: params.deviceCredential },
-          [], // TODO(dmaretskyi): Service access credentials.
-        );
-      } else {
-        // TODO: throw here or from identity if device chain can't be loaded, to avoid indefinite hangup
-        await warnAfterTimeout(10_000, 'Waiting for identity to be ready for edge connection', async () => {
-          await identity.ready();
-        });
-
-        invariant(identity.deviceCredentialChain);
-
-        edgeIdentity = await createChainEdgeIdentity(
-          identity.signer,
-          identity.identityKey,
-          identity.deviceKey,
-          identity.deviceCredentialChain,
-          [], // TODO(dmaretskyi): Service access credentials.
-        );
-      }
-    } else {
-      edgeIdentity = await createEphemeralEdgeIdentity();
-    }
-
-    if (this._edgeConnection) {
-      this._edgeConnection.setIdentity(edgeIdentity);
-    }
-    this.networkManager.setPeerInfo({
-      identityKey: edgeIdentity.identityKey,
-      peerKey: edgeIdentity.peerKey,
-    });
-  }
 }

package/src/packlets/services/service-host.test.ts

@@ -2,8 +2,9 @@
 // Copyright 2023 DXOS.org
 //
 
+import chai, { expect } from 'chai';
+import chaiAsPromised from 'chai-as-promised';
 import { rmSync } from 'node:fs';
-import { afterEach, onTestFinished, describe, expect, test } from 'vitest';
 
 import { asyncTimeout, latch, Trigger } from '@dxos/async';
 import { Config } from '@dxos/config';
@@ -13,10 +14,13 @@ import { type PublicKey } from '@dxos/keys';
 import { MemorySignalManagerContext } from '@dxos/messaging';
 import { type Identity } from '@dxos/protocols/proto/dxos/client/services';
 import { type Credential } from '@dxos/protocols/proto/dxos/halo/credentials';
+import { afterTest, describe, test } from '@dxos/test';
 import { isNode } from '@dxos/util';
 
 import { createMockCredential, createServiceHost } from '../testing';
 
+chai.use(chaiAsPromised);
+
 describe('ClientServicesHost', () => {
   const dataRoot = '/tmp/dxos/client-services/service-host/storage';
 
@@ -34,7 +38,7 @@ describe('ClientServicesHost', () => {
   test('queryCredentials', async () => {
     const host = createServiceHost(new Config(), new MemorySignalManagerContext());
     await host.open(new Context());
-    onTestFinished(() => host.close());
+    afterTest(() => host.close());
 
     await host.services.IdentityService!.createIdentity({});
     const { spaceKey } = await host.services.SpacesService!.createSpace();
@@ -45,7 +49,7 @@ describe('ClientServicesHost', () => {
       tick();
       // console.log(credential);
     });
-    onTestFinished(() => stream.close());
+    afterTest(() => stream.close());
 
     await done();
   });
@@ -53,7 +57,7 @@ describe('ClientServicesHost', () => {
   test('write and query credentials', async () => {
     const host = createServiceHost(new Config(), new MemorySignalManagerContext());
     await host.open(new Context());
-    onTestFinished(() => host.close());
+    afterTest(() => host.close());
 
     await host.services.IdentityService!.createIdentity({});
 
@@ -82,7 +86,7 @@ describe('ClientServicesHost', () => {
         queriedCredential.wake(credential);
       }
     });
-    onTestFinished(() => credentials.close());
+    afterTest(() => credentials.close());
 
     await queriedCredential.wait();
   });
@@ -90,7 +94,7 @@ describe('ClientServicesHost', () => {
   test('sign presentation', async () => {
     const host = createServiceHost(new Config(), new MemorySignalManagerContext());
     await host.open(new Context());
-    onTestFinished(() => host.close());
+    afterTest(() => host.close());
 
     await host.services.IdentityService!.createIdentity({});
 
@@ -143,9 +147,9 @@ describe('ClientServicesHost', () => {
           trigger.wake(identity.identity);
         }
       });
-      await expect(asyncTimeout(trigger.wait(), 200)).rejects.toBeInstanceOf(Error);
+      await expect(asyncTimeout(trigger.wait(), 200)).to.be.rejectedWith();
       await stream?.close();
       await host.close();
     }
-  });
+  }).onlyEnvironments('nodejs', 'chromium', 'firefox');
 });

package/src/packlets/services/service-host.ts

@@ -6,7 +6,7 @@ import { Event, synchronized } from '@dxos/async';
 import { clientServiceBundle, type ClientServices } from '@dxos/client-protocol';
 import { type Config } from '@dxos/config';
 import { Context } from '@dxos/context';
-import { EdgeClient, EdgeHttpClient, createStubEdgeIdentity, type EdgeConnection } from '@dxos/edge-client';
+import { EdgeClient, type EdgeConnection } from '@dxos/edge-client';
 import { invariant } from '@dxos/invariant';
 import { PublicKey } from '@dxos/keys';
 import { type LevelDB } from '@dxos/kv-store';
@@ -15,7 +15,7 @@ import { EdgeSignalManager, WebsocketSignalManager, type SignalManager } from '@
 import {
   SwarmNetworkManager,
   createIceProvider,
-  createRtcTransportFactory,
+  createSimplePeerTransportFactory,
   type TransportFactory,
 } from '@dxos/network-manager';
 import { trace } from '@dxos/protocols';
@@ -26,13 +26,12 @@ import { WebsocketRpcClient } from '@dxos/websocket-rpc';
 
 import { ServiceContext, type ServiceContextRuntimeParams } from './service-context';
 import { ServiceRegistry } from './service-registry';
-import { EdgeAgentServiceImpl } from '../agents';
 import { DevicesServiceImpl } from '../devices';
 import { DevtoolsHostEvents, DevtoolsServiceImpl } from '../devtools';
 import {
+  type CollectDiagnosticsBroadcastHandler,
   createCollectDiagnosticsBroadcastHandler,
   createDiagnostics,
-  type CollectDiagnosticsBroadcastHandler,
 } from '../diagnostics';
 import { IdentityServiceImpl, type CreateIdentityOptions } from '../identity';
 import { ContactsServiceImpl } from '../identity/contacts-service';
@@ -90,7 +89,6 @@ export class ClientServicesHost {
   private _callbacks?: ClientServicesHostCallbacks;
   private _devtoolsProxy?: WebsocketRpcClient<{}, ClientServices>;
   private _edgeConnection?: EdgeConnection = undefined;
-  private _edgeHttpClient?: EdgeHttpClient = undefined;
 
   private _serviceContext!: ServiceContext;
   private readonly _runtimeParams: ServiceContextRuntimeParams;
@@ -214,13 +212,13 @@ export class ClientServicesHost {
 
     const edgeEndpoint = config?.get('runtime.services.edge.url');
     if (edgeEndpoint) {
-      this._edgeConnection = new EdgeClient(createStubEdgeIdentity(), { socketEndpoint: edgeEndpoint });
-      this._edgeHttpClient = new EdgeHttpClient(edgeEndpoint);
+      const randomKey = PublicKey.random().toHex();
+      this._edgeConnection = new EdgeClient(randomKey, randomKey, { socketEndpoint: edgeEndpoint });
     }
 
     const {
       connectionLog = true,
-      transportFactory = createRtcTransportFactory(
+      transportFactory = createSimplePeerTransportFactory(
         { iceServers: this._config?.get('runtime.services.ice') },
         this._config?.get('runtime.services.iceProviders') &&
           createIceProvider(this._config!.get('runtime.services.iceProviders')!),
@@ -280,7 +278,6 @@ export class ClientServicesHost {
       this._networkManager,
       this._signalManager,
       this._edgeConnection,
-      this._edgeHttpClient,
       this._runtimeParams,
       this._config.get('runtime.client.edgeFeatures'),
     );
@@ -290,11 +287,6 @@ export class ClientServicesHost {
       return this._serviceContext.dataSpaceManager!;
     };
 
-    const agentManagerProvider = async () => {
-      await this._serviceContext.initialized.wait();
-      return this._serviceContext.edgeAgentManager!;
-    };
-
     const identityService = new IdentityServiceImpl(
       this._serviceContext.identityManager,
       this._serviceContext.keyring,
@@ -336,8 +328,6 @@ export class ClientServicesHost {
         config: this._config,
         context: this._serviceContext,
       }),
-
-      EdgeAgentService: new EdgeAgentServiceImpl(agentManagerProvider),
     });
 
     await this._serviceContext.open(ctx);

package/src/packlets/services/service-registry.test.ts

@@ -2,7 +2,7 @@
 // Copyright 2022 DXOS.org
 //
 
-import { describe, expect, test } from 'vitest';
+import { expect } from 'chai';
 
 import { Event } from '@dxos/async';
 import { type ClientServices } from '@dxos/client-protocol';
@@ -12,6 +12,7 @@ import { log } from '@dxos/log';
 import { schema } from '@dxos/protocols/proto';
 import { type SystemService, SystemStatus } from '@dxos/protocols/proto/dxos/client/services';
 import { createLinkedPorts, createProtoRpcPeer, createServiceBundle } from '@dxos/rpc';
+import { describe, test } from '@dxos/test';
 
 import { ServiceRegistry } from './service-registry';
 import { SystemServiceImpl } from '../system';

package/src/packlets/spaces/data-space-manager.test.ts

@@ -2,7 +2,7 @@
 // Copyright 2022 DXOS.org
 //
 
-import { describe, expect, test } from 'vitest';
+import { expect } from 'chai';
 
 import { asyncTimeout, latch } from '@dxos/async';
 import { createAdmissionCredentials } from '@dxos/credentials';
@@ -10,7 +10,7 @@ import { AuthStatus } from '@dxos/echo-pipeline';
 import { writeMessages } from '@dxos/feed-store';
 import { log } from '@dxos/log';
 import { SpaceState } from '@dxos/protocols/proto/dxos/client/services';
-import { openAndClose } from '@dxos/test-utils';
+import { describe, openAndClose, test } from '@dxos/test';
 
 import { TestBuilder, type TestPeer } from '../testing';
 

package/src/packlets/spaces/data-space-manager.ts

@@ -14,11 +14,8 @@ import {
   type DelegateInvitationCredential,
   type MemberInfo,
 } from '@dxos/credentials';
+import { convertLegacyReferences, findInlineObjectOfType, type EchoEdgeReplicator, type EchoHost } from '@dxos/echo-db';
 import {
-  convertLegacyReferences,
-  findInlineObjectOfType,
-  type EchoEdgeReplicator,
-  type EchoHost,
   AuthStatus,
   CredentialServerExtension,
   type MeshEchoReplicator,
@@ -35,8 +32,8 @@ import {
   type ObjectStructure,
   type SpaceDoc,
 } from '@dxos/echo-protocol';
-import { TYPE_PROPERTIES, createObjectId, getTypeReference } from '@dxos/echo-schema';
-import type { EdgeConnection, EdgeHttpClient } from '@dxos/edge-client';
+import { TYPE_PROPERTIES, generateEchoId, getTypeReference } from '@dxos/echo-schema';
+import type { EdgeConnection } from '@dxos/edge-client';
 import { writeMessages, type FeedStore } from '@dxos/feed-store';
 import { invariant } from '@dxos/invariant';
 import { type Keyring } from '@dxos/keyring';
@@ -46,7 +43,7 @@ import { AlreadyJoinedError, trace as Trace } from '@dxos/protocols';
 import { Invitation, SpaceState } from '@dxos/protocols/proto/dxos/client/services';
 import { type Runtime } from '@dxos/protocols/proto/dxos/config';
 import { type FeedMessage } from '@dxos/protocols/proto/dxos/echo/feed';
-import { type SpaceMetadata, EdgeReplicationSetting } from '@dxos/protocols/proto/dxos/echo/metadata';
+import { type SpaceMetadata } from '@dxos/protocols/proto/dxos/echo/metadata';
 import { SpaceMember, type Credential, type ProfileDocument } from '@dxos/protocols/proto/dxos/halo/credentials';
 import { type DelegateSpaceInvitation } from '@dxos/protocols/proto/dxos/halo/invitations';
 import { type PeerState } from '@dxos/protocols/proto/dxos/mesh/presence';
@@ -110,7 +107,6 @@ export type DataSpaceManagerParams = {
   echoHost: EchoHost;
   invitationsManager: InvitationsManager;
   edgeConnection?: EdgeConnection;
-  edgeHttpClient?: EdgeHttpClient;
   meshReplicator?: MeshEchoReplicator;
   echoEdgeReplicator?: EchoEdgeReplicator;
   runtimeParams?: DataSpaceManagerRuntimeParams;
@@ -120,7 +116,6 @@ export type DataSpaceManagerParams = {
 export type DataSpaceManagerRuntimeParams = {
   spaceMemberPresenceAnnounceInterval?: number;
   spaceMemberPresenceOfflineTimeout?: number;
-  activeEdgeNotarizationPollingInterval?: number;
   disableP2pReplication?: boolean;
 };
 
@@ -140,7 +135,6 @@ export class DataSpaceManager extends Resource {
   private readonly _echoHost: EchoHost;
   private readonly _invitationsManager: InvitationsManager;
   private readonly _edgeConnection?: EdgeConnection = undefined;
-  private readonly _edgeHttpClient?: EdgeHttpClient = undefined;
   private readonly _edgeFeatures?: Runtime.Client.EdgeFeatures = undefined;
   private readonly _meshReplicator?: MeshEchoReplicator = undefined;
   private readonly _echoEdgeReplicator?: EchoEdgeReplicator = undefined;
@@ -160,7 +154,6 @@ export class DataSpaceManager extends Resource {
     this._edgeConnection = params.edgeConnection;
     this._edgeFeatures = params.edgeFeatures;
     this._echoEdgeReplicator = params.echoEdgeReplicator;
-    this._edgeHttpClient = params.edgeHttpClient;
     this._runtimeParams = params.runtimeParams;
 
     trace.diagnostic({
@@ -297,7 +290,7 @@ export class DataSpaceManager extends Resource {
       },
     };
 
-    const propertiesId = createObjectId();
+    const propertiesId = generateEchoId();
     document.change((doc: SpaceDoc) => {
       setDeep(doc, ['objects', propertiesId], properties);
     });
@@ -395,26 +388,6 @@ export class DataSpaceManager extends Resource {
     });
   }
 
-  async setSpaceEdgeReplicationSetting(spaceKey: PublicKey, setting: EdgeReplicationSetting) {
-    const space = this._spaces.get(spaceKey);
-    invariant(space, 'Space not found.');
-
-    await this._metadataStore.setSpaceEdgeReplicationSetting(spaceKey, setting);
-
-    if (space.isOpen) {
-      switch (setting) {
-        case EdgeReplicationSetting.DISABLED:
-          await this._echoEdgeReplicator?.disconnectFromSpace(space.id);
-          break;
-        case EdgeReplicationSetting.ENABLED:
-          await this._echoEdgeReplicator?.connectToSpace(space.id);
-          break;
-      }
-    }
-
-    space.stateUpdate.emit();
-  }
-
   private async _constructSpace(metadata: SpaceMetadata) {
     log('construct space', { metadata });
     const gossip = new Gossip({
@@ -506,23 +479,13 @@ export class DataSpaceManager extends Resource {
       },
       cache: metadata.cache,
       edgeConnection: this._edgeConnection,
-      edgeHttpClient: this._edgeHttpClient,
       edgeFeatures: this._edgeFeatures,
-      activeEdgeNotarizationPollingInterval: this._runtimeParams?.activeEdgeNotarizationPollingInterval,
     });
     dataSpace.postOpen.append(async () => {
-      const setting = dataSpace.getEdgeReplicationSetting();
-      if (setting === EdgeReplicationSetting.ENABLED) {
-        await this._echoEdgeReplicator?.connectToSpace(dataSpace.id);
-      } else if (this._echoEdgeReplicator) {
-        log('not connecting EchoEdgeReplicator because of EdgeReplicationSetting', { spaceId: dataSpace.id });
-      }
+      await this._echoEdgeReplicator?.connectToSpace(dataSpace.id);
     });
     dataSpace.preClose.append(async () => {
-      const setting = dataSpace.getEdgeReplicationSetting();
-      if (setting === EdgeReplicationSetting.ENABLED) {
-        await this._echoEdgeReplicator?.disconnectFromSpace(dataSpace.id);
-      }
+      await this._echoEdgeReplicator?.disconnectFromSpace(dataSpace.id);
     });
 
     presence.newPeer.on((peerState) => {