@dxos/app-framework 0.3.10-next.ef70620 → 0.3.11-main.bd26370

package/src/plugins/common/layout.ts

@@ -13,17 +13,19 @@ import type { Plugin } from '../PluginHost';
 /**
  * Basic state provided by a layout plugin.
  */
+// TODO(burdon): Josiah: why do we use zod here?
 export const Layout = z.object({
   fullscreen: z.boolean(),
   sidebarOpen: z.boolean(),
   complementarySidebarOpen: z.boolean(),
 
-  dialogContent: z.any().optional().describe('Data to be passed to the dialog Surface.'),
+  // TODO(burdon): Why do we have a single root?
   dialogOpen: z.boolean(),
+  dialogContent: z.any().optional().describe('Data to be passed to the dialog Surface.'),
 
-  popoverAnchorId: z.string().optional(),
-  popoverContent: z.any().optional().describe('Data to be passed to the popover Surface.'),
   popoverOpen: z.boolean(),
+  popoverContent: z.any().optional().describe('Data to be passed to the popover Surface.'),
+  popoverAnchorId: z.string().optional(),
 
   // TODO(wittjosiah): Array?
   active: z.string().optional().describe('Id of the currently active item.'),
@@ -52,7 +54,7 @@ export const parseLayoutPlugin = (plugin: Plugin) => {
 // Intents
 //
 
-const LAYOUT_ACTION = 'dxos.org/plugin/intent';
+const LAYOUT_ACTION = 'dxos.org/plugin/layout';
 // TODO(wittjosiah): Consider consolidating some action types (e.g. toggle).
 export enum LayoutAction {
   TOGGLE_FULLSCREEN = `${LAYOUT_ACTION}/toggle-fullscreen`,

package/src/plugins/common/settings.ts

@@ -0,0 +1,22 @@
+//
+// Copyright 2023 DXOS.org
+//
+
+import { type Plugin } from '../PluginHost';
+
+// TODO(burdon): Plugins should export ts-effect object (see local-storage).
+// TODO(burdon): Auto generate form.
+// TODO(burdon): Set surface's data.type to plugin id (allow custom settings surface).
+
+export type SettingsProvides<T extends Record<string, any> = Record<string, any>> = {
+  settings: T; // TODO(burdon): Read-only.
+};
+
+export const parseSettingsPlugin = (plugin: Plugin) => {
+  return typeof (plugin.provides as any).settings === 'object' ? (plugin as Plugin<SettingsProvides>) : undefined;
+};
+
+const SETTINGS_ACTION = 'dxos.org/plugin/settings';
+export enum SettingsAction {
+  OPEN = `${SETTINGS_ACTION}/open`,
+}