@dxc-technology/halstack-react 6.0.0 → 6.1.0

package/switch/Switch.stories.tsx

@@ -1,5 +1,4 @@
 import React from "react";
-import { userEvent, within } from "@storybook/testing-library";
 import DxcSwitch from "./Switch";
 import { BackgroundColorProvider } from "../BackgroundColorContext";
 import Title from "../../.storybook/components/Title";
@@ -21,6 +20,10 @@ export const Chromatic = () => (
       <Title title="Without label" theme="light" level={4} />
       <DxcSwitch />
     </ExampleContainer>
+    <ExampleContainer pseudoState="pseudo-focus-visible">
+      <Title title="Focused" theme="light" level={4} />
+      <DxcSwitch label="Switch" labelPosition="after" />
+    </ExampleContainer>
     <ExampleContainer>
       <Title title="Checked" theme="light" level={4} />
       <DxcSwitch label="Switch" defaultChecked />
@@ -47,6 +50,10 @@ export const Chromatic = () => (
           <Title title="With label" theme="dark" level={4} />
           <DxcSwitch label="Switch" />
         </ExampleContainer>
+        <ExampleContainer pseudoState="pseudo-focus-visible">
+          <Title title="Focused" theme="dark" level={4} />
+          <DxcSwitch label="Switch" labelPosition="after" />
+        </ExampleContainer>
         <ExampleContainer>
           <Title title="Checked" theme="dark" level={4} />
           <DxcSwitch label="Switch" defaultChecked />
@@ -129,32 +136,3 @@ export const Chromatic = () => (
     </ExampleContainer>
   </>
 );
-
-const Switch = () => (
-  <ExampleContainer>
-    <Title title="Focused" theme="light" level={4} />
-    <DxcSwitch label="Switch" />
-  </ExampleContainer>
-);
-export const FocusedSwitch = Switch.bind({});
-FocusedSwitch.play = async ({ canvasElement }) => {
-  const canvas = within(canvasElement);
-  canvas.getByRole("switch").focus();
-};
-
-const DarkSwitch = () => (
-  <BackgroundColorProvider color="#333333">
-    <DarkContainer>
-      <ExampleContainer>
-        <Title title="Focused" theme="dark" level={4} />
-        <DxcSwitch label="Switch" />
-      </ExampleContainer>
-    </DarkContainer>
-  </BackgroundColorProvider>
-);
-
-export const FocusedSwitchOnDark = DarkSwitch.bind({});
-FocusedSwitchOnDark.play = async ({ canvasElement }) => {
-  const canvas = within(canvasElement);
-  canvas.getByRole("switch").focus();
-};

package/switch/Switch.test.js

@@ -37,7 +37,7 @@ describe("Switch component tests", function () {
 
     expect(onChange).toHaveBeenCalled();
   });
-  test("Everytime the user clicks the component the onchange function is called with the correct value CONTROLLED COMPONENT", function () {
+  test("Calls correct function on key down", function () {
     var onChange = jest.fn();
 
     var _render3 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
@@ -47,6 +47,30 @@ describe("Switch component tests", function () {
     })),
         getByText = _render3.getByText;
 
+    _react2.fireEvent.focus(getByText("SwitchComponent"));
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: "Enter"
+    });
+
+    expect(onChange).toHaveBeenCalled();
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: " "
+    });
+
+    expect(onChange).toHaveBeenCalled();
+  });
+  test("Everytime the user clicks the component the onchange function is called with the correct value CONTROLLED COMPONENT", function () {
+    var onChange = jest.fn();
+
+    var _render4 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+      label: "SwitchComponent",
+      checked: false,
+      onChange: onChange
+    })),
+        getByText = _render4.getByText;
+
     _react2.fireEvent.click(getByText("SwitchComponent"));
 
     _react2.fireEvent.click(getByText("SwitchComponent"));
@@ -54,14 +78,60 @@ describe("Switch component tests", function () {
     expect(onChange.mock.calls[0][0]).toBe(true);
     expect(onChange.mock.calls[1][0]).toBe(true);
   });
+  test("Everytime the user use enter in the component, the onchange function is called with the correct value CONTROLLED COMPONENT", function () {
+    var onChange = jest.fn();
+
+    var _render5 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+      label: "SwitchComponent",
+      checked: false,
+      onChange: onChange
+    })),
+        getByText = _render5.getByText;
+
+    _react2.fireEvent.focus(getByText("SwitchComponent"));
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: "Enter"
+    });
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: "Enter"
+    });
+
+    expect(onChange.mock.calls[0][0]).toBe(true);
+    expect(onChange.mock.calls[1][0]).toBe(true);
+  });
+  test("Everytime the user use space in the component, the onchange function is called with the correct value CONTROLLED COMPONENT", function () {
+    var onChange = jest.fn();
+
+    var _render6 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+      label: "SwitchComponent",
+      checked: false,
+      onChange: onChange
+    })),
+        getByText = _render6.getByText;
+
+    _react2.fireEvent.focus(getByText("SwitchComponent"));
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: " "
+    });
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: " "
+    });
+
+    expect(onChange.mock.calls[0][0]).toBe(true);
+    expect(onChange.mock.calls[1][0]).toBe(true);
+  });
   test("Everytime the user clicks the component the onchange function is called with the correct value UNCONTROLLED COMPONENT", function () {
     var onChange = jest.fn();
 
-    var _render4 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+    var _render7 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
       label: "SwitchComponent",
       onChange: onChange
     })),
-        getByText = _render4.getByText;
+        getByText = _render7.getByText;
 
     _react2.fireEvent.click(getByText("SwitchComponent"));
 
@@ -70,13 +140,57 @@ describe("Switch component tests", function () {
     expect(onChange.mock.calls[0][0]).toBe(true);
     expect(onChange.mock.calls[1][0]).toBe(false);
   });
+  test("Everytime the user use enter in the component, the onchange function is called with the correct value UNCONTROLLED COMPONENT", function () {
+    var onChange = jest.fn();
+
+    var _render8 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+      label: "SwitchComponent",
+      onChange: onChange
+    })),
+        getByText = _render8.getByText;
+
+    _react2.fireEvent.focus(getByText("SwitchComponent"));
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: "Enter"
+    });
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: "Enter"
+    });
+
+    expect(onChange.mock.calls[0][0]).toBe(true);
+    expect(onChange.mock.calls[1][0]).toBe(false);
+  });
+  test("Everytime the user use space in the component, the onchange function is called with the correct value UNCONTROLLED COMPONENT", function () {
+    var onChange = jest.fn();
+
+    var _render9 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+      label: "SwitchComponent",
+      onChange: onChange
+    })),
+        getByText = _render9.getByText;
+
+    _react2.fireEvent.focus(getByText("SwitchComponent"));
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: " "
+    });
+
+    _react2.fireEvent.keyDown(getByText("SwitchComponent"), {
+      key: " "
+    });
+
+    expect(onChange.mock.calls[0][0]).toBe(true);
+    expect(onChange.mock.calls[1][0]).toBe(false);
+  });
   test("Renders with correct initial value and initial state when it is uncontrolled", function () {
-    var _render5 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+    var _render10 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
       label: "Default label",
       defaultChecked: true,
       value: "test-defaultChecked"
     })),
-        getByRole = _render5.getByRole;
+        getByRole = _render10.getByRole;
 
     var inputEl = getByRole("switch");
     expect(inputEl.checked).toBe(true);
@@ -84,11 +198,11 @@ describe("Switch component tests", function () {
     expect(inputEl.getAttribute("aria-checked")).toBe("true");
   });
   test("Renders with correct aria attributes", function () {
-    var _render6 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
+    var _render11 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Switch["default"], {
       label: "Default label"
     })),
-        getByRole = _render6.getByRole,
-        getByText = _render6.getByText;
+        getByRole = _render11.getByRole,
+        getByText = _render11.getByText;
 
     var inputEl = getByRole("switch");
     var label = getByText("Default label");

package/switch/types.d.ts

@@ -1,11 +1,11 @@
-declare type Space = "xxsmall" | "xsmall" | "small" | "medium" | "large" | "xlarge" | "xxlarge";
-declare type Margin = {
+export declare type Space = "xxsmall" | "xsmall" | "small" | "medium" | "large" | "xlarge" | "xxlarge";
+export declare type Margin = {
     top?: Space;
     bottom?: Space;
     left?: Space;
     right?: Space;
 };
-declare type Props = {
+export declare type SwitchPropsType = {
     /**
      * Initial state of the switch, only when it is uncontrolled.
      */
@@ -59,4 +59,3 @@ declare type Props = {
      */
     tabIndex?: number;
 };
-export default Props;

package/tabs/types.d.ts

@@ -6,7 +6,7 @@ declare type Margin = {
     left?: Space;
     right?: Space;
 };
-declare type SVG = React.SVGProps<SVGSVGElement>;
+declare type SVG = React.ReactNode & React.SVGProps<SVGSVGElement>;
 declare type TabCommonProps = {
     /**
      * Whether the tab is disabled or not.

package/tabs-nav/NavTabs.js

@@ -91,15 +91,15 @@ var DxcNavTabs = function DxcNavTabs(_ref) {
       return getPropInChild(child, "active");
     });
 
-    switch (event.keyCode) {
-      case 37:
-        // arrow left
+    switch (event.key) {
+      case "Left":
+      case "ArrowLeft":
         event.preventDefault();
         setInnerFocus(getPreviousTabIndex(children, innerFocus === null ? activeTab : innerFocus));
         break;
 
-      case 39:
-        // arrow right
+      case "Right":
+      case "ArrowRight":
         event.preventDefault();
         setInnerFocus(getNextTabIndex(children, innerFocus === null ? activeTab : innerFocus));
         break;

package/tabs-nav/Tab.js

@@ -59,11 +59,9 @@ var DxcTab = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, _ref2) {
   var handleOnKeyDown = function handleOnKeyDown(event) {
     var _tabRef$current2;
 
-    switch (event.keyCode) {
-      case 13: // enter
-
-      case 32:
-        // space
+    switch (event.key) {
+      case "Enter":
+      case "Space":
         tabRef === null || tabRef === void 0 ? void 0 : (_tabRef$current2 = tabRef.current) === null || _tabRef$current2 === void 0 ? void 0 : _tabRef$current2.click();
         event.preventDefault();
         break;

package/tabs-nav/types.d.ts

@@ -1,5 +1,5 @@
 /// <reference types="react" />
-declare type SVG = React.SVGProps<SVGSVGElement>;
+declare type SVG = React.ReactNode & React.SVGProps<SVGSVGElement>;
 export declare type TabProps = {
     /**
      * Whether the tab is active or not.

package/tag/types.d.ts

@@ -6,7 +6,7 @@ declare type Margin = {
     left?: Space;
     right?: Space;
 };
-declare type SVG = React.SVGProps<SVGSVGElement>;
+declare type SVG = React.ReactNode & React.SVGProps<SVGSVGElement>;
 declare type TagCommonProps = {
     /**
      * If defined, the tag will be displayed as an anchor, using this prop as "href".

package/text-input/TextInput.js

@@ -110,14 +110,6 @@ var makeCancelable = function makeCancelable(promise) {
   };
 };
 
-var getNotOptionalErrorMessage = function getNotOptionalErrorMessage() {
-  return "This field is required. Please, enter a value.";
-};
-
-var getPatternErrorMessage = function getPatternErrorMessage() {
-  return "Please match the format requested.";
-};
-
 var patternMatch = function patternMatch(pattern, value) {
   return new RegExp(pattern).test(value);
 };
@@ -307,14 +299,14 @@ var DxcTextInput = /*#__PURE__*/_react["default"].forwardRef(function (_ref, ref
   };
 
   var handleIOnKeyDown = function handleIOnKeyDown(event) {
-    switch (event.keyCode) {
-      case 40:
-        // Arrow Down
+    switch (event.key) {
+      case "Down":
+      case "ArrowDown":
+        event.preventDefault();
+
         if ((numberInputContext === null || numberInputContext === void 0 ? void 0 : numberInputContext.typeNumber) === "number") {
           decrementNumber();
-          event.preventDefault();
         } else {
-          event.preventDefault();
           openSuggestions();
 
           if (!isAutosuggestError && !isSearching && filteredSuggestions.length > 0) {
@@ -326,13 +318,13 @@ var DxcTextInput = /*#__PURE__*/_react["default"].forwardRef(function (_ref, ref
 
         break;
 
-      case 38:
-        // Arrow Up
+      case "Up":
+      case "ArrowUp":
+        event.preventDefault();
+
         if ((numberInputContext === null || numberInputContext === void 0 ? void 0 : numberInputContext.typeNumber) === "number") {
           incrementNumber();
-          event.preventDefault();
         } else {
-          event.preventDefault();
           openSuggestions();
 
           if (!isAutosuggestError && !isSearching && filteredSuggestions.length > 0) {
@@ -344,8 +336,8 @@ var DxcTextInput = /*#__PURE__*/_react["default"].forwardRef(function (_ref, ref
 
         break;
 
-      case 27:
-        // Esc
+      case "Esc":
+      case "Escape":
         event.preventDefault();
 
         if (hasSuggestions()) {
@@ -355,8 +347,7 @@ var DxcTextInput = /*#__PURE__*/_react["default"].forwardRef(function (_ref, ref
 
         break;
 
-      case 13:
-        // Enter
+      case "Enter":
         if (hasSuggestions() && !isSearching) {
           var validFocusedSuggestion = filteredSuggestions.length > 0 && visualFocusedSuggIndex >= 0 && visualFocusedSuggIndex < filteredSuggestions.length;
           validFocusedSuggestion && changeValue(filteredSuggestions[visualFocusedSuggIndex]);

package/text-input/TextInput.stories.tsx

@@ -1,6 +1,5 @@
 import React from "react";
-import { userEvent, within, waitFor } from "@storybook/testing-library";
-import { fireEvent } from "@testing-library/react";
+import { userEvent, within, fireEvent } from "@storybook/testing-library";
 import { BackgroundColorProvider } from "../BackgroundColorContext";
 import Title from "../../.storybook/components/Title";
 import ExampleContainer from "../../.storybook/components/ExampleContainer";

package/text-input/types.d.ts

@@ -6,7 +6,7 @@ declare type Margin = {
     left?: Space;
     right?: Space;
 };
-declare type SVG = React.SVGProps<SVGSVGElement>;
+declare type SVG = React.ReactNode & React.SVGProps<SVGSVGElement>;
 declare type Action = {
     /**
      * This function will be called when the user clicks the action.

package/toggle-group/types.d.ts

@@ -6,7 +6,7 @@ declare type Margin = {
     left?: Space;
     right?: Space;
 };
-declare type SVG = React.SVGProps<SVGSVGElement>;
+declare type SVG = React.ReactNode & React.SVGProps<SVGSVGElement>;
 declare type OptionCommons = {
     /**
      * Number with the option inner value.

package/wizard/types.d.ts

@@ -6,7 +6,7 @@ export declare type Margin = {
     left?: Space;
     right?: Space;
 };
-declare type SVG = React.SVGProps<SVGSVGElement>;
+declare type SVG = React.ReactNode & React.SVGProps<SVGSVGElement>;
 declare type Step = {
     /**
      * Step label.