@dxc-technology/halstack-react 0.0.0-f53e801 → 0.0.0-f54247d

package/checkbox/Checkbox.stories.tsx

@@ -4,7 +4,7 @@ import { BackgroundColorProvider } from "../BackgroundColorContext";
 import Title from "../../.storybook/components/Title";
 import ExampleContainer from "../../.storybook/components/ExampleContainer";
 import DarkContainer from "../../.storybook/components/DarkSection";
-import { userEvent } from "@storybook/testing-library";
+import styled from "styled-components";
 
 export default {
   title: "Checkbox",
@@ -17,29 +17,33 @@ const Checkbox = () => (
       <Title title="Default" theme="light" level={4} />
       <DxcCheckbox label="Checkbox" />
     </ExampleContainer>
-    <ExampleContainer>
-      <Title title="Focused" theme="light" level={4} />
-      <DxcCheckbox label="Focused" />
-    </ExampleContainer>
     <ExampleContainer>
       <Title title="Checked" theme="light" level={4} />
       <DxcCheckbox label="Checkbox" defaultChecked />
     </ExampleContainer>
     <ExampleContainer>
-      <Title title="Optional" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" optional />
+      <Title title="Disabled" theme="light" level={4} />
+      <DxcCheckbox label="Checkbox" disabled />
     </ExampleContainer>
     <ExampleContainer>
-      <Title title="Disabled and checked" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" disabled defaultChecked />
+      <Title title="Disabled, checked and optional" theme="light" level={4} />
+      <DxcCheckbox label="Checkbox" disabled defaultChecked optional />
     </ExampleContainer>
-    <ExampleContainer>
-      <Title title="Disabled and optional" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" disabled optional />
+    <ExampleContainer pseudoState="pseudo-focus">
+      <Title title="Focused" theme="light" level={4} />
+      <DxcCheckbox label="Focused" />
+    </ExampleContainer>
+    <ExampleContainer pseudoState="pseudo-hover">
+      <Title title="Hovered" theme="light" level={4} />
+      <DxcCheckbox label="Hovered" />
+    </ExampleContainer>
+    <ExampleContainer pseudoState="pseudo-hover">
+      <Title title="Hovered and checked" theme="light" level={4} />
+      <DxcCheckbox label="Hovered" defaultChecked />
     </ExampleContainer>
     <ExampleContainer>
-      <Title title="Disabled, optional and checked" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" disabled optional defaultChecked />
+      <Title title="Optional" theme="light" level={4} />
+      <DxcCheckbox label="Checkbox" optional />
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Label after" theme="light" level={4} />
@@ -53,25 +57,9 @@ const Checkbox = () => (
       <Title title="Optional with label after" theme="light" level={4} />
       <DxcCheckbox label="Checkbox" optional labelPosition="after" />
     </ExampleContainer>
-    <ExampleContainer>
-      <Title title="Disabled and checked with label after" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" disabled defaultChecked labelPosition="after" />
-    </ExampleContainer>
     <ExampleContainer>
       <Title title="Disabled and optional with label after" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" disabled optional labelPosition="after" />
-    </ExampleContainer>
-    <ExampleContainer>
-      <Title title="Disabled, optional and checked with label after" theme="light" level={4} />
-      <DxcCheckbox label="Checkbox" disabled optional defaultChecked labelPosition="after" />
-    </ExampleContainer>
-    <ExampleContainer pseudoState="pseudo-hover">
-      <Title title="Hovered" theme="light" level={4} />
-      <DxcCheckbox label="Hovered" />
-    </ExampleContainer>
-    <ExampleContainer pseudoState="pseudo-hover">
-      <Title title="Hovered and checked" theme="light" level={4} />
-      <DxcCheckbox label="Hovered" defaultChecked />
+      <DxcCheckbox label="Checkbox" disabled labelPosition="after" optional />
     </ExampleContainer>
     <BackgroundColorProvider color="#333333">
       <DarkContainer>
@@ -84,20 +72,28 @@ const Checkbox = () => (
           <DxcCheckbox label="Checkbox" defaultChecked />
         </ExampleContainer>
         <ExampleContainer>
-          <Title title="Optional" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" optional />
+          <Title title="Disabled" theme="dark" level={4} />
+          <DxcCheckbox label="Checkbox" disabled />
         </ExampleContainer>
         <ExampleContainer>
-          <Title title="Disabled and checked" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" disabled defaultChecked />
+          <Title title="Disabled, checked and optional" theme="dark" level={4} />
+          <DxcCheckbox label="Checkbox" disabled defaultChecked optional />
         </ExampleContainer>
-        <ExampleContainer>
-          <Title title="Disabled and optional" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" disabled optional />
+        <ExampleContainer pseudoState="pseudo-focus">
+          <Title title="Focused" theme="dark" level={4} />
+          <DxcCheckbox label="Focused" />
+        </ExampleContainer>
+        <ExampleContainer pseudoState="pseudo-hover">
+          <Title title="Hovered" theme="dark" level={4} />
+          <DxcCheckbox label="Hovered" />
+        </ExampleContainer>
+        <ExampleContainer pseudoState="pseudo-hover">
+          <Title title="Hovered and checked" theme="dark" level={4} />
+          <DxcCheckbox label="Hovered" defaultChecked />
         </ExampleContainer>
         <ExampleContainer>
-          <Title title="Disabled, optional and checked" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" disabled optional defaultChecked />
+          <Title title="Optional" theme="dark" level={4} />
+          <DxcCheckbox label="Checkbox" optional />
         </ExampleContainer>
         <ExampleContainer>
           <Title title="Label after" theme="dark" level={4} />
@@ -111,25 +107,9 @@ const Checkbox = () => (
           <Title title="Optional with label after" theme="dark" level={4} />
           <DxcCheckbox label="Checkbox" optional labelPosition="after" />
         </ExampleContainer>
-        <ExampleContainer>
-          <Title title="Disabled and checked with label after" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" disabled defaultChecked labelPosition="after" />
-        </ExampleContainer>
         <ExampleContainer>
           <Title title="Disabled and optional with label after" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" disabled optional labelPosition="after" />
-        </ExampleContainer>
-        <ExampleContainer>
-          <Title title="Disabled, optional and checked with label after" theme="dark" level={4} />
-          <DxcCheckbox label="Checkbox" disabled optional defaultChecked labelPosition="after" />
-        </ExampleContainer>
-        <ExampleContainer pseudoState="pseudo-hover">
-          <Title title="Hovered" theme="dark" level={4} />
-          <DxcCheckbox label="Hovered" />
-        </ExampleContainer>
-        <ExampleContainer pseudoState="pseudo-hover">
-          <Title title="Hovered and checked" theme="dark" level={4} />
-          <DxcCheckbox label="Hovered" defaultChecked />
+          <DxcCheckbox label="Checkbox" disabled labelPosition="after" optional />
         </ExampleContainer>
       </DarkContainer>
     </BackgroundColorProvider>
@@ -178,11 +158,51 @@ const Checkbox = () => (
       <Title title="Xxlarge" theme="light" level={4} />
       <DxcCheckbox label="Xxlarge" margin="xxlarge" />
     </ExampleContainer>
+    <ExampleContainer>
+      <Title title="Overflow container" theme="light" level={4} />
+      <ScrollableContainer id="scroll-container">
+        <DxcCheckbox label="Checkbox" defaultChecked />
+        <DxcCheckbox label="Checkbox" defaultChecked />
+        <DxcCheckbox label="Checkbox" />
+        <DxcCheckbox label="Checkbox" defaultChecked />
+        <DxcCheckbox label="Checkbox" />
+        <DxcCheckbox label="Checkbox" />
+        <DxcCheckbox label="Checkbox" />
+        <DxcCheckbox label="Checkbox" defaultChecked />
+      </ScrollableContainer>
+    </ExampleContainer>
+    <ExampleContainer>
+      <Title title="Label overflow" theme="light" level={4} />
+      <SmallContainer>
+        <DxcCheckbox label="Very long label to check its overflowing" defaultChecked />
+        <DxcCheckbox label="Very long label to check its overflowing" labelPosition="after" />
+      </SmallContainer>
+    </ExampleContainer>
   </>
 );
 
 export const Chromatic = Checkbox.bind({});
+
 Chromatic.play = async () => {
-  await userEvent.tab();
-  await userEvent.tab();
+  const listEl = document.getElementById("scroll-container");
+  listEl?.scrollTo?.({ top: 50 });
 };
+
+const ScrollableContainer = styled.div`
+  display: flex;
+  flex-direction: column;
+  gap: 14px;
+  width: 200px;
+  height: 200px;
+  border: 1px solid #000;
+  padding: 14px;
+  overflow: auto;
+`;
+
+const SmallContainer = styled.div`
+  display: flex;
+  flex-direction: column;
+  gap: 14px;
+  width: 150px;
+  height: 150px;
+`;

package/checkbox/Checkbox.test.js

@@ -6,25 +6,39 @@ var _react = _interopRequireDefault(require("react"));
 
 var _react2 = require("@testing-library/react");
 
+var _userEvent = _interopRequireDefault(require("@testing-library/user-event"));
+
 var _Checkbox = _interopRequireDefault(require("./Checkbox"));
 
 describe("Checkbox component tests", function () {
-  test("Checkbox renders with correct text", function () {
+  test("Checkbox renders with correct aria-labelledby and aria-required", function () {
     var _render = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
       label: "Checkbox"
     })),
-        getByText = _render.getByText;
+        getByText = _render.getByText,
+        getByRole = _render.getByRole;
 
-    expect(getByText("Checkbox")).toBeTruthy();
+    var labelId = getByText("Checkbox").getAttribute("id");
+    expect(getByRole("checkbox").getAttribute("aria-labelledby")).toBe(labelId);
+    expect(getByRole("checkbox").getAttribute("aria-required")).toBe("true");
+  });
+  test("Optional checkbox renders with correct aria-required", function () {
+    var _render2 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
+      label: "Checkbox",
+      optional: true
+    })),
+        getByRole = _render2.getByRole;
+
+    expect(getByRole("checkbox").getAttribute("aria-required")).toBe("false");
   });
   test("Calls correct function on click", function () {
     var onChange = jest.fn();
 
-    var _render2 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
+    var _render3 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
       label: "Checkbox",
       onChange: onChange
     })),
-        getByText = _render2.getByText;
+        getByText = _render3.getByText;
 
     _react2.fireEvent.click(getByText("Checkbox"));
 
@@ -34,45 +48,108 @@ describe("Checkbox component tests", function () {
     var onChange = jest.fn();
     var component = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
       label: "Checkbox",
-      onChange: onChange
+      onChange: onChange,
+      name: "test"
     }));
     var visibleCheckbox = component.getByText("Checkbox");
     var input = component.getByRole("checkbox");
-    expect(input.checked).toBe(false);
+    var submitInput = component.container.querySelector("input[name=\"test\"]");
+    expect(input.getAttribute("aria-checked")).toBe("false");
+    expect(submitInput.checked).toBe(false);
 
     _react2.fireEvent.click(visibleCheckbox);
 
     expect(onChange).toHaveBeenCalled();
     expect(onChange).toHaveBeenCalledWith(true);
-    expect(input.checked).toBe(true);
+    expect(input.getAttribute("aria-checked")).toBe("true");
+    expect(submitInput.checked).toBe(true);
   });
   test("Controlled checkbox", function () {
     var onChange = jest.fn();
     var component = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
       label: "Checkbox",
       checked: false,
-      onChange: onChange
+      onChange: onChange,
+      name: "test"
     }));
     var input = component.getByRole("checkbox");
     var visibleCheckbox = component.getByText("Checkbox");
+    var submitInput = component.container.querySelector("input[name=\"test\"]");
 
     _react2.fireEvent.click(visibleCheckbox);
 
     expect(onChange).toHaveBeenCalled();
     expect(onChange).toHaveBeenCalledWith(true);
-    expect(input.checked).toBe(false);
+    expect(input.getAttribute("aria-checked")).toBe("false");
+    expect(submitInput.checked).toBe(false);
   });
   test("Renders with correct initial value and initial state when it is uncontrolled", function () {
-    var _render3 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
+    var _render4 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
       label: "Default label",
       defaultChecked: true,
-      value: "test-defaultChecked"
+      value: "test-defaultChecked",
+      name: "test"
+    })),
+        getByRole = _render4.getByRole,
+        container = _render4.container;
+
+    var checkbox = getByRole("checkbox");
+    var submitInput = container.querySelector("input[name=\"test\"]");
+    expect(submitInput.value).toBe("test-defaultChecked");
+    expect(checkbox.getAttribute("aria-checked")).toBe("true");
+    expect(submitInput.checked).toBe(true);
+  });
+  test("Test disable keyboard and mouse interactions", function () {
+    var onChange = jest.fn();
+
+    var _render5 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
+      label: "Checkbox",
+      onChange: onChange,
+      disabled: true,
+      name: "test"
     })),
-        getByRole = _render3.getByRole;
+        getByRole = _render5.getByRole,
+        getByText = _render5.getByText,
+        container = _render5.container;
 
     var input = getByRole("checkbox");
-    expect(input.checked).toBe(true);
-    expect(input.value).toBe("test-defaultChecked");
-    expect(input.getAttribute("aria-checked")).toBe("true");
+    var visibleCheckbox = getByText("Checkbox");
+    var submitInput = container.querySelector("input[name=\"test\"]");
+
+    _react2.fireEvent.click(visibleCheckbox);
+
+    expect(onChange).toHaveBeenCalledTimes(0);
+    expect(input.getAttribute("aria-checked")).toBe("false");
+    expect(input.getAttribute("aria-disabled")).toBe("true");
+    expect(submitInput.checked).toBe(false);
+
+    _userEvent["default"].tab();
+
+    expect(document.activeElement === input).toBeFalsy();
+  });
+  test("Test keyboard interactions", function () {
+    var onChange = jest.fn();
+
+    var _render6 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_Checkbox["default"], {
+      label: "Checkbox",
+      name: "test",
+      onChange: onChange
+    })),
+        getByRole = _render6.getByRole;
+
+    var checkbox = getByRole("checkbox");
+
+    _userEvent["default"].tab();
+
+    expect(document.activeElement === checkbox).toBeTruthy();
+
+    _react2.fireEvent.keyDown(checkbox, {
+      key: " ",
+      code: "Space",
+      keyCode: 32,
+      charCode: 32
+    });
+
+    expect(onChange).toHaveBeenCalledWith(true);
   });
 });

package/checkbox/types.d.ts

@@ -1,5 +1,5 @@
-declare type Space = "xxsmall" | "xsmall" | "small" | "medium" | "large" | "xlarge" | "xxlarge";
-declare type Margin = {
+export declare type Space = "xxsmall" | "xsmall" | "small" | "medium" | "large" | "xlarge" | "xxlarge";
+export declare type Margin = {
     top?: Space;
     bottom?: Space;
     left?: Space;
@@ -61,4 +61,8 @@ declare type Props = {
      */
     tabIndex?: number;
 };
+/**
+ * Reference to the component.
+ */
+export declare type RefType = HTMLDivElement;
 export default Props;

package/common/variables.js

@@ -179,13 +179,13 @@ var componentTokens = {
     titleLabelFontStyle: globalTokens.type_normal,
     titleLabelFontColor: globalTokens.hal_black,
     disabledTitleLabelFontColor: globalTokens.hal_grey_l_60,
-    titleLabelPaddingLeft: "0px",
-    titleLabelPaddingRight: "16px",
     titleLabelPaddingTop: "0px",
     titleLabelPaddingBottom: "0px",
+    titleLabelPaddingLeft: "0px",
+    titleLabelPaddingRight: "16px",
+    focusBorderColor: globalTokens.hal_blue_l_50,
     focusBorderStyle: "solid",
     focusBorderThickness: "2px",
-    focusBorderColor: globalTokens.hal_blue_l_50,
     borderRadius: "4px",
     boxShadowOffsetX: "0px",
     boxShadowOffsetY: "6px",
@@ -354,7 +354,7 @@ var componentTokens = {
     backgroundColorChecked: globalTokens.hal_blue_s_35,
     backgroundColorCheckedOnDark: globalTokens.hal_grey_l_90,
     hoverBackgroundColorChecked: globalTokens.hal_blue_d_20,
-    hoverBackgroundColorCheckedOnDark: global.hal_white,
+    hoverBackgroundColorCheckedOnDark: globalTokens.hal_white,
     disabledBackgroundColorChecked: globalTokens.hal_grey_l_60,
     disabledBackgroundColorCheckedOnDark: globalTokens.color_grey_800,
     borderColor: globalTokens.hal_blue_s_35,
@@ -408,7 +408,7 @@ var componentTokens = {
     pickerHoverDateBackgroundColor: globalTokens.hal_purple_l_90,
     pickerSelectedDateColor: globalTokens.hal_white,
     pickerSelectedDateBackgroundColor: globalTokens.hal_purple_s_38,
-    pickerActualDateFontColor: globalTokens.hal_grey_l_60,
+    pickerActualDateFontColor: globalTokens.hal_black,
     pickerYearFontColor: globalTokens.hal_black,
     pickerMonthFontColor: globalTokens.hal_black,
     pickerWeekFontColor: globalTokens.hal_black,
@@ -416,7 +416,8 @@ var componentTokens = {
     pickerMonthArrowsBackgroundColor: globalTokens.transparent,
     pickerFocusColor: globalTokens.hal_blue_l_50,
     pickerHeight: "316px",
-    pickerWidth: "290px"
+    // not referenced in the actual implementation
+    pickerWidth: "292px"
   },
   dialog: {
     overlayColor: globalTokens.hal_black,
@@ -763,13 +764,13 @@ var componentTokens = {
     fontTextTransform: "none",
     verticalPadding: "0.75rem",
     horizontalPadding: "2rem",
-    marginRight: "2rem",
-    marginLeft: "2rem",
+    marginRight: "40px",
+    marginLeft: "20px",
     itemsPerPageSelectorMarginLeft: "0px",
-    itemsPerPageSelectorMarginRight: "1rem",
+    itemsPerPageSelectorMarginRight: "0.5rem",
     pageSelectorMarginRight: "30px",
     pageSelectorMarginLeft: "0px",
-    totalItemsContainerMarginRight: "3rem",
+    totalItemsContainerMarginRight: "2.5rem",
     totalItemsContainerMarginLeft: "0px"
   },
   progressBar: {
@@ -804,7 +805,6 @@ var componentTokens = {
   quickNav: {
     fontColor: globalTokens.hal_grey_s_40,
     hoverFontColor: globalTokens.hal_purple_d_70,
-    selectedFontColor: globalTokens.hal_purple_s_38,
     dividerBorderColor: globalTokens.hal_grey_l_75,
     focusBorderColor: globalTokens.hal_blue_l_50,
     focusBorderStyle: globalTokens.border_solid,
@@ -1025,7 +1025,7 @@ var componentTokens = {
     trackLineColorOnDark: globalTokens.hal_blue_l_50,
     totalLineThickness: "2px",
     totalLineVerticalPosition: "50%",
-    totalLineColor: globalTokens.hal_grey_l_90,
+    totalLineColor: "#0000001a",
     totalLineColorOnDark: globalTokens.hal_grey_l_75,
     disabledThumbVerticalPosition: "10px",
     disabledThumbBackgroundColor: globalTokens.hal_grey_l_60,
@@ -1424,6 +1424,9 @@ var defaultTranslatedComponentLabels = {
     },
     logoAlternativeText: "Logo"
   },
+  applicationLayout: {
+    visibilityToggleTitle: "Toggle visibility sidenav"
+  },
   alert: {
     infoTitleText: "information",
     successTitleText: "success",
@@ -1440,7 +1443,8 @@ var defaultTranslatedComponentLabels = {
     singleButtonLabelDefault: "Select file",
     dropAreaButtonLabelDefault: "Select",
     multipleDropAreaLabelDefault: "or drop files",
-    singleDropAreaLabelDefault: "or drop a file"
+    singleDropAreaLabelDefault: "or drop a file",
+    deleteFileActionTitle: "Remove file"
   },
   footer: {
     copyrightText: function copyrightText(year) {
@@ -1462,7 +1466,7 @@ var defaultTranslatedComponentLabels = {
     incrementValueTitle: "Increment value"
   },
   paginator: {
-    itemsPerPageText: "Items per page ",
+    itemsPerPageText: "Items per page: ",
     minToMaxOfText: function minToMaxOfText(minNumberOfItems, maxNumberOfItems, totalItems) {
       return "".concat(minNumberOfItems, " to ").concat(maxNumberOfItems, " of ").concat(totalItems);
     },
@@ -1486,6 +1490,10 @@ var defaultTranslatedComponentLabels = {
     actionClearSelectionTitle: "Clear selection",
     actionClearSearchTitle: "Clear search"
   },
+  tabs: {
+    scrollLeft: "Scroll left",
+    scrollRight: "Scroll right"
+  },
   textInput: {
     clearFieldActionTitle: "Clear field",
     searchingMessage: "Searching...",
@@ -1493,12 +1501,12 @@ var defaultTranslatedComponentLabels = {
   },
   calendar: {
     days: ["Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"],
-    daysShort: ["Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"],
+    daysShort: ["Su", "Mo", "Tu", "We", "Th", "Fr", "Sa"],
     months: ["January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"],
-    monthsShort: ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"]
-  },
-  applicationLayout: {
-    visibilityToggleTitle: "Toggle visibility sidenav"
+    monthsShort: ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"],
+    previousMonthTitle: "Previous month",
+    nextMonthTitle: "Next month",
+    openCalendar: "Open calendar"
   }
 };
 exports.defaultTranslatedComponentLabels = defaultTranslatedComponentLabels;

package/date-input/Calendar.d.ts

@@ -0,0 +1,4 @@
+import React from "react";
+import { CalendarPropsType } from "./types";
+declare const _default: React.MemoExoticComponent<({ selectedDate, innerDate, onInnerDateChange, onDaySelect }: CalendarPropsType) => JSX.Element>;
+export default _default;