@dxc-technology/halstack-react 0.0.0-e792e0c → 0.0.0-e832ef8

package/test/ResultsetTable.test.js

@@ -1,5 +1,7 @@
 import React from "react";
-import { render, fireEvent } from "@testing-library/react";
+import { render, fireEvent, act } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+
 import DxcResultsetTable from "../src/resultsetTable/ResultsetTable";
 
 const columns = [
@@ -14,7 +16,7 @@ const columns = [
   {
     displayValue: "City",
     isSortable: false,
-  }
+  },
 ];
 
 const rows = [
@@ -30,7 +32,7 @@ const rows = [
     {
       displayValue: "Oviedo",
       sortValue: "Oviedo",
-    }
+    },
   ],
   [
     {
@@ -61,7 +63,7 @@ const rows = [
     {
       displayValue: "Albacete",
       sortValue: "Albacete",
-    }
+    },
   ],
   [
     {
@@ -75,7 +77,7 @@ const rows = [
     {
       displayValue: "Albacete",
       sortValue: "Albacete",
-    }
+    },
   ],
   [
     {
@@ -89,7 +91,7 @@ const rows = [
     {
       displayValue: "Madrid",
       sortValue: "Madrid",
-    }
+    },
   ],
   [
     {
@@ -120,7 +122,7 @@ const rows = [
     {
       displayValue: "Madrid",
       sortValue: "Madrid",
-    }
+    },
   ],
   [
     {
@@ -134,7 +136,7 @@ const rows = [
     {
       displayValue: "Barcelona",
       sortValue: "Barcelona",
-    }
+    },
   ],
   [
     {
@@ -185,7 +187,7 @@ const rows2 = [
     {
       displayValue: "OtherValue",
       sortValue: "OtherValue",
-    }
+    },
   ],
   [
     {
@@ -216,21 +218,22 @@ const rows2 = [
     {
       displayValue: "OtherValue",
       sortValue: "OtherValue",
-    }
+    },
   ],
 ];
 
 describe("ResultsetTable component tests", () => {
   test("ResultsetTable rendered correctly", () => {
-    const { getByText } = render(<DxcResultsetTable columns={columns} rows={rows} itemsPerPage={3}></DxcResultsetTable>);
+    const { getByText } = render(
+      <DxcResultsetTable columns={columns} rows={rows} itemsPerPage={3}></DxcResultsetTable>
+    );
     expect(getByText("Peter")).toBeTruthy();
   });
   test("Resultsettable shows as many rows as itemsPerPage", () => {
-    const { getByText, queryByText } = render(
+    const { getAllByRole } = render(
       <DxcResultsetTable columns={columns} rows={rows} itemsPerPage={3}></DxcResultsetTable>
     );
-    expect(getByText("Peter")).toBeTruthy();
-    expect(queryByText("Rick")).toBeFalsy();
+    expect(getAllByRole("row").length - 1).toEqual(3);
   });
 
   test("Resultsettable shows rows on second page", () => {
@@ -240,23 +243,49 @@ describe("ResultsetTable component tests", () => {
     expect(getByText("Peter")).toBeTruthy();
     expect(getByText("Louis")).toBeTruthy();
     expect(getByText("Lana")).toBeTruthy();
-    const nextButton = getAllByRole("button")[2];
+    expect(getAllByRole("row").length - 1).toEqual(3);
+    const nextButton = getAllByRole("button")[3];
     fireEvent.click(nextButton);
     expect(getByText("4 to 6 of 10")).toBeTruthy();
-    expect(getByText("Page: 2 of 4")).toBeTruthy();
+    // expect(getByText("Page: 2 of 4")).toBeTruthy();
+    expect(getByText("Rick")).toBeTruthy();
+    expect(getByText("Mark")).toBeTruthy();
+    expect(getByText("Cris")).toBeTruthy();
+    expect(getAllByRole("row").length - 1).toEqual(3);
+  });
+
+  test("Resultsettable goToPage works as expected", () => {
+    const { getByText, getAllByRole, getByRole } = render(
+      <DxcResultsetTable columns={columns} showGoToPage={true} rows={rows} itemsPerPage={3}></DxcResultsetTable>
+    );
+    expect(getByText("Peter")).toBeTruthy();
+    expect(getByText("Louis")).toBeTruthy();
+    expect(getByText("Lana")).toBeTruthy();
+    expect(getAllByRole("row").length - 1).toEqual(3);
+    const goToPageSelect = getAllByRole("button")[2];
+    act(() => {
+      userEvent.click(goToPageSelect);
+    });
+    const goToPageOption = getByText("2");
+    act(() => {
+      userEvent.click(goToPageOption);
+    });
+
+    expect(getByText("4 to 6 of 10")).toBeTruthy();
     expect(getByText("Rick")).toBeTruthy();
     expect(getByText("Mark")).toBeTruthy();
     expect(getByText("Cris")).toBeTruthy();
+    expect(getAllByRole("row").length - 1).toEqual(3);
   });
 
   test("Resultsettable going to the last page shows only one row", () => {
     const { getByText, getAllByRole } = render(
       <DxcResultsetTable columns={columns} rows={rows} itemsPerPage={3}></DxcResultsetTable>
     );
-    const lastButton = getAllByRole("button")[3];
+    debugger;
+    const lastButton = getAllByRole("button")[4];
     fireEvent.click(lastButton);
     expect(getByText("10 to 10 of 10")).toBeTruthy();
-    expect(getByText("Page: 4 of 4")).toBeTruthy();
     expect(getAllByRole("row")).toHaveLength(2);
     expect(getByText("Cosmin")).toBeTruthy();
   });
@@ -273,10 +302,28 @@ describe("ResultsetTable component tests", () => {
     expect(component.queryByText("Cosmin")).not.toBeTruthy();
   });
   test("Resultsettable change rows should go to first page", () => {
-    const {queryByText, rerender} = render(<DxcResultsetTable columns={columns} rows={rows} itemsPerPage={3}></DxcResultsetTable>);
+    const { queryByText, rerender } = render(
+      <DxcResultsetTable columns={columns} rows={rows} itemsPerPage={3}></DxcResultsetTable>
+    );
     expect(queryByText("Peter")).toBeTruthy();
     rerender(<DxcResultsetTable columns={columns} rows={rows2} itemsPerPage={3}></DxcResultsetTable>);
     expect(queryByText("1 to 3 of 3")).toBeTruthy();
   });
 
+  test("Resultsettable change itemsPerPage should go to first page", () => {
+    const { getAllByRole, queryByText, rerender } = render(
+      <DxcResultsetTable
+        columns={columns}
+        rows={rows}
+        itemsPerPage={3}
+        itemsPerPageOptions={[2, 3]}
+      ></DxcResultsetTable>
+    );
+    const lastButton = getAllByRole("button")[5];
+    fireEvent.click(lastButton);
+    expect(getAllByRole("row").length - 1).toEqual(1);
+    rerender(<DxcResultsetTable columns={columns} rows={rows} itemsPerPage={6}></DxcResultsetTable>);
+    expect(getAllByRole("row").length - 1).toEqual(6);
+    expect(queryByText("Peter")).toBeTruthy();
+  });
 });

package/test/Select.test.js

@@ -1,5 +1,6 @@
 import React from "react";
-import { render, fireEvent, act } from "@testing-library/react";
+import { render, act } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
 import DxcSelect from "../src/select/Select";
 
 const optionsWithoutIcon = [
@@ -20,18 +21,43 @@ const optionsWithoutIcon = [
 const optionsWithIcons = [
   {
     value: 1,
-    label: "Facebook",
-    iconSrc: "/testIconFacebook",
+    label: "Image 1",
+    icon: (
+      <svg
+        data-testid="image-1"
+        xmlns="http://www.w3.org/2000/svg"
+        height="24px"
+        viewBox="0 0 24 24"
+        width="24px"
+        fill="currentColor"
+      >
+        <path d="M0 0h24v24H0V0z" fill="none" />
+        <path d="M16 1H4c-1.1 0-2 .9-2 2v14h2V3h12V1zm3 4H8c-1.1 0-2 .9-2 2v14c0 1.1.9 2 2 2h11c1.1 0 2-.9 2-2V7c0-1.1-.9-2-2-2zm0 16H8V7h11v14z" />
+      </svg>
+    ),
   },
   {
     value: 2,
-    label: "Twitter",
-    iconSrc: "/testIconTwitter",
-  },
-  {
-    value: 3,
-    label: "Linkedin",
-    iconSrc: "/testIconLinkedin",
+    label: "Image 2",
+    icon: (
+      <svg
+        data-testid="image-2"
+        version="1.1"
+        x="0px"
+        y="0px"
+        width="24px"
+        height="24px"
+        viewBox="0 0 24 24"
+        enable-background="new 0 0 24 24"
+      >
+        <g id="Bounding_Box">
+          <rect fill="none" width="24" height="24" />
+        </g>
+        <g id="Master">
+          <path d="M19,9.3V4h-3v2.6L12,3L2,12h3v8h5v-6h4v6h5v-8h3L19,9.3z M10,10c0-1.1,0.9-2,2-2s2,0.9,2,2H10z" />
+        </g>
+      </svg>
+    ),
   },
 ];
 
@@ -51,7 +77,7 @@ describe("Select component tests", () => {
     expect(queryByText("Apple")).toBeFalsy();
     const select = getByRole("button");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
     expect(getByText("Amazon")).toBeTruthy();
     expect(getByText("Ebay")).toBeTruthy();
@@ -59,29 +85,27 @@ describe("Select component tests", () => {
   });
 
   test("Select renders options with icons before", () => {
-    const { getByRole, getAllByRole } = render(
+    const { getByRole, getByTestId } = render(
       <DxcSelect label="test-select-name" options={optionsWithIcons}></DxcSelect>
     );
     const select = getByRole("button");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
-    expect(getAllByRole("img")[0].getAttribute("src")).toEqual("/testIconFacebook");
-    expect(getAllByRole("img")[1].getAttribute("src")).toEqual("/testIconTwitter");
-    expect(getAllByRole("img")[2].getAttribute("src")).toEqual("/testIconLinkedin");
+    expect(getByTestId("image-1")).toBeTruthy();
+    expect(getByTestId("image-2")).toBeTruthy();
   });
 
   test("Select renders options with icons after", () => {
-    const { getByRole, getAllByRole } = render(
+    const { getByRole, getByTestId } = render(
       <DxcSelect label="test-select-name" options={optionsWithIcons} iconPosition="after"></DxcSelect>
     );
     const select = getByRole("button");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
-    expect(getAllByRole("img")[0].getAttribute("src")).toEqual("/testIconFacebook");
-    expect(getAllByRole("img")[1].getAttribute("src")).toEqual("/testIconTwitter");
-    expect(getAllByRole("img")[2].getAttribute("src")).toEqual("/testIconLinkedin");
+    expect(getByTestId("image-1")).toBeTruthy();
+    expect(getByTestId("image-2")).toBeTruthy();
   });
 
   test("Select renders with a default value", () => {
@@ -107,7 +131,7 @@ describe("Select component tests", () => {
     expect(queryByText("Apple")).toBeFalsy();
     const select = getByText("test-select-name");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
     expect(queryByText("Amazon")).toBeFalsy();
     expect(queryByText("Ebay")).toBeFalsy();
@@ -121,11 +145,11 @@ describe("Select component tests", () => {
     );
     const select = getByText("Amazon");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
     const option2 = getByText("Ebay");
     act(() => {
-      fireEvent.click(option2);
+      userEvent.click(option2);
     });
     expect(onChange).toHaveBeenCalledWith(2);
     //The value is not changed
@@ -145,11 +169,11 @@ describe("Select component tests", () => {
     );
     const select = getByText("Amazon, Ebay");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
     const option3 = getByText("Apple");
     act(() => {
-      fireEvent.click(option3);
+      userEvent.click(option3);
     });
     expect(onChange).toHaveBeenCalledWith([1, 2, 3]);
     //The value is not changed
@@ -163,27 +187,24 @@ describe("Select component tests", () => {
     );
     const select = getByRole("button");
     act(() => {
-      fireEvent.click(select);
+      userEvent.click(select);
     });
-    const option1 = getByText("Amazon");
-    const option2 = getByText("Ebay");
-    const option3 = getByText("Apple");
     act(() => {
-      fireEvent.click(option1);
+      userEvent.click(getByText("Amazon"));
     });
     expect(onChange).toHaveBeenCalledWith([1]);
     act(() => {
-      fireEvent.click(option2);
+      userEvent.click(getByText("Ebay"));
     });
     expect(onChange).toHaveBeenCalledWith([1, 2]);
     expect(getByText("Amazon, Ebay")).toBeTruthy();
     act(() => {
-      fireEvent.click(option3);
+      userEvent.click(getByText("Apple"));
     });
     expect(onChange).toHaveBeenCalledWith([1, 2, 3]);
     expect(getByText("Amazon, Ebay, Apple")).toBeTruthy();
     act(() => {
-      fireEvent.click(option1);
+      userEvent.click(getByText("Amazon"));
     });
     expect(onChange).toHaveBeenCalledWith([2, 3]);
     expect(getByText("Ebay, Apple")).toBeTruthy();

package/test/Sidenav.test.js

@@ -3,85 +3,43 @@ import { render, fireEvent } from "@testing-library/react";
 import DxcSidenav from "../src/sidenav/Sidenav";
 
 const navContent = <p>nav-content-test</p>;
-const pageContent = <p>page-content-test</p>;
 
 describe("Sidenav component tests", () => {
-  test("Sidenav in overlay mode renders nav and page content, and arrow", () => {
-    const { getByText, queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent}></DxcSidenav>
-    );
-    expect(getByText("nav-content-test")).toBeTruthy();
-    expect(getByText("page-content-test")).toBeTruthy();
-    expect(queryByTestId("arrow-to-right")).toBeTruthy();
-  });
-
-  test("Sidenav in push mode renders nav and page content, and arrow", () => {
-    const { getByText, queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} mode="push"></DxcSidenav>
-    );
+  test("Sidenav  renders nav  content", () => {
+    const { getByText } = render(<DxcSidenav>{navContent}</DxcSidenav>);
     expect(getByText("nav-content-test")).toBeTruthy();
-    expect(getByText("page-content-test")).toBeTruthy();
-    expect(queryByTestId("arrow-to-right")).toBeTruthy();
   });
 
-  test("Sidenav in overlay mode renders nav and page content in mobile version", () => {
+  test("Sidenav renders nav and page content in mobile version", () => {
     //425 is mobile width
     Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, value: 425 });
-    const { getByText } = render(<DxcSidenav navContent={navContent} pageContent={pageContent}></DxcSidenav>);
+    const { getByText } = render(<DxcSidenav>{navContent}</DxcSidenav>);
     expect(getByText("nav-content-test")).toBeTruthy();
-    expect(getByText("page-content-test")).toBeTruthy();
   });
 
-  test("Sidenav in push mode renders nav and page content in mobile version", () => {
-    //425 is mobile width
-    Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, value: 425 });
+  test("Sidenav renders compound components", () => {
     const { getByText } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} mode="push"></DxcSidenav>
-    );
-    expect(getByText("nav-content-test")).toBeTruthy();
-    expect(getByText("page-content-test")).toBeTruthy();
-  });
-
-  test("Sidenav in overlay mode not renders arrow", () => {
-    //We need to force the offsetWidth value to detect that is not responsive
-    Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, value: 1024 });
-    const { queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} displayArrow={false}></DxcSidenav>
-    );
-    expect(queryByTestId("arrow-to-right")).toBeNull();
-  });
-
-  test("Sidenav in push mode not renders arrow", () => {
-    //We need to force the offsetWidth value to detect that is not responsive
-    Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, value: 1024 });
-    const { queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} displayArrow={false} mode="push"></DxcSidenav>
-    );
-    expect(queryByTestId("arrow-to-right")).toBeNull();
-  });
-
-  test("Sidenav renders arrow with arrow distance", () => {
-    const { queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} arrowDistance="10px"></DxcSidenav>
+      <DxcSidenav>
+        <DxcSidenav.Title>test-title</DxcSidenav.Title>
+        <DxcSidenav.Subtitle>test-subtitle</DxcSidenav.Subtitle>
+        <DxcSidenav.Link href="#">test-link</DxcSidenav.Link>
+      </DxcSidenav>
     );
-    expect(queryByTestId("arrow-to-right")).toBeTruthy();
+    expect(getByText("test-title")).toBeTruthy();
+    expect(getByText("test-subtitle")).toBeTruthy();
+    expect(getByText("test-link")).toBeTruthy();
   });
 
-  test("Sidenav in overlay mode always renders arrow in mobile version", () => {
-    //425 is mobile width
-    Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, value: 425 });
-    const { queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} displayArrow={false}></DxcSidenav>
+  test("Sidenav link onClick", () => {
+    const onClick = jest.fn();
+    const { getByText } = render(
+      <DxcSidenav>
+        <DxcSidenav.Link onClick={onClick}>test-link</DxcSidenav.Link>
+      </DxcSidenav>
     );
-    expect(queryByTestId("arrow-to-right")).toBeTruthy();
-  });
 
-  test("Sidenav in push mode always renders arrow in mobile version", () => {
-    //425 is mobile width
-    Object.defineProperty(HTMLElement.prototype, "offsetWidth", { configurable: true, value: 425 });
-    const { queryByTestId } = render(
-      <DxcSidenav navContent={navContent} pageContent={pageContent} displayArrow={false} mode="push"></DxcSidenav>
-    );
-    expect(queryByTestId("arrow-to-right")).toBeTruthy();
+    const link = getByText("test-link");
+    fireEvent.click(link);
+    expect(onClick).toHaveBeenCalled();
   });
 });

package/test/Slider.test.js

@@ -4,7 +4,7 @@ import DxcSlider from "../src/slider/Slider";
 
 describe("Slider component tests", () => {
   test("Slider renders with correct text", () => {
-    const { getByText } = render(<DxcSlider minValue={0} maxValue={100} showLimitsValues></DxcSlider>);
+    const { getByText } = render(<DxcSlider minValue={0} maxValue={100} showLimitsValues />);
     expect(getByText("0")).toBeTruthy();
     expect(getByText("100")).toBeTruthy();
   });
@@ -12,37 +12,29 @@ describe("Slider component tests", () => {
   test("Calls correct function onChange in controlled slider", () => {
     const onChange = jest.fn();
     const { getByRole } = render(
-      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues value={13} showInput></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues value={13} showInput />
     );
     act(() => {
       fireEvent.change(getByRole("textbox"), { target: { value: 25 } });
     });
-    expect(onChange).toHaveBeenCalledWith("25");
+    expect(onChange).toHaveBeenCalledWith(25);
   });
 
   test("Calls correct function onChange in uncontrolled slider", () => {
     const onChange = jest.fn();
     const { getByRole } = render(
-      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues showInput></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues showInput />
     );
     act(() => {
       fireEvent.change(getByRole("textbox"), { target: { value: 25 } });
     });
-    expect(onChange).toHaveBeenCalledWith("25");
+    expect(onChange).toHaveBeenCalledWith(25);
   });
 
   test("Disabled slider have disabled input", () => {
     const onChange = jest.fn();
     const { getByRole } = render(
-      <DxcSlider
-        minValue={0}
-        maxValue={100}
-        onChange={onChange}
-        showLimitsValues
-        disabled
-        showInput
-        value={13}
-      ></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues disabled showInput value={13} />
     );
     act(() => {
       fireEvent.change(getByRole("textbox"), { target: { value: 25 } });
@@ -54,7 +46,7 @@ describe("Slider component tests", () => {
   test("Calls correct function onDragEnd", () => {
     const onDragEnd = jest.fn();
     const { getByRole } = render(
-      <DxcSlider minValue={0} maxValue={100} showLimitsValues showInput onDragEnd={onDragEnd} value={25}></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} showLimitsValues showInput onDragEnd={onDragEnd} value={25} />
     );
     act(() => {
       fireEvent.mouseDown(getByRole("slider"));
@@ -62,4 +54,21 @@ describe("Slider component tests", () => {
     });
     expect(onDragEnd).toHaveBeenCalled();
   });
+
+  test("Calls correct function labelFormatCallback", () => {
+    const labelFormatCallback = jest.fn((x) => `${x}$`);
+    const { getByText } = render(
+      <DxcSlider
+        minValue={0}
+        maxValue={100}
+        showLimitsValues
+        showInput
+        value={25}
+        labelFormatCallback={labelFormatCallback}
+      />
+    );
+    expect(getByText("0$")).toBeTruthy();
+    expect(getByText("100$")).toBeTruthy();
+    expect(labelFormatCallback).toHaveBeenCalledTimes(2);
+  });
 });

package/test/Spinner.test.js

@@ -24,4 +24,9 @@ describe("Spinner component tests", () => {
     expect(getByText("test-loading")).toBeTruthy();
     expect(getByText("75%")).toBeTruthy();
   });
+
+  test("Get spinner by role", () => {
+    const { getByRole } = render(<DxcSpinner label="test-loading" value={75} showValue></DxcSpinner>);
+    expect(getByRole("progressbar")).toBeTruthy();
+  });
 });

package/test/Tabs.test.js

@@ -14,6 +14,21 @@ const sampleTabs = [
   },
 ];
 
+const sampleTabsWithBadge = [
+  {
+    label: "Tab-1",
+    notificationNumber: "10",
+  },
+  {
+    label: "Tab-2",
+    notificationNumber: "20",
+  },
+  {
+    label: "Tab-3",
+    notificationNumber: "101",
+  },
+];
+
 describe("Tabs component tests", () => {
   test("Tabs render with correct labels", () => {
     const { getByText } = render(<DxcTabs tabs={sampleTabs}></DxcTabs>);
@@ -21,6 +36,12 @@ describe("Tabs component tests", () => {
     expect(getByText("Tab-2")).toBeTruthy();
     expect(getByText("Tab-3")).toBeTruthy();
   });
+  test("Tabs render with correct labels and badges", () => {
+    const { getByText } = render(<DxcTabs tabs={sampleTabsWithBadge}></DxcTabs>);
+    expect(getByText("10")).toBeTruthy();
+    expect(getByText("20")).toBeTruthy();
+    expect(getByText("+99")).toBeTruthy();
+  });
 
   test("Tabs render with correct icons", () => {
     const { getAllByRole } = render(