@dxc-technology/halstack-react 0.0.0-bd24f1d → 0.0.0-beebecd

package/test/{Number.test.js → NumberInput.test.js}

@@ -1,75 +1,100 @@
 import React from "react";
 import { render, fireEvent } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
-import DxcNumber from "../src/number/Number";
+import DxcNumberInput from "../src/number-input/NumberInput";
 
-describe("Number component tests", () => {
-  test("Number renders with label", () => {
-    const { getByText } = render(<DxcNumber label="Number label" />);
-    expect(getByText("Number label")).toBeTruthy();
+describe("Number input component tests", () => {
+  test("Number input renders with label", () => {
+    const { getByText } = render(<DxcNumberInput label="Number input label" />);
+    expect(getByText("Number input label")).toBeTruthy();
   });
 
-  test("Number renders with helper text", () => {
-    const { getByText } = render(<DxcNumber helperText="Helper text" />);
+  test("Number input renders with helper text", () => {
+    const { getByText } = render(<DxcNumberInput helperText="Helper text" />);
     expect(getByText("Helper text")).toBeTruthy();
   });
 
-  test("Number renders with placeholder", () => {
-    const { getByLabelText } = render(<DxcNumber label="Number label" placeholder="Placeholder" />);
+  test("Number input renders with placeholder", () => {
+    const { getByLabelText } = render(<DxcNumberInput label="Number label" placeholder="Placeholder" />);
     const number = getByLabelText("Number label");
     expect(number.getAttribute("placeholder")).toBe("Placeholder");
   });
 
-  test("Number renders increment and decrement buttons", () => {
-    const { queryAllByRole } = render(<DxcNumber label="Number label" />);
+  test("Number input renders increment and decrement buttons", () => {
+    const { queryAllByRole } = render(<DxcNumberInput label="Number label" />);
     expect(queryAllByRole("button").length).toBe(2);
   });
 
-  test("Number is disabled", () => {
-    const { getByLabelText } = render(<DxcNumber label="Number label" disabled />);
+  test("Number input is disabled", () => {
+    const { getByLabelText } = render(<DxcNumberInput label="Number label" disabled />);
     const number = getByLabelText("Number label");
     expect(number.disabled).toBeTruthy();
   });
 
-  test("Number is optional", () => {
-    const { getByText } = render(<DxcNumber label="Number label" optional />);
+  test("Number input is optional", () => {
+    const { getByText } = render(<DxcNumberInput label="Number label" optional />);
     expect(getByText("(Optional)")).toBeTruthy();
   });
 
+  test("Number input is not optional: required field, displays error if not filled in", () => {
+    const onBlur = jest.fn();
+    const onChange = jest.fn();
+    const { getByRole } = render(<DxcNumberInput onBlur={onBlur} onChange={onChange} />);
+    const input = getByRole("textbox");
+
+    userEvent.type(input, "1");
+    userEvent.clear(input);
+    fireEvent.blur(input);
+    expect(onBlur).toHaveBeenCalled();
+    expect(onBlur).toHaveBeenCalledWith({ value: "", error: "This field is required. Please, enter a value." });
+    expect(onChange).toHaveBeenCalled();
+    expect(onChange).toHaveBeenCalledWith({ value: "", error: "This field is required. Please, enter a value." });
+  });
+
   test("Suffix and prefix must be shown)", () => {
-    const { getByText } = render(<DxcNumber label="Number label" prefix="+34" suffix="USD" />);
+    const { getByText } = render(<DxcNumberInput label="Number input label" prefix="+34" suffix="USD" />);
     expect(getByText("+34")).toBeTruthy();
     expect(getByText("USD")).toBeTruthy();
   });
 
-  test("Invalid number renders error", () => {
-    const { getByText } = render(<DxcNumber error="Error message." />);
+  test("Invalid number input renders error", () => {
+    const { getByText } = render(<DxcNumberInput error="Error message." />);
     expect(getByText("Error message.")).toBeTruthy();
   });
 
   test("onChange function is called correctly", () => {
     const onChange = jest.fn();
-    const { getByLabelText } = render(<DxcNumber label="Number label" onChange={onChange} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText } = render(<DxcNumberInput label="Number input label" onChange={onChange} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "t");
-    expect(onChange).not.toHaveBeenCalledWith("t");
+    expect(onChange).not.toHaveBeenCalledWith({ value: "t", error: null });
     expect(number.value).toBe("");
     userEvent.type(number, "1");
-    expect(onChange).toHaveBeenCalledWith("1");
+    expect(onChange).toHaveBeenCalledWith({ value: "1", error: null });
     expect(number.value).toBe("1");
   });
 
   test("Error message is shown if the value is less than the min value", () => {
-    const { getByLabelText, getByText } = render(<DxcNumber label="Number label" min={5} />);
-    const number = getByLabelText("Number label");
+    const onChange = jest.fn(({ value, error }) => {
+      expect(value).toBe("1");
+      expect(error).toBe("Value must be greater than or equal to 5.");
+    });
+    const onBlur = jest.fn(({ value, error }) => {
+      expect(value).toBe("1");
+      expect(error).toBe("Value must be greater than or equal to 5.");
+    });
+    const { getByLabelText } = render(
+      <DxcNumberInput label="Number input label" min={5} onBlur={onBlur} onChange={onChange} />
+    );
+    const number = getByLabelText("Number input label");
+
     userEvent.type(number, "1");
     fireEvent.blur(number);
-    expect(getByText("Value must be greater than or equal to 5.")).toBeTruthy();
   });
 
   test("Cannot decrement the value if it is less than the min value", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" min={5} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" min={5} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "1");
     fireEvent.blur(number);
     expect(number.value).toBe("1");
@@ -79,8 +104,8 @@ describe("Number component tests", () => {
   });
 
   test("Increment the value when it is less than the min value", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" min={5} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" min={5} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "1");
     fireEvent.blur(number);
     expect(number.value).toBe("1");
@@ -90,16 +115,24 @@ describe("Number component tests", () => {
   });
 
   test("Error message is shown if the value is greater than the max value", () => {
-    const { getByLabelText, getByText } = render(<DxcNumber label="Number label" max={10} />);
-    const number = getByLabelText("Number label");
+    const onChange = jest.fn();
+    const onBlur = jest.fn();
+    const { getByLabelText } = render(
+      <DxcNumberInput label="Number input label" max={10} onBlur={onBlur} onChange={onChange} />
+    );
+    const number = getByLabelText("Number input label");
+
     userEvent.type(number, "12");
+    expect(onChange).toHaveBeenCalledTimes(2);
+    expect(onChange).toHaveBeenCalledWith({ value: "12", error: "Value must be less than or equal to 10." });
     fireEvent.blur(number);
-    expect(getByText("Value must be less than or equal to 10.")).toBeTruthy();
+    expect(onBlur).toHaveBeenCalled();
+    expect(onBlur).toHaveBeenCalledWith({ value: "12", error: "Value must be less than or equal to 10." });
   });
 
   test("Cannot increment the value if it is greater than the max value", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" max={10} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" max={10} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "12");
     fireEvent.blur(number);
     expect(number.value).toBe("12");
@@ -109,8 +142,8 @@ describe("Number component tests", () => {
   });
 
   test("Decrement the value when it is greater than the max value", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" max={10} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" max={10} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "12");
     fireEvent.blur(number);
     expect(number.value).toBe("12");
@@ -120,8 +153,8 @@ describe("Number component tests", () => {
   });
 
   test("Increment and decrement the value with min and max values", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" min={5} max={10} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" min={5} max={10} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "1");
     fireEvent.blur(number);
     expect(number.value).toBe("1");
@@ -142,8 +175,8 @@ describe("Number component tests", () => {
   });
 
   test("Increment and decrement the value with step", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" step={5} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" step={5} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "10");
     fireEvent.blur(number);
     expect(number.value).toBe("10");
@@ -160,13 +193,16 @@ describe("Number component tests", () => {
   });
 
   test("Increment and decrement the value with min, max and step", () => {
-    const { getByLabelText, getByText, getAllByRole } = render(
-      <DxcNumber label="Number label" min={5} max={20} step={8} />
+    const onBlur = jest.fn(({ value, error }) => {
+      expect(value).toBe("1");
+      expect(error).toBe("Value must be greater than or equal to 5.");
+    });
+    const { getByLabelText, getAllByRole } = render(
+      <DxcNumberInput label="Number input label" min={5} max={20} step={8} onBlur={onBlur} />
     );
-    const number = getByLabelText("Number label");
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "1");
     fireEvent.blur(number);
-    expect(getByText("Value must be greater than or equal to 5.")).toBeTruthy();
     const increment = getAllByRole("button")[1];
     userEvent.click(increment);
     expect(number.value).toBe("5");
@@ -186,8 +222,8 @@ describe("Number component tests", () => {
   });
 
   test("Increment and decrement the value with min, max and step using the arrows in keyboard", () => {
-    const { getByLabelText } = render(<DxcNumber label="Number label" min={5} max={20} step={5} />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText } = render(<DxcNumberInput label="Number input label" min={5} max={20} step={5} />);
+    const number = getByLabelText("Number input label");
     userEvent.type(number, "1");
     fireEvent.keyDown(number, { keyCode: 38 });
     expect(number.value).toBe("5");
@@ -209,27 +245,9 @@ describe("Number component tests", () => {
     expect(number.value).toBe("5");
   });
 
-  test("Custom error messages", () => {
-    const onChange = jest.fn((value) => {
-      expect(value).toBe("2");
-    });
-
-    const onBlur = jest.fn(({ value, error }) => {
-      expect(value).toBe("2");
-      expect(error).toBe("Value must be greater than or equal to 5.");
-    });
-
-    const { getByLabelText } = render(
-      <DxcNumber label="Number label" min={5} step={8} onChange={onChange} onBlur={onBlur} />
-    );
-    const number = getByLabelText("Number label");
-    userEvent.type(number, "2");
-    fireEvent.blur(number);
-  });
-
   test("Number has correct accesibility attributes", () => {
-    const { getByLabelText, getAllByRole } = render(<DxcNumber label="Number label" />);
-    const number = getByLabelText("Number label");
+    const { getByLabelText, getAllByRole } = render(<DxcNumberInput label="Number input label" />);
+    const number = getByLabelText("Number input label");
     expect(number.getAttribute("aria-autocomplete")).toBeNull();
     expect(number.getAttribute("aria-controls")).toBeNull();
     expect(number.getAttribute("aria-expanded")).toBeNull();

package/test/Paginator.test.js

@@ -62,7 +62,7 @@ describe("Paginator component tests", () => {
     act(() => {
       userEvent.click(goToPageSelect);
     });
-    const goToPageOption = getByRole("option", { name: /2/i });
+    const goToPageOption = getByText("2");
     act(() => {
       userEvent.click(goToPageOption);
     });

package/test/PasswordInput.test.js

@@ -0,0 +1,83 @@
+import React from "react";
+import { render, fireEvent } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import DxcPasswordInput from "../src/password-input/PasswordInput";
+
+describe("Password input component tests", () => {
+  test("Password input renders with label", () => {
+    const { getByText } = render(<DxcPasswordInput label="Password input label" />);
+    expect(getByText("Password input label")).toBeTruthy();
+  });
+
+  test("Password input renders with helper text", () => {
+    const { getByText } = render(<DxcPasswordInput helperText="Helper text" />);
+    expect(getByText("Helper text")).toBeTruthy();
+  });
+
+  test("Password input renders error", () => {
+    const { getByText } = render(<DxcPasswordInput error="Error message." />);
+    expect(getByText("Error message.")).toBeTruthy();
+  });
+
+  test("onChange function is called correctly", () => {
+    const onChange = jest.fn();
+    const { getByRole } = render(<DxcPasswordInput label="Password input" onChange={onChange} />);
+    const passwordInput = getByRole("textbox");
+    userEvent.type(passwordInput, "Pa$$w0rd");
+    expect(onChange).toHaveBeenCalledWith({ value: "P", error: null });
+    expect(passwordInput.value).toBe("Pa$$w0rd");
+  });
+
+  test("onBlur function is called correctly", () => {
+    const onBlur = jest.fn();
+    const { getByRole } = render(<DxcPasswordInput label="Password input" onBlur={onBlur} />);
+    const passwordInput = getByRole("textbox");
+    userEvent.type(passwordInput, "Pa$$w0rd");
+    fireEvent.blur(passwordInput);
+    expect(onBlur).toHaveBeenCalledWith({ value: "Pa$$w0rd", error: null });
+    expect(passwordInput.value).toBe("Pa$$w0rd");
+  });
+
+  test("Clear password input value", () => {
+    const { getAllByRole, getByRole } = render(<DxcPasswordInput label="Password input" clearable />);
+    const passwordInput = getByRole("textbox");
+    userEvent.type(passwordInput, "Pa$$w0rd");
+    expect(passwordInput.value).toBe("Pa$$w0rd");
+    const clearButton = getAllByRole("button")[0];
+    userEvent.click(clearButton);
+    expect(passwordInput.value).toBe("");
+  });
+
+  test("Non clearable password input has no clear icon", () => {
+    const { getAllByRole, getByRole } = render(<DxcPasswordInput label="Password input" />);
+    const passwordInput = getByRole("textbox");
+    userEvent.type(passwordInput, "Pa$$w0rd");
+    expect(passwordInput.value).toBe("Pa$$w0rd");
+    const buttons = getAllByRole("button");
+    expect(buttons.length).toBe(1);
+  });
+
+  test("Show/hide password input button works correctly", () => {
+    const { getAllByRole, getByRole } = render(<DxcPasswordInput label="Password input" clearable />);
+    const passwordInput = getByRole("textbox");
+    userEvent.type(passwordInput, "Pa$$w0rd");
+    expect(passwordInput.value).toBe("Pa$$w0rd");
+    expect(passwordInput.type).toBe("password");
+    const showButton = getAllByRole("button")[1];
+    userEvent.click(showButton);
+    expect(passwordInput.type).toBe("text");
+  });
+
+  test("Password input has correct accesibility attributes", () => {
+    const { getByRole } = render(<DxcPasswordInput label="Password input" />);
+    const passwordInput = getByRole("textbox");
+    expect(passwordInput.getAttribute("aria-autocomplete")).toBeNull();
+    expect(passwordInput.getAttribute("aria-controls")).toBeNull();
+    const showButton = getByRole("button");
+    expect(showButton.getAttribute("aria-expanded")).toBe("false");
+    expect(showButton.getAttribute("aria-label")).toBe("Show");
+    userEvent.click(showButton);
+    expect(showButton.getAttribute("aria-expanded")).toBe("true");
+    expect(showButton.getAttribute("aria-label")).toBe("Hide");
+  });
+});

package/test/ResultsetTable.test.js

@@ -266,13 +266,12 @@ describe("ResultsetTable component tests", () => {
     act(() => {
       userEvent.click(goToPageSelect);
     });
-    const goToPageOption = getByRole("option", { name: /2/i });
+    const goToPageOption = getByText("2");
     act(() => {
       userEvent.click(goToPageOption);
     });
 
     expect(getByText("4 to 6 of 10")).toBeTruthy();
-    // expect(getByText("Page: 2 of 4")).toBeTruthy();
     expect(getByText("Rick")).toBeTruthy();
     expect(getByText("Mark")).toBeTruthy();
     expect(getByText("Cris")).toBeTruthy();

package/test/Select.test.js

@@ -21,18 +21,43 @@ const optionsWithoutIcon = [
 const optionsWithIcons = [
   {
     value: 1,
-    label: "Facebook",
-    iconSrc: "/testIconFacebook",
+    label: "Image 1",
+    icon: (
+      <svg
+        data-testid="image-1"
+        xmlns="http://www.w3.org/2000/svg"
+        height="24px"
+        viewBox="0 0 24 24"
+        width="24px"
+        fill="currentColor"
+      >
+        <path d="M0 0h24v24H0V0z" fill="none" />
+        <path d="M16 1H4c-1.1 0-2 .9-2 2v14h2V3h12V1zm3 4H8c-1.1 0-2 .9-2 2v14c0 1.1.9 2 2 2h11c1.1 0 2-.9 2-2V7c0-1.1-.9-2-2-2zm0 16H8V7h11v14z" />
+      </svg>
+    ),
   },
   {
     value: 2,
-    label: "Twitter",
-    iconSrc: "/testIconTwitter",
-  },
-  {
-    value: 3,
-    label: "Linkedin",
-    iconSrc: "/testIconLinkedin",
+    label: "Image 2",
+    icon: (
+      <svg
+        data-testid="image-2"
+        version="1.1"
+        x="0px"
+        y="0px"
+        width="24px"
+        height="24px"
+        viewBox="0 0 24 24"
+        enable-background="new 0 0 24 24"
+      >
+        <g id="Bounding_Box">
+          <rect fill="none" width="24" height="24" />
+        </g>
+        <g id="Master">
+          <path d="M19,9.3V4h-3v2.6L12,3L2,12h3v8h5v-6h4v6h5v-8h3L19,9.3z M10,10c0-1.1,0.9-2,2-2s2,0.9,2,2H10z" />
+        </g>
+      </svg>
+    ),
   },
 ];
 
@@ -60,29 +85,27 @@ describe("Select component tests", () => {
   });
 
   test("Select renders options with icons before", () => {
-    const { getByRole, getAllByRole } = render(
+    const { getByRole, getByTestId } = render(
       <DxcSelect label="test-select-name" options={optionsWithIcons}></DxcSelect>
     );
     const select = getByRole("button");
     act(() => {
       userEvent.click(select);
     });
-    expect(getAllByRole("img")[0].getAttribute("src")).toEqual("/testIconFacebook");
-    expect(getAllByRole("img")[1].getAttribute("src")).toEqual("/testIconTwitter");
-    expect(getAllByRole("img")[2].getAttribute("src")).toEqual("/testIconLinkedin");
+    expect(getByTestId("image-1")).toBeTruthy();
+    expect(getByTestId("image-2")).toBeTruthy();
   });
 
   test("Select renders options with icons after", () => {
-    const { getByRole, getAllByRole } = render(
+    const { getByRole, getByTestId } = render(
       <DxcSelect label="test-select-name" options={optionsWithIcons} iconPosition="after"></DxcSelect>
     );
     const select = getByRole("button");
     act(() => {
       userEvent.click(select);
     });
-    expect(getAllByRole("img")[0].getAttribute("src")).toEqual("/testIconFacebook");
-    expect(getAllByRole("img")[1].getAttribute("src")).toEqual("/testIconTwitter");
-    expect(getAllByRole("img")[2].getAttribute("src")).toEqual("/testIconLinkedin");
+    expect(getByTestId("image-1")).toBeTruthy();
+    expect(getByTestId("image-2")).toBeTruthy();
   });
 
   test("Select renders with a default value", () => {

package/test/Spinner.test.js

@@ -24,4 +24,9 @@ describe("Spinner component tests", () => {
     expect(getByText("test-loading")).toBeTruthy();
     expect(getByText("75%")).toBeTruthy();
   });
+
+  test("Get spinner by role", () => {
+    const { getByRole } = render(<DxcSpinner label="test-loading" value={75} showValue></DxcSpinner>);
+    expect(getByRole("progressbar")).toBeTruthy();
+  });
 });