@dxc-technology/halstack-react 0.0.0-375a8b0 → 0.0.0-376c368

package/number-input/NumberInput.accessibility.test.js

@@ -0,0 +1,227 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+var _regenerator = _interopRequireDefault(require("@babel/runtime/regenerator"));
+var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
+var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
+var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
+var _react = _interopRequireDefault(require("react"));
+var _react2 = require("@testing-library/react");
+var _axeHelper = require("../../test/accessibility/axe-helper.js");
+var _NumberInput = _interopRequireDefault(require("./NumberInput"));
+// Mocking DOMRect for Radix Primitive Popover
+global.globalThis = global;
+global.DOMRect = {
+  fromRect: function fromRect() {
+    return {
+      top: 0,
+      left: 0,
+      bottom: 0,
+      right: 0,
+      width: 0,
+      height: 0
+    };
+  }
+};
+global.ResizeObserver = /*#__PURE__*/function () {
+  function ResizeObserver() {
+    (0, _classCallCheck2["default"])(this, ResizeObserver);
+  }
+  return (0, _createClass2["default"])(ResizeObserver, [{
+    key: "observe",
+    value: function observe() {}
+  }, {
+    key: "unobserve",
+    value: function unobserve() {}
+  }, {
+    key: "disconnect",
+    value: function disconnect() {}
+  }]);
+}();
+describe("Number input component accessibility tests", function () {
+  it("Should not have basic accessibility issues", /*#__PURE__*/(0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee() {
+    var _render, container, results;
+    return _regenerator["default"].wrap(function _callee$(_context) {
+      while (1) switch (_context.prev = _context.next) {
+        case 0:
+          _render = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_NumberInput["default"], {
+            label: "Number input label",
+            helperText: "Helper text",
+            placeholder: "Placeholder",
+            defaultValue: "10",
+            margin: "medium",
+            min: 0,
+            max: 100,
+            suffix: "Suffix",
+            prefix: "Prefix",
+            name: "Name",
+            size: "medium",
+            step: 1
+          })), container = _render.container;
+          _context.next = 3;
+          return (0, _axeHelper.axe)(container);
+        case 3:
+          results = _context.sent;
+          expect(results).toHaveNoViolations();
+        case 5:
+        case "end":
+          return _context.stop();
+      }
+    }, _callee);
+  })));
+  it("Should not have basic accessibility issues for optional mode", /*#__PURE__*/(0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee2() {
+    var _render2, container, results;
+    return _regenerator["default"].wrap(function _callee2$(_context2) {
+      while (1) switch (_context2.prev = _context2.next) {
+        case 0:
+          _render2 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_NumberInput["default"], {
+            label: "Number input label",
+            helperText: "Helper text",
+            placeholder: "Placeholder",
+            defaultValue: "10",
+            margin: "medium",
+            min: 0,
+            max: 100,
+            suffix: "Suffix",
+            prefix: "Prefix",
+            name: "Name",
+            size: "medium",
+            step: 1,
+            optional: true
+          })), container = _render2.container;
+          _context2.next = 3;
+          return (0, _axeHelper.axe)(container);
+        case 3:
+          results = _context2.sent;
+          expect(results).toHaveNoViolations();
+        case 5:
+        case "end":
+          return _context2.stop();
+      }
+    }, _callee2);
+  })));
+  it("Should not have basic accessibility issues for error mode", /*#__PURE__*/(0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee3() {
+    var _render3, container, results;
+    return _regenerator["default"].wrap(function _callee3$(_context3) {
+      while (1) switch (_context3.prev = _context3.next) {
+        case 0:
+          _render3 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_NumberInput["default"], {
+            label: "Number input label",
+            helperText: "Helper text",
+            placeholder: "Placeholder",
+            defaultValue: "10",
+            margin: "medium",
+            min: 0,
+            max: 100,
+            suffix: "Suffix",
+            prefix: "Prefix",
+            name: "Name",
+            error: "Input error",
+            size: "medium",
+            step: 1
+          })), container = _render3.container;
+          _context3.next = 3;
+          return (0, _axeHelper.axe)(container);
+        case 3:
+          results = _context3.sent;
+          expect(results).toHaveNoViolations();
+        case 5:
+        case "end":
+          return _context3.stop();
+      }
+    }, _callee3);
+  })));
+  it("Should not have basic accessibility issues for disabled mode", /*#__PURE__*/(0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee4() {
+    var _render4, container, results;
+    return _regenerator["default"].wrap(function _callee4$(_context4) {
+      while (1) switch (_context4.prev = _context4.next) {
+        case 0:
+          _render4 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_NumberInput["default"], {
+            label: "Number input label",
+            helperText: "Helper text",
+            placeholder: "Placeholder",
+            defaultValue: "10",
+            margin: "medium",
+            min: 0,
+            max: 100,
+            suffix: "Suffix",
+            prefix: "Prefix",
+            name: "Name",
+            size: "medium",
+            step: 1,
+            disabled: true
+          })), container = _render4.container;
+          _context4.next = 3;
+          return (0, _axeHelper.axe)(container);
+        case 3:
+          results = _context4.sent;
+          expect(results).toHaveNoViolations();
+        case 5:
+        case "end":
+          return _context4.stop();
+      }
+    }, _callee4);
+  })));
+  it("Should not have basic accessibility issues for read-only mode", /*#__PURE__*/(0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee5() {
+    var _render5, container, results;
+    return _regenerator["default"].wrap(function _callee5$(_context5) {
+      while (1) switch (_context5.prev = _context5.next) {
+        case 0:
+          _render5 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_NumberInput["default"], {
+            label: "Number input label",
+            helperText: "Helper text",
+            placeholder: "Placeholder",
+            defaultValue: "10",
+            margin: "medium",
+            min: 0,
+            max: 100,
+            suffix: "Suffix",
+            prefix: "Prefix",
+            name: "Name",
+            size: "medium",
+            step: 1,
+            readOnly: true
+          })), container = _render5.container;
+          _context5.next = 3;
+          return (0, _axeHelper.axe)(container);
+        case 3:
+          results = _context5.sent;
+          expect(results).toHaveNoViolations();
+        case 5:
+        case "end":
+          return _context5.stop();
+      }
+    }, _callee5);
+  })));
+  it("Should not have basic accessibility issues for autocomplete mode", /*#__PURE__*/(0, _asyncToGenerator2["default"])( /*#__PURE__*/_regenerator["default"].mark(function _callee6() {
+    var _render6, container, results;
+    return _regenerator["default"].wrap(function _callee6$(_context6) {
+      while (1) switch (_context6.prev = _context6.next) {
+        case 0:
+          _render6 = (0, _react2.render)( /*#__PURE__*/_react["default"].createElement(_NumberInput["default"], {
+            label: "Number input label",
+            helperText: "Helper text",
+            placeholder: "Placeholder",
+            defaultValue: "10",
+            margin: "medium",
+            min: 0,
+            max: 100,
+            suffix: "Suffix",
+            prefix: "Prefix",
+            name: "Name",
+            size: "medium",
+            step: 1,
+            autocomplete: "on"
+          })), container = _render6.container;
+          _context6.next = 3;
+          return (0, _axeHelper.axe)(container);
+        case 3:
+          results = _context6.sent;
+          expect(results).toHaveNoViolations();
+        case 5:
+        case "end":
+          return _context6.stop();
+      }
+    }, _callee6);
+  })));
+});

package/number-input/NumberInput.js

@@ -1,72 +1,76 @@
 "use strict";
 
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
-
+var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports["default"] = void 0;
-
 var _taggedTemplateLiteral2 = _interopRequireDefault(require("@babel/runtime/helpers/taggedTemplateLiteral"));
-
-var _react = _interopRequireDefault(require("react"));
-
+var _react = _interopRequireWildcard(require("react"));
 var _styledComponents = _interopRequireDefault(require("styled-components"));
-
 var _TextInput = _interopRequireDefault(require("../text-input/TextInput"));
-
-var _NumberInputContext = _interopRequireDefault(require("./NumberInputContext"));
-
+var _NumberInputContext = require("./NumberInputContext");
 var _templateObject;
-
+function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { "default": e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n["default"] = e, t && t.set(e, n), n; }
 var DxcNumberInput = /*#__PURE__*/_react["default"].forwardRef(function (_ref, ref) {
-  var _ref$label = _ref.label,
-      label = _ref$label === void 0 ? "" : _ref$label,
-      _ref$name = _ref.name,
-      name = _ref$name === void 0 ? "" : _ref$name,
-      value = _ref.value,
-      _ref$helperText = _ref.helperText,
-      helperText = _ref$helperText === void 0 ? "" : _ref$helperText,
-      _ref$placeholder = _ref.placeholder,
-      placeholder = _ref$placeholder === void 0 ? "" : _ref$placeholder,
-      _ref$disabled = _ref.disabled,
-      disabled = _ref$disabled === void 0 ? false : _ref$disabled,
-      _ref$optional = _ref.optional,
-      optional = _ref$optional === void 0 ? false : _ref$optional,
-      _ref$prefix = _ref.prefix,
-      prefix = _ref$prefix === void 0 ? "" : _ref$prefix,
-      _ref$suffix = _ref.suffix,
-      suffix = _ref$suffix === void 0 ? "" : _ref$suffix,
-      min = _ref.min,
-      max = _ref.max,
-      _ref$step = _ref.step,
-      step = _ref$step === void 0 ? 1 : _ref$step,
-      onChange = _ref.onChange,
-      onBlur = _ref.onBlur,
-      _ref$error = _ref.error,
-      error = _ref$error === void 0 ? "" : _ref$error,
-      _ref$autocomplete = _ref.autocomplete,
-      autocomplete = _ref$autocomplete === void 0 ? "off" : _ref$autocomplete,
-      margin = _ref.margin,
-      _ref$size = _ref.size,
-      size = _ref$size === void 0 ? "medium" : _ref$size,
-      _ref$tabIndex = _ref.tabIndex,
-      tabIndex = _ref$tabIndex === void 0 ? 0 : _ref$tabIndex;
-  return /*#__PURE__*/_react["default"].createElement(_NumberInputContext["default"].Provider, {
+  var label = _ref.label,
+    name = _ref.name,
+    defaultValue = _ref.defaultValue,
+    value = _ref.value,
+    helperText = _ref.helperText,
+    placeholder = _ref.placeholder,
+    disabled = _ref.disabled,
+    optional = _ref.optional,
+    readOnly = _ref.readOnly,
+    prefix = _ref.prefix,
+    suffix = _ref.suffix,
+    min = _ref.min,
+    max = _ref.max,
+    _ref$step = _ref.step,
+    step = _ref$step === void 0 ? 1 : _ref$step,
+    onChange = _ref.onChange,
+    onBlur = _ref.onBlur,
+    error = _ref.error,
+    autocomplete = _ref.autocomplete,
+    margin = _ref.margin,
+    size = _ref.size,
+    tabIndex = _ref.tabIndex;
+  var numberInputRef = _react["default"].useRef(null);
+  (0, _react.useEffect)(function () {
+    var _numberInputRef$curre;
+    var input = (_numberInputRef$curre = numberInputRef.current) === null || _numberInputRef$curre === void 0 ? void 0 : _numberInputRef$curre.getElementsByTagName("input")[0];
+    var preventDefault = function preventDefault(event) {
+      event.preventDefault();
+    };
+    input === null || input === void 0 ? void 0 : input.addEventListener("wheel", preventDefault, {
+      passive: false
+    });
+    return function () {
+      input === null || input === void 0 ? void 0 : input.removeEventListener("wheel", preventDefault);
+    };
+  }, []);
+  return /*#__PURE__*/_react["default"].createElement(_NumberInputContext.NumberInputContext.Provider, {
     value: {
       typeNumber: "number",
       minNumber: min,
       maxNumber: max,
       stepNumber: step
     }
-  }, /*#__PURE__*/_react["default"].createElement(NumberInputContainer, null, /*#__PURE__*/_react["default"].createElement(_TextInput["default"], {
+  }, /*#__PURE__*/_react["default"].createElement(NumberInputContainer, {
+    ref: numberInputRef,
+    size: size
+  }, /*#__PURE__*/_react["default"].createElement(_TextInput["default"], {
     label: label,
     name: name,
+    defaultValue: defaultValue,
     value: value,
     helperText: helperText,
     placeholder: placeholder,
     disabled: disabled,
     optional: optional,
+    readOnly: readOnly,
     prefix: prefix,
     suffix: suffix,
     error: error,
@@ -79,8 +83,7 @@ var DxcNumberInput = /*#__PURE__*/_react["default"].forwardRef(function (_ref, r
     ref: ref
   })));
 });
-
-var NumberInputContainer = _styledComponents["default"].div(_templateObject || (_templateObject = (0, _taggedTemplateLiteral2["default"])(["\n  // Chrome, Safari, Edge, Opera\n  input::-webkit-outer-spin-button,\n  input::-webkit-inner-spin-button {\n    -webkit-appearance: none;\n    margin: 0;\n  }\n\n  // Firefox\n  input[type=\"number\"] {\n    -moz-appearance: textfield;\n  }\n"])));
-
-var _default = DxcNumberInput;
-exports["default"] = _default;
+var NumberInputContainer = _styledComponents["default"].div(_templateObject || (_templateObject = (0, _taggedTemplateLiteral2["default"])(["\n  ", "\n  // Chrome, Safari, Edge, Opera\n  input::-webkit-outer-spin-button,\n  input::-webkit-inner-spin-button {\n    -webkit-appearance: none;\n    margin: 0;\n  }\n\n  // Firefox\n  input[type=\"number\"] {\n    -moz-appearance: textfield;\n  }\n"])), function (props) {
+  return props.size == "fillParent" && "width: 100%;";
+});
+var _default = exports["default"] = DxcNumberInput;

package/number-input/NumberInput.stories.tsx

@@ -1,12 +1,11 @@
 import React from "react";
-import { BackgroundColorProvider } from "../BackgroundColorContext";
 import Title from "../../.storybook/components/Title";
 import ExampleContainer from "../../.storybook/components/ExampleContainer";
-import DarkContainer from "../../.storybook/components/DarkSection";
 import DxcNumberInput from "./NumberInput";
+import DxcFlex from "../flex/Flex";
 
 export default {
-  title: "Number input ",
+  title: "Number Input",
   component: DxcNumberInput,
 };
 
@@ -22,7 +21,7 @@ export const Chromatic = () => (
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Helper text, optional and value" theme="light" level={4} />
-      <DxcNumberInput label="Number input" value="12" helperText="Help message" optional />
+      <DxcNumberInput label="Number input" defaultValue="12" helperText="Help message" optional />
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Disabled and placeholder" theme="light" level={4} />
@@ -30,7 +29,26 @@ export const Chromatic = () => (
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Disabled, helper text, optional and value" theme="light" level={4} />
-      <DxcNumberInput label="Disabled number input" helperText="Help message" disabled optional value="10" />
+      <DxcNumberInput label="Disabled number input" helperText="Help message" disabled optional defaultValue="10" />
+    </ExampleContainer>
+    <ExampleContainer>
+      <Title title="Read only" theme="light" level={4} />
+      <DxcNumberInput label="Example label" helperText="Help message" readOnly optional prefix="€" defaultValue="33" />
+    </ExampleContainer>
+    <ExampleContainer pseudoState="pseudo-hover">
+      <Title title="Hovered read only" theme="light" level={4} />
+      <DxcNumberInput label="Example label" helperText="Help message" readOnly optional prefix="€" defaultValue="1" />
+    </ExampleContainer>
+    <ExampleContainer pseudoState="pseudo-active">
+      <Title title="Active read only" theme="light" level={4} />
+      <DxcNumberInput
+        label="Example label"
+        helperText="Help message"
+        readOnly
+        optional
+        prefix="€"
+        placeholder="Placeholder"
+      />
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Prefix" theme="light" level={4} />
@@ -42,29 +60,14 @@ export const Chromatic = () => (
     </ExampleContainer>
     <ExampleContainer>
       <Title title="Invalid" theme="light" level={4} />
-      <DxcNumberInput label="Error number input" helperText="Help message" error="Error message." value="23" optional />
-    </ExampleContainer>
-    <BackgroundColorProvider color="#333333">
-      <DarkContainer>
-        <Title title="Dark" theme="dark" level={2} />
-        <ExampleContainer>
-          <Title title="Helper text, placeholder and optional" theme="dark" level={4} />
-          <DxcNumberInput label="Number input" helperText="Help message" placeholder="Placeholder" optional />
-        </ExampleContainer>
-        <ExampleContainer>
-          <Title title="Helper text, value and error" theme="dark" level={4} />
-          <DxcNumberInput label="Number input" helperText="Help message" error="Error message." value="199" />
-        </ExampleContainer>
-        <ExampleContainer>
-          <Title title="Disabled and placeholder" theme="dark" level={4} />
-          <DxcNumberInput label="Disabled number input" disabled placeholder="Placeholder" />
-        </ExampleContainer>
-        <ExampleContainer>
-          <Title title="Disabled, helper text, optional and value" theme="dark" level={4} />
-          <DxcNumberInput label="Disabled number input" helperText="Help message" disabled optional value="1232454" />
-        </ExampleContainer>
-      </DarkContainer>
-    </BackgroundColorProvider>
+      <DxcNumberInput
+        label="Error number input"
+        helperText="Help message"
+        error="Error message."
+        defaultValue="23"
+        optional
+      />
+    </ExampleContainer>
     <Title title="Margins" theme="light" level={2} />
     <ExampleContainer>
       <Title title="Xxsmall margin" theme="light" level={4} />
@@ -111,5 +114,13 @@ export const Chromatic = () => (
       <Title title="FillParent size" theme="light" level={4} />
       <DxcNumberInput label="FillParent" size="fillParent" />
     </ExampleContainer>
+    <ExampleContainer>
+      <Title title="Different sizes inside a flex" theme="light" level={4} />
+      <DxcFlex justifyContent="space-between" gap="1rem">
+        <DxcNumberInput label="fillParent" size="fillParent" />
+        <DxcNumberInput label="medium" size="medium" />
+        <DxcNumberInput label="large" size="large" />
+      </DxcFlex>
+    </ExampleContainer>
   </>
 );

package/number-input/NumberInput.test.d.ts

@@ -0,0 +1 @@
+export {};