@dxc-technology/halstack-react 0.0.0-2aeb707 → 0.0.0-2b0d695

package/test/Select.test.js

@@ -21,18 +21,43 @@ const optionsWithoutIcon = [
 const optionsWithIcons = [
   {
     value: 1,
-    label: "Facebook",
-    iconSrc: "/testIconFacebook",
+    label: "Image 1",
+    icon: (
+      <svg
+        data-testid="image-1"
+        xmlns="http://www.w3.org/2000/svg"
+        height="24px"
+        viewBox="0 0 24 24"
+        width="24px"
+        fill="currentColor"
+      >
+        <path d="M0 0h24v24H0V0z" fill="none" />
+        <path d="M16 1H4c-1.1 0-2 .9-2 2v14h2V3h12V1zm3 4H8c-1.1 0-2 .9-2 2v14c0 1.1.9 2 2 2h11c1.1 0 2-.9 2-2V7c0-1.1-.9-2-2-2zm0 16H8V7h11v14z" />
+      </svg>
+    ),
   },
   {
     value: 2,
-    label: "Twitter",
-    iconSrc: "/testIconTwitter",
-  },
-  {
-    value: 3,
-    label: "Linkedin",
-    iconSrc: "/testIconLinkedin",
+    label: "Image 2",
+    icon: (
+      <svg
+        data-testid="image-2"
+        version="1.1"
+        x="0px"
+        y="0px"
+        width="24px"
+        height="24px"
+        viewBox="0 0 24 24"
+        enable-background="new 0 0 24 24"
+      >
+        <g id="Bounding_Box">
+          <rect fill="none" width="24" height="24" />
+        </g>
+        <g id="Master">
+          <path d="M19,9.3V4h-3v2.6L12,3L2,12h3v8h5v-6h4v6h5v-8h3L19,9.3z M10,10c0-1.1,0.9-2,2-2s2,0.9,2,2H10z" />
+        </g>
+      </svg>
+    ),
   },
 ];
 
@@ -60,29 +85,27 @@ describe("Select component tests", () => {
   });
 
   test("Select renders options with icons before", () => {
-    const { getByRole, getAllByRole } = render(
+    const { getByRole, getByTestId } = render(
       <DxcSelect label="test-select-name" options={optionsWithIcons}></DxcSelect>
     );
     const select = getByRole("button");
     act(() => {
       userEvent.click(select);
     });
-    expect(getAllByRole("img")[0].getAttribute("src")).toEqual("/testIconFacebook");
-    expect(getAllByRole("img")[1].getAttribute("src")).toEqual("/testIconTwitter");
-    expect(getAllByRole("img")[2].getAttribute("src")).toEqual("/testIconLinkedin");
+    expect(getByTestId("image-1")).toBeTruthy();
+    expect(getByTestId("image-2")).toBeTruthy();
   });
 
   test("Select renders options with icons after", () => {
-    const { getByRole, getAllByRole } = render(
+    const { getByRole, getByTestId } = render(
       <DxcSelect label="test-select-name" options={optionsWithIcons} iconPosition="after"></DxcSelect>
     );
     const select = getByRole("button");
     act(() => {
       userEvent.click(select);
     });
-    expect(getAllByRole("img")[0].getAttribute("src")).toEqual("/testIconFacebook");
-    expect(getAllByRole("img")[1].getAttribute("src")).toEqual("/testIconTwitter");
-    expect(getAllByRole("img")[2].getAttribute("src")).toEqual("/testIconLinkedin");
+    expect(getByTestId("image-1")).toBeTruthy();
+    expect(getByTestId("image-2")).toBeTruthy();
   });
 
   test("Select renders with a default value", () => {
@@ -166,25 +189,22 @@ describe("Select component tests", () => {
     act(() => {
       userEvent.click(select);
     });
-    const option1 = getByText("Amazon");
-    const option2 = getByText("Ebay");
-    const option3 = getByText("Apple");
     act(() => {
-      userEvent.click(option1);
+      userEvent.click(getByText("Amazon"));
     });
     expect(onChange).toHaveBeenCalledWith([1]);
     act(() => {
-      userEvent.click(option2);
+      userEvent.click(getByText("Ebay"));
     });
     expect(onChange).toHaveBeenCalledWith([1, 2]);
     expect(getByText("Amazon, Ebay")).toBeTruthy();
     act(() => {
-      userEvent.click(option3);
+      userEvent.click(getByText("Apple"));
     });
     expect(onChange).toHaveBeenCalledWith([1, 2, 3]);
     expect(getByText("Amazon, Ebay, Apple")).toBeTruthy();
     act(() => {
-      userEvent.click(option1);
+      userEvent.click(getByText("Amazon"));
     });
     expect(onChange).toHaveBeenCalledWith([2, 3]);
     expect(getByText("Ebay, Apple")).toBeTruthy();

package/test/Slider.test.js

@@ -4,7 +4,7 @@ import DxcSlider from "../src/slider/Slider";
 
 describe("Slider component tests", () => {
   test("Slider renders with correct text", () => {
-    const { getByText } = render(<DxcSlider minValue={0} maxValue={100} showLimitsValues></DxcSlider>);
+    const { getByText } = render(<DxcSlider minValue={0} maxValue={100} showLimitsValues />);
     expect(getByText("0")).toBeTruthy();
     expect(getByText("100")).toBeTruthy();
   });
@@ -12,37 +12,29 @@ describe("Slider component tests", () => {
   test("Calls correct function onChange in controlled slider", () => {
     const onChange = jest.fn();
     const { getByRole } = render(
-      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues value={13} showInput></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues value={13} showInput />
     );
     act(() => {
       fireEvent.change(getByRole("textbox"), { target: { value: 25 } });
     });
-    expect(onChange).toHaveBeenCalledWith("25");
+    expect(onChange).toHaveBeenCalledWith(25);
   });
 
   test("Calls correct function onChange in uncontrolled slider", () => {
     const onChange = jest.fn();
     const { getByRole } = render(
-      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues showInput></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues showInput />
     );
     act(() => {
       fireEvent.change(getByRole("textbox"), { target: { value: 25 } });
     });
-    expect(onChange).toHaveBeenCalledWith("25");
+    expect(onChange).toHaveBeenCalledWith(25);
   });
 
   test("Disabled slider have disabled input", () => {
     const onChange = jest.fn();
     const { getByRole } = render(
-      <DxcSlider
-        minValue={0}
-        maxValue={100}
-        onChange={onChange}
-        showLimitsValues
-        disabled
-        showInput
-        value={13}
-      ></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} onChange={onChange} showLimitsValues disabled showInput value={13} />
     );
     act(() => {
       fireEvent.change(getByRole("textbox"), { target: { value: 25 } });
@@ -54,7 +46,7 @@ describe("Slider component tests", () => {
   test("Calls correct function onDragEnd", () => {
     const onDragEnd = jest.fn();
     const { getByRole } = render(
-      <DxcSlider minValue={0} maxValue={100} showLimitsValues showInput onDragEnd={onDragEnd} value={25}></DxcSlider>
+      <DxcSlider minValue={0} maxValue={100} showLimitsValues showInput onDragEnd={onDragEnd} value={25} />
     );
     act(() => {
       fireEvent.mouseDown(getByRole("slider"));
@@ -64,7 +56,7 @@ describe("Slider component tests", () => {
   });
 
   test("Calls correct function labelFormatCallback", () => {
-    const labelFormatCallback = jest.fn(x => `${x}$`);
+    const labelFormatCallback = jest.fn((x) => `${x}$`);
     const { getByText } = render(
       <DxcSlider
         minValue={0}
@@ -73,7 +65,7 @@ describe("Slider component tests", () => {
         showInput
         value={25}
         labelFormatCallback={labelFormatCallback}
-      ></DxcSlider>
+      />
     );
     expect(getByText("0$")).toBeTruthy();
     expect(getByText("100$")).toBeTruthy();

package/test/Spinner.test.js

@@ -24,4 +24,9 @@ describe("Spinner component tests", () => {
     expect(getByText("test-loading")).toBeTruthy();
     expect(getByText("75%")).toBeTruthy();
   });
+
+  test("Get spinner by role", () => {
+    const { getByRole } = render(<DxcSpinner label="test-loading" value={75} showValue></DxcSpinner>);
+    expect(getByRole("progressbar")).toBeTruthy();
+  });
 });

package/test/Tabs.test.js

@@ -14,6 +14,21 @@ const sampleTabs = [
   },
 ];
 
+const sampleTabsWithBadge = [
+  {
+    label: "Tab-1",
+    notificationNumber: "10",
+  },
+  {
+    label: "Tab-2",
+    notificationNumber: "20",
+  },
+  {
+    label: "Tab-3",
+    notificationNumber: "101",
+  },
+];
+
 describe("Tabs component tests", () => {
   test("Tabs render with correct labels", () => {
     const { getByText } = render(<DxcTabs tabs={sampleTabs}></DxcTabs>);
@@ -21,6 +36,12 @@ describe("Tabs component tests", () => {
     expect(getByText("Tab-2")).toBeTruthy();
     expect(getByText("Tab-3")).toBeTruthy();
   });
+  test("Tabs render with correct labels and badges", () => {
+    const { getByText } = render(<DxcTabs tabs={sampleTabsWithBadge}></DxcTabs>);
+    expect(getByText("10")).toBeTruthy();
+    expect(getByText("20")).toBeTruthy();
+    expect(getByText("+99")).toBeTruthy();
+  });
 
   test("Tabs render with correct icons", () => {
     const { getAllByRole } = render(