@dvukovic/style-guide 0.3.93 → 0.3.94

package/src/eslint/plugins/sonarjs.js

@@ -1,33 +1,39 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["sonarjs"],
-    rules: {
-        "sonarjs/no-all-duplicated-branches": "error",
-        "sonarjs/no-collapsible-if": "error",
-        "sonarjs/no-collection-size-mischeck": "error",
-        "sonarjs/no-duplicated-branches": "error",
-        "sonarjs/no-element-overwrite": "error",
-        "sonarjs/no-empty-collection": "error",
-        "sonarjs/no-gratuitous-expressions": "error",
-        "sonarjs/no-identical-conditions": "error",
-        "sonarjs/no-identical-expressions": "error",
-        "sonarjs/no-identical-functions": "error",
-        "sonarjs/no-ignored-return": "error",
-        "sonarjs/no-inverted-boolean-check": "error",
-        "sonarjs/no-nested-switch": "error",
-        "sonarjs/no-nested-template-literals": "error",
-        "sonarjs/no-one-iteration-loop": "error",
-        "sonarjs/no-redundant-boolean": "error",
-        "sonarjs/no-redundant-jump": "error",
-        "sonarjs/no-same-line-conditional": "error",
-        "sonarjs/no-small-switch": "error",
-        "sonarjs/no-unused-collection": "error",
-        "sonarjs/no-use-of-empty-return-value": "error",
-        "sonarjs/no-useless-catch": "error",
-        "sonarjs/non-existent-operator": "error",
-        "sonarjs/prefer-immediate-return": "error",
-        "sonarjs/prefer-object-literal": "error",
-        "sonarjs/prefer-single-boolean-return": "error",
-        "sonarjs/prefer-while": "error",
-    },
+// sonarjs v3 changed rules significantly - needs manual review
+// import sonarjs from "eslint-plugin-sonarjs"
+
+const plugin = {
+    // plugins: {
+    //     sonarjs,
+    // },
+    // rules: {
+    //     "sonarjs/no-all-duplicated-branches": "error",
+    //     "sonarjs/no-collapsible-if": "error",
+    //     "sonarjs/no-collection-size-mischeck": "error",
+    //     "sonarjs/no-duplicated-branches": "error",
+    //     "sonarjs/no-element-overwrite": "error",
+    //     "sonarjs/no-empty-collection": "error",
+    //     "sonarjs/no-gratuitous-expressions": "error",
+    //     "sonarjs/no-identical-conditions": "error",
+    //     "sonarjs/no-identical-expressions": "error",
+    //     "sonarjs/no-identical-functions": "error",
+    //     "sonarjs/no-ignored-return": "error",
+    //     "sonarjs/no-inverted-boolean-check": "error",
+    //     "sonarjs/no-nested-switch": "error",
+    //     "sonarjs/no-nested-template-literals": "error",
+    //     "sonarjs/no-one-iteration-loop": "error",
+    //     "sonarjs/no-redundant-boolean": "error",
+    //     "sonarjs/no-redundant-jump": "error",
+    //     "sonarjs/no-same-line-conditional": "error",
+    //     "sonarjs/no-small-switch": "error",
+    //     "sonarjs/no-unused-collection": "error",
+    //     "sonarjs/no-use-of-empty-return-value": "error",
+    //     "sonarjs/no-useless-catch": "error",
+    //     "sonarjs/non-existent-operator": "error",
+    //     "sonarjs/prefer-immediate-return": "error",
+    //     "sonarjs/prefer-object-literal": "error",
+    //     "sonarjs/prefer-single-boolean-return": "error",
+    //     "sonarjs/prefer-while": "error",
+    // },
 }
+
+export default plugin

package/src/eslint/plugins/sort-destructure-keys.js

@@ -1,7 +1,12 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["sort-destructure-keys"],
+import sortDestructureKeys from "eslint-plugin-sort-destructure-keys"
+
+const plugin = {
+    plugins: {
+        "sort-destructure-keys": sortDestructureKeys,
+    },
     rules: {
         "sort-destructure-keys/sort-destructure-keys": "error",
     },
 }
+
+export default plugin

package/src/eslint/plugins/sort-keys-fix.js

@@ -1,7 +1,12 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["sort-keys-fix"],
+import sortKeysFix from "eslint-plugin-sort-keys-fix"
+
+const plugin = {
+    plugins: {
+        "sort-keys-fix": sortKeysFix,
+    },
     rules: {
         "sort-keys-fix/sort-keys-fix": "error",
     },
 }
+
+export default plugin

package/src/eslint/plugins/storybook.js

@@ -1,6 +1,9 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["storybook"],
+import storybook from "eslint-plugin-storybook"
+
+const plugin = {
+    plugins: {
+        storybook,
+    },
     rules: {
         "storybook/await-interactions": "error",
         "storybook/context-in-play-function": "error",
@@ -17,3 +20,5 @@ module.exports = {
         "storybook/use-storybook-testing-library": "error",
     },
 }
+
+export default plugin

package/src/eslint/plugins/stylistic.js

@@ -1,6 +1,9 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["@stylistic"],
+import stylistic from "@stylistic/eslint-plugin"
+
+const plugin = {
+    plugins: {
+        "@stylistic": stylistic,
+    },
     rules: {
         "@stylistic/lines-between-class-members": ["error", "always"],
         "@stylistic/padding-line-between-statements": [
@@ -34,3 +37,5 @@ module.exports = {
         "@stylistic/spaced-comment": ["error", "always", { markers: ["/"] }],
     },
 }
+
+export default plugin

package/src/eslint/plugins/typescript-eslint.js

@@ -1,6 +1,9 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["@typescript-eslint"],
+import typescriptEslint from "typescript-eslint"
+
+const plugin = {
+    plugins: {
+        "@typescript-eslint": typescriptEslint.plugin,
+    },
     rules: {
         "@typescript-eslint/adjacent-overload-signatures": "error",
         "@typescript-eslint/array-type": "error",
@@ -66,7 +69,6 @@ module.exports = {
         "@typescript-eslint/no-duplicate-type-constituents": "error",
         "@typescript-eslint/no-dynamic-delete": "error",
         "@typescript-eslint/no-empty-function": "error",
-        "@typescript-eslint/no-empty-interface": "error",
         "@typescript-eslint/no-empty-object-type": "error",
         "@typescript-eslint/no-explicit-any": "error",
         "@typescript-eslint/no-extra-non-null-assertion": "error",
@@ -78,7 +80,6 @@ module.exports = {
         "@typescript-eslint/no-inferrable-types": "error",
         "@typescript-eslint/no-invalid-void-type": "error",
         "@typescript-eslint/no-loop-func": "error",
-        "@typescript-eslint/no-loss-of-precision": "error",
         "@typescript-eslint/no-meaningless-void-operator": [
             "error",
             {
@@ -107,6 +108,7 @@ module.exports = {
         "@typescript-eslint/no-unnecessary-type-arguments": "error",
         "@typescript-eslint/no-unnecessary-type-assertion": "error",
         "@typescript-eslint/no-unnecessary-type-constraint": "error",
+        "@typescript-eslint/no-unnecessary-type-conversion": "error",
         "@typescript-eslint/no-unnecessary-type-parameters": "error",
         "@typescript-eslint/no-unsafe-function-type": "error",
         "@typescript-eslint/no-unsafe-type-assertion": "off",
@@ -116,6 +118,7 @@ module.exports = {
                 allowTernary: true,
             },
         ],
+        "@typescript-eslint/no-unused-private-class-members": "error",
         "@typescript-eslint/no-unused-vars": [
             "error",
             {
@@ -178,7 +181,6 @@ module.exports = {
         "no-empty-function": "off",
         "no-implied-eval": "off",
         "no-loop-func": "off",
-        "no-loss-of-precision": "off",
         "no-return-await": "off",
         "no-shadow": "off",
         "no-throw-literal": "off",
@@ -190,3 +192,5 @@ module.exports = {
         "require-await": "off",
     },
 }
+
+export default plugin

package/src/eslint/plugins/typescript-sort-keys.js

@@ -1,8 +1,13 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["typescript-sort-keys"],
+import typescriptSortKeys from "eslint-plugin-typescript-sort-keys"
+
+const plugin = {
+    plugins: {
+        "typescript-sort-keys": typescriptSortKeys,
+    },
     rules: {
         "typescript-sort-keys/interface": "error",
         "typescript-sort-keys/string-enum": "error",
     },
 }
+
+export default plugin

package/src/eslint/plugins/unicorn.js

@@ -1,9 +1,13 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["unicorn"],
+import unicorn from "eslint-plugin-unicorn"
+
+const plugin = {
+    plugins: {
+        unicorn,
+    },
     rules: {
         "unicorn/better-regex": "error",
         "unicorn/catch-error-name": "error",
+        "unicorn/consistent-date-clone": "error",
         "unicorn/consistent-destructuring": "error",
         "unicorn/consistent-empty-array-spread": "error",
         "unicorn/consistent-existence-index-check": "error",
@@ -25,23 +29,28 @@ module.exports = {
         ],
         "unicorn/new-for-builtins": "error",
         "unicorn/no-abusive-eslint-disable": "error",
+        "unicorn/no-accessor-recursion": "error",
         "unicorn/no-anonymous-default-export": "error",
         "unicorn/no-array-callback-reference": "error",
         "unicorn/no-array-method-this-argument": "error",
         "unicorn/no-array-push-push": "error",
         "unicorn/no-array-reduce": "error",
+        "unicorn/no-array-reverse": "error",
         "unicorn/no-await-expression-member": "error",
         "unicorn/no-await-in-promise-methods": "error",
         "unicorn/no-console-spaces": "error",
         "unicorn/no-document-cookie": "error",
         "unicorn/no-empty-file": "error",
         "unicorn/no-for-loop": "error",
+        "unicorn/no-immediate-mutation": "error",
         "unicorn/no-instanceof-array": "error",
+        "unicorn/no-instanceof-builtins": "error",
         "unicorn/no-invalid-fetch-options": "error",
         "unicorn/no-invalid-remove-event-listener": "error",
         "unicorn/no-length-as-slice-end": "error",
         "unicorn/no-lonely-if": "error",
         "unicorn/no-magic-array-flat-depth": "error",
+        "unicorn/no-named-default": "error",
         "unicorn/no-negation-in-equality-check": "error",
         "unicorn/no-new-array": "error",
         "unicorn/no-new-buffer": "error",
@@ -52,11 +61,15 @@ module.exports = {
         "unicorn/no-thenable": "error",
         "unicorn/no-this-assignment": "error",
         "unicorn/no-typeof-undefined": "error",
+        "unicorn/no-unnecessary-array-flat-depth": "error",
+        "unicorn/no-unnecessary-array-splice-count": "error",
         "unicorn/no-unnecessary-await": "error",
         "unicorn/no-unnecessary-polyfills": "error",
         "unicorn/no-unreadable-array-destructuring": "error",
         "unicorn/no-unreadable-iife": "error",
         "unicorn/no-unused-properties": "error",
+        "unicorn/no-useless-collection-argument": "error",
+        "unicorn/no-useless-error-capture-stack-trace": "error",
         "unicorn/no-useless-fallback-in-spread": "error",
         "unicorn/no-useless-length-check": "error",
         "unicorn/no-useless-promise-resolve-reject": "error",
@@ -81,6 +94,7 @@ module.exports = {
         "unicorn/prefer-dom-node-text-content": "error",
         "unicorn/prefer-event-target": "error",
         "unicorn/prefer-export-from": ["error", { ignoreUsedVariables: true }],
+        "unicorn/prefer-import-meta-properties": "error",
         "unicorn/prefer-includes": "error",
         "unicorn/prefer-json-parse-buffer": "error",
         "unicorn/prefer-keyboard-event-key": "error",
@@ -98,6 +112,7 @@ module.exports = {
         "unicorn/prefer-query-selector": "error",
         "unicorn/prefer-reflect-apply": "error",
         "unicorn/prefer-regexp-test": "error",
+        "unicorn/prefer-response-static-json": "error",
         "unicorn/prefer-set-has": "error",
         "unicorn/prefer-set-size": "error",
         "unicorn/prefer-string-raw": "error",
@@ -151,3 +166,5 @@ module.exports = {
         "unicorn/throw-new-error": "error",
     },
 }
+
+export default plugin

package/src/eslint/plugins/unused-imports.js

@@ -1,7 +1,12 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["unused-imports"],
+import unusedImports from "eslint-plugin-unused-imports"
+
+const plugin = {
+    plugins: {
+        "unused-imports": unusedImports,
+    },
     rules: {
         "unused-imports/no-unused-imports": "error",
     },
 }
+
+export default plugin

package/src/eslint/plugins/vitest.js

@@ -1,7 +1,19 @@
-/** @type {import("eslint").ESLint.ConfigData} */
-module.exports = {
-    plugins: ["@vitest"],
+import vitest from "@vitest/eslint-plugin"
+
+const plugin = {
+    plugins: {
+        "@vitest": vitest,
+    },
     rules: {
+        "@vitest/consistent-each-for": [
+            "error",
+            {
+                describe: "each",
+                it: "for",
+                suite: "each",
+                test: "for",
+            },
+        ],
         "@vitest/consistent-test-it": [
             "error",
             {
@@ -28,6 +40,7 @@ module.exports = {
         "@vitest/no-focused-tests": "error",
         "@vitest/no-identical-title": "error",
         "@vitest/no-import-node-test": "error",
+        "@vitest/no-importing-vitest-globals": "error",
         "@vitest/no-interpolation-in-snapshots": "error",
         "@vitest/no-large-snapshots": "error",
         "@vitest/no-mocks-import": "error",
@@ -40,6 +53,8 @@ module.exports = {
         "@vitest/no-test-prefixes": "error",
         "@vitest/no-test-return-statement": "error",
         "@vitest/padding-around-all": "error",
+        "@vitest/prefer-called-exactly-once-with": "error",
+        "@vitest/prefer-called-once": "error",
         "@vitest/prefer-called-with": "error",
         "@vitest/prefer-comparison-matcher": "error",
         "@vitest/prefer-each": "error",
@@ -50,15 +65,22 @@ module.exports = {
         "@vitest/prefer-lowercase-title": "error",
         "@vitest/prefer-mock-promise-shorthand": "error",
         "@vitest/prefer-spy-on": "error",
+        "@vitest/prefer-strict-boolean-matchers": "error",
         "@vitest/prefer-strict-equal": "error",
         "@vitest/prefer-to-be": "error",
-        "@vitest/prefer-to-be-falsy": "error",
         "@vitest/prefer-to-be-object": "error",
-        "@vitest/prefer-to-be-truthy": "error",
         "@vitest/prefer-to-contain": "error",
         "@vitest/prefer-to-have-length": "error",
         "@vitest/prefer-todo": "error",
         "@vitest/prefer-vi-mocked": "error",
+        "@vitest/require-awaited-expect-poll": "error",
+        "@vitest/require-import-vi-mock": "error",
+        "@vitest/require-mock-type-parameters": [
+            "error",
+            {
+                checkImportFunctions: false,
+            },
+        ],
         "@vitest/require-to-throw-message": "error",
         "@vitest/require-top-level-describe": [
             "error",
@@ -70,5 +92,8 @@ module.exports = {
         "@vitest/valid-expect": "error",
         "@vitest/valid-expect-in-promise": "error",
         "@vitest/valid-title": "error",
+        "@vitest/warn-todo": "warn",
     },
 }
+
+export default plugin

package/src/package-json/configs/core.js

@@ -1,10 +1,8 @@
-const { packageJsonCore } = require("../plugins/package-json.js")
+import packageJsonCore from "../plugins/package-json.js"
 
 /** @type {import("npm-package-json-lint/dist/src/configuration").Config} */
 const config = {
-    rules: {
-        ...packageJsonCore.rules,
-    },
+    ...packageJsonCore,
 }
 
-module.exports = config
+export default config

package/src/package-json/plugins/package-json.js

@@ -1,5 +1,5 @@
 /** @type {import("npm-package-json-lint/dist/src/configuration").Config} */
-const packageJsonCore = {
+const plugin = {
     rules: {
         "bin-type": "error",
         "bundledDependencies-type": "error",
@@ -78,6 +78,4 @@ const packageJsonCore = {
     },
 }
 
-module.exports = {
-    packageJsonCore,
-}
+export default plugin

package/src/prettier/configs/core.js

@@ -1,9 +1,9 @@
-const { prettierPluginEmbed } = require("../plugins/embed.js")
-const { prettierPluginSql } = require("../plugins/sql.js")
-const { prettierPlugin } = require("../plugins/prettier.js")
+import prettierPluginEmbed from "../plugins/embed.js"
+import prettierPlugin from "../plugins/prettier.js"
+import prettierPluginSql from "../plugins/sql.js"
 
 /** @type {import("prettier").Config} */
-module.exports = {
+const config = {
     plugins: [
         "prettier-plugin-prisma",
         "prettier-plugin-sql",
@@ -18,3 +18,5 @@ module.exports = {
     ...prettierPluginSql,
     ...prettierPluginEmbed,
 }
+
+export default config

package/src/prettier/configs/core.test.js

@@ -0,0 +1,24 @@
+import { format } from "prettier"
+
+import config from "./core.js"
+
+describe("prettier core", () => {
+    test("loads without errors", async () => {
+        const result = await format("const x = 1", {
+            ...config,
+            parser: "babel",
+        })
+
+        expect(result).toBeDefined()
+        expect(typeof result).toBe("string")
+    })
+
+    test("formats code correctly", async () => {
+        const result = await format("const x=1", {
+            ...config,
+            parser: "babel",
+        })
+
+        expect(result).toContain("const x = 1")
+    })
+})

package/src/prettier/plugins/embed.js

@@ -1,8 +1,6 @@
 /** @type {import("prettier-plugin-embed").PrettierPluginEmbedOptions} */
-const prettierPluginEmbed = {
+const plugin = {
     embeddedSqlTags: ["sql"],
 }
 
-module.exports = {
-    prettierPluginEmbed,
-}
+export default plugin

package/src/prettier/plugins/prettier.js

@@ -1,5 +1,5 @@
 /** @type {import("prettier").Config} */
-const prettierPlugin = {
+const plugin = {
     arrowParens: "always",
     bracketSameLine: false,
     bracketSpacing: true,
@@ -18,6 +18,4 @@ const prettierPlugin = {
     useTabs: false,
 }
 
-module.exports = {
-    prettierPlugin,
-}
+export default plugin

package/src/prettier/plugins/sql.js

@@ -1,9 +1,7 @@
 /** @type {import("prettier-plugin-sql").SqlBaseOptions} */
-const prettierPluginSql = {
+const plugin = {
     keywordCase: "upper",
     language: "postgresql",
 }
 
-module.exports = {
-    prettierPluginSql,
-}
+export default plugin

package/src/stylelint/configs/core.js

@@ -1,9 +1,9 @@
-const { stylelint } = require("../plugins/stylelint")
-const { stylelintOrder } = require("../plugins/order")
-const { stylelintNoUnusedSelectors } = require("../plugins/no-unused-selectors")
+import stylelintNoUnusedSelectors from "../plugins/no-unused-selectors.js"
+import stylelintOrder from "../plugins/order.js"
+import stylelint from "../plugins/stylelint.js"
 
 /** @type {import("stylelint").Config} */
-module.exports = {
+const config = {
     allowEmptyInput: true,
     defaultSeverity: "error",
     plugins: ["stylelint-order", "stylelint-no-unused-selectors"],
@@ -17,3 +17,5 @@ module.exports = {
         ...stylelintNoUnusedSelectors.rules,
     },
 }
+
+export default config

package/src/stylelint/configs/core.test.js

@@ -0,0 +1,24 @@
+import stylelint from "stylelint"
+
+import config from "./core.js"
+
+describe("stylelint core", () => {
+    test("loads without errors", async () => {
+        const result = await stylelint.lint({
+            code: "a { padding: 10px; }",
+            config,
+        })
+
+        expect(result).toBeDefined()
+        expect(result.errored).toBe(false)
+    })
+
+    test("detects violations", async () => {
+        const result = await stylelint.lint({
+            code: "a { color: red;; }",
+            config,
+        })
+
+        expect(result.errored).toBe(true)
+    })
+})

package/src/stylelint/plugins/no-unused-selectors.js

@@ -1,10 +1,8 @@
 /** @type {import("stylelint").Config} */
-const stylelintNoUnusedSelectors = {
+const plugin = {
     rules: {
         "plugin/no-unused-selectors": true,
     },
 }
 
-module.exports = {
-    stylelintNoUnusedSelectors,
-}
+export default plugin

package/src/stylelint/plugins/order.js

@@ -1,5 +1,5 @@
 /** @type {import("stylelint").Config} */
-const stylelintOrder = {
+const plugin = {
     rules: {
         "order/order": [
             "custom-properties",
@@ -14,6 +14,4 @@ const stylelintOrder = {
     },
 }
 
-module.exports = {
-    stylelintOrder,
-}
+export default plugin

package/src/stylelint/plugins/stylelint.js

@@ -1,5 +1,5 @@
 /** @type {import("stylelint").Config} */
-const stylelint = {
+const plugin = {
     rules: {
         "alpha-value-notation": "percentage",
         "annotation-no-unknown": true,
@@ -7,6 +7,7 @@ const stylelint = {
         "at-rule-no-unknown": [true, { ignoreAtRules: ["theme", "mixin"] }],
         "at-rule-no-vendor-prefix": true,
         "block-no-empty": true,
+        "block-no-redundant-nested-style-rules": true,
         "color-function-notation": "modern",
         "color-hex-length": "long",
         "color-named": "never",
@@ -38,6 +39,7 @@ const stylelint = {
         "keyframe-block-no-duplicate-selectors": true,
         "keyframe-declaration-no-important": true,
         "keyframe-selector-notation": "percentage",
+        "layer-name-pattern": "^[a-z][a-z0-9.-]*$",
         "length-zero-no-unit": true,
         "lightness-notation": "percentage",
         "media-feature-name-no-unknown": true,
@@ -45,16 +47,20 @@ const stylelint = {
         "media-feature-name-value-no-unknown": true,
         "media-feature-range-notation": "prefix",
         "media-query-no-invalid": true,
+        "media-type-no-deprecated": true,
         "named-grid-areas-no-invalid": true,
+        "nesting-selector-no-missing-scoping-root": true,
         "no-descending-specificity": true,
         "no-duplicate-at-import-rules": true,
         "no-duplicate-selectors": true,
         "no-empty-source": true,
         "no-invalid-double-slash-comments": true,
         "no-invalid-position-at-import-rule": true,
+        "no-invalid-position-declaration": true,
         "no-irregular-whitespace": true,
         "no-unknown-animations": true,
         "number-max-precision": 3,
+        "property-no-deprecated": true,
         "property-no-unknown": true,
         "property-no-vendor-prefix": true,
         "rule-empty-line-before": [
@@ -75,6 +81,7 @@ const stylelint = {
         "selector-type-no-unknown": true,
         "shorthand-property-no-redundant-values": true,
         "string-no-newline": true,
+        "syntax-string-no-invalid": true,
         "unit-allowed-list": ["px", "rem", "%", "fr", "vw", "vh", "s", "deg", "ms"],
         "unit-no-unknown": true,
         "value-keyword-case": "lower",
@@ -82,6 +89,4 @@ const stylelint = {
     },
 }
 
-module.exports = {
-    stylelint,
-}
+export default plugin