@dvukovic/style-guide 0.16.0 → 0.17.0

package/dist/eslint/rules/no-instanceof-error/no-instanceof-error.d.ts

@@ -0,0 +1,16 @@
+export namespace noInstanceofError {
+    function create(context: any): {
+        BinaryExpression(node: any): void;
+    };
+    namespace meta {
+        namespace docs {
+            let description: string;
+        }
+        let fixable: string;
+        namespace messages {
+            let forbidden: string;
+        }
+        let schema: never[];
+        let type: string;
+    }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@dvukovic/style-guide",
-    "version": "0.16.0",
+    "version": "0.17.0",
     "description": "My own style guide",
     "repository": {
         "type": "git",

package/src/cli/generators/eslint.js

@@ -31,6 +31,8 @@ export function generateESLintConfig(options) {
     }
 
     if (framework === "next") {
+        imports.push("react")
+        configs.push("react()")
         imports.push("next")
         configs.push("next()")
         ignores.push("out")

package/src/cli/generators/scripts.js

@@ -26,11 +26,13 @@ export function generateScripts(tools, packageManager) {
     if (tools.includes("cspell")) {
         scripts["lint:cspell"] = "cspell --no-progress --no-summary --unique '**'"
         lintParts.push(`${runner} lint:cspell`)
+        fixParts.push(`${runner} lint:cspell`)
     }
 
     if (tools.includes("knip")) {
         scripts["lint:knip"] = "knip --cache"
         lintParts.push(`${runner} lint:knip`)
+        fixParts.push(`${runner} lint:knip`)
     }
 
     if (lintParts.length > 0) {

package/src/eslint/plugins/dvukovic.js

@@ -1,5 +1,6 @@
 import { documentTodos } from "../rules/document-todos/document-todos.js"
 import { noCommentedOutCode } from "../rules/no-commented-out-code/no-commented-out-code.js"
+import { noInstanceofError } from "../rules/no-instanceof-error/no-instanceof-error.js"
 import { noT } from "../rules/no-t/no-t.js"
 
 /** @type {import("@eslint/config-helpers").Config} */
@@ -9,6 +10,7 @@ export const dvukovic = {
             rules: {
                 "document-todos": documentTodos,
                 "no-commented-out-code": noCommentedOutCode,
+                "no-instanceof-error": noInstanceofError,
                 "no-t": noT,
             },
         },
@@ -16,6 +18,7 @@ export const dvukovic = {
     rules: {
         "dvukovic/document-todos": ["error", { url: "http" }],
         "dvukovic/no-commented-out-code": "error",
+        "dvukovic/no-instanceof-error": "error",
         "dvukovic/no-t": "error",
     },
 }

package/src/eslint/rules/no-instanceof-error/no-instanceof-error.js

@@ -0,0 +1,36 @@
+export const noInstanceofError = {
+    create(context) {
+        return {
+            BinaryExpression(node) {
+                if (
+                    node.operator === "instanceof" &&
+                    node.right.type === "Identifier" &&
+                    node.right.name === "Error"
+                ) {
+                    context.report({
+                        fix(fixer) {
+                            const leftText = context.sourceCode.getText(node.left)
+
+                            return fixer.replaceText(node, `Error.isError(${leftText})`)
+                        },
+                        messageId: "forbidden",
+                        node,
+                    })
+                }
+            },
+        }
+    },
+    meta: {
+        docs: {
+            description:
+                "Forbids `instanceof Error` in favor of `Error.isError()` which works across realms.",
+        },
+        fixable: "code",
+        messages: {
+            forbidden:
+                "Use `Error.isError()` instead of `instanceof Error`. It works across realms where `instanceof` fails.",
+        },
+        schema: [],
+        type: "problem",
+    },
+}