@dvukovic/style-guide 0.14.1 → 0.14.2

package/src/eslint/rules/document-todos/document-todos.test.js

@@ -1,174 +0,0 @@
-import { ESLint } from "eslint"
-import tseslint from "typescript-eslint"
-
-import { documentTodos } from "./document-todos.js"
-
-const createEslint = (url = "http") => {
-    return new ESLint({
-        overrideConfig: [
-            {
-                files: ["**/*.ts"],
-                languageOptions: {
-                    parser: tseslint.parser,
-                },
-                plugins: {
-                    dvukovic: {
-                        rules: {
-                            "document-todos": documentTodos,
-                        },
-                    },
-                },
-                rules: {
-                    "dvukovic/document-todos": ["error", { url }],
-                },
-            },
-        ],
-        overrideConfigFile: true,
-    })
-}
-
-describe("dvukovic/document-todos", () => {
-    test("reports TODO without URL", async () => {
-        const eslint = createEslint()
-        const code = `// TODO: fix this later\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("reports FIXME without URL", async () => {
-        const eslint = createEslint()
-        const code = `// FIXME: broken feature\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("allows TODO with URL", async () => {
-        const eslint = createEslint()
-        const code = `// TODO: fix this later https://github.com/issue/1\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("allows FIXME with URL", async () => {
-        const eslint = createEslint()
-        const code = `// FIXME: broken feature http://jira.com/123\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("allows regular comments", async () => {
-        const eslint = createEslint()
-        const code = `// This is a regular comment\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("reports lowercase todo without URL", async () => {
-        const eslint = createEslint()
-        const code = `// todo fix this later\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("reports lowercase fixme without URL", async () => {
-        const eslint = createEslint()
-        const code = `// fixme broken feature\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("reports TODO in block comments without URL", async () => {
-        const eslint = createEslint()
-        const code = `/* TODO: fix this later */\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("allows TODO in block comments with URL", async () => {
-        const eslint = createEslint()
-        const code = `/* TODO: fix this https://example.com/issue/1 */\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("uses custom URL prefix", async () => {
-        const eslint = createEslint("https://jira.example.com")
-        const code = `// TODO: fix this https://jira.example.com/PROJ-123\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("reports when URL does not match custom prefix", async () => {
-        const eslint = createEslint("https://jira.example.com")
-        const code = `// TODO: fix this https://github.com/issue/1\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("reports multiple TODO comments without URLs", async () => {
-        const eslint = createEslint()
-        const code = `// TODO: first issue\n// TODO: second issue\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/document-todos"
-        })
-
-        expect(errors?.length).toBe(2)
-    })
-})

package/src/eslint/rules/no-commented-out-code/no-commented-out-code.test.js

@@ -1,89 +0,0 @@
-import { ESLint } from "eslint"
-import tseslint from "typescript-eslint"
-
-import { dvukovic } from "../../plugins/dvukovic.js"
-
-const eslint = new ESLint({
-    overrideConfig: [
-        {
-            files: ["**/*.ts"],
-            languageOptions: {
-                parser: tseslint.parser,
-            },
-        },
-        dvukovic,
-    ],
-    overrideConfigFile: true,
-})
-
-describe("dvukovic/no-commented-out-code", () => {
-    test("detects commented-out code", async () => {
-        const code = `// const x = 1\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-commented-out-code"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("detects multi-line commented-out code", async () => {
-        const code = `// function foo() {
-//     return 1
-// }
-const y = 2
-`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-commented-out-code"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("detects block commented-out code", async () => {
-        const code = `/* const x = 1 */\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-commented-out-code"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("allows regular comments", async () => {
-        const code = `// This is a regular comment\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-commented-out-code"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("allows TODO comments", async () => {
-        const code = `// TODO: fix this later\nconst y = 2\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-commented-out-code"
-        })
-
-        expect(errors).toHaveLength(0)
-    })
-
-    test("allows region comments", async () => {
-        const code = `// #region\nconst y = 2\n// #endregion\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-commented-out-code"
-        })
-
-        expect(errors).toHaveLength(0)
-    })
-})

package/src/eslint/rules/no-restricted-dependencies/no-restricted-dependencies.test.js

@@ -1,237 +0,0 @@
-import { ESLint } from "eslint"
-import jsoncParser from "jsonc-eslint-parser"
-
-import { noRestrictedDependencies } from "./no-restricted-dependencies.js"
-
-const createEslint = (options) => {
-    return new ESLint({
-        overrideConfig: [
-            {
-                files: ["**/package.json"],
-                languageOptions: {
-                    parser: jsoncParser,
-                },
-                plugins: {
-                    custom: {
-                        rules: {
-                            "no-restricted-dependencies": noRestrictedDependencies,
-                        },
-                    },
-                },
-                rules: {
-                    "custom/no-restricted-dependencies": ["error", options],
-                },
-            },
-        ],
-        overrideConfigFile: true,
-    })
-}
-
-const getErrors = async (eslint, packageJson) => {
-    const results = await eslint.lintText(packageJson, { filePath: "package.json" })
-
-    return (
-        results[0]?.messages.filter((message) => {
-            return message.ruleId === "custom/no-restricted-dependencies"
-        }) ?? []
-    )
-}
-
-describe("no-restricted-dependencies", () => {
-    test("detects restricted package in dependencies", async () => {
-        const eslint = createEslint({ dependencies: ["lodash"] })
-        const packageJson = JSON.stringify(
-            {
-                dependencies: {
-                    lodash: "^4.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(1)
-        expect(errors[0]?.message).toContain("lodash")
-    })
-
-    test("detects restricted package in devDependencies", async () => {
-        const eslint = createEslint({ devDependencies: ["jest"] })
-        const packageJson = JSON.stringify(
-            {
-                devDependencies: {
-                    jest: "^29.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(1)
-    })
-
-    test("detects pattern with wildcard", async () => {
-        const eslint = createEslint({ devDependencies: ["@types/*"] })
-        const packageJson = JSON.stringify(
-            {
-                devDependencies: {
-                    "@types/node": "^20.0.0",
-                    "@types/react": "^18.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(2)
-    })
-
-    test("allows non-restricted packages", async () => {
-        const eslint = createEslint({ dependencies: ["lodash"] })
-        const packageJson = JSON.stringify(
-            {
-                dependencies: {
-                    react: "^18.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(0)
-    })
-
-    test("detects multiple restricted packages", async () => {
-        const eslint = createEslint({ dependencies: ["lodash", "ramda", "underscore"] })
-        const packageJson = JSON.stringify(
-            {
-                dependencies: {
-                    lodash: "^4.0.0",
-                    ramda: "^0.29.0",
-                    react: "^18.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(2)
-    })
-
-    test("handles empty options", async () => {
-        const eslint = createEslint({})
-        const packageJson = JSON.stringify(
-            {
-                dependencies: {
-                    lodash: "^4.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(0)
-    })
-
-    test("restricts @types/* in dependencies but allows in devDependencies", async () => {
-        const eslint = createEslint({ dependencies: ["@types/*"] })
-        const packageJson = JSON.stringify(
-            {
-                dependencies: {
-                    "@types/node": "^20.0.0",
-                },
-                devDependencies: {
-                    "@types/react": "^18.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(1)
-        expect(errors[0]?.message).toContain("@types/node")
-        expect(errors[0]?.message).toContain("dependencies")
-    })
-
-    test("restricts different patterns in different dependency types", async () => {
-        const eslint = createEslint({
-            dependencies: ["@types/*", "lodash"],
-            devDependencies: ["jest"],
-        })
-        const packageJson = JSON.stringify(
-            {
-                dependencies: {
-                    "@types/node": "^20.0.0",
-                    lodash: "^4.0.0",
-                },
-                devDependencies: {
-                    "@types/react": "^18.0.0",
-                    jest: "^29.0.0",
-                },
-                name: "test",
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(3)
-    })
-
-    test("restricts in peerDependencies", async () => {
-        const eslint = createEslint({ peerDependencies: ["react"] })
-        const packageJson = JSON.stringify(
-            {
-                name: "test",
-                peerDependencies: {
-                    react: "^18.0.0",
-                },
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(1)
-    })
-
-    test("restricts in optionalDependencies", async () => {
-        const eslint = createEslint({ optionalDependencies: ["fsevents"] })
-        const packageJson = JSON.stringify(
-            {
-                name: "test",
-                optionalDependencies: {
-                    fsevents: "^2.0.0",
-                },
-            },
-            null,
-            4,
-        )
-
-        const errors = await getErrors(eslint, packageJson)
-
-        expect(errors.length).toBe(1)
-    })
-})

package/src/eslint/rules/no-t/no-t.test.js

@@ -1,85 +0,0 @@
-import { ESLint } from "eslint"
-import tseslint from "typescript-eslint"
-
-import { dvukovic } from "../../plugins/dvukovic.js"
-
-const eslint = new ESLint({
-    overrideConfig: [
-        {
-            files: ["**/*.ts"],
-            languageOptions: {
-                parser: tseslint.parser,
-            },
-        },
-        dvukovic,
-    ],
-    overrideConfigFile: true,
-})
-
-describe("dvukovic/no-t", () => {
-    test("detects single-character type parameter", async () => {
-        const code = `function foo<T>(arg: T): T { return arg }\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-t"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("detects multiple single-character type parameters", async () => {
-        const code = `type Entry<K, V> = { key: K; value: V }\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-t"
-        })
-
-        expect(errors?.length).toBe(2)
-    })
-
-    test("allows descriptive type parameters", async () => {
-        const code = `function foo<Element>(arg: Element): Element { return arg }\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-t"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("allows descriptive type parameters in type alias", async () => {
-        const code = `type Entry<Key, Value> = { key: Key; value: Value }\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-t"
-        })
-
-        expect(errors?.length).toBe(0)
-    })
-
-    test("detects single-character in interface", async () => {
-        const code = `interface Container<T> { value: T }\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-t"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-
-    test("detects single-character in class", async () => {
-        const code = `class Box<T> { constructor(public value: T) {} }\n`
-
-        const results = await eslint.lintText(code, { filePath: "test.ts" })
-        const errors = results[0]?.messages.filter((message) => {
-            return message.ruleId === "dvukovic/no-t"
-        })
-
-        expect(errors?.length).toBe(1)
-    })
-})