@dvukovic/style-guide 0.13.0 → 0.14.0

package/dist/src/eslint/plugins/validate-rules.d.ts

@@ -0,0 +1 @@
+export function validatePluginRules(pluginConfig: any): void;

package/dist/src/eslint/plugins/validate-rules.test.d.ts

@@ -0,0 +1 @@
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@dvukovic/style-guide",
-    "version": "0.13.0",
+    "version": "0.14.0",
     "description": "My own style guide",
     "repository": {
         "type": "git",
@@ -109,6 +109,7 @@
         "prettier": "3.8.1",
         "release-it": "19.2.4",
         "semver": "7.7.3",
+        "storybook": "10.2.3",
         "stylelint": "16.26.1",
         "typescript": "5.9.3",
         "vitest": "4.0.18"

package/src/eslint/plugins/playwright.js

@@ -6,7 +6,7 @@ export const playwright = {
         playwright: plugin,
     },
     rules: {
-        "playwright/enforce-consistent-spacing-between-blocks": "error",
+        "playwright/consistent-spacing-between-blocks": "error",
         "playwright/expect-expect": "error",
         "playwright/max-expects": ["error", { max: 15 }],
         "playwright/max-nested-describe": ["error", { max: 4 }],

package/src/eslint/plugins/validate-rules.js

@@ -0,0 +1,33 @@
+export function validatePluginRules(pluginConfig) {
+    const { plugins, rules } = pluginConfig
+
+    if (!plugins || !rules) {
+        return
+    }
+
+    for (const ruleKey of Object.keys(rules)) {
+        const separatorIndex = ruleKey.startsWith("@")
+            ? ruleKey.indexOf("/", ruleKey.indexOf("/") + 1)
+            : ruleKey.indexOf("/")
+
+        if (separatorIndex === -1) {
+            continue
+        }
+
+        const pluginPrefix = ruleKey.slice(0, separatorIndex)
+        const ruleName = ruleKey.slice(separatorIndex + 1)
+        const plugin = plugins[pluginPrefix]
+
+        if (!plugin) {
+            throw new Error(
+                `Rule "${ruleKey}" references plugin "${pluginPrefix}" which is not in plugins`,
+            )
+        }
+
+        const pluginRules = plugin.rules ?? plugin.module?.rules
+
+        if (!pluginRules?.[ruleName]) {
+            throw new Error(`Rule "${ruleName}" does not exist in plugin "${pluginPrefix}"`)
+        }
+    }
+}

package/src/eslint/plugins/validate-rules.test.js

@@ -0,0 +1,68 @@
+import { baseline } from "./baseline.js"
+import { dvukovic } from "./dvukovic.js"
+import { eslint } from "./eslint.js"
+import { eslintComments } from "./eslint-comments.js"
+import { importX } from "./import-x.js"
+import { jest } from "./jest.js"
+import { mobx } from "./mobx.js"
+import { nodeN } from "./n.js"
+import { next } from "./next.js"
+import { packageJson } from "./package-json.js"
+import { playwright } from "./playwright.js"
+import { promise } from "./promise.js"
+import { react } from "./react.js"
+import { reactHooks } from "./react-hooks.js"
+import { rimac } from "./rimac.js"
+import { securityNode } from "./security-node.js"
+import { simpleImportSort } from "./simple-import-sort.js"
+import { sonarjs } from "./sonarjs.js"
+import { sonarjsAws } from "./sonarjs-aws.js"
+import { sortDestructureKeys } from "./sort-destructure-keys.js"
+import { sortKeysFix } from "./sort-keys-fix.js"
+import { storybook } from "./storybook.js"
+import { stylistic } from "./stylistic.js"
+import { typescriptEslint } from "./typescript-eslint.js"
+import { typescriptSortKeys } from "./typescript-sort-keys.js"
+import { unicorn } from "./unicorn.js"
+import { unusedImports } from "./unused-imports.js"
+import { validatePluginRules } from "./validate-rules.js"
+import { vitest } from "./vitest.js"
+
+const allPlugins = {
+    baseline,
+    dvukovic,
+    eslint,
+    eslintComments,
+    importX,
+    jest,
+    mobx,
+    next,
+    nodeN,
+    packageJson,
+    playwright,
+    promise,
+    react,
+    reactHooks,
+    rimac,
+    securityNode,
+    simpleImportSort,
+    sonarjs,
+    sonarjsAws,
+    sortDestructureKeys,
+    sortKeysFix,
+    storybook,
+    stylistic,
+    typescriptEslint,
+    typescriptSortKeys,
+    unicorn,
+    unusedImports,
+    vitest,
+}
+
+describe("plugin rules", () => {
+    for (const [name, config] of Object.entries(allPlugins)) {
+        test(`${name} has no invalid rules`, () => {
+            validatePluginRules(config)
+        })
+    }
+})

package/src/eslint/plugins/vitest.js

@@ -65,6 +65,7 @@ export const vitest = {
         "@vitest/prefer-hooks-on-top": "error",
         "@vitest/prefer-lowercase-title": "error",
         "@vitest/prefer-mock-promise-shorthand": "error",
+        "@vitest/prefer-mock-return-shorthand": "error",
         "@vitest/prefer-spy-on": "error",
         "@vitest/prefer-strict-boolean-matchers": "error",
         "@vitest/prefer-strict-equal": "error",
@@ -75,7 +76,6 @@ export const vitest = {
         "@vitest/prefer-todo": "error",
         "@vitest/prefer-vi-mocked": "error",
         "@vitest/require-awaited-expect-poll": "error",
-        "@vitest/require-import-vi-mock": "error",
         "@vitest/require-mock-type-parameters": [
             "error",
             {
@@ -93,7 +93,6 @@ export const vitest = {
         "@vitest/valid-expect": "error",
         "@vitest/valid-expect-in-promise": "error",
         "@vitest/valid-title": "error",
-        "@vitest/vitest/prefer-mock-return-shorthand": "error",
         "@vitest/warn-todo": "warn",
     },
 }