@dvsa/cvs-feature-flags 1.1.0-canary.6 → 2.0.0

package/feature-flags.d.ts

@@ -1,2 +1,2 @@
 import { FeatureFlagsClientName } from './';
-export declare const getFeatureFlags: <T>(clientName: FeatureFlagsClientName, email?: string) => Promise<T>;
+export declare const getFeatureFlags: <T>(clientName: FeatureFlagsClientName) => Promise<T>;

package/feature-flags.js

@@ -3,47 +3,20 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getFeatureFlags = void 0;
 const appconfig_1 = require("@aws-lambda-powertools/parameters/appconfig");
 const config_1 = require("./config");
-function hasEmails(flag) {
-    return typeof flag === 'object' && flag !== null && Array.isArray(flag.emails);
-}
-function resolveVariants(config, email) {
-    const resolved = {};
-    for (const [key, value] of Object.entries(config)) {
-        if (!hasEmails(value)) {
-            resolved[key] = value;
-            continue;
-        }
-        const { emails, ...flagValues } = value;
-        if (!emails || (emails && Array.isArray(emails) && emails.length === 0)) {
-            resolved[key] = flagValues;
-            continue;
-        }
-        const normalisedEmail = email?.toLowerCase();
-        console.log('got emails', { emails, normalisedEmail });
-        const isTargeted = normalisedEmail && emails.map((e) => e.toLowerCase()).includes(normalisedEmail);
-        console.log('isTargeted', isTargeted);
-        resolved[key] = isTargeted ? flagValues : { ...flagValues, enabled: false };
-    }
-    console.log('Resolving Variants', { resolved });
-    return resolved;
-}
+// When instantiating the feature flags, we should be scoping this and caching it to the invocation instance.
+// Each invocation of a lambda will get new feature flags, and that should not change throughout the lambda lifecycle.
+// However, we don't want to cache them across invocations (ie outside the handler).
 class FeatureFlagsClient {
-    async get(clientName, email) {
-        const conf = email ? { ...config_1.defaultFeatureFlagConfig, maxAge: 0 } : config_1.defaultFeatureFlagConfig;
-        const config = await (0, appconfig_1.getAppConfig)(`${clientName}-profile`, {
-            ...conf,
+    async get(clientName) {
+        const featureFlags = await (0, appconfig_1.getAppConfig)(`${clientName}-profile`, {
+            ...config_1.defaultFeatureFlagConfig,
             transform: 'json',
         });
-        if (!email) {
-            console.log('no email returning config', { config });
-            return config;
-        }
-        console.log('Try to resolve variant', { config, email });
-        return resolveVariants(config, email);
+        return featureFlags;
     }
 }
-const getFeatureFlags = async (clientName, email) => {
+const getFeatureFlags = async (clientName) => {
     const client = new FeatureFlagsClient();
-    return await client.get(clientName, email);
+    return await client.get(clientName);
 };
 exports.getFeatureFlags = getFeatureFlags;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dvsa/cvs-feature-flags",
-  "version": "1.1.0-canary.6",
+  "version": "2.0.0",
   "description": "Common package to be used in CVS to manage feature flags",
   "author": "DVSA",
   "license": "ISC",

package/profiles/vta.d.ts

@@ -7,5 +7,5 @@ declare const defaultFeatureFlags: {
     };
 };
 export type FeatureFlags = typeof defaultFeatureFlags;
-export declare const getProfile: (email?: string) => Promise<FeatureFlags>;
+export declare const getProfile: () => Promise<FeatureFlags>;
 export {};

package/profiles/vta.js

@@ -15,8 +15,8 @@ const defaultFeatureFlags = {
         enabled: false,
     },
 };
-const getProfile = async (email) => {
-    const flags = await (0, feature_flags_1.getFeatureFlags)(__1.FeatureFlagsClientName.VTA, email);
+const getProfile = async () => {
+    const flags = await (0, feature_flags_1.getFeatureFlags)(__1.FeatureFlagsClientName.VTA);
     return (0, lodash_merge_1.default)(defaultFeatureFlags, flags);
 };
 exports.getProfile = getProfile;

package/profiles/vtm.d.ts

@@ -1,4 +1,4 @@
 declare const defaultFeatureFlags: {};
 export type FeatureFlags = typeof defaultFeatureFlags;
-export declare const getProfile: (email?: string) => Promise<{}>;
+export declare const getProfile: () => Promise<{}>;
 export {};

package/profiles/vtm.js

@@ -8,8 +8,8 @@ const lodash_merge_1 = __importDefault(require("lodash.merge"));
 const __1 = require("..");
 const feature_flags_1 = require("../feature-flags");
 const defaultFeatureFlags = {};
-const getProfile = async (email) => {
-    const flags = await (0, feature_flags_1.getFeatureFlags)(__1.FeatureFlagsClientName.VTM, email);
+const getProfile = async () => {
+    const flags = await (0, feature_flags_1.getFeatureFlags)(__1.FeatureFlagsClientName.VTM);
     return (0, lodash_merge_1.default)(defaultFeatureFlags, flags);
 };
 exports.getProfile = getProfile;

package/profiles/vtx.d.ts

@@ -1,22 +1,7 @@
 declare const defaultFeatureFlags: {
-    welshTranslation: {
-        enabled: boolean;
-        translatePassTestResult: boolean;
-        translateFailTestResult: boolean;
-        translatePrsTestResult: boolean;
-    };
-    issueDocsCentrally: {
-        enabled: boolean;
-    };
     recallsApi: {
         enabled: boolean;
     };
-    automatedCt: {
-        enabled: boolean;
-    };
-    abandonedCerts: {
-        enabled: boolean;
-    };
     specialistDefects: {
         enabled: boolean;
         adasImNumbers: number[];
@@ -71,5 +56,5 @@ declare const defaultFeatureFlags: {
     };
 };
 export type FeatureFlags = typeof defaultFeatureFlags;
-export declare const getProfile: (email?: string) => Promise<FeatureFlags>;
+export declare const getProfile: () => Promise<FeatureFlags>;
 export {};

package/profiles/vtx.js

@@ -8,24 +8,9 @@ const lodash_merge_1 = __importDefault(require("lodash.merge"));
 const __1 = require("..");
 const feature_flags_1 = require("../feature-flags");
 const defaultFeatureFlags = {
-    welshTranslation: {
-        enabled: true,
-        translatePassTestResult: true,
-        translateFailTestResult: true,
-        translatePrsTestResult: true,
-    },
-    issueDocsCentrally: {
-        enabled: true,
-    },
     recallsApi: {
         enabled: true,
     },
-    automatedCt: {
-        enabled: false,
-    },
-    abandonedCerts: {
-        enabled: true,
-    },
     specialistDefects: {
         enabled: false,
         adasImNumbers: [29],
@@ -80,8 +65,8 @@ const defaultFeatureFlags = {
         reporting: false,
     },
 };
-const getProfile = async (email) => {
-    const flags = await (0, feature_flags_1.getFeatureFlags)(__1.FeatureFlagsClientName.VTX, email);
+const getProfile = async () => {
+    const flags = await (0, feature_flags_1.getFeatureFlags)(__1.FeatureFlagsClientName.VTX);
     return (0, lodash_merge_1.default)(defaultFeatureFlags, flags);
 };
 exports.getProfile = getProfile;