@duke-dsh-plugins/dsh-agent-approval 1.4.0 → 1.4.2

package/client.js

@@ -353,6 +353,19 @@ window.__ModuleLoader__.load({
         return typeof s === "string" && s.length > n ? s.slice(0, n) + "…" : s || "";
       }
 
+      /**
+        Mirror of Host `shortId()`: DSH prefixes session ids with the literal
+        `"session-"` before the UUID, so a naive `slice(0, 8)` shows nothing
+        but `"session-"`. Strip the known prefix so the chip displays 8 chars
+        of the UUID proper. Kept here too because the bundle has no shared
+        module with the Host half.
+      */
+      function shortSessionId(id) {
+        const s = String(id);
+        const tail = s.indexOf("session-") === 0 ? s.slice("session-".length) : s;
+        return tail.slice(0, 8);
+      }
+
       function fmtTime(iso) {
         try {
           const d = new Date(iso);
@@ -624,16 +637,17 @@ window.__ModuleLoader__.load({
                       const cwd = typeof info.cwd === "string" && info.cwd !== "" ? info.cwd : "";
                       const tip =
                         "会话 ID：" + sid + (cwd !== "" ? "\n工作区：" + cwd : "");
+                      const sidShort = shortSessionId(sid);
                       return h(
                         "span",
                         { key: sid, className: "aapr-chip", title: tip },
                         h(
                           "span",
                           { className: "aapr-chip-title" },
-                          title !== "" ? title : sid.slice(0, 8),
+                          title !== "" ? title : sidShort,
                         ),
                         title !== ""
-                          ? h("span", { className: "aapr-chip-id" }, sid.slice(0, 8))
+                          ? h("span", { className: "aapr-chip-id" }, sidShort)
                           : null,
                         h(
                           "button",

package/index.js

@@ -145,9 +145,22 @@ function trunc(value, n) {
   return value.length > n ? value.slice(0, n) + "…[truncated]" : value;
 }
 
-/** First 8 chars of a session id (display form in records and chips). */
+/**
+ * First 8 chars of a session / run id (display form in records and chips).
+ * DSH prefixes session ids with the literal `"session-"` before the UUID
+ * (see `@deepseek-ai/dsh-host-apiproxy` `session create` and
+ * `@deepseek-ai/dsh-headless` SessionId(`session-${randomUUID()}`)); a naive
+ * `slice(0, 8)` lands on that meaningless 8-char prefix and every audit row
+ * shows nothing but `"session-"`. Strip the known prefix before truncating
+ * so the displayed fragment comes from the UUID proper (where the real
+ * discriminator lives); id shapes without the prefix (subagent `run.id`
+ * = raw `randomUUID()`) are unaffected.
+ */
+const SESSION_ID_PREFIX = "session-";
 function shortId(id) {
-  return String(id).slice(0, 8);
+  const s = String(id);
+  const tail = s.startsWith(SESSION_ID_PREFIX) ? s.slice(SESSION_ID_PREFIX.length) : s;
+  return tail.slice(0, 8);
 }
 
 /** Best-effort error text. */
@@ -325,9 +338,26 @@ export class AgentApprovalService extends TypertRemoteService {
 
   // ---- knob plumbing --------------------------------------------------------
 
+  /**
+   * The session's durable events as a plain readonly array. DSH 0.1.2-rc.1
+   * removed the public `session.events` snapshot array in favor of
+   * `snapshotEvents(from?, to?)` / `eventAt(seq)` / `seq` — reading the old
+   * field yields undefined and every fold below threw TypeError, which the
+   * listeners' try/catch swallowed, so no session could ever enter `_enabled`
+   * (every escalation fell through to the human answerer). Prefer the new
+   * accessor; fall back to the legacy array on 0.1.1.
+   */
+  _eventsOf(session) {
+    if (session && typeof session.snapshotEvents === "function") {
+      return session.snapshotEvents();
+    }
+    const legacy = session ? session.events : undefined;
+    return Array.isArray(legacy) ? legacy : [];
+  }
+
   /** Last `sandbox/mode` / `approval/policy` value in the session log fold. */
   _lastKnob(session, type, field) {
-    const events = session.events;
+    const events = this._eventsOf(session);
     for (let i = events.length - 1; i >= 0; i--) {
       const e = events[i];
       if (e.type === type) return e.data[field];
@@ -670,7 +700,7 @@ export class AgentApprovalService extends TypertRemoteService {
   /** Read the exact tool-call arguments JSON from the session log by callId. */
   _callArgsOf(session, callId) {
     if (callId === undefined) return undefined;
-    const events = session.events;
+    const events = this._eventsOf(session);
     for (let i = events.length - 1; i >= 0; i--) {
       const e = events[i];
       if (e.type === "tool/call" && e.data.callId === callId) return e.data.arguments;
@@ -688,7 +718,7 @@ export class AgentApprovalService extends TypertRemoteService {
    * the requesting agent phrased its justification.
    */
   _recentUserContext(session) {
-    const events = session.events;
+    const events = this._eventsOf(session);
     let first = "";
     const last = []; // chronological, capped at 3
     for (let i = 0; i < events.length; i++) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@duke-dsh-plugins/dsh-agent-approval",
-  "version": "1.4.0",
+  "version": "1.4.2",
   "description": "Agent-decided approvals for DeepSeek Harness: a workspace-write base permission mode where an independent approval subagent judges every sandbox escalation (risky operations are rejected), with a configurable approval model and an audit log in Settings.",
   "repository": {
     "type": "git",