@dudousxd/nestjs-agent-telescope 0.8.0 → 0.8.2

package/dist/index.d.cts

@@ -122,13 +122,19 @@ declare class RagTelescopeWatcher implements Watcher {
 /**
  * The "Agent" overview dashboard. Panels bind to the `agent.*` data providers.
  *
- * `threadHref` is a URL template for deep-linking a `{threadId}` cell out to the HOST's own thread
- * viewer (e.g. the standalone `@dudousxd/nestjs-agent-dashboard` SPA) — omitted by default (no
- * internal thread view exists), passed straight through when the host supplies one. `runHref` deep-
- * links a `{runId}` cell to the trace waterfall — defaults to {@link DEFAULT_TRACE_HREF} (the
- * in-app route), so a `runId` column works out of the box with no host option needed; a host may
- * still override it. Every table whose rows carry a `threadId`/`runId` gets a `Column.link` for it
- * (via {@link col}); `threadHref` left unset leaves that column plain text.
+ * `threadHref` and `runHref` are URL templates for deep-linking a `{threadId}` / `{runId}` cell out
+ * to the HOST's own viewer (e.g. the standalone `@dudousxd/nestjs-agent-dashboard` SPA). Both are
+ * omitted by default, and a cell whose template is unset renders as plain text.
+ *
+ * `runHref` used to default to `'#/traces/{runId}'`, and that default could only 404. Telescope's
+ * trace waterfall is keyed by **`traceId`** — `LinkSpec`'s doc says so, and `TracesService`
+ * resolves it with `storage.get({ traceId })` — while an agent's `runId` is a different identifier
+ * that {@link import('./agent-telescope.watcher.js').AgentTelescopeWatcher} never ties to one: it
+ * records `type: 'agent'` entries and stamps no trace at all. So every `Run` cell on the shipped
+ * dashboard pointed at a trace that does not exist, and clicking one answered
+ * `404 · No entries for trace <runId>`. Substituting the wrong key into a route that had been read
+ * correctly is the whole bug — hence no default here. A host that has a run viewer passes its own
+ * template; one that does not gets plain text, which is honest.
  *
  * Layout: eight sections (Overview lean; Spend; Reliability; Activity; Approvals; Tools;
  * Retrieval; Retrieval sources), each sized so its panel count is an exact multiple of its `cols` —

package/dist/index.d.ts

@@ -122,13 +122,19 @@ declare class RagTelescopeWatcher implements Watcher {
 /**
  * The "Agent" overview dashboard. Panels bind to the `agent.*` data providers.
  *
- * `threadHref` is a URL template for deep-linking a `{threadId}` cell out to the HOST's own thread
- * viewer (e.g. the standalone `@dudousxd/nestjs-agent-dashboard` SPA) — omitted by default (no
- * internal thread view exists), passed straight through when the host supplies one. `runHref` deep-
- * links a `{runId}` cell to the trace waterfall — defaults to {@link DEFAULT_TRACE_HREF} (the
- * in-app route), so a `runId` column works out of the box with no host option needed; a host may
- * still override it. Every table whose rows carry a `threadId`/`runId` gets a `Column.link` for it
- * (via {@link col}); `threadHref` left unset leaves that column plain text.
+ * `threadHref` and `runHref` are URL templates for deep-linking a `{threadId}` / `{runId}` cell out
+ * to the HOST's own viewer (e.g. the standalone `@dudousxd/nestjs-agent-dashboard` SPA). Both are
+ * omitted by default, and a cell whose template is unset renders as plain text.
+ *
+ * `runHref` used to default to `'#/traces/{runId}'`, and that default could only 404. Telescope's
+ * trace waterfall is keyed by **`traceId`** — `LinkSpec`'s doc says so, and `TracesService`
+ * resolves it with `storage.get({ traceId })` — while an agent's `runId` is a different identifier
+ * that {@link import('./agent-telescope.watcher.js').AgentTelescopeWatcher} never ties to one: it
+ * records `type: 'agent'` entries and stamps no trace at all. So every `Run` cell on the shipped
+ * dashboard pointed at a trace that does not exist, and clicking one answered
+ * `404 · No entries for trace <runId>`. Substituting the wrong key into a route that had been read
+ * correctly is the whole bug — hence no default here. A host that has a run viewer passes its own
+ * template; one that does not gets plain text, which is honest.
  *
  * Layout: eight sections (Overview lean; Spend; Reliability; Activity; Approvals; Tools;
  * Retrieval; Retrieval sources), each sized so its panel count is an exact multiple of its `cols` —

package/dist/index.js

@@ -18,9 +18,8 @@ function col(key, label, href) {
   };
 }
 __name(col, "col");
-var DEFAULT_TRACE_HREF = "#/traces/{runId}";
 function agentDashboard(opts = {}) {
-  const runHref = opts.runHref ?? DEFAULT_TRACE_HREF;
+  const runHref = opts.runHref;
   return {
     id: "agent.overview",
     label: "Agent",
@@ -1086,9 +1085,15 @@ function agentRunsTrendProvider() {
 __name(agentRunsTrendProvider, "agentRunsTrendProvider");
 var DEFAULT_RECENT_LIMIT = 50;
 var MAX_RECENT_LIMIT = 500;
+function readPositiveNumber(raw) {
+  if (typeof raw === "number") return Number.isFinite(raw) && raw > 0 ? raw : void 0;
+  if (typeof raw !== "string" || raw.trim() === "") return void 0;
+  const parsed = Number(raw);
+  return Number.isFinite(parsed) && parsed > 0 ? parsed : void 0;
+}
+__name(readPositiveNumber, "readPositiveNumber");
 function resolveLimit(query, fallback) {
-  const raw = query?.limit;
-  const value = typeof raw === "number" && Number.isFinite(raw) ? raw : fallback;
+  const value = readPositiveNumber(query?.limit) ?? fallback;
   return Math.min(MAX_RECENT_LIMIT, Math.max(1, Math.trunc(value)));
 }
 __name(resolveLimit, "resolveLimit");
@@ -1104,8 +1109,7 @@ function governanceLimitProvider(name, defaultLimit, fetch, format) {
 }
 __name(governanceLimitProvider, "governanceLimitProvider");
 function resolvePage(query) {
-  const raw = query?.page;
-  const value = typeof raw === "number" && Number.isFinite(raw) ? raw : 1;
+  const value = readPositiveNumber(query?.page) ?? 1;
   return Math.max(1, Math.trunc(value));
 }
 __name(resolvePage, "resolvePage");