@ductape/sdk 0.2.25 → 0.3.0

package/dist/features/feature-control-flow.validator.d.ts

@@ -0,0 +1,8 @@
+export type FeatureControlFlowMode = 'portable' | 'legacy';
+export interface FeatureControlFlowDiagnostic {
+    code: string;
+    message: string;
+    line: number;
+    column: number;
+}
+export declare function inspectFeatureHandlerControlFlow(source: string, mode?: FeatureControlFlowMode): FeatureControlFlowDiagnostic[];

package/dist/features/feature-control-flow.validator.js

@@ -0,0 +1,108 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.inspectFeatureHandlerControlFlow = inspectFeatureHandlerControlFlow;
+const parser_1 = require("@babel/parser");
+const NATIVE_BRANCH_NODES = new Map([
+    ['IfStatement', ['FEATURE_NATIVE_IF', 'Use ctx.branch(ctx.when.*, { then, else }) instead of a native if statement.']],
+    ['ConditionalExpression', ['FEATURE_NATIVE_TERNARY', 'Use ctx.branch() instead of a native ternary expression.']],
+    ['SwitchStatement', ['FEATURE_NATIVE_SWITCH', 'Use explicit ctx.branch() paths instead of a native switch statement.']],
+    ['ForStatement', ['FEATURE_NATIVE_LOOP', 'Move runtime-sized iteration into ctx.functions instead of a native loop.']],
+    ['ForInStatement', ['FEATURE_NATIVE_LOOP', 'Move runtime-sized iteration into ctx.functions instead of a native loop.']],
+    ['ForOfStatement', ['FEATURE_NATIVE_LOOP', 'Move runtime-sized iteration into ctx.functions instead of a native loop.']],
+    ['WhileStatement', ['FEATURE_NATIVE_LOOP', 'Move runtime-sized iteration into ctx.functions instead of a native loop.']],
+    ['DoWhileStatement', ['FEATURE_NATIVE_LOOP', 'Move runtime-sized iteration into ctx.functions instead of a native loop.']],
+]);
+const COLLECTION_METHODS = new Set([
+    'map', 'filter', 'find', 'findIndex', 'some', 'every', 'reduce', 'reduceRight', 'forEach',
+]);
+function memberName(node) {
+    var _a, _b;
+    if (!node || (node.type !== 'MemberExpression' && node.type !== 'OptionalMemberExpression'))
+        return undefined;
+    if (!node.computed && ((_a = node.property) === null || _a === void 0 ? void 0 : _a.type) === 'Identifier')
+        return node.property.name;
+    if (node.computed && ((_b = node.property) === null || _b === void 0 ? void 0 : _b.type) === 'StringLiteral')
+        return node.property.value;
+    return undefined;
+}
+function isMemberPath(node, objectName, propertyName) {
+    var _a;
+    return ((node === null || node === void 0 ? void 0 : node.type) === 'MemberExpression' || (node === null || node === void 0 ? void 0 : node.type) === 'OptionalMemberExpression') &&
+        ((_a = node.object) === null || _a === void 0 ? void 0 : _a.type) === 'Identifier' && node.object.name === objectName &&
+        memberName(node) === propertyName;
+}
+function diagnostic(node, code, message) {
+    var _a, _b, _c, _d;
+    return { code, message, line: (_b = (_a = node.loc) === null || _a === void 0 ? void 0 : _a.start.line) !== null && _b !== void 0 ? _b : 1, column: ((_d = (_c = node.loc) === null || _c === void 0 ? void 0 : _c.start.column) !== null && _d !== void 0 ? _d : 0) + 1 };
+}
+function inspectFeatureHandlerControlFlow(source, mode = 'portable') {
+    var _a;
+    let root;
+    try {
+        root = (0, parser_1.parseExpression)(`(${source})`, { sourceType: 'module', plugins: ['typescript'] });
+    }
+    catch (firstError) {
+        try {
+            const wrapper = (0, parser_1.parseExpression)(`({${source}})`, { sourceType: 'module', plugins: ['typescript'] });
+            root = (_a = wrapper.properties) === null || _a === void 0 ? void 0 : _a[0];
+        }
+        catch (_b) {
+            return [{
+                    code: 'FEATURE_HANDLER_PARSE_ERROR',
+                    message: `Feature handler source could not be parsed: ${firstError instanceof Error ? firstError.message : String(firstError)}`,
+                    line: 1,
+                    column: 1,
+                }];
+        }
+    }
+    const diagnostics = [];
+    const seen = new Set();
+    const add = (node, code, message) => {
+        const item = diagnostic(node, code, message);
+        const key = `${item.code}:${item.line}:${item.column}`;
+        if (!seen.has(key)) {
+            seen.add(key);
+            diagnostics.push(item);
+        }
+    };
+    const visit = (node) => {
+        var _a;
+        if (!node || typeof node !== 'object')
+            return;
+        if (mode === 'portable') {
+            const native = NATIVE_BRANCH_NODES.get(node.type);
+            if (native)
+                add(node, native[0], native[1]);
+            if (node.type === 'LogicalExpression') {
+                add(node, 'FEATURE_NATIVE_LOGICAL_BRANCH', `Native "${node.operator}" short-circuiting is evaluated while recording. Use ctx.branch(), ctx.when, or ctx.default().`);
+            }
+            if ((node.type === 'CallExpression' || node.type === 'OptionalCallExpression') &&
+                COLLECTION_METHODS.has((_a = memberName(node.callee)) !== null && _a !== void 0 ? _a : '')) {
+                add(node, 'FEATURE_NATIVE_COLLECTION_CONTROL_FLOW', `Native .${memberName(node.callee)}() is not portable runtime collection logic. Use ctx.functions instead.`);
+            }
+        }
+        if (node.type === 'CallExpression' || node.type === 'OptionalCallExpression') {
+            if (isMemberPath(node.callee, 'Date', 'now'))
+                add(node, 'FEATURE_HOST_TIME', 'Use ctx.transform.now() instead of Date.now().');
+            if (isMemberPath(node.callee, 'Math', 'random'))
+                add(node, 'FEATURE_HOST_RANDOM', 'Use a portable function or reusable action instead of Math.random().');
+            if (memberName(node.callee) === 'randomUUID')
+                add(node, 'FEATURE_HOST_UUID', 'Use ctx.transform.uuid() instead of a host crypto API.');
+        }
+        if ((node.type === 'MemberExpression' || node.type === 'OptionalMemberExpression') &&
+            isMemberPath(node.object, 'process', 'env')) {
+            add(node, 'FEATURE_HOST_ENVIRONMENT', 'Do not read process.env while recording. Use Ductape variables, constants, secrets, or runtime function configuration.');
+        }
+        for (const [key, value] of Object.entries(node)) {
+            if (key === 'loc' || key === 'start' || key === 'end' || key === 'extra')
+                continue;
+            if (Array.isArray(value))
+                value.forEach(visit);
+            else if (value && typeof value === 'object')
+                visit(value);
+        }
+    };
+    visit(root);
+    return diagnostics.sort((a, b) => a.line - b.line || a.column - b.column || a.code.localeCompare(b.code));
+}
+//# sourceMappingURL=feature-control-flow.validator.js.map

package/dist/features/feature-control-flow.validator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"feature-control-flow.validator.js","sourceRoot":"","sources":["../../src/features/feature-control-flow.validator.ts"],"names":[],"mappings":";;AA2CA,4EAqEC;AAhHD,0CAAgD;AAWhD,MAAM,mBAAmB,GAAG,IAAI,GAAG,CAA2B;IAC5D,CAAC,aAAa,EAAE,CAAC,mBAAmB,EAAE,8EAA8E,CAAC,CAAC;IACtH,CAAC,uBAAuB,EAAE,CAAC,wBAAwB,EAAE,0DAA0D,CAAC,CAAC;IACjH,CAAC,iBAAiB,EAAE,CAAC,uBAAuB,EAAE,uEAAuE,CAAC,CAAC;IACvH,CAAC,cAAc,EAAE,CAAC,qBAAqB,EAAE,2EAA2E,CAAC,CAAC;IACtH,CAAC,gBAAgB,EAAE,CAAC,qBAAqB,EAAE,2EAA2E,CAAC,CAAC;IACxH,CAAC,gBAAgB,EAAE,CAAC,qBAAqB,EAAE,2EAA2E,CAAC,CAAC;IACxH,CAAC,gBAAgB,EAAE,CAAC,qBAAqB,EAAE,2EAA2E,CAAC,CAAC;IACxH,CAAC,kBAAkB,EAAE,CAAC,qBAAqB,EAAE,2EAA2E,CAAC,CAAC;CAC3H,CAAC,CAAC;AAEH,MAAM,kBAAkB,GAAG,IAAI,GAAG,CAAC;IACjC,KAAK,EAAE,QAAQ,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,EAAE,OAAO,EAAE,QAAQ,EAAE,aAAa,EAAE,SAAS;CAC1F,CAAC,CAAC;AAEH,SAAS,UAAU,CAAC,IAAS;;IAC3B,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,kBAAkB,IAAI,IAAI,CAAC,IAAI,KAAK,0BAA0B,CAAC;QAAE,OAAO,SAAS,CAAC;IAC9G,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,CAAA,MAAA,IAAI,CAAC,QAAQ,0CAAE,IAAI,MAAK,YAAY;QAAE,OAAO,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC;IACtF,IAAI,IAAI,CAAC,QAAQ,IAAI,CAAA,MAAA,IAAI,CAAC,QAAQ,0CAAE,IAAI,MAAK,eAAe;QAAE,OAAO,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC;IACzF,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,YAAY,CAAC,IAAS,EAAE,UAAkB,EAAE,YAAoB;;IACvE,OAAO,CAAC,CAAA,IAAI,aAAJ,IAAI,uBAAJ,IAAI,CAAE,IAAI,MAAK,kBAAkB,IAAI,CAAA,IAAI,aAAJ,IAAI,uBAAJ,IAAI,CAAE,IAAI,MAAK,0BAA0B,CAAC;QACrF,CAAA,MAAA,IAAI,CAAC,MAAM,0CAAE,IAAI,MAAK,YAAY,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,UAAU;QACrE,UAAU,CAAC,IAAI,CAAC,KAAK,YAAY,CAAC;AACtC,CAAC;AAED,SAAS,UAAU,CAAC,IAAS,EAAE,IAAY,EAAE,OAAe;;IAC1D,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,EAAE,MAAA,MAAA,IAAI,CAAC,GAAG,0CAAE,KAAK,CAAC,IAAI,mCAAI,CAAC,EAAE,MAAM,EAAE,CAAC,MAAA,MAAA,IAAI,CAAC,GAAG,0CAAE,KAAK,CAAC,MAAM,mCAAI,CAAC,CAAC,GAAG,CAAC,EAAE,CAAC;AACvG,CAAC;AAED,SAAgB,gCAAgC,CAC9C,MAAc,EACd,OAA+B,UAAU;;IAEzC,IAAI,IAAS,CAAC;IACd,IAAI,CAAC;QACH,IAAI,GAAG,IAAA,wBAAe,EAAC,IAAI,MAAM,GAAG,EAAE,EAAE,UAAU,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC;IAC3F,CAAC;IAAC,OAAO,UAAU,EAAE,CAAC;QACpB,IAAI,CAAC;YACH,MAAM,OAAO,GAAQ,IAAA,wBAAe,EAAC,KAAK,MAAM,IAAI,EAAE,EAAE,UAAU,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC;YACzG,IAAI,GAAG,MAAA,OAAO,CAAC,UAAU,0CAAG,CAAC,CAAC,CAAC;QACjC,CAAC;QAAC,WAAM,CAAC;YACP,OAAO,CAAC;oBACN,IAAI,EAAE,6BAA6B;oBACnC,OAAO,EAAE,+CAA+C,UAAU,YAAY,KAAK,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,UAAU,CAAC,EAAE;oBAC/H,IAAI,EAAE,CAAC;oBACP,MAAM,EAAE,CAAC;iBACV,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,MAAM,WAAW,GAAmC,EAAE,CAAC;IACvD,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,MAAM,GAAG,GAAG,CAAC,IAAS,EAAE,IAAY,EAAE,OAAe,EAAE,EAAE;QACvD,MAAM,IAAI,GAAG,UAAU,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;QAC7C,MAAM,GAAG,GAAG,GAAG,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,EAAE,CAAC;QACvD,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;YACnB,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;YACd,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACzB,CAAC;IACH,CAAC,CAAC;IAEF,MAAM,KAAK,GAAG,CAAC,IAAS,EAAE,EAAE;;QAC1B,IAAI,CAAC,IAAI,IAAI,OAAO,IAAI,KAAK,QAAQ;YAAE,OAAO;QAE9C,IAAI,IAAI,KAAK,UAAU,EAAE,CAAC;YACxB,MAAM,MAAM,GAAG,mBAAmB,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClD,IAAI,MAAM;gBAAE,GAAG,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;YAC5C,IAAI,IAAI,CAAC,IAAI,KAAK,mBAAmB,EAAE,CAAC;gBACtC,GAAG,CAAC,IAAI,EAAE,+BAA+B,EACvC,WAAW,IAAI,CAAC,QAAQ,gGAAgG,CAAC,CAAC;YAC9H,CAAC;YACD,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,gBAAgB,IAAI,IAAI,CAAC,IAAI,KAAK,wBAAwB,CAAC;gBAC1E,kBAAkB,CAAC,GAAG,CAAC,MAAA,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,mCAAI,EAAE,CAAC,EAAE,CAAC;gBAC1D,GAAG,CAAC,IAAI,EAAE,wCAAwC,EAChD,WAAW,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,yEAAyE,CAAC,CAAC;YACjH,CAAC;QACH,CAAC;QAED,IAAI,IAAI,CAAC,IAAI,KAAK,gBAAgB,IAAI,IAAI,CAAC,IAAI,KAAK,wBAAwB,EAAE,CAAC;YAC7E,IAAI,YAAY,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,KAAK,CAAC;gBAAE,GAAG,CAAC,IAAI,EAAE,mBAAmB,EAAE,gDAAgD,CAAC,CAAC;YAC/H,IAAI,YAAY,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,CAAC;gBAAE,GAAG,CAAC,IAAI,EAAE,qBAAqB,EAAE,sEAAsE,CAAC,CAAC;YAC1J,IAAI,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,YAAY;gBAAE,GAAG,CAAC,IAAI,EAAE,mBAAmB,EAAE,wDAAwD,CAAC,CAAC;QACzI,CAAC;QACD,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,kBAAkB,IAAI,IAAI,CAAC,IAAI,KAAK,0BAA0B,CAAC;YAC9E,YAAY,CAAC,IAAI,CAAC,MAAM,EAAE,SAAS,EAAE,KAAK,CAAC,EAAE,CAAC;YAChD,GAAG,CAAC,IAAI,EAAE,0BAA0B,EAClC,wHAAwH,CAAC,CAAC;QAC9H,CAAC;QAED,KAAK,MAAM,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;YAChD,IAAI,GAAG,KAAK,KAAK,IAAI,GAAG,KAAK,OAAO,IAAI,GAAG,KAAK,KAAK,IAAI,GAAG,KAAK,OAAO;gBAAE,SAAS;YACnF,IAAI,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC;gBAAE,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;iBAC1C,IAAI,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ;gBAAE,KAAK,CAAC,KAAK,CAAC,CAAC;QAC5D,CAAC;IACH,CAAC,CAAC;IAEF,KAAK,CAAC,IAAI,CAAC,CAAC;IACZ,OAAO,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,MAAM,GAAG,CAAC,CAAC,MAAM,IAAI,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC;AAC5G,CAAC"}

package/dist/features/features.service.js

@@ -47,6 +47,7 @@ var _a, _b;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.featureService = exports.FeatureCompilationError = exports.FeatureService = exports.FeatureError = void 0;
 const crypto_1 = require("crypto");
+const feature_control_flow_validator_1 = require("./feature-control-flow.validator");
 const functions_1 = require("../functions");
 const products_service_1 = __importDefault(require("../products/services/products.service"));
 const processor_service_1 = __importDefault(require("../processor/services/processor.service"));
@@ -2519,16 +2520,16 @@ class FeatureCompiler {
         this.options = options;
     }
     validatePortableControlFlow() {
-        const source = this.options.handler.toString();
-        if (/\bDate\s*\.\s*now\s*\(/.test(source) || /\bMath\s*\.\s*random\s*\(/.test(source)) {
-            throw new FeatureCompilationError(this.options.tag, '(handler)', 'Date.now() and Math.random() run while the Feature is being compiled and would become frozen literals. ' +
-                'Use ctx.transform.now() for the current runtime timestamp. Generate random or unique values through a portable function or reusable action.');
-        }
-        const containsNullishBranch = /\?\?/.test(source) ||
-            /!==\s*null\s*&&[\s\S]{0,300}!==\s*void\s+0/.test(source);
-        if (containsNullishBranch && !this.options.branchOverrides) {
-            throw new FeatureCompilationError(this.options.tag, '(handler)', 'Nullish branching on a step result cannot be inferred safely. Provide branchOverrides for the step output that records this branch, ' +
-                'or use an explicit portable branch primitive. The Feature was not persisted.');
+        var _a, _b, _c;
+        if (this.options.controlFlowMode !== 'legacy' &&
+            (this.options.branchOverrides || ((_b = (_a = this.options.recordScenarios) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0) > 0)) {
+            throw new FeatureCompilationError(this.options.tag, '(handler)', 'branchOverrides and recordScenarios require controlFlowMode: "legacy". ' +
+                'For portable Features, use ctx.branch()/ctx.when and move runtime-sized algorithms into ctx.functions.');
+        }
+        const diagnostics = (0, feature_control_flow_validator_1.inspectFeatureHandlerControlFlow)(this.options.handler.toString(), (_c = this.options.controlFlowMode) !== null && _c !== void 0 ? _c : 'portable');
+        if (diagnostics.length > 0) {
+            throw new FeatureCompilationError(this.options.tag, '(handler)', 'Feature control-flow validation failed. The Feature was not persisted.\n' +
+                diagnostics.map((item) => `${item.code} at ${item.line}:${item.column} - ${item.message}`).join('\n'));
         }
     }
     /**