@ductape/sdk 0.1.134 → 0.1.135

package/dist/products/services/products.service.d.ts

@@ -470,6 +470,11 @@ export default class ProductsBuilderService implements IProductsBuilderService {
     private validateAppData;
     private validateVariablesSchema;
     private validateVariablesValues;
+    /**
+     * base_url placeholders ({{key}} / :key) are syntactically required for the URL to resolve
+     * to something requestable — unlike custom app variables, there is no "optional" case here.
+     */
+    private validateBaseUrlVariablesRequired;
     private validateAppEnvs;
     private validateAppAuth;
     createAppAccessTag(app_tag: string, known_app_id?: string): Promise<IAppAccess>;

package/dist/products/services/products.service.js

@@ -2641,6 +2641,25 @@ class ProductsBuilderService {
                 this.inputsService.validateFeatureInputData(find, data);
         });
     }
+    /**
+     * base_url placeholders ({{key}} / :key) are syntactically required for the URL to resolve
+     * to something requestable — unlike custom app variables, there is no "optional" case here.
+     */
+    validateBaseUrlVariablesRequired(variables, baseUrlVariableKeys) {
+        if (!(baseUrlVariableKeys === null || baseUrlVariableKeys === void 0 ? void 0 : baseUrlVariableKeys.length))
+            return;
+        const provided = new Map((variables !== null && variables !== void 0 ? variables : []).map((v) => [v.key, v.value]));
+        const missing = baseUrlVariableKeys
+            .map((v) => v.key)
+            .filter((key) => {
+            const value = provided.get(key);
+            return value === undefined || value === null || String(value).trim() === '';
+        });
+        if (missing.length) {
+            throw new Error(`base_url for app environment requires a value for: ${missing.join(', ')}. ` +
+                `Provide them via envs[].variables when connecting/updating the app.`);
+        }
+    }
     validateAppEnvs(envs, version) {
         const { envs: appEnvs } = version;
         return envs.map((env) => {
@@ -2653,6 +2672,7 @@ class ProductsBuilderService {
             // const updates = this.validateAppAuth(auth, version);
             this.validateVariablesSchema(env.variables, version.variables, appEnv.base_url_variables);
             this.validateVariablesValues(env.variables, version.variables);
+            this.validateBaseUrlVariablesRequired(env.variables, appEnv.base_url_variables);
             /*if (updates && updates.data) {
               env.auth.data = updates.data;
             }
@@ -2897,6 +2917,7 @@ class ProductsBuilderService {
         }
     }
     async updateApp(access_tag, data) {
+        var _a, _b, _c, _d;
         try {
             const app = await this.fetchApp(access_tag);
             if (!app) {
@@ -2913,6 +2934,13 @@ class ProductsBuilderService {
             /*if (data.access_tag && this.fetchApp(data.access_tag)) {
                       throw new Error(`access_tag ${access_tag} is in use`); // TODO: also check on the backend
                   }*/
+            if ((_a = data.envs) === null || _a === void 0 ? void 0 : _a.length) {
+                const thirdPartyApp = await this.fetchThirdPartyAppByAccessTag(access_tag);
+                const version = (_c = (_b = thirdPartyApp === null || thirdPartyApp === void 0 ? void 0 : thirdPartyApp.versions) === null || _b === void 0 ? void 0 : _b.find((v) => v.tag === thirdPartyApp.version)) !== null && _c !== void 0 ? _c : (_d = thirdPartyApp === null || thirdPartyApp === void 0 ? void 0 : thirdPartyApp.versions) === null || _d === void 0 ? void 0 : _d[0];
+                if (version) {
+                    data.envs = this.validateAppEnvs(data.envs, version);
+                }
+            }
             await this.productApi.updateProduct(this.product_id, Object.assign(Object.assign({ _id }, data), { access_tag, component: enums_1.ProductComponents.APP, action: enums_1.RequestAction.UPDATE }), this.getUserAccess());
         }
         catch (e) {