@duckmind/dm-darwin-x64 0.66.4 → 0.66.6

package/extensions/dm-lens/clients/dispatch/runners/prisma-validate.js

@@ -3,6 +3,9 @@ import { safeSpawnAsync } from "../../safe-spawn.js";
 import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { PRIORITY } from "../priorities.js";
 import { resolveLocalFirstAsync } from "./utils/runner-helpers.js";
+import { getIsolatedNpxSpawnOptions } from "../../tool-probe.js";
+import { finishParsedRun } from "./utils/tool-failure.js";
+const PRISMA_VALIDATION_REPORT = /\bValidation Error Count:\s*\d+/;
 function parsePrismaValidateOutput(raw, filePath) {
   const output = raw.split(`
 `).map((line) => line.trim()).filter(Boolean).filter((line) => !line.startsWith("Environment variables loaded")).filter((line) => !line.startsWith("Prisma schema loaded")).join(" ");
@@ -34,23 +37,30 @@ const prismaValidateRunner = {
     const cwd = resolveRunnerCwd(ctx, "prisma-validate");
     const resolved = await resolveLocalFirstAsync("prisma", cwd);
     const absPath = path.resolve(cwd, ctx.filePath);
-    const result = await safeSpawnAsync(resolved.cmd, [...resolved.args, "validate", "--schema", absPath], { timeout: 20000, cwd });
+    const result = await safeSpawnAsync(resolved.cmd, [...resolved.args, "validate", "--schema", absPath], {
+      timeout: 20000,
+      cwd,
+      ...resolved.cmd === "npx" ? getIsolatedNpxSpawnOptions() : {}
+    });
     if (result.error && !result.stdout && !result.stderr) {
       return { status: "skipped", diagnostics: [], semantic: "none" };
     }
     if (result.status === 0) {
       return { status: "succeeded", diagnostics: [], semantic: "none" };
     }
-    const diagnostics = parsePrismaValidateOutput(`${result.stdout ?? ""}
-${result.stderr ?? ""}`, ctx.filePath);
+    const output = `${result.stdout ?? ""}
+${result.stderr ?? ""}`;
+    const diagnostics = parsePrismaValidateOutput(output, ctx.filePath);
     if (diagnostics.length === 0) {
       return { status: "skipped", diagnostics: [], semantic: "none" };
     }
-    return {
-      status: "failed",
-      diagnostics,
-      semantic: "blocking"
-    };
+    return finishParsedRun({
+      tool: "prisma-validate",
+      ctx,
+      result,
+      diagnostics: PRISMA_VALIDATION_REPORT.test(output) ? diagnostics : [],
+      classify: () => ({ status: "failed", semantic: "blocking" })
+    });
   }
 };
 export default prismaValidateRunner;

package/extensions/dm-lens/clients/dispatch/runners/psscriptanalyzer.js

@@ -5,6 +5,7 @@ import { incrementDegradationCount } from "../../degradation-ledger.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
 import { probeToolAsync } from "../../tool-probe.js";
 import { resolveRunnerCwd } from "../../tool-cwd.js";
+import { findingsResult } from "../types.js";
 import { PRIORITY } from "../priorities.js";
 import {
   classifyProbeFailure,
@@ -300,11 +301,10 @@ const psScriptAnalyzerRunner = {
         return { status: "succeeded", diagnostics: [], semantic: "none" };
       }
       const hasErrors = diagnostics.some((d) => d.severity === "error");
-      return {
+      return findingsResult(diagnostics, {
         status: hasErrors ? "failed" : "succeeded",
-        diagnostics,
         semantic: hasErrors ? "blocking" : "warning"
-      };
+      });
     } finally {
       await fs.unlink(tmpScript).catch(() => {});
     }

package/extensions/dm-lens/clients/dispatch/runners/pyright.js

@@ -1,5 +1,5 @@
 import { logExtension } from "../../extension-log.js";
-import { getLSPService } from "../../lsp/index.js";
+import { getLSPService } from "../../lsp/capabilities.js";
 import {
   augmentPythonEnvironment,
   detectPythonEnvironment

package/extensions/dm-lens/clients/dispatch/runners/rust-clippy.js

@@ -79,7 +79,29 @@ const rustClippyRunner = {
       return { status: "succeeded", diagnostics: [], semantic: "none" };
     }
     const allDiagnostics = parseClippyOutput(raw, ctx.filePath, cargoDir);
-    if (allDiagnostics.length === 0) {
+    const hasRecognizedCargoOutput = raw.split(`
+`).some((line) => {
+      try {
+        const reason = JSON.parse(line).reason;
+        return reason === "build-finished" || reason === "compiler-artifact" || reason === "compiler-message" || reason === "build-script-executed";
+      } catch {
+        return false;
+      }
+    });
+    const absEdited = resolve(ctx.filePath);
+    const diagnostics = allDiagnostics.filter((d) => pathsEqual(resolve(cargoDir, d.filePath), absEdited));
+    const hasBlocking = diagnostics.some((d) => d.semantic === "blocking");
+    const semantic = hasBlocking ? "blocking" : diagnostics.length > 0 ? "warning" : "none";
+    if (result.error || result.failure) {
+      return {
+        status: "failed",
+        diagnostics,
+        semantic,
+        failureKind: result.failure === "timeout" || result.spawnFailure?.kind === "timeout" ? "timeout" : "server_error",
+        rawOutput: raw.substring(0, 500)
+      };
+    }
+    if (allDiagnostics.length === 0 && !(result.status === 0 && hasRecognizedCargoOutput)) {
       return {
         status: "failed",
         diagnostics: [],
@@ -87,13 +109,10 @@ const rustClippyRunner = {
         rawOutput: raw.substring(0, 500)
       };
     }
-    const absEdited = resolve(ctx.filePath);
-    const diagnostics = allDiagnostics.filter((d) => pathsEqual(resolve(cargoDir, d.filePath), absEdited));
-    const hasErrors = diagnostics.some((d) => d.semantic === "blocking");
     return {
-      status: hasErrors ? "failed" : "succeeded",
+      status: "succeeded",
       diagnostics,
-      semantic: hasErrors ? "blocking" : diagnostics.length > 0 ? "warning" : "none"
+      semantic
     };
   }
 };

package/extensions/dm-lens/clients/dispatch/runners/shellcheck.js

@@ -6,11 +6,60 @@ import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { PRIORITY } from "../priorities.js";
 import {
   createAvailabilityChecker,
+  coveringLaneAvailable,
   lspPrimaryCoversFile,
   resolveAvailableOrInstall
 } from "./utils/runner-helpers.js";
 import { finishParsedRun } from "./utils/tool-failure.js";
 const shellcheck = createAvailabilityChecker("shellcheck", ".exe");
+const SHELLCHECK_DIALECTS = [
+  "sh",
+  "bash",
+  "dash",
+  "ksh",
+  "busybox"
+];
+export const SHELLCHECK_SUPPORTED_DIALECTS = SHELLCHECK_DIALECTS;
+const SHEBANG_REGEXP = /^#!(.+)/;
+const SHEBANG_INTERPRETER_REGEXP = /^[/](?:[^ /]+[/])*(?:env +(?:-S +)?)?([^ /]+)/;
+const SHELLCHECK_SHELL_OR_EMPTY_REGEXP = /^\s*(?:#\s*shellcheck\s+(?:\S+\s+)*shell=(\w+)|#|$)/;
+const DIALECT_SNIFF_BYTES = 4096;
+function parseShebang(content) {
+  const match = SHEBANG_REGEXP.exec(content);
+  if (!match || !match[1])
+    return null;
+  const interpreter = SHEBANG_INTERPRETER_REGEXP.exec(match[1].trim());
+  if (!interpreter || !interpreter[1])
+    return null;
+  return interpreter[1].trim();
+}
+function parseShellDirective(content) {
+  for (const line of content.split(`
+`)) {
+    const match = SHELLCHECK_SHELL_OR_EMPTY_REGEXP.exec(line);
+    if (match === null)
+      break;
+    if (match[1])
+      return match[1].trim();
+  }
+  return null;
+}
+export function resolveShellFileDialect(filePath) {
+  let content;
+  try {
+    content = fs.readFileSync(filePath)?.subarray(0, DIALECT_SNIFF_BYTES).toString("utf8");
+  } catch {
+    return { shebang: null, directive: null, dialect: "bash" };
+  }
+  const directive = parseShellDirective(content);
+  const shebang = parseShebang(content);
+  const parsed = directive ?? shebang ?? (path.extname(filePath).toLowerCase() === ".zsh" ? "zsh" : null);
+  return {
+    shebang,
+    directive,
+    dialect: parsed ?? "bash"
+  };
+}
 function findShellcheckConfig(cwd) {
   const local = path.join(cwd, ".shellcheckrc");
   if (fs.existsSync(local))
@@ -78,8 +127,24 @@ const shellcheckRunner = {
   skipTestFiles: false,
   async run(ctx) {
     const cwd = resolveRunnerCwd(ctx, "shellcheck");
-    if (lspPrimaryCoversFile(ctx, "bash") && await ctx.hasTool("bash-language-server") && await ctx.hasTool("shellcheck")) {
-      return { status: "skipped", diagnostics: [], semantic: "none" };
+    const cover = lspPrimaryCoversFile(ctx, "shellcheck");
+    if (cover && await coveringLaneAvailable(ctx, cover) && await ctx.hasTool("shellcheck")) {
+      return {
+        status: "skipped",
+        diagnostics: [],
+        semantic: "none",
+        skipReason: "covered-by-primary",
+        claimSource: cover.claimSource
+      };
+    }
+    const dialectInfo = resolveShellFileDialect(ctx.filePath);
+    if (!SHELLCHECK_DIALECTS.includes(dialectInfo.dialect)) {
+      return {
+        status: "skipped",
+        diagnostics: [],
+        semantic: "none",
+        skipReason: "dialect-unsupported"
+      };
     }
     let cmd = null;
     if (await shellcheck.isAvailableAsync(cwd)) {
@@ -91,8 +156,10 @@ const shellcheckRunner = {
     }
     if (!cmd)
       return { status: "skipped", diagnostics: [], semantic: "none" };
-    const shellDialect = "bash";
-    const args = ["--format", "json", "--shell", shellDialect];
+    const args = ["--format", "json"];
+    if (!dialectInfo.shebang && !dialectInfo.directive) {
+      args.push("--shell", dialectInfo.dialect);
+    }
     const configPath = findShellcheckConfig(ctx.cwd);
     if (!configPath) {
       args.push("--severity", "info");

package/extensions/dm-lens/clients/dispatch/runners/shfmt.js

@@ -2,6 +2,7 @@ import { safeSpawnAsync } from "../../safe-spawn.js";
 import { findNearestContaining } from "../../path-utils.js";
 import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { PRIORITY } from "../priorities.js";
+import { findingsResult } from "../types.js";
 import {
   createAvailabilityChecker,
   resolveAvailableOrInstall
@@ -52,7 +53,10 @@ const shfmtRunner = {
           rule: "shfmt-parse-error"
         }
       ];
-      return { status: "failed", diagnostics, semantic: "blocking" };
+      return findingsResult(diagnostics, {
+        status: "failed",
+        semantic: "blocking"
+      });
     }
     if (!hasEditorConfig(cwd)) {
       return { status: "skipped", diagnostics: [], semantic: "none" };

package/extensions/dm-lens/clients/dispatch/runners/spellcheck.js

@@ -2,6 +2,7 @@ import * as path from "node:path";
 import { pathsEqual } from "../../path-utils.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
 import { PRIORITY } from "../priorities.js";
+import { findingsResult } from "../types.js";
 import {
   createAvailabilityChecker,
   resolveRunnerCwd
@@ -67,11 +68,10 @@ const spellcheckRunner = {
     if (diagnostics.length === 0) {
       return { status: "succeeded", diagnostics: [], semantic: "none" };
     }
-    return {
+    return findingsResult(diagnostics, {
       status: "failed",
-      diagnostics,
       semantic: "warning"
-    };
+    });
   }
 };
 export default spellcheckRunner;

package/extensions/dm-lens/clients/dispatch/runners/swiftlint.js

@@ -3,6 +3,7 @@ import { pathsEqual } from "../../path-utils.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
 import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { PRIORITY } from "../priorities.js";
+import { findingsResult } from "../types.js";
 import {
   createAvailabilityChecker,
   resolveToolCommandWithInstallFallback
@@ -135,11 +136,10 @@ const swiftlintRunner = {
       return { status: "succeeded", diagnostics: [], semantic: "none" };
     }
     const hasBlocking = diagnostics.some((d) => d.semantic === "blocking");
-    return {
+    return findingsResult(diagnostics, {
       status: hasBlocking ? "failed" : "succeeded",
-      diagnostics,
       semantic: hasBlocking ? "blocking" : "warning"
-    };
+    });
   }
 };
 export default swiftlintRunner;

package/extensions/dm-lens/clients/dispatch/runners/taplo.js

@@ -1,13 +1,15 @@
 import * as path from "node:path";
 import { pathsEqual } from "../../path-utils.js";
-import { findLocalBinUpwards } from "../../package-manager.js";
+import { findLocalBinUpwards, localBinPath } from "../../package-manager.js";
 import { stripAnsi } from "../../sanitize.js";
 import { safeSpawnAsync } from "../../safe-spawn.js";
 import { resolveRunnerCwd } from "../../tool-cwd.js";
 import { getLinterPolicyForCwd } from "../../tool-policy.js";
 import { PRIORITY } from "../priorities.js";
+import { findingsResult } from "../types.js";
 import {
   createAvailabilityChecker,
+  coveringLaneAvailable,
   lspPrimaryCoversFile,
   resolveToolCommandWithInstallFallback
 } from "./utils/runner-helpers.js";
@@ -72,10 +74,17 @@ const taploRunner = {
     if (policy && !policy.preferredRunners.includes("taplo")) {
       return { status: "skipped", diagnostics: [], semantic: "none" };
     }
-    if (lspPrimaryCoversFile(ctx, "toml") && await ctx.hasTool("taplo")) {
-      return { status: "skipped", diagnostics: [], semantic: "none" };
+    const cover = lspPrimaryCoversFile(ctx, "taplo");
+    if (cover && await coveringLaneAvailable(ctx, cover)) {
+      return {
+        status: "skipped",
+        diagnostics: [],
+        semantic: "none",
+        skipReason: "covered-by-primary",
+        claimSource: cover.claimSource
+      };
     }
-    let cmd = findLocalBinUpwards("taplo", cwd) ?? null;
+    let cmd = localBinPath(findLocalBinUpwards("taplo", cwd)) ?? null;
     if (!cmd) {
       if (await taplo.isAvailableAsync(cwd)) {
         cmd = taplo.getCommand(cwd);
@@ -95,7 +104,10 @@ const taploRunner = {
     if (diagnostics.length === 0) {
       return { status: "succeeded", diagnostics: [], semantic: "none" };
     }
-    return { status: "failed", diagnostics, semantic: "blocking" };
+    return findingsResult(diagnostics, {
+      status: "failed",
+      semantic: "blocking"
+    });
   }
 };
 export default taploRunner;

package/extensions/dm-lens/clients/dispatch/runners/tree-sitter.js

@@ -1,12 +1,16 @@
 import * as path from "node:path";
 import { RuleCache } from "../../cache/rule-cache.js";
 import { isRuleIgnoredForPath } from "../rule-ignores.js";
+import { ruleIgnoredForPath } from "../rule-policy.js";
 import { isTestFile } from "../../file-utils.js";
 import {
   buildOrUpdateGraph,
   computeImpactCascade,
   recordEntitySnapshotDiff
 } from "../../review-graph/service.js";
+import {
+  classifyTreeSitterWasmError
+} from "../../tree-sitter-client.js";
 import {
   getSharedTreeSitterClient,
   isTreeSitterWasmAborted,
@@ -23,6 +27,7 @@ import {
 } from "../../tree-sitter-query-loader.js";
 import { classifyDefect } from "../diagnostic-taxonomy.js";
 import { PRIORITY } from "../priorities.js";
+import { findingsResult } from "../types.js";
 const blastCooldownByFile = new Map;
 const BLAST_COOLDOWN_MS = 5000;
 function runBlastRadiusInBackground(cwd, filePath, languageId, facts) {
@@ -383,7 +388,7 @@ const treeSitterRunner = {
     }
     const fileIsTest = isTestFile(filePath);
     const ignoreRoot = ctx.projectRoot ?? ctx.cwd;
-    const effectiveQueries = (ctx.blockingOnly ? languageQueries.filter((q) => q.inline_tier !== "review") : languageQueries).filter((q) => !(fileIsTest && q.skip_test_files) && !isRuleIgnoredForPath(filePath, ignoreRoot, q.ignore_paths));
+    const effectiveQueries = (ctx.blockingOnly ? languageQueries.filter((q) => q.inline_tier !== "review") : languageQueries).filter((q) => !(fileIsTest && q.skip_test_files) && !isRuleIgnoredForPath(filePath, ignoreRoot, q.ignore_paths) && !ruleIgnoredForPath(q.id, filePath, ignoreRoot, ctx.rulePolicy));
     logTreeSitter({
       phase: "queries_loaded",
       filePath,
@@ -393,6 +398,9 @@ const treeSitterRunner = {
       cacheHit,
       metadata: { blockingOnly: !!ctx.blockingOnly }
     });
+    if (effectiveQueries.length === 0) {
+      return { status: "succeeded", diagnostics: [], semantic: "none" };
+    }
     const contentFromFacts = ctx.facts.getFileFact(filePath, "file.content");
     const contentOverride = contentFromFacts !== undefined && contentFromFacts !== null ? contentFromFacts : undefined;
     const diagnostics = [];
@@ -429,7 +437,7 @@ const treeSitterRunner = {
       }
     } catch (err) {
       const msg = err instanceof Error ? err.message : String(err);
-      if (msg.includes("Aborted") || msg.includes("abort()")) {
+      if (classifyTreeSitterWasmError(err) === "abort") {
         markTreeSitterWasmAborted();
         logTreeSitter({
           phase: "query_error",
@@ -521,11 +529,10 @@ const treeSitterRunner = {
       queryCount: languageQueries.length,
       effectiveQueryCount: effectiveQueries.length
     });
-    return {
+    return findingsResult(diagnostics, {
       status: hasBlocking ? "failed" : "succeeded",
-      diagnostics,
       semantic: hasBlocking ? "blocking" : "warning"
-    };
+    });
   }
 };
 export default treeSitterRunner;

package/extensions/dm-lens/clients/dispatch/runners/trivy-config.js

@@ -10,6 +10,7 @@ import {
   resolveSeverityFloor
 } from "../../trivy-client.js";
 import { PRIORITY } from "../priorities.js";
+import { findingsResult } from "../types.js";
 import {
   createAvailabilityChecker,
   resolveAvailableOrInstall
@@ -151,11 +152,10 @@ const trivyConfigRunner = {
       return { status: "succeeded", diagnostics: [], semantic: "none" };
     }
     const hasBlocking = diagnostics.some((d) => d.semantic === "blocking");
-    return {
+    return findingsResult(diagnostics, {
       status: hasBlocking ? "failed" : "succeeded",
-      diagnostics,
       semantic: hasBlocking ? "blocking" : "warning"
-    };
+    });
   }
 };
 export default trivyConfigRunner;