@duckmind/dm-darwin-x64 0.33.1 → 0.33.4

package/extensions/dm-ask/btw-ui.test.ts

@@ -1,270 +0,0 @@
-import type { Theme } from "@mariozechner/pi-coding-agent";
-import { type TUI, visibleWidth } from "@mariozechner/pi-tui";
-import { makeTui } from "@juicesharp/rpiv-test-utils";
-import { afterEach, describe, expect, it, vi } from "vitest";
-import type { AskTurn } from "./ask.js";
-import { AskOverlayController, showAskOverlay } from "./ask-ui.js";
-
-const identityTheme = {
-	fg: (_c: string, s: string) => s,
-	bg: (_c: string, s: string) => s,
-	bold: (s: string) => s,
-	strikethrough: (s: string) => s,
-} as unknown as Theme;
-
-function makeTurn(q: string, a = "ans"): AskTurn {
-	return {
-		userMessage: { role: "user", content: q, timestamp: 0 },
-		assistantMessage: {
-			role: "assistant",
-			content: [{ type: "text", text: a }],
-			api: "anthropic" as never,
-			provider: "anthropic" as never,
-			model: "m",
-			usage: {} as never,
-			stopReason: "done" as never,
-			timestamp: 0,
-		},
-	};
-}
-
-function makeController(opts: { question?: string; history?: AskTurn[]; tui?: TUI; rows?: number } = {}) {
-	const tui = opts.tui ?? (makeTui() as unknown as TUI);
-	(tui as unknown as { terminal: { rows: number } }).terminal = { rows: opts.rows ?? 24 };
-	const done = vi.fn();
-	const controller = new AbortController();
-	const onClearHistory = vi.fn();
-	const ctl = new AskOverlayController(
-		opts.question ?? "what?",
-		opts.history ?? [],
-		identityTheme,
-		tui,
-		done,
-		controller,
-		onClearHistory,
-	);
-	return { ctl, tui, done, controller, onClearHistory };
-}
-
-afterEach(() => {
-	vi.restoreAllMocks();
-});
-
-describe("AskOverlayController — initial (pending) render", () => {
-	it("contains the banner, echo line, pending glyph, and dismiss footer", () => {
-		const { ctl } = makeController({ question: "hello?" });
-		const out = ctl.render(80).join("\n");
-		expect(out).toContain("/ask hello?");
-		expect(out).toContain("…"); // PENDING_GLYPH
-		expect(out).toContain("Esc to dismiss");
-	});
-
-	it("does NOT show 'scroll' or 'clear' hints when pending + no history", () => {
-		const { ctl } = makeController({ question: "q" });
-		const out = ctl.render(80).join("\n");
-		expect(out).not.toContain("↑/↓ to scroll");
-		expect(out).not.toContain("x to clear history");
-	});
-
-	it("shows 'x to clear history' hint when history is non-empty", () => {
-		const { ctl } = makeController({ history: [makeTurn("prev")] });
-		const out = ctl.render(80).join("\n");
-		expect(out).toContain("x to clear history");
-	});
-});
-
-describe("AskOverlayController — setAnswer", () => {
-	it("replaces pending glyph with the answer text", () => {
-		const { ctl, tui } = makeController();
-		ctl.setAnswer("forty-two");
-		const out = ctl.render(80).join("\n");
-		expect(out).toContain("forty-two");
-		expect(out).not.toContain("…");
-		expect(tui.requestRender).toHaveBeenCalled();
-	});
-
-	it("enables the 'scroll' footer hint once the mode is no longer pending", () => {
-		const { ctl } = makeController();
-		ctl.setAnswer("a");
-		expect(ctl.render(80).join("\n")).toContain("↑/↓ to scroll");
-	});
-
-	it("wraps multi-line answers into the answer body", () => {
-		const { ctl } = makeController();
-		ctl.setAnswer("line1\nline2\nline3");
-		const out = ctl.render(80);
-		expect(out.some((l) => l.includes("line1"))).toBe(true);
-		expect(out.some((l) => l.includes("line2"))).toBe(true);
-		expect(out.some((l) => l.includes("line3"))).toBe(true);
-	});
-});
-
-describe("AskOverlayController — setError", () => {
-	it("renders the error message in the answer slot", () => {
-		const { ctl } = makeController();
-		ctl.setError("boom: nope");
-		const out = ctl.render(80).join("\n");
-		expect(out).toContain("boom: nope");
-		expect(out).not.toContain("…");
-	});
-});
-
-describe("AskOverlayController — handleInput", () => {
-	it("Esc aborts the controller and resolves done()", () => {
-		const { ctl, controller, done } = makeController();
-		ctl.handleInput("\u001b");
-		expect(controller.signal.aborted).toBe(true);
-		expect(done).toHaveBeenCalled();
-	});
-
-	it("'x' clears in-memory history and invokes onClearHistory", () => {
-		const { ctl, onClearHistory, tui } = makeController({ history: [makeTurn("a"), makeTurn("b")] });
-		ctl.handleInput("x");
-		expect(onClearHistory).toHaveBeenCalledTimes(1);
-		const out = ctl.render(80).join("\n");
-		expect(out).not.toContain("/ask a");
-		expect(out).not.toContain("/ask b");
-		expect(out).not.toContain("x to clear history");
-		expect(tui.requestRender).toHaveBeenCalled();
-	});
-
-	it("unknown keys do not abort or clear", () => {
-		const { ctl, controller, done, onClearHistory } = makeController();
-		ctl.handleInput("z");
-		expect(controller.signal.aborted).toBe(false);
-		expect(done).not.toHaveBeenCalled();
-		expect(onClearHistory).not.toHaveBeenCalled();
-	});
-});
-
-describe("AskOverlayController — scroll + clipping", () => {
-	it("render() returns all natural lines when within maxRows", () => {
-		const { ctl } = makeController({ rows: 100 });
-		ctl.setAnswer("answer-body");
-		const lines = ctl.render(80);
-		// banner + blank + 0 history + echo + blank + 1 answer + blank + footer = 7
-		expect(lines.length).toBe(7);
-	});
-
-	it("clips top when content overflows terminal height; scroll↑ reveals older history", () => {
-		// Use distinct non-overlapping markers so substring matches are unambiguous.
-		const history: AskTurn[] = Array.from({ length: 20 }, (_, i) => makeTurn(`mark-${i + 1}-end`));
-		const { ctl } = makeController({ history, rows: 10 });
-		ctl.setAnswer("A");
-		const base = ctl.render(80);
-		const maxRows = Math.floor(10 * 0.85); // 8
-		expect(base.length).toBe(maxRows);
-		// Bottom-anchored: footer + answer visible; earliest history hidden
-		expect(base.join("\n")).not.toContain("mark-1-end");
-		expect(base.join("\n")).toContain("mark-20-end");
-		expect(base.join("\n")).toContain("Esc to dismiss");
-		// Scroll up reveals older history at the top.
-		ctl.handleInput("\u001b[A");
-		const scrolled = ctl.render(80);
-		expect(scrolled.length).toBe(maxRows);
-	});
-
-	it("scroll↓ at bottom stays clamped (no throw, still renders maxRows)", () => {
-		const history: AskTurn[] = Array.from({ length: 20 }, (_, i) => makeTurn(`mark-${i + 1}-end`));
-		const { ctl } = makeController({ history, rows: 10 });
-		ctl.setAnswer("A");
-		ctl.handleInput("\u001b[B"); // down
-		const out = ctl.render(80);
-		const maxRows = Math.floor(10 * 0.85);
-		expect(out.length).toBe(maxRows);
-	});
-
-	it("invalidate() is a callable no-op", () => {
-		const { ctl } = makeController();
-		expect(() => ctl.invalidate()).not.toThrow();
-	});
-});
-
-describe("AskOverlayController — banner + echo formatting", () => {
-	it("banner is padded to full visible width", () => {
-		const { ctl } = makeController({ question: "q" });
-		const banner = ctl.render(40)[0];
-		expect(visibleWidth(banner)).toBe(40);
-	});
-
-	it("truncates long questions in the banner with ellipsis", () => {
-		const long = "a".repeat(200);
-		const { ctl } = makeController({ question: long });
-		const banner = ctl.render(40)[0];
-		expect(visibleWidth(banner)).toBe(40);
-		expect(banner).toContain("…");
-	});
-
-	it("history echo uses '/ask ' prefix and trims whitespace", () => {
-		const { ctl } = makeController({ history: [makeTurn("  multi\nline   q  ")] });
-		const out = ctl.render(80).join("\n");
-		expect(out).toContain("/ask multi line q");
-	});
-});
-
-describe("showAskOverlay — factory wiring", () => {
-	it("invokes ctx.ui.custom with overlay options and resolves controllerReady with the AskOverlayController", async () => {
-		const requestRender = vi.fn();
-		const tui = { requestRender, terminal: { rows: 24 } } as unknown as TUI;
-		const custom = vi.fn((factory: unknown, opts: unknown) => {
-			const f = factory as (
-				tui: TUI,
-				theme: Theme,
-				kb: undefined,
-				done: (v: undefined) => void,
-			) => AskOverlayController;
-			const ctl = f(tui, identityTheme, undefined, () => {});
-			// Keep `opts` addressable for the assertion below.
-			(custom as unknown as { lastOpts: unknown }).lastOpts = opts;
-			return new Promise<void>(() => {
-				// keep pending so we can inspect the controller
-				void ctl;
-			});
-		});
-		const ctx = { ui: { custom } } as never;
-
-		const { controllerReady } = showAskOverlay({
-			ctx,
-			question: "q",
-			history: [],
-			controller: new AbortController(),
-			onClearHistory: vi.fn(),
-		});
-
-		const ctl = await controllerReady;
-		expect(ctl).toBeInstanceOf(AskOverlayController);
-		expect(custom).toHaveBeenCalledTimes(1);
-		const opts = (custom as unknown as { lastOpts: { overlay: boolean; overlayOptions: unknown } }).lastOpts;
-		expect(opts).toMatchObject({ overlay: true });
-		expect(opts.overlayOptions).toMatchObject({ anchor: "bottom-center" });
-	});
-
-	it("controller returned by the factory is the same one exposed via controllerReady", async () => {
-		let factoryCtl: AskOverlayController | undefined;
-		const custom = vi.fn((factory: unknown) => {
-			const f = factory as (
-				tui: TUI,
-				theme: Theme,
-				kb: undefined,
-				done: (v: undefined) => void,
-			) => AskOverlayController;
-			factoryCtl = f(
-				{ requestRender: vi.fn(), terminal: { rows: 24 } } as unknown as TUI,
-				identityTheme,
-				undefined,
-				() => {},
-			);
-			return new Promise<void>(() => {});
-		});
-		const ctx = { ui: { custom } } as never;
-		const { controllerReady } = showAskOverlay({
-			ctx,
-			question: "q",
-			history: [],
-			controller: new AbortController(),
-			onClearHistory: vi.fn(),
-		});
-		const ctl = await controllerReady;
-		expect(ctl).toBe(factoryCtl);
-	});
-});

package/extensions/dm-ask/btw.command.test.ts

@@ -1,152 +0,0 @@
-import type { Api, Model } from "@mariozechner/pi-ai";
-import { createMockCtx, createMockDM } from "@juicesharp/rpiv-test-utils";
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-vi.mock("./ask-ui.js", () => ({
-	showAskOverlay: vi.fn(),
-}));
-
-vi.mock("@mariozechner/pi-ai", async (importOriginal) => {
-	const actual = await importOriginal<typeof import("@mariozechner/pi-ai")>();
-	return {
-		...actual,
-		completeSimple: vi.fn(),
-		getSupportedThinkingLevels: vi.fn(() => ["off", "minimal", "low", "medium", "high"]),
-	};
-});
-
-import { completeSimple } from "@mariozechner/pi-ai";
-import { ASK_COMMAND_NAME, ASK_STATE_KEY, registerAskCommand } from "./ask.js";
-import { showAskOverlay } from "./ask-ui.js";
-
-const model = { provider: "a", id: "m" } as unknown as Model<Api>;
-
-type OverlayCtl = { setAnswer: ReturnType<typeof vi.fn>; setError: ReturnType<typeof vi.fn> };
-
-function stubOverlay(): OverlayCtl {
-	const ctl: OverlayCtl = { setAnswer: vi.fn(), setError: vi.fn() };
-	vi.mocked(showAskOverlay).mockReturnValueOnce({
-		overlayPromise: Promise.resolve(),
-		controllerReady: Promise.resolve(ctl as never),
-	} as never);
-	return ctl;
-}
-
-function doneResponse(text: string) {
-	return {
-		role: "assistant",
-		content: [{ type: "text", text }],
-		timestamp: Date.now(),
-		stopReason: "done",
-	};
-}
-
-beforeEach(() => {
-	vi.mocked(showAskOverlay).mockReset();
-	vi.mocked(completeSimple).mockReset();
-});
-
-afterEach(() => {
-	delete (globalThis as Record<symbol, unknown>)[ASK_STATE_KEY];
-});
-
-function register() {
-	const { DM, captured } = createMockDM();
-	registerAskCommand(pi);
-	return captured.commands.get(ASK_COMMAND_NAME)!;
-}
-
-describe("/ask — early-return branches", () => {
-	it("!hasUI notifies error and skips overlay", async () => {
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: false, model });
-		await cmd.handler("anything", ctx as never);
-		expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("interactive"), "error");
-		expect(showAskOverlay).not.toHaveBeenCalled();
-	});
-
-	it("empty question emits usage warning", async () => {
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: true, model });
-		await cmd.handler("   ", ctx as never);
-		expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("Usage"), "warning");
-		expect(showAskOverlay).not.toHaveBeenCalled();
-	});
-
-	it("missing model notifies error", async () => {
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: true });
-		await cmd.handler("hello?", ctx as never);
-		expect(ctx.ui.notify).toHaveBeenCalledWith(expect.stringContaining("active model"), "error");
-		expect(showAskOverlay).not.toHaveBeenCalled();
-	});
-});
-
-describe("/ask — happy path", () => {
-	it("invokes overlay, awaits executor, pipes answer to setAnswer", async () => {
-		const ctl = stubOverlay();
-		vi.mocked(completeSimple).mockResolvedValueOnce(doneResponse("42") as never);
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: true, model });
-		await cmd.handler("what is 6 times 7?", ctx as never);
-		expect(showAskOverlay).toHaveBeenCalledTimes(1);
-		const params = vi.mocked(showAskOverlay).mock.calls[0][0];
-		expect(params.question).toBe("what is 6 times 7?");
-		expect(params.history).toEqual([]);
-		expect(ctl.setAnswer).toHaveBeenCalledWith("42");
-		expect(ctl.setError).not.toHaveBeenCalled();
-	});
-});
-
-describe("/ask — aborted", () => {
-	it("does not touch the overlay controller", async () => {
-		const ctl = stubOverlay();
-		vi.mocked(completeSimple).mockResolvedValueOnce({
-			role: "assistant",
-			content: [],
-			timestamp: Date.now(),
-			stopReason: "aborted",
-		} as never);
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: true, model });
-		await cmd.handler("q", ctx as never);
-		expect(ctl.setAnswer).not.toHaveBeenCalled();
-		expect(ctl.setError).not.toHaveBeenCalled();
-	});
-});
-
-describe("/ask — executor failure", () => {
-	it("pipes error into setError", async () => {
-		const ctl = stubOverlay();
-		vi.mocked(completeSimple).mockResolvedValueOnce({
-			role: "assistant",
-			content: [],
-			timestamp: Date.now(),
-			stopReason: "error",
-			errorMessage: "upstream 502",
-		} as never);
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: true, model });
-		await cmd.handler("q", ctx as never);
-		expect(ctl.setError).toHaveBeenCalledWith(expect.stringContaining("upstream 502"));
-		expect(ctl.setAnswer).not.toHaveBeenCalled();
-	});
-});
-
-describe("/ask — cross-session hint is rendered after turns accumulate", () => {
-	it("second invocation's systemPrompt contains the recent-questions section", async () => {
-		stubOverlay();
-		vi.mocked(completeSimple).mockResolvedValueOnce(doneResponse("ans1") as never);
-		const cmd = register();
-		const ctx = createMockCtx({ hasUI: true, model });
-		await cmd.handler("first question", ctx as never);
-
-		stubOverlay();
-		vi.mocked(completeSimple).mockResolvedValueOnce(doneResponse("ans2") as never);
-		await cmd.handler("second question", ctx as never);
-
-		const secondSystemPrompt = vi.mocked(completeSimple).mock.calls[1][1].systemPrompt ?? "";
-		expect(secondSystemPrompt).toContain("Recent /ask questions across sessions");
-		expect(secondSystemPrompt).toContain("first question");
-	});
-});