@ducci/jarvis 1.0.8 → 1.0.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ducci/jarvis",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "A fully automated agent system that lives on a server.",
   "main": "./src/index.js",
   "type": "module",
@@ -20,7 +20,7 @@
     "setup": "node ./src/scripts/onboarding.js",
     "dev": "nodemon ./src/server/app.js",
     "prepare": "cd ui && npm install && npm run build",
-    "publish": "node scripts/publish.js",
+    "release": "node scripts/publish.js",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "keywords": [

package/src/server/agent.js

@@ -85,7 +85,20 @@ async function runAgentLoop(client, config, session, tools, toolDefs, prepareMes
         status: 'model_error',
         runToolCalls,
         checkpoint: null,
-        errorDetail: e.apiErrors ?? { message: e.message },
+        errorDetail: e.apiErrors ?? { message: e.message, stack: e.stack },
+        contextInfo: { messageCount: preparedMessages.length },
+      };
+    }
+
+    if (!modelResult.choices || modelResult.choices.length === 0) {
+      return {
+        iteration,
+        response: 'Model returned an empty response.',
+        logSummary: `Model error on iteration ${iteration}: Empty choices array.`,
+        status: 'model_error',
+        runToolCalls,
+        checkpoint: null,
+        errorDetail: { message: 'Empty choices array from LLM' },
         contextInfo: { messageCount: preparedMessages.length },
       };
     }
@@ -168,7 +181,20 @@ async function runAgentLoop(client, config, session, tools, toolDefs, prepareMes
         status: 'model_error',
         runToolCalls,
         checkpoint: null,
-        errorDetail: e.apiErrors ?? { message: e.message },
+        errorDetail: e.apiErrors ?? { message: e.message, stack: e.stack },
+        contextInfo: { messageCount: wrapUpMessages.length },
+      };
+    }
+
+    if (!wrapUpResult.choices || wrapUpResult.choices.length === 0) {
+      return {
+        iteration,
+        response: 'Wrap-up call returned an empty response.',
+        logSummary: 'Iteration limit reached. Wrap-up returned empty choices.',
+        status: 'model_error',
+        runToolCalls,
+        checkpoint: null,
+        errorDetail: { message: 'Empty choices array in wrap-up' },
         contextInfo: { messageCount: wrapUpMessages.length },
       };
     }
@@ -244,63 +270,79 @@ export async function handleChat(config, requestSessionId, userMessage) {
   let finalStatus = 'ok';
 
   // Handoff loop
-  while (true) {
-    const run = await runAgentLoop(client, config, session, tools, toolDefs, prepareMessages);
-    allToolCalls.push(...run.runToolCalls);
-
-    if (run.status !== 'checkpoint_reached') {
-      finalResponse = run.response;
-      finalLogSummary = run.logSummary;
-      finalStatus = run.status;
+  try {
+    while (true) {
+      const run = await runAgentLoop(client, config, session, tools, toolDefs, prepareMessages);
+      allToolCalls.push(...run.runToolCalls);
+
+      if (run.status !== 'checkpoint_reached') {
+        finalResponse = run.response;
+        finalLogSummary = run.logSummary;
+        finalStatus = run.status;
+
+        const logEntry = {
+          iteration: run.iteration,
+          model: config.selectedModel,
+          userInput: userMessage,
+          toolCalls: allToolCalls,
+          response: finalResponse,
+          logSummary: finalLogSummary,
+          status: finalStatus,
+        };
+        if (run.errorDetail) logEntry.errorDetail = run.errorDetail;
+        if (run.contextInfo) logEntry.contextInfo = run.contextInfo;
+        if (run.rawResponse) logEntry.rawResponse = run.rawResponse;
+        appendLog(sessionId, logEntry);
+        break;
+      }
 
-      const logEntry = {
+      // Checkpoint reached — log this run
+      appendLog(sessionId, {
         iteration: run.iteration,
         model: config.selectedModel,
         userInput: userMessage,
-        toolCalls: allToolCalls,
-        response: finalResponse,
-        logSummary: finalLogSummary,
-        status: finalStatus,
-      };
-      if (run.errorDetail) logEntry.errorDetail = run.errorDetail;
-      if (run.contextInfo) logEntry.contextInfo = run.contextInfo;
-      if (run.rawResponse) logEntry.rawResponse = run.rawResponse;
-      appendLog(sessionId, logEntry);
-      break;
-    }
-
-    // Checkpoint reached — log this run
-    appendLog(sessionId, {
-      iteration: run.iteration,
-      model: config.selectedModel,
-      userInput: userMessage,
-      toolCalls: run.runToolCalls,
-      response: run.response,
-      logSummary: run.logSummary,
-      status: 'checkpoint_reached',
-    });
+        toolCalls: run.runToolCalls,
+        response: run.response,
+        logSummary: run.logSummary,
+        status: 'checkpoint_reached',
+      });
 
-    // Check handoff limit
-    session.metadata.handoffCount++;
-    if (session.metadata.handoffCount > config.maxHandoffs) {
-      finalResponse = run.response;
-      finalLogSummary = run.logSummary;
-      finalStatus = 'intervention_required';
+      // Check handoff limit
+      session.metadata.handoffCount++;
+      if (session.metadata.handoffCount > config.maxHandoffs) {
+        finalResponse = run.response;
+        finalLogSummary = run.logSummary;
+        finalStatus = 'intervention_required';
+
+        appendLog(sessionId, {
+          iteration: 0,
+          model: config.selectedModel,
+          userInput: userMessage,
+          toolCalls: [],
+          response: finalResponse,
+          logSummary: 'Max handoffs exceeded. Human intervention required.',
+          status: 'intervention_required',
+        });
+        break;
+      }
 
-      appendLog(sessionId, {
-        iteration: 0,
-        model: config.selectedModel,
-        userInput: userMessage,
-        toolCalls: [],
-        response: finalResponse,
-        logSummary: 'Max handoffs exceeded. Human intervention required.',
-        status: 'intervention_required',
-      });
-      break;
+      // Resume with checkpoint.remaining as new prompt
+      session.messages.push({ role: 'user', content: run.checkpoint.remaining });
     }
-
-    // Resume with checkpoint.remaining as new prompt
-    session.messages.push({ role: 'user', content: run.checkpoint.remaining });
+  } catch (e) {
+    const errorLog = {
+      iteration: 0,
+      model: config.selectedModel,
+      userInput: userMessage,
+      toolCalls: allToolCalls,
+      response: `An unexpected server error occurred: ${e.message}`,
+      logSummary: `Critical error: ${e.message}`,
+      status: 'error',
+      errorDetail: { message: e.message, stack: e.stack },
+    };
+    appendLog(sessionId, errorLog);
+    // Re-throw to let app.js handle the HTTP response
+    throw e;
   }
 
   saveSession(sessionId, session);