@dtlabs/ai-toolkit 0.8.0 → 0.10.0

package/.claude/scripts/tests/wb-render.checks-sanitize-commit-paths.test.js

@@ -0,0 +1,352 @@
+'use strict'
+
+const { spawnSync } = require('child_process')
+const os   = require('os')
+const fs   = require('fs')
+const path = require('path')
+
+const RENDER = path.resolve(__dirname, '../wb-render.js')
+const TMPDIR = os.tmpdir()
+
+// ── Fixture helpers ───────────────────────────────────────────────────────────
+
+function makeWb(overrides) {
+  return Object.assign({
+    schemaVersion: 2,
+    feature: 'TEST',
+    title: 'Test WB',
+    phases: []
+  }, overrides)
+}
+
+function makePhase(id, title, tasks, commitOverride) {
+  return {
+    id,
+    title,
+    commit: commitOverride !== undefined ? commitOverride : { type: 'feat', scope: id, subject: `implement ${id}` },
+    tasks: tasks != null ? tasks : []
+  }
+}
+
+function makeTask(id, domain, overrides) {
+  return Object.assign({
+    id,
+    title: `Task ${id}`,
+    domain,
+    agentType: 'developer-backend',
+    agentMinutes: 10,
+    outcome: `outcome of ${id}`,
+    dependsOn: [],
+    verificationCommands: ['echo ok'],
+    commit: { type: 'feat', scope: 'wb', subject: `implement ${id}` }
+  }, overrides)
+}
+
+function writeFixture(wb) {
+  const p = path.join(TMPDIR, `wb-test-${Date.now()}-${Math.random().toString(36).slice(2)}.json`)
+  fs.writeFileSync(p, JSON.stringify(wb), 'utf8')
+  return p
+}
+
+function runRender(jsonPath, prefix, destDir) {
+  const args = [jsonPath, prefix]
+  if (destDir) args.push(destDir)
+  return spawnSync(process.execPath, [RENDER, ...args], { encoding: 'utf8' })
+}
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Group 1: sanitizeField — via CSV and Markdown output
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('wb-render.js — Group 1: sanitizeField behaviour via output files', () => {
+
+  // ── Test 1: pipe in task title → CSV row has exactly 8 columns ───────────────
+
+  test('pipe in task title is replaced so CSV data row has exactly 8 pipe-separated columns', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE', { title: 'foo|bar' })
+    const phase = makePhase('US-01', 'Phase One', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-sanitize-t1-'))
+    try {
+      // Act
+      runRender(jsonPath, 'TEST', tmpDir)
+      const csv = fs.readFileSync(path.join(tmpDir, 'TEST-Work-Breakdown.csv'), 'utf8')
+      const dataRows = csv.split('\n').filter((l, i) => i > 0 && l.trim() !== '')
+
+      // Assert: each data row has exactly 8 pipe-separated fields (pipe in title is replaced with space)
+      expect(dataRows.length).toBeGreaterThan(0)
+      for (const row of dataRows) {
+        expect(row.split('|')).toHaveLength(8)
+      }
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 2: LF in phase title → no embedded newline in CSV data rows ─────────
+
+  test('LF in phase title is replaced with space so CSV has no extra lines in data section', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase\nOne', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-sanitize-t2-'))
+    try {
+      // Act
+      runRender(jsonPath, 'TEST', tmpDir)
+      const csv = fs.readFileSync(path.join(tmpDir, 'TEST-Work-Breakdown.csv'), 'utf8')
+      const nonEmptyLines = csv.split('\n').filter(l => l.trim() !== '')
+
+      // Assert: exactly 2 non-empty lines — 1 header + 1 data row (no extra LF-split lines)
+      expect(nonEmptyLines).toHaveLength(2)
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 3: CR in phase title → no carriage-return in CSV output ─────────────
+
+  test('CR in phase title is stripped so CSV content contains no carriage-return characters', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase\rOne', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-sanitize-t3-'))
+    try {
+      // Act
+      runRender(jsonPath, 'TEST', tmpDir)
+      const csv = fs.readFileSync(path.join(tmpDir, 'TEST-Work-Breakdown.csv'), 'utf8')
+
+      // Assert: no raw CR bytes anywhere in the CSV
+      expect(csv).not.toContain('\r')
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 4: pipe in task title → MD table row contains sanitized form ─────────
+
+  test('pipe in task title is replaced with space in Markdown task table so raw pipe is absent', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE', { title: 'foo|bar' })
+    const phase = makePhase('US-01', 'Phase One', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-sanitize-t4-'))
+    try {
+      // Act
+      runRender(jsonPath, 'TEST', tmpDir)
+      const md = fs.readFileSync(path.join(tmpDir, 'TEST-Work-Breakdown.md'), 'utf8')
+
+      // Assert: sanitized value present; raw piped title absent
+      expect(md).toContain('foo bar')
+      expect(md).not.toContain('foo|bar')
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 5: null task title → no crash, exit 0 ───────────────────────────────
+
+  test('null task title does not crash the renderer and process exits with code 0', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE', { title: null })
+    const phase = makePhase('US-01', 'Phase One', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-sanitize-t5-'))
+    try {
+      // Act
+      const result = runRender(jsonPath, 'TEST', tmpDir)
+
+      // Assert
+      expect(result.status).toBe(0)
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+})
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Group 2: buildCommitSubject / phase commit formatting — via CSV and MD output
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('wb-render.js — Group 2: commit message formatting in output files', () => {
+
+  // ── Test 6: CSV commit_message uses phase commit type and prefix arg ──────────
+
+  test('CSV commit_message starts with type(PREFIX): when phase.commit is present', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase One', [task], { type: 'feat', subject: 'implement us-01' })
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-commit-t6-'))
+    try {
+      // Act
+      runRender(jsonPath, 'TEST-PREFIX', tmpDir)
+      const csv = fs.readFileSync(path.join(tmpDir, 'TEST-PREFIX-Work-Breakdown.csv'), 'utf8')
+      const dataRows = csv.split('\n').filter((l, i) => i > 0 && l.trim() !== '')
+
+      // Assert: commit_message column (index 2) starts with feat(TEST-PREFIX):
+      expect(dataRows.length).toBeGreaterThan(0)
+      for (const row of dataRows) {
+        const cols = row.split('|')
+        expect(cols[2]).toMatch(/^feat\(TEST-PREFIX\):/)
+      }
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 7: missing phase.commit → CSV falls back to chore(PREFIX): ──────────
+
+  test('CSV commit_message falls back to chore(PREFIX): when phase has no commit field', () => {
+    // Arrange: phase object without a commit field
+    const task  = makeTask('T-01', 'BE')
+    const phase = { id: 'US-01', title: 'Phase One', tasks: [task] }
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-commit-t7-'))
+    try {
+      // Act
+      runRender(jsonPath, 'TEST-PREFIX', tmpDir)
+      const csv = fs.readFileSync(path.join(tmpDir, 'TEST-PREFIX-Work-Breakdown.csv'), 'utf8')
+      const dataRows = csv.split('\n').filter((l, i) => i > 0 && l.trim() !== '')
+
+      // Assert: commit_message column (index 2) starts with chore(TEST-PREFIX):
+      expect(dataRows.length).toBeGreaterThan(0)
+      for (const row of dataRows) {
+        const cols = row.split('|')
+        expect(cols[2]).toMatch(/^chore\(TEST-PREFIX\):/)
+      }
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 8: long phase commit subject → Markdown commit section renders correctly
+
+  test('long phase commit subject is rendered verbatim in Markdown commit section', () => {
+    // Arrange: subject long enough to produce a commit line exceeding 72 chars
+    const longSubject = 'a'.repeat(85) // "feat(PREFIX): " (14 chars) + 85 = 99 chars total
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase One', [task], { type: 'feat', subject: longSubject })
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-commit-t8-'))
+    try {
+      // Act
+      runRender(jsonPath, 'PREFIX', tmpDir)
+      const md = fs.readFileSync(path.join(tmpDir, 'PREFIX-Work-Breakdown.md'), 'utf8')
+
+      // Assert: the full commit line appears in the MD (phaseCommit renders untruncated)
+      const expectedLine = `feat(PREFIX): ${longSubject}`
+      expect(md).toContain(expectedLine)
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+})
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Group 3: Output file paths
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('wb-render.js — Group 3: output file path resolution', () => {
+
+  // ── Test 9: default destDir is same directory as JSON file ───────────────────
+
+  test('output files are written to the JSON directory when no destDir argument is provided', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase One', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath  = writeFixture(wb)
+    const prefix    = 'TEST-P9'
+    const jsonDir   = path.dirname(jsonPath)
+    const expectedMd  = path.join(jsonDir, `${prefix}-Work-Breakdown.md`)
+    const expectedCsv = path.join(jsonDir, `${prefix}-Work-Breakdown.csv`)
+    try {
+      // Act: run without destDir — output defaults to JSON's directory
+      runRender(jsonPath, prefix)
+
+      // Assert: both output files exist in the JSON's directory
+      expect(fs.existsSync(expectedMd)).toBe(true)
+      expect(fs.existsSync(expectedCsv)).toBe(true)
+    } finally {
+      try { fs.unlinkSync(jsonPath) }  catch (_) {}
+      try { fs.unlinkSync(expectedMd) }  catch (_) {}
+      try { fs.unlinkSync(expectedCsv) } catch (_) {}
+    }
+  })
+
+  // ── Test 10: explicit destDir overrides output location ──────────────────────
+
+  test('output files appear in explicit destDir and not in the JSON file directory', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase One', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath  = writeFixture(wb)
+    const prefix    = 'TEST-P10'
+    const customDir = fs.mkdtempSync(path.join(TMPDIR, 'wb-paths-t10-'))
+    const jsonDir   = path.dirname(jsonPath)
+    try {
+      // Act
+      runRender(jsonPath, prefix, customDir)
+
+      // Assert: output files are in customDir
+      expect(fs.existsSync(path.join(customDir, `${prefix}-Work-Breakdown.md`))).toBe(true)
+      expect(fs.existsSync(path.join(customDir, `${prefix}-Work-Breakdown.csv`))).toBe(true)
+
+      // Assert: output files are NOT in the JSON's directory (unique prefix ensures no collision)
+      expect(fs.existsSync(path.join(jsonDir, `${prefix}-Work-Breakdown.md`))).toBe(false)
+      expect(fs.existsSync(path.join(jsonDir, `${prefix}-Work-Breakdown.csv`))).toBe(false)
+    } finally {
+      fs.rmSync(customDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+  // ── Test 11: stdout JSON contains markdownPath and csvPath keys ───────────────
+
+  test('stdout from a successful run is valid JSON with correct markdownPath and csvPath values', () => {
+    // Arrange
+    const task  = makeTask('T-01', 'BE')
+    const phase = makePhase('US-01', 'Phase One', [task])
+    const wb    = makeWb({ phases: [phase] })
+    const jsonPath = writeFixture(wb)
+    const tmpDir   = fs.mkdtempSync(path.join(TMPDIR, 'wb-paths-t11-'))
+    const prefix   = 'TEST-P11'
+    try {
+      // Act
+      const result = runRender(jsonPath, prefix, tmpDir)
+      const parsed = JSON.parse(result.stdout.trim())
+
+      // Assert: stdout JSON has the expected path keys with correct values
+      expect(parsed).toHaveProperty('markdownPath')
+      expect(parsed).toHaveProperty('csvPath')
+      expect(parsed.markdownPath).toBe(path.join(tmpDir, `${prefix}-Work-Breakdown.md`))
+      expect(parsed.csvPath).toBe(path.join(tmpDir, `${prefix}-Work-Breakdown.csv`))
+    } finally {
+      fs.rmSync(tmpDir, { recursive: true, force: true })
+      try { fs.unlinkSync(jsonPath) } catch (_) {}
+    }
+  })
+
+})

package/.claude/scripts/tests/wb-render.regression-pm-phase3-csv.test.js

@@ -0,0 +1,219 @@
+'use strict'
+
+const { spawnSync } = require('child_process')
+const os   = require('os')
+const fs   = require('fs')
+const path = require('path')
+
+const RENDER  = path.resolve(__dirname, '../wb-render.js')
+const FIXTURE = path.resolve(__dirname, 'fixtures/wb-valid.json')
+const TMPDIR  = os.tmpdir()
+const PREFIX  = 'REG-TEST'
+
+// Load the fixture JSON to derive expected values
+const fixtureWb = JSON.parse(fs.readFileSync(FIXTURE, 'utf8'))
+const allFixtureTasks = fixtureWb.phases.flatMap(p => p.tasks ?? [])
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Regression: CSV produced by wb-render.js is correctly parsed by pm-phase3
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe('wb-render.js → pm-phase3 CSV parsing regression', () => {
+  let tmpDir
+  let rawDataLines  // trimmed, non-header, non-empty lines from the CSV (raw strings)
+  let rows          // output of pm-phase3 row mapping + filter
+  let phaseMap      // output of pm-phase3 phase grouping
+
+  beforeAll(() => {
+    // Arrange: render the standard fixture into a unique temp directory
+    tmpDir = fs.mkdtempSync(path.join(TMPDIR, 'wb-reg-pm3-'))
+    spawnSync(process.execPath, [RENDER, FIXTURE, PREFIX, tmpDir], { encoding: 'utf8' })
+
+    const csvPath = path.join(tmpDir, `${PREFIX}-Work-Breakdown.csv`)
+    const csvContent = fs.readFileSync(csvPath, 'utf8')
+
+    // Save raw data lines for structural assertions (before pm-phase3 field mapping)
+    rawDataLines = csvContent
+      .split('\n')
+      .map(l => l.trim())
+      .filter(l => l && !l.startsWith('phase_id'))
+
+    // ── pm-phase3 parsing logic — inlined verbatim from pm-phase3.js lines 77-105 ─
+    rows = csvContent
+      .split('\n')
+      .map(l => l.trim())
+      .filter(l => l && !l.startsWith('phase_id'))  // skip header and empty lines
+      .map(l => {
+        const [phase_id, phase_title, commit_message, depends_on, task_id, task_title, domain, agent_type] = l.split('|')
+        return { phase_id, phase_title, commit_message, depends_on: depends_on || '', task_id, task_title, domain, agent_type }
+      })
+      .filter(r => r.phase_id && r.task_id)
+
+    // Group rows into phases preserving order
+    phaseMap = new Map()
+    for (const row of rows) {
+      if (!phaseMap.has(row.phase_id)) {
+        phaseMap.set(row.phase_id, {
+          phase_id:       row.phase_id,
+          title:          row.phase_title,
+          commit_message: row.commit_message,
+          depends_on:     row.depends_on.split(' ').filter(Boolean),  // [] for empty
+          impl_tasks:     [],
+          test_tasks:     [],
+        })
+      }
+      const p = phaseMap.get(row.phase_id)
+      if (row.domain === 'TEST') {
+        p.test_tasks.push({ task_id: row.task_id, agent_type: row.agent_type })
+      } else {
+        p.impl_tasks.push({ task_id: row.task_id, agent_type: row.agent_type })
+      }
+    }
+  })
+
+  afterAll(() => {
+    if (tmpDir) fs.rmSync(tmpDir, { recursive: true, force: true })
+  })
+
+  // ── Test 1: row count matches fixture task count ──────────────────────────────
+
+  test('rows.length equals the total number of tasks in the fixture after pm-phase3 parsing', () => {
+    // Arrange: allFixtureTasks derived from wb-valid.json (6 tasks across 2 phases)
+
+    // Act: rows computed in beforeAll via inlined pm-phase3 logic
+
+    // Assert
+    expect(rows.length).toBe(allFixtureTasks.length)
+  })
+
+  // ── Test 2: every raw data line has exactly 8 pipe-separated fields ───────────
+
+  test('every non-header data line in the CSV has exactly 8 pipe-separated fields', () => {
+    // Arrange: rawDataLines are the trimmed, non-empty, non-header lines
+    expect(rawDataLines.length).toBeGreaterThan(0)
+
+    // Act & Assert
+    for (const line of rawDataLines) {
+      expect(line.split('|')).toHaveLength(8)
+    }
+  })
+
+  // ── Test 3: every parsed row has non-empty phase_id and task_id ───────────────
+
+  test('every parsed row has a non-empty phase_id and task_id after pm-phase3 mapping', () => {
+    // Arrange: rows computed in beforeAll
+    expect(rows.length).toBeGreaterThan(0)
+
+    // Act & Assert
+    for (const row of rows) {
+      expect(row.phase_id).toBeTruthy()
+      expect(row.task_id).toBeTruthy()
+    }
+  })
+
+  // ── Test 4: phaseMap size matches fixture phase count ─────────────────────────
+
+  test('phaseMap.size equals the number of phases in the fixture', () => {
+    // Arrange: fixtureWb.phases has 2 phases (INFRA and US-01)
+
+    // Act: phaseMap computed in beforeAll
+
+    // Assert
+    expect(phaseMap.size).toBe(fixtureWb.phases.length)
+  })
+
+  // ── Test 5: INFRA phase has the correct impl_tasks count ─────────────────────
+
+  test('INFRA phase in phaseMap has 2 impl_tasks (the 2 non-TEST domain tasks)', () => {
+    // Arrange: fixture INFRA phase has INFRA-TASK-INFRA-01 and INFRA-TASK-INFRA-02 (domain INFRA)
+    const infraPhase = phaseMap.get('INFRA')
+
+    // Assert
+    expect(infraPhase).toBeDefined()
+    expect(infraPhase.impl_tasks).toHaveLength(2)
+  })
+
+  // ── Test 6: INFRA phase has the correct test_tasks count ─────────────────────
+
+  test('INFRA phase in phaseMap has 1 test_task (the TEST domain task)', () => {
+    // Arrange: fixture INFRA phase has INFRA-TASK-TEST-01 (domain TEST)
+    const infraPhase = phaseMap.get('INFRA')
+
+    // Assert
+    expect(infraPhase).toBeDefined()
+    expect(infraPhase.test_tasks).toHaveLength(1)
+  })
+
+  // ── Test 7: US-01 phase has the correct impl_tasks count ─────────────────────
+
+  test('US-01 phase in phaseMap has 2 impl_tasks (the 2 BE domain tasks)', () => {
+    // Arrange: fixture US-01 phase has US-01-TASK-BE-01 and US-01-TASK-BE-02 (domain BE)
+    const us01Phase = phaseMap.get('US-01')
+
+    // Assert
+    expect(us01Phase).toBeDefined()
+    expect(us01Phase.impl_tasks).toHaveLength(2)
+  })
+
+  // ── Test 8: US-01 phase has the correct test_tasks count ─────────────────────
+
+  test('US-01 phase in phaseMap has 1 test_task (the TEST domain task)', () => {
+    // Arrange: fixture US-01 phase has US-01-TASK-TEST-01 (domain TEST)
+    const us01Phase = phaseMap.get('US-01')
+
+    // Assert
+    expect(us01Phase).toBeDefined()
+    expect(us01Phase.test_tasks).toHaveLength(1)
+  })
+
+  // ── Test 9: INFRA phase depends_on is an empty array ─────────────────────────
+
+  test('INFRA phase depends_on is an empty array after split+filter because it has no external dependencies', () => {
+    // Arrange: INFRA phase tasks have no cross-phase dependsOn references
+    const infraPhase = phaseMap.get('INFRA')
+
+    // Assert
+    expect(infraPhase).toBeDefined()
+    expect(infraPhase.depends_on).toEqual([])
+  })
+
+  // ── Test 10: US-01 phase depends_on contains INFRA ───────────────────────────
+
+  test('US-01 phase depends_on contains "INFRA" because US-01-TASK-BE-01 references an INFRA-phase task', () => {
+    // Arrange: US-01-TASK-BE-01 has dependsOn: ['INFRA-TASK-INFRA-02'] (cross-phase)
+    const us01Phase = phaseMap.get('US-01')
+
+    // Assert
+    expect(us01Phase).toBeDefined()
+    expect(us01Phase.depends_on).toContain('INFRA')
+  })
+
+  // ── Test 11: no row has undefined as any field value ─────────────────────────
+
+  test('no parsed row has undefined as any of its 8 destructured field values', () => {
+    // Arrange: if the CSV had fewer than 8 pipe-delimited columns, destructuring would
+    // yield undefined for the missing positions — this test guards against that regression
+    const FIELDS = ['phase_id', 'phase_title', 'commit_message', 'depends_on', 'task_id', 'task_title', 'domain', 'agent_type']
+    expect(rows.length).toBeGreaterThan(0)
+
+    // Act & Assert
+    for (const row of rows) {
+      for (const field of FIELDS) {
+        expect(row[field]).not.toBeUndefined()
+      }
+    }
+  })
+
+  // ── Test 12: agent_type has no surrounding whitespace ────────────────────────
+
+  test('agent_type on every parsed row is a clean string with no surrounding whitespace', () => {
+    // Arrange: CSV rows end with a newline; l.trim() removes it, but this test confirms
+    // the agent_type value (last column) arrives clean after pm-phase3 parsing
+    expect(rows.length).toBeGreaterThan(0)
+
+    // Act & Assert
+    for (const row of rows) {
+      expect(row.agent_type).toBe(row.agent_type.trim())
+    }
+  })
+})