@dsivd/prestations-ng 19.2.0-beta.7 → 19.2.0-beta.9

package/CHANGELOG.md

@@ -8,6 +8,32 @@
 
 ## [19.2.0] - should be aligned with prestations-be 19.2.x
 
+### Added
+
+- [eslint/configs/spec-ts-recommended.mjs](projects/prestations-ng/src/eslint/configs/spec-ts-recommended.mjs)
+    - New `prestationsNg.configs.specTsRecommended` ESLint config for the Vitest specs, to use in the `extends` of a
+      `**/*.spec.ts` block: the `recommended` config of `@vitest/eslint-plugin`, which also counts the assertions of
+      the `HttpTestingController` and of the helpers of the specs. It needs `@vitest/eslint-plugin` in the
+      devDependencies of your project, only when you use it. See
+      [UPGRADING_V19.md](UPGRADING_V19.md#migrate-to-eslint-flat-configuration).
+- [foehn-bo-multi-upload.component.ts](projects/prestations-ng/src/foehn-upload/foehn-bo-multi-upload/foehn-bo-multi-upload.component.ts)
+    - New `localUpload` input. When set to `true`, selected files are kept purely local
+      (as `DocumentReferenceWithFile`, no `uploadUrl()` call) so they can be cancelled before
+      being sent. Files show up immediately in the list with a "pending" indicator (dictionary
+      key `foehn-uploader.pending-label`, French default provided) since they're not uploaded
+      yet. It is your responsibility to upload/delete them at save time,
+      e.g. via the new
+      [document-changes.helper.ts](projects/prestations-ng/src/foehn-upload/document-changes.helper.ts)
+      (`splitDocumentChanges`) which computes `filesToAdd`/`documentsToDelete` from the model.
+    - The default (direct upload) mode is unchanged.
+    - New `maxFileSizeInMo` input: a client-side, per-file size limit that doesn't depend on
+      the `fileMaxSizeInBytesByFormKey` server configuration (useful for consumers that don't
+      expose that config yet). When both are set, the smallest limit applies. A file too big gets
+      the usual `413` error, which can be customized with `customErrors` (`{fileName}`,
+      `{fileMaxSize}`).
+    - New `chooseButtonStyleModifier` input, appended to the choose button's CSS classes
+      (e.g. `btn-sm`), mirroring the same input already available on other uploaders.
+
 ### Changed
 
 Library now runs as strict mode, which may cause some errors to appear in your project after updating.
@@ -41,7 +67,7 @@ Please check the [UPGRADING_V19.md](UPGRADING_V19.md) guide for more information
       (_read-only_), `timeslotRemaining` (_read-only_), `canClose` (_read-only_)
     - `foehn-autocomplete`: `searchValue`, `inputHasFocus`, `hideSuggestions`, `displayedElements`,
       `notificationMessageUpdated`, `VIEW_PORT_HEIGHT` (_read-only_)
-    - `foehn-multiselect-autocomplete`: `autocompleteInputValue`, `showEmptyListMessage`, `srAnnouncements`
+    - `foehn-multiselect-autocomplete`: `autocompleteInputValue`, `showEmptyListMessage` (_read-only_), `srAnnouncements`
     - `foehn-select`, `foehn-radio`, `foehn-checkbox` and the autocompletes (`FoehnCheckableGroupComponent`):
       `groupedElements`
     - `foehn-radio`: `inputValue`
@@ -98,6 +124,11 @@ Please check the [UPGRADING_V19.md](UPGRADING_V19.md) guide for more information
 
 ### Fixed
 
+- `foehn-multiselect-autocomplete`: the suggestions and the message displayed once every element is selected follow a
+  model changed by the project, not only by the user. Once every element was selected, a model set back to some of
+  them kept the message and the hidden input; a model selecting every element did not display the message; the
+  suggestions still contained the elements selected by the project. An empty list of elements no longer displays
+  the message (every element of the list has already been added).
 - `providePrestationsNgCore()` registers again the HTTP interceptors lost with `FoehnPageModule` in 19.0.0: the
   `foehn-transmit-waiting-modal` is displayed again during a long transmission, the warning before the expiration of
   the session receives its date again, and a new version of the application deployed meanwhile is detected again.

package/CONTRIBUTING.md

@@ -94,9 +94,10 @@ This project uses a set of scripts to lint and format the code, along with pre-c
 
 Important scripts are :
 
-- `npm run lint` : run ESLint and Prettier on all files
+- `npm run lint` : run ESLint and Prettier on all files, and check the types of the TypeScript files compiled by no
+  build (`lint:types`: `cypress/`, which Cypress only transpiles, and the configuration files of `tsconfig.config.json`)
 - `npm run format`: run ESLint and Prettier on all files and fix errors automatically
-- `npm run validate`: clean and run all tests
+- `npm run validate`: clean, lint and run all tests
 
 **Husky** is used as a pre-commit hook to automatically output linting and formatting errors for staged files before committing.
 In the end, this utilitary calls `npm run lint-staged` which you can also call yourself of course. To have this pre-commit hook,

package/UPGRADING_V19.md

@@ -1064,6 +1064,8 @@ npm install --save-dev eslint-plugin-simple-import-sort@13
 npm install --save-dev eslint-config-prettier@10
 npm install --save-dev eslint-plugin-import-x@4
 npm install --save-dev prettier
+# only if your project has Vitest specs (see "Migrate to vitest")
+npm install --save-dev @vitest/eslint-plugin@1
 ```
 
 In your `front` folder, add a `.prettierrc` file with the following content:
@@ -1140,6 +1142,12 @@ export default tseslint.config(
         extends: [...prestationsNg.configs.templateRecommended],
     },
 
+    // ─── Vitest specs (only if your project has Vitest specs) ─────────────────
+    {
+        files: ['**/*.spec.ts'],
+        extends: [...prestationsNg.configs.specTsRecommended],
+    },
+
     // ─── Prettier (must be last — disables formatting rules) ───────────────────
     prettier,
 );
@@ -1150,6 +1158,11 @@ everything: the `eslint`, `typescript-eslint` and `angular-eslint` baselines, th
 accessibility set, the naming and import conventions, and the rules written by the library
 itself. You declare no `plugins` and list no rule.
 
+`specTsRecommended` is the `recommended` config of `@vitest/eslint-plugin`, which also counts the assertions
+made by the `HttpTestingController` (`expectOne`, `expectNone`, `verify`) and by helpers named `expect*`,
+`assert*` or `test*`. The `**/*.spec.ts` pattern does not reach the Cypress `*.spec.cy.ts` files. It needs
+`@vitest/eslint-plugin` only when you use it: the other configs work without it.
+
 The packages installed above are still required — the library's config imports them from your
 `node_modules` rather than shipping its own copies. For the same reason, do **not** spread
 `angular.configs.tsRecommended` or `angular.configs.templateRecommended` yourself: they are

package/eslint/configs/spec-ts-recommended.mjs

@@ -0,0 +1,34 @@
+/**
+ * The house preset of the Vitest specs: the recommended rules of `@vitest/eslint-plugin`, with the
+ * assertions also made by the helpers of the specs and by the `HttpTestingController`.
+ *
+ * Meant for the `extends` of a `**\/*.spec.ts` block (the Cypress `*.spec.cy.ts` files are not
+ * Vitest specs).
+ *
+ * @param {import('@vitest/eslint-plugin').default} vitest the `@vitest/eslint-plugin` module
+ * @returns {import('typescript-eslint').ConfigArray}
+ */
+const specTsRecommended = (vitest) => [
+    vitest.configs.recommended,
+    {
+        name: 'prestations-ng/spec-ts-recommended',
+        rules: {
+            'vitest/expect-expect': [
+                'error',
+                {
+                    assertFunctionNames: [
+                        'expect',
+                        'expect*',
+                        'assert*',
+                        'test*',
+                        '*.expectOne',
+                        '*.expectNone',
+                        '*.verify',
+                    ],
+                },
+            ],
+        },
+    },
+];
+
+export default specTsRecommended;

package/eslint/index.mjs

@@ -1,9 +1,17 @@
+import specTsRecommended from './configs/spec-ts-recommended.mjs';
 import templateRecommended from './configs/template-recommended.mjs';
 import templateRules from './configs/template-rules.mjs';
 import tsRecommended from './configs/ts-recommended.mjs';
 import tsRules from './configs/ts-rules.mjs';
 import rules from './rules/index.mjs';
 
+// Only needed by the projects linting Vitest specs: the other configs can be used without it.
+const vitest = await import('@vitest/eslint-plugin').then(
+    (module) => module.default,
+    () => null,
+);
+const specTsRecommendedConfig = vitest ? specTsRecommended(vitest) : null;
+
 const plugin = {
     meta: { name: '@dsivd/prestations-ng' },
     rules,
@@ -16,6 +24,15 @@ const configs = {
     // Only this library's own rules, for a project that supplies its own style.
     tsRules: tsRules(plugin),
     templateRules: templateRules(plugin),
+    // The preset of the Vitest specs (needs @vitest/eslint-plugin)
+    get specTsRecommended() {
+        if (!specTsRecommendedConfig) {
+            throw new Error(
+                'prestationsNg.configs.specTsRecommended needs @vitest/eslint-plugin: npm install --save-dev @vitest/eslint-plugin@1',
+            );
+        }
+        return specTsRecommendedConfig;
+    },
 };
 
 export { configs, plugin, rules };