@dsivd/prestations-ng 19.2.0-beta.24 → 19.2.0-beta.26
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +10 -6
- package/ESLINT_PLUGIN.md +19 -2
- package/GOOD_PRACTICES.md +60 -17
- package/UPGRADING_V19.md +5 -2
- package/eslint/configs/ts-recommended.mjs +5 -0
- package/fesm2022/dsivd-prestations-ng.mjs +2 -1
- package/fesm2022/dsivd-prestations-ng.mjs.map +1 -1
- package/package.json +1 -1
- package/schematics/ng-update/migrations/update-19_2_0/index.js +4 -3
- package/schematics/utility/form-signal/form-signal-migration.js +13 -1
- package/src/eslint/configs/__tests__/configs.test.mjs +15 -0
- package/src/eslint/configs/ts-recommended.mjs +5 -0
- package/types/dsivd-prestations-ng.d.ts +2 -1
package/package.json
CHANGED
|
@@ -39,7 +39,7 @@
|
|
|
39
39
|
"ng-update": {
|
|
40
40
|
"migrations": "./schematics/migration-collection.json"
|
|
41
41
|
},
|
|
42
|
-
"version": "19.2.0-beta.
|
|
42
|
+
"version": "19.2.0-beta.26",
|
|
43
43
|
"module": "fesm2022/dsivd-prestations-ng.mjs",
|
|
44
44
|
"typings": "types/dsivd-prestations-ng.d.ts",
|
|
45
45
|
"exports": {
|
|
@@ -24,8 +24,9 @@ exports.default = () => (tree, context) => __awaiter(void 0, void 0, void 0, fun
|
|
|
24
24
|
}
|
|
25
25
|
context.logger.info(`Applying migration for prestations-ng to version ${version}: the form and the reference of the pages are signals`);
|
|
26
26
|
const report = (0, form_signal_migration_1.migrateFormSignal)(tree, yield loadCompiler());
|
|
27
|
-
context.logger.info(`
|
|
28
|
-
`${report.
|
|
27
|
+
context.logger.info(`Checked ${report.pages} pages, migrated ${report.migratedPages} of them and ${report.templates} templates: ` +
|
|
28
|
+
`${report.writes} writes of the form, ${report.tracks} lists tracked by $index, ` +
|
|
29
|
+
`${report.listPaths} getList() replaced by getListPath(), ` +
|
|
29
30
|
`${report.redeclarations} fields hiding a signal of the page removed.`);
|
|
30
31
|
if (report.warnings.length) {
|
|
31
32
|
context.logger.warn([
|
|
@@ -36,4 +37,4 @@ exports.default = () => (tree, context) => __awaiter(void 0, void 0, void 0, fun
|
|
|
36
37
|
}
|
|
37
38
|
return tree;
|
|
38
39
|
});
|
|
39
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
40
|
+
//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiaW5kZXguanMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi8uLi8uLi8uLi9wcm9qZWN0cy9wcmVzdGF0aW9ucy1uZy9zY2hlbWF0aWNzL25nLXVwZGF0ZS9taWdyYXRpb25zL3VwZGF0ZS0xOV8yXzAvaW5kZXgudHMiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6Ijs7Ozs7Ozs7Ozs7QUFBQSwyREFLb0M7QUFFcEMsOEZBQXVGO0FBR3ZGLE1BQU0sT0FBTyxHQUFHLFFBQVEsQ0FBQztBQUV6Qjs7O0dBR0c7QUFDSCxNQUFNLFlBQVksR0FBRyxHQUFzQixFQUFFLENBQ3pDLElBQUksUUFBUSxDQUFDLFdBQVcsRUFBRSwwQkFBMEIsQ0FBQyxDQUNqRCxtQkFBbUIsQ0FDRCxDQUFDO0FBRTNCLGtCQUFlLEdBQVMsRUFBRSxDQUFDLENBQU8sSUFBVSxFQUFFLE9BQXlCLEVBQUUsRUFBRTtJQUN2RSxnREFBZ0Q7SUFDaEQsSUFBSSxDQUFDLElBQUksQ0FBQyxNQUFNLENBQUMsY0FBYyxDQUFDLEVBQUUsQ0FBQztRQUMvQixNQUFNLElBQUksZ0NBQW1CLENBQ3pCLG9FQUFvRSxDQUN2RSxDQUFDO0lBQ04sQ0FBQztJQUNELE9BQU8sQ0FBQyxNQUFNLENBQUMsSUFBSSxDQUNmLG9EQUFvRCxPQUFPLHVEQUF1RCxDQUNySCxDQUFDO0lBQ0YsTUFBTSxNQUFNLEdBQUcsSUFBQSx5Q0FBaUIsRUFBQyxJQUFJLEVBQUUsTUFBTSxZQUFZLEVBQUUsQ0FBQyxDQUFDO0lBQzdELE9BQU8sQ0FBQyxNQUFNLENBQUMsSUFBSSxDQUNmLFdBQVcsTUFBTSxDQUFDLEtBQUssb0JBQW9CLE1BQU0sQ0FBQyxhQUFhLGdCQUFnQixNQUFNLENBQUMsU0FBUyxjQUFjO1FBQ3pHLEdBQUcsTUFBTSxDQUFDLE1BQU0sd0JBQXdCLE1BQU0sQ0FBQyxNQUFNLDRCQUE0QjtRQUNqRixHQUFHLE1BQU0sQ0FBQyxTQUFTLHdDQUF3QztRQUMzRCxHQUFHLE1BQU0sQ0FBQyxjQUFjLDhDQUE4QyxDQUM3RSxDQUFDO0lBQ0YsSUFBSSxNQUFNLENBQUMsUUFBUSxDQUFDLE1BQU0sRUFBRSxDQUFDO1FBQ3pCLE9BQU8sQ0FBQyxNQUFNLENBQUMsSUFBSSxDQUNmO1lBQ0kscUJBQXFCLE1BQU0sQ0FBQyxRQUFRLENBQUMsTUFBTSxrREFBa0Q7Z0JBQ3pGLGdFQUFnRTtZQUNwRSxHQUFHLE1BQU0sQ0FBQyxRQUFRLENBQUMsR0FBRyxDQUFDLENBQUMsT0FBTyxFQUFFLEVBQUUsQ0FBQyxLQUFLLE9BQU8sRUFBRSxDQUFDO1NBQ3RELENBQUMsSUFBSSxDQUFDLElBQUksQ0FBQyxDQUNmLENBQUM7SUFDTixDQUFDO0lBQ0QsT0FBTyxJQUFJLENBQUM7QUFDaEIsQ0FBQyxDQUFBLENBQUMifQ==
|
|
@@ -25,6 +25,7 @@ const SKIPPED_DIRECTORIES = new Set([
|
|
|
25
25
|
function migrateFormSignal(tree, compiler) {
|
|
26
26
|
const report = {
|
|
27
27
|
pages: 0,
|
|
28
|
+
migratedPages: 0,
|
|
28
29
|
templates: 0,
|
|
29
30
|
writes: 0,
|
|
30
31
|
tracks: 0,
|
|
@@ -56,6 +57,11 @@ function migrateFormSignal(tree, compiler) {
|
|
|
56
57
|
formType: page.formType,
|
|
57
58
|
});
|
|
58
59
|
edits.push(...classResult.edits);
|
|
60
|
+
// A page is migrated when its class or its template changes
|
|
61
|
+
const classMigrated = classResult.edits.length > 0;
|
|
62
|
+
if (classMigrated) {
|
|
63
|
+
report.migratedPages++;
|
|
64
|
+
}
|
|
59
65
|
report.writes += classResult.writes;
|
|
60
66
|
report.listPaths += classResult.listPaths;
|
|
61
67
|
report.redeclarations += classResult.redeclarations;
|
|
@@ -90,6 +96,9 @@ function migrateFormSignal(tree, compiler) {
|
|
|
90
96
|
: templateResult.content,
|
|
91
97
|
});
|
|
92
98
|
report.templates++;
|
|
99
|
+
if (!classMigrated) {
|
|
100
|
+
report.migratedPages++;
|
|
101
|
+
}
|
|
93
102
|
}
|
|
94
103
|
report.writes += templateResult.writes;
|
|
95
104
|
report.tracks += templateResult.tracks;
|
|
@@ -102,6 +111,9 @@ function migrateFormSignal(tree, compiler) {
|
|
|
102
111
|
if (templateResult.content !== template) {
|
|
103
112
|
tree.overwrite(templatePath, templateResult.content);
|
|
104
113
|
report.templates++;
|
|
114
|
+
if (!classMigrated) {
|
|
115
|
+
report.migratedPages++;
|
|
116
|
+
}
|
|
105
117
|
}
|
|
106
118
|
report.writes += templateResult.writes;
|
|
107
119
|
report.tracks += templateResult.tracks;
|
|
@@ -181,4 +193,4 @@ function objectPathImport(source) {
|
|
|
181
193
|
text: `${end ? '\n' : ''}import { ObjectPath } from '@dsivd/prestations-ng';${end ? '' : '\n'}`,
|
|
182
194
|
};
|
|
183
195
|
}
|
|
184
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
196
|
+
//# sourceMappingURL=data:application/json;base64,{"version":3,"file":"form-signal-migration.js","sourceRoot":"","sources":["../../../../../projects/prestations-ng/schematics/utility/form-signal/form-signal-migration.ts"],"names":[],"mappings":";;AAwCA,8CAyIC;AAjLD,+CAAgE;AAEhE,iCAAiC;AAEjC,uDAAqD;AACrD,mCAAqE;AACrE,iDAAyE;AACzE,6DAAiE;AAEjE,MAAM,mBAAmB,GAAG,IAAI,GAAG,CAAC;IAChC,cAAc;IACd,MAAM;IACN,UAAU;IACV,MAAM;IACN,UAAU;CACb,CAAC,CAAC;AAiBH;;;;;;;GAOG;AACH,SAAgB,iBAAiB,CAC7B,IAAU,EACV,QAAkB;IAElB,MAAM,MAAM,GAA8B;QACtC,KAAK,EAAE,CAAC;QACR,aAAa,EAAE,CAAC;QAChB,SAAS,EAAE,CAAC;QACZ,MAAM,EAAE,CAAC;QACT,MAAM,EAAE,CAAC;QACT,SAAS,EAAE,CAAC;QACZ,cAAc,EAAE,CAAC;QACjB,QAAQ,EAAE,EAAE;KACf,CAAC;IACF,MAAM,KAAK,GAAG,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACzC,MAAM,KAAK,GAAG,IAAA,8BAAe,EAAC,KAAK,CAAC,CAAC;IACrC,MAAM,WAAW,GAAG,IAAI,GAAG,EAA4B,CAAC;IACxD,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;;QACnB,OAAA,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,EAAE;YACvB,GAAG,CAAC,MAAA,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,mCAAI,EAAE,CAAC;YACrC,IAAI;SACP,CAAC,CAAA;KAAA,CACL,CAAC;IAEF,MAAM,IAAI,GAAG,CACT,IAAY,EACZ,IAAY,EACZ,QAA4B,EAC5B,MAAM,GAAG,CAAC,EACN,EAAE;QACN,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CACzB,MAAM,CAAC,QAAQ,CAAC,IAAI,CAChB,GAAG,IAAI,IAAI,IAAA,cAAM,EAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,KAAK,OAAO,CAAC,OAAO,EAAE,CACzE,CACJ,CAAC;IACN,CAAC,CAAC;IAEF,KAAK,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,IAAI,WAAW,EAAE,CAAC;QAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC;QAC9B,MAAM,KAAK,GAAW,EAAE,CAAC;QACzB,IAAI,qBAAqB,GAAG,KAAK,CAAC;QAClC,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;YAC3B,MAAM,CAAC,KAAK,EAAE,CAAC;YACf,MAAM,WAAW,GAAG,IAAA,kCAAgB,EAAC,IAAI,CAAC,MAAM,EAAE,IAAI,CAAC,IAAI,EAAE;gBACzD,UAAU,EAAE,IAAI,CAAC,UAAU;gBAC3B,QAAQ,EAAE,IAAI,CAAC,QAAQ;aAC1B,CAAC,CAAC;YACH,KAAK,CAAC,IAAI,CAAC,GAAG,WAAW,CAAC,KAAK,CAAC,CAAC;YACjC,4DAA4D;YAC5D,MAAM,aAAa,GAAG,WAAW,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC;YACnD,IAAI,aAAa,EAAE,CAAC;gBAChB,MAAM,CAAC,aAAa,EAAE,CAAC;YAC3B,CAAC;YACD,MAAM,CAAC,MAAM,IAAI,WAAW,CAAC,MAAM,CAAC;YACpC,MAAM,CAAC,SAAS,IAAI,WAAW,CAAC,SAAS,CAAC;YAC1C,MAAM,CAAC,cAAc,IAAI,WAAW,CAAC,cAAc,CAAC;YACpD,qBAAqB,KAArB,qBAAqB,GAAK,WAAW,CAAC,qBAAqB,EAAC;YAC5D,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,WAAW,CAAC,QAAQ,CAAC,CAAC;YAE5C,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;gBACtB,MAAM,KAAK,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;gBAC5D,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CACvB,KAAK,EACL,IAAI,CAAC,cAAc,CAAC,MAAM,EAAE,GAAG,CAAC,CACnC,CAAC;gBACF,qGAAqG;gBACrG,yEAAyE;gBACzE,MAAM,KAAK,GAAG,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,cAAc,CAAC;oBACjD,CAAC,CAAC,IAAI,CAAC,KAAK,GAAG,CAAC,CAAC;oBACjB,CAAC,CAAC,IAAI,CAAC;gBACX,IAAI,KAAK,IAAI,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;oBACnC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE;wBAClB;4BACI,MAAM,EAAE,KAAK;4BACb,OAAO,EACH,+EAA+E;yBACtF;qBACJ,CAAC,CAAC;oBACH,SAAS;gBACb,CAAC;gBACD,MAAM,cAAc,GAAG,IAAA,oCAAe,EAClC,QAAQ,EACR,QAAQ,EACR,IAAI,CAAC,IAAI,EACT,EAAE,UAAU,EAAE,IAAI,CAAC,UAAU,EAAE,CAClC,CAAC;gBACF,IAAI,cAAc,CAAC,OAAO,KAAK,QAAQ,EAAE,CAAC;oBACtC,KAAK,CAAC,IAAI,CAAC;wBACP,KAAK;wBACL,GAAG,EAAE,IAAI,CAAC,cAAc,CAAC,MAAM,EAAE,GAAG,CAAC;wBACrC,IAAI,EAAE,KAAK;4BACP,CAAC,CAAC,cAAc,CAAC,OAAO;iCACjB,UAAU,CAAC,KAAK,EAAE,KAAK,KAAK,EAAE,CAAC;iCAC/B,UAAU,CAAC,IAAI,EAAE,KAAK,CAAC;4BAC9B,CAAC,CAAC,cAAc,CAAC,OAAO;qBAC/B,CAAC,CAAC;oBACH,MAAM,CAAC,SAAS,EAAE,CAAC;oBACnB,IAAI,CAAC,aAAa,EAAE,CAAC;wBACjB,MAAM,CAAC,aAAa,EAAE,CAAC;oBAC3B,CAAC;gBACL,CAAC;gBACD,MAAM,CAAC,MAAM,IAAI,cAAc,CAAC,MAAM,CAAC;gBACvC,MAAM,CAAC,MAAM,IAAI,cAAc,CAAC,MAAM,CAAC;gBACvC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,cAAc,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;YAC1D,CAAC;iBAAM,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;gBAC1B,MAAM,YAAY,GAAG,IAAA,WAAI,EACrB,IAAA,cAAO,EAAC,IAAA,gBAAS,EAAC,IAAI,CAAC,IAAI,CAAC,CAAC,EAC7B,IAAI,CAAC,WAAW,CACnB,CAAC;gBACF,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC;gBAC7C,MAAM,cAAc,GAAG,IAAA,oCAAe,EAClC,QAAQ,EACR,QAAQ,EACR,YAAY,EACZ,EAAE,UAAU,EAAE,IAAI,CAAC,UAAU,EAAE,CAClC,CAAC;gBACF,IAAI,cAAc,CAAC,OAAO,KAAK,QAAQ,EAAE,CAAC;oBACtC,IAAI,CAAC,SAAS,CAAC,YAAY,EAAE,cAAc,CAAC,OAAO,CAAC,CAAC;oBACrD,MAAM,CAAC,SAAS,EAAE,CAAC;oBACnB,IAAI,CAAC,aAAa,EAAE,CAAC;wBACjB,MAAM,CAAC,aAAa,EAAE,CAAC;oBAC3B,CAAC;gBACL,CAAC;gBACD,MAAM,CAAC,MAAM,IAAI,cAAc,CAAC,MAAM,CAAC;gBACvC,MAAM,CAAC,MAAM,IAAI,cAAc,CAAC,MAAM,CAAC;gBACvC,IAAI,CAAC,YAAY,EAAE,QAAQ,EAAE,cAAc,CAAC,QAAQ,CAAC,CAAC;YAC1D,CAAC;QACL,CAAC;QACD,IAAI,qBAAqB,EAAE,CAAC;YACxB,KAAK,CAAC,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC;QAC9C,CAAC;QACD,MAAM,QAAQ,GAAG,IAAA,kBAAU,EAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QACzC,IAAI,QAAQ,KAAK,IAAI,EAAE,CAAC;YACpB,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;QACxC,CAAC;IACL,CAAC;IACD,OAAO,MAAM,CAAC;AAClB,CAAC;AAED,SAAS,eAAe,CAAC,SAAmB;IACxC,MAAM,KAAK,GAAkB,EAAE,CAAC;IAChC,KAAK,MAAM,IAAI,IAAI,SAAS,CAAC,QAAQ,EAAE,CAAC;QACpC,IAAI,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,EAAE,CAAC;YAClD,MAAM,KAAK,GAAG,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACnC,IAAI,KAAK,EAAE,CAAC;gBACR,KAAK,CAAC,IAAI,CAAC;oBACP,IAAI,EAAE,KAAK,CAAC,IAAI;oBAChB,MAAM,EAAE,EAAE,CAAC,gBAAgB,CACvB,KAAK,CAAC,IAAI,EACV,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAC,EAC/B,EAAE,CAAC,YAAY,CAAC,MAAM,EACtB,IAAI,CACP;iBACJ,CAAC,CAAC;YACP,CAAC;QACL,CAAC;IACL,CAAC;IACD,KAAK,MAAM,IAAI,IAAI,SAAS,CAAC,OAAO,EAAE,CAAC;QACnC,IAAI,CAAC,mBAAmB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACjC,KAAK,CAAC,IAAI,CAAC,GAAG,eAAe,CAAC,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACxD,CAAC;IACL,CAAC;IACD,OAAO,KAAK,CAAC;AACjB,CAAC;AAED;;GAEG;AACH,SAAS,gBAAgB,CAAC,MAAqB;;IAC3C,MAAM,OAAO,GAAG,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,EAAE,CAAC,mBAAmB,CAAC,CAAC;IACjE,KAAK,MAAM,WAAW,IAAI,OAAO,EAAE,CAAC;QAChC,MAAM,aAAa,GAAG,MAAA,WAAW,CAAC,YAAY,0CAAE,aAAa,CAAC;QAC9D,IACI,EAAE,CAAC,eAAe,CAAC,WAAW,CAAC,eAAe,CAAC;YAC/C,WAAW,CAAC,eAAe,CAAC,IAAI,KAAK,uBAAuB;YAC5D,aAAa;YACb,EAAE,CAAC,cAAc,CAAC,aAAa,CAAC;YAChC,CAAC,CAAA,MAAA,WAAW,CAAC,YAAY,0CAAE,UAAU,CAAA,EACvC,CAAC;YACC,IACI,aAAa,CAAC,QAAQ,CAAC,IAAI,CACvB,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,KAAK,YAAY,CAClD,EACH,CAAC;gBACC,OAAO,EAAE,KAAK,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC;YAC1C,CAAC;YACD,wFAAwF;YACxF,MAAM,QAAQ,GAAG,aAAa,CAAC,QAAQ,CAAC;YACxC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CACtB,CAAC,OAAO,EAAE,EAAE,CACR,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,YAAY,EAAE,IAAI,EAAE;gBAChD,WAAW,EAAE,MAAM;aACtB,CAAC,GAAG,CAAC,CACb,CAAC;YACF,MAAM,SAAS,GACX,QAAQ,CAAC,MAAM,GAAG,CAAC;gBACf,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CACb,QAAQ,CAAC,CAAC,CAAC,CAAC,MAAM,EAAE,EACpB,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,CAC/B;gBACH,CAAC,CAAC,IAAI,CAAC;YACf,IAAI,IAAI,EAAE,CAAC;gBACP,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;gBACpC,OAAO,EAAE,KAAK,EAAE,GAAG,EAAE,KAAK,EAAE,IAAI,EAAE,aAAa,SAAS,EAAE,EAAE,CAAC;YACjE,CAAC;YACD,MAAM,IAAI,GAAG,QAAQ,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;YAC3C,OAAO;gBACH,KAAK,EAAE,IAAI,CAAC,MAAM,EAAE;gBACpB,GAAG,EAAE,IAAI,CAAC,MAAM,EAAE;gBAClB,IAAI,EAAE,GAAG,SAAS,YAAY;aACjC,CAAC;QACN,CAAC;IACL,CAAC;IACD,MAAM,GAAG,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;IACtE,OAAO;QACH,KAAK,EAAE,GAAG;QACV,GAAG;QACH,IAAI,EAAE,GAAG,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,sDAAsD,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE;KAClG,CAAC;AACN,CAAC"}
|
|
@@ -126,6 +126,21 @@ describe('eslint configs', () => {
|
|
|
126
126
|
);
|
|
127
127
|
});
|
|
128
128
|
|
|
129
|
+
describe('tsRecommended', () => {
|
|
130
|
+
// The last entry setting a rule wins, as in ESLint
|
|
131
|
+
const rules = Object.assign(
|
|
132
|
+
{},
|
|
133
|
+
...configs.tsRecommended.map((entry) => entry.rules ?? {}),
|
|
134
|
+
);
|
|
135
|
+
|
|
136
|
+
it('should report a constructor only calling super() with the rule of typescript-eslint', () => {
|
|
137
|
+
expect(rules['@typescript-eslint/no-useless-constructor']).toBe(
|
|
138
|
+
'error',
|
|
139
|
+
);
|
|
140
|
+
expect(rules['no-useless-constructor']).toBe('off');
|
|
141
|
+
});
|
|
142
|
+
});
|
|
143
|
+
|
|
129
144
|
describe('specTsRecommended', () => {
|
|
130
145
|
const rulesOf = (config) =>
|
|
131
146
|
Object.assign({}, ...config.map((entry) => entry.rules ?? {}));
|
|
@@ -92,6 +92,11 @@ const tsRecommended = (plugin) => [
|
|
|
92
92
|
// off here — @typescript-eslint/no-shadow handles it correctly for TS
|
|
93
93
|
'no-shadow': 'off',
|
|
94
94
|
'@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
|
|
95
|
+
// a constructor only passing its parameters to super(), e.g. the
|
|
96
|
+
// `constructor() { super(); }` left once the services are injected with
|
|
97
|
+
// inject(); off here — the core rule ignores the parameter properties
|
|
98
|
+
'no-useless-constructor': 'off',
|
|
99
|
+
'@typescript-eslint/no-useless-constructor': 'error',
|
|
95
100
|
'@typescript-eslint/no-unused-vars': [
|
|
96
101
|
'error',
|
|
97
102
|
{
|
|
@@ -334,7 +334,8 @@ declare abstract class FoehnInputComponent<T> implements OnInit, AfterViewInit {
|
|
|
334
334
|
* Writes a value at a path of the model, in a new model: the objects and arrays along the path are copied, the
|
|
335
335
|
* others are kept as they are (`ObjectPathHelper`), and the result goes through `updateNgModel()`. Bind a field of
|
|
336
336
|
* an object edited as is with `[model]="model()?.firstName" (modelChange)="patchNgModel(['firstName'], $event)"`,
|
|
337
|
-
* or replace an item of a list with `patchNgModel([index],
|
|
337
|
+
* or replace an item of a list with `[model]="item" (modelChange)="patchNgModel([$index], $event)"`. The same
|
|
338
|
+
* value changes nothing.
|
|
338
339
|
*
|
|
339
340
|
* @param path the keys and indexes leading to the value, e.g. `['address', 'street']` or `[index]`
|
|
340
341
|
* @param value the new value (`null` and `undefined` included: the model of the `foehn-*` components can be)
|