@dsivd/prestations-ng 19.2.0-beta.12 → 19.2.0-beta.14

package/UPGRADING_V19.md

@@ -1448,6 +1448,36 @@ When using `IntelliJ`, you can run code inspection on your project to fix deprec
 - In your `tsconfig.json` file, add `"strict": true` in `compilerOptions` and remove `alwaysStrict`, `noImplicitThis`, `strictBindCallApply` and `strictFunctionTypes` as they are already included in `strict` mode.
 - In your `tsconfig.json` file, remove `useDefineForClassFields` from `compilerOptions`.
 
+Without `useDefineForClassFields: false`, the class fields follow the standard semantics: they are initialized before
+the body of the constructor, so before the parameter properties, and a field declared again in a subclass overwrites
+the value set by the parent class. Two errors can appear:
+
+- TS2729 (`Property 'x' is used before its initialization`): a field initializer uses a parameter property of the
+  constructor. Use `inject()` in the initializer, or assign the field in the constructor. Don't move a
+  `private readonly x = inject(X)` field above the public fields: the `@typescript-eslint/member-ordering` rule of
+  `@dsivd/prestations-ng/eslint` wants the public fields first.
+
+    ```diff
+    - readonly items = toSignal(this.itemService.getItems(), { initialValue: [] });
+    -
+    - constructor(private readonly itemService: ItemService) {}
+    + readonly items = toSignal(inject(ItemService).getItems(), { initialValue: [] });
+    ```
+
+    ```ts
+    readonly items: Signal<Item[]>;
+
+    private readonly itemService = inject(ItemService);
+
+    constructor() {
+        this.items = toSignal(this.itemService.getItems(), { initialValue: [] });
+    }
+    ```
+
+- TS2612 (`Property 'x' will overwrite the base property`): a subclass declares again a field of its parent class,
+  e.g. to narrow its type. Add `declare` (`declare form: MyForm | null | undefined;`) or remove the declaration, but
+  never add an initializer: it would overwrite the value set by the parent class.
+
 Now fix your project until no more errors (unlike `tsc -b`, these commands write nothing):
 
 ```bash
@@ -1563,7 +1593,7 @@ then uninstall zone.js:
 npm uninstall zone.js
 ```
 
-`zone.js` stays in your `package-lock.json` as an optional peer dependency of `@angular/core`: this is expected. Check
+`zone.js` can stay in your `package-lock.json` as an optional peer dependency of `@angular/core`: this is expected. Check
 instead that the build of your application no longer outputs a `polyfills` chunk (unless you still have other
 polyfills, e.g. `@angular/localize/init`).
 
@@ -1618,6 +1648,10 @@ Pay attention to:
     }
     ```
 
+- the fields read by the template and set in `ngAfterViewInit()`, `ngAfterContentInit()` or `ngAfterViewChecked()`:
+  derive them with `computed()` from `viewChild()` or `contentChild()` (see "Deriving a state from view queries"
+  in [GOOD_PRACTICES.md](GOOD_PRACTICES.md)).
+
 - `NgZone`: `onStable`, `onMicrotaskEmpty` and `onUnstable` never emit without zone.js, and `run()` or
   `runOutsideAngular()` are useless. To act on the rendered DOM (focus, scroll...), replace them, as well as the
   `setTimeout()` waiting for the view, by `afterNextRender()`. `AbstractMenuPageComponent.ngZone` is deprecated.
@@ -1637,7 +1671,9 @@ Pay attention to:
   (`ExpressionChangedAfterItHasBeenCheckedError`). Fix the component (signal, `markForCheck()`) rather than the
   test.
 - `await fixture.whenStable()` waits for the change detection and for the pending tasks of the application
-  (e.g. the debounced `userInput` of the prestations-ng inputs), not for the timers.
+  (e.g. the debounced `userInput` of the prestations-ng inputs), not for the timers, nor for the HTTP requests of a
+  spec: `provideHttpClientTesting()` keeps them pending until the test answers them. Answer them first with
+  `HttpTestingController` (`expectOne(...).flush(...)`), then `await fixture.whenStable()`.
 
 ### Last but not least, check if your application is working!!!
 

package/package.json

@@ -39,7 +39,7 @@
   "ng-update": {
     "migrations": "./schematics/migration-collection.json"
   },
-  "version": "19.2.0-beta.12",
+  "version": "19.2.0-beta.14",
   "module": "fesm2022/dsivd-prestations-ng.mjs",
   "typings": "types/dsivd-prestations-ng.d.ts",
   "exports": {