@dsivd/prestations-ng 19.2.0-beta.11 → 19.2.0-beta.13

package/UPGRADING_V19.md

@@ -1246,7 +1246,7 @@ In `front/src/`, remove the file `typings.d.ts` if it is still there.
 {
     "extends": "./tsconfig.json",
     "compilerOptions": {
-        "outDir": "../out-tsc/app",
+        "outDir": "./out-tsc/app",
         "types": []
     },
     "include": ["src/**/*.ts"],
@@ -1448,12 +1448,45 @@ When using `IntelliJ`, you can run code inspection on your project to fix deprec
 - In your `tsconfig.json` file, add `"strict": true` in `compilerOptions` and remove `alwaysStrict`, `noImplicitThis`, `strictBindCallApply` and `strictFunctionTypes` as they are already included in `strict` mode.
 - In your `tsconfig.json` file, remove `useDefineForClassFields` from `compilerOptions`.
 
-Now fix your project until no more errors:
+Without `useDefineForClassFields: false`, the class fields follow the standard semantics: they are initialized before
+the body of the constructor, so before the parameter properties, and a field declared again in a subclass overwrites
+the value set by the parent class. Two errors can appear:
+
+- TS2729 (`Property 'x' is used before its initialization`): a field initializer uses a parameter property of the
+  constructor. Use `inject()` in the initializer, or assign the field in the constructor. Don't move a
+  `private readonly x = inject(X)` field above the public fields: the `@typescript-eslint/member-ordering` rule of
+  `@dsivd/prestations-ng/eslint` wants the public fields first.
+
+    ```diff
+    - readonly items = toSignal(this.itemService.getItems(), { initialValue: [] });
+    -
+    - constructor(private readonly itemService: ItemService) {}
+    + readonly items = toSignal(inject(ItemService).getItems(), { initialValue: [] });
+    ```
+
+    ```ts
+    readonly items: Signal<Item[]>;
+
+    private readonly itemService = inject(ItemService);
+
+    constructor() {
+        this.items = toSignal(this.itemService.getItems(), { initialValue: [] });
+    }
+    ```
+
+- TS2612 (`Property 'x' will overwrite the base property`): a subclass declares again a field of its parent class,
+  e.g. to narrow its type. Add `declare` (`declare form: MyForm | null | undefined;`) or remove the declaration, but
+  never add an initializer: it would overwrite the value set by the parent class.
+
+Now fix your project until no more errors (unlike `tsc -b`, these commands write nothing):
 
 ```bash
-npx tsc -b --noEmit
+npx tsc -p tsconfig.app.json --noEmit
+npx tsc -p tsconfig.spec.json --noEmit
 ```
 
+`tsc` doesn't check the templates: the errors reported by `strictTemplates` appear when you build your application.
+
 and finally run the following commands to build, test and start your application:
 
 ```bash
@@ -1515,6 +1548,8 @@ The CommonJS dependencies of prestations-ng are now `"iban"` and `"dayjs"` (whic
 "allowedCommonJsDependencies": ["iban", "dayjs"]
 ```
 
+Also remove the packages that are no longer installed (`npm ls <package>` lists nothing).
+
 ### Zoneless (optional but recommended)
 
 Since v19.2, prestations-ng does not need zone.js anymore: the state of its components is held by signals, which
@@ -1558,6 +1593,10 @@ then uninstall zone.js:
 npm uninstall zone.js
 ```
 
+`zone.js` stays in your `package-lock.json` as an optional peer dependency of `@angular/core`: this is expected. Check
+instead that the build of your application no longer outputs a `polyfills` chunk (unless you still have other
+polyfills, e.g. `@angular/localize/init`).
+
 #### Check your components
 
 Without zone.js, Angular refreshes a component only when it is notified that something changed:
@@ -1601,12 +1640,18 @@ Pay attention to:
     ngOnInit(): void {
         super.ngOnInit();
         this.sessionInfoWithApplicationService.prefillForm((info) => {
-            this.form.email = info?.email ?? null;
-            this.changeDetectorRef.markForCheck();
+            if (this.form) {
+                this.form.email = info?.email ?? null;
+                this.changeDetectorRef.markForCheck();
+            }
         });
     }
     ```
 
+- the fields read by the template and set in `ngAfterViewInit()`, `ngAfterContentInit()` or `ngAfterViewChecked()`:
+  derive them with `computed()` from `viewChild()` or `contentChild()` (see "Deriving a state from view queries"
+  in [GOOD_PRACTICES.md](GOOD_PRACTICES.md)).
+
 - `NgZone`: `onStable`, `onMicrotaskEmpty` and `onUnstable` never emit without zone.js, and `run()` or
   `runOutsideAngular()` are useless. To act on the rendered DOM (focus, scroll...), replace them, as well as the
   `setTimeout()` waiting for the view, by `afterNextRender()`. `AbstractMenuPageComponent.ngZone` is deprecated.

package/fesm2022/dsivd-prestations-ng.mjs

@@ -3867,7 +3867,10 @@ class FoehnFeedbackNotificationComponent {
             .post(`api/feedbacknotification/queryparams/${reference}`, fbu, {
             responseType: 'text',
         })
-            .pipe(map((cryptedUrlParams) => `${feedBackFormBaseUrl}?q=${encodeURIComponent(cryptedUrlParams)}`));
+            .pipe(map((cryptedUrlParams) => `${feedBackFormBaseUrl}?q=${encodeURIComponent(cryptedUrlParams)}`), catchError((e) => {
+            console.error('Unable to get the feedback url, returning null', e);
+            return of(null);
+        }));
     }
     getCategory(sessionInfoData, etapeInfo) {
         if (sessionInfoData?.categories) {