@dsivd/prestations-ng 19.2.0-beta.11 → 19.2.0-beta.12

package/CHANGELOG.md

@@ -218,6 +218,9 @@ Please check the [UPGRADING_V19.md](UPGRADING_V19.md) guide for more information
 - `ng add @dsivd/prestations-ng` works again on the Angular workspaces created since Angular 14: it failed because
   `angular.json` no longer has a `defaultProject` (the dependencies are now added to every application), then
   because of the comments of `tsconfig.json` (now kept, like its formatting).
+- `foehn-feedback-notification`: an error of `api/feedbacknotification/queryparams/{reference}` is logged and the
+  links are displayed without the feedback url, it reached the `ErrorHandler` as unhandled.
+- The npm package no longer contains its own archive (`dsivd-prestations-ng-<version>.tgz`).
 
 ## [19.1.1]
 

package/CONTRIBUTING.md

@@ -171,7 +171,7 @@ Alternatively, you can manually publish the package. Although this method is not
 - Ensure you can push to the npm registry: `npm adduser --registry=https://registry.npmjs.org --scope=@dsivd`
 - Update the version number in `package.json` either manually or with `npm version`
 - Commit and tag the version change
-- Package a new version of the library with `npm package`
+- Package a new version of the library with `npm run package`
 - Publish the package:
     - `npm run publish:stable` for stable version (released to everybody)
     - `npm run publish:next` for next version (development only)

package/GOOD_PRACTICES.md

@@ -461,8 +461,10 @@ private readonly changeDetectorRef = inject(ChangeDetectorRef);
 ngOnInit(): void {
     super.ngOnInit();
     this.sessionInfoWithApplicationService.prefillForm((info) => {
-        this.form.email = info?.email ?? null;
-        this.changeDetectorRef.markForCheck();
+        if (this.form) {
+            this.form.email = info?.email ?? null;
+            this.changeDetectorRef.markForCheck();
+        }
     });
 }
 ```

package/UPGRADING_V19.md

@@ -1246,7 +1246,7 @@ In `front/src/`, remove the file `typings.d.ts` if it is still there.
 {
     "extends": "./tsconfig.json",
     "compilerOptions": {
-        "outDir": "../out-tsc/app",
+        "outDir": "./out-tsc/app",
         "types": []
     },
     "include": ["src/**/*.ts"],
@@ -1448,12 +1448,15 @@ When using `IntelliJ`, you can run code inspection on your project to fix deprec
 - In your `tsconfig.json` file, add `"strict": true` in `compilerOptions` and remove `alwaysStrict`, `noImplicitThis`, `strictBindCallApply` and `strictFunctionTypes` as they are already included in `strict` mode.
 - In your `tsconfig.json` file, remove `useDefineForClassFields` from `compilerOptions`.
 
-Now fix your project until no more errors:
+Now fix your project until no more errors (unlike `tsc -b`, these commands write nothing):
 
 ```bash
-npx tsc -b --noEmit
+npx tsc -p tsconfig.app.json --noEmit
+npx tsc -p tsconfig.spec.json --noEmit
 ```
 
+`tsc` doesn't check the templates: the errors reported by `strictTemplates` appear when you build your application.
+
 and finally run the following commands to build, test and start your application:
 
 ```bash
@@ -1515,6 +1518,8 @@ The CommonJS dependencies of prestations-ng are now `"iban"` and `"dayjs"` (whic
 "allowedCommonJsDependencies": ["iban", "dayjs"]
 ```
 
+Also remove the packages that are no longer installed (`npm ls <package>` lists nothing).
+
 ### Zoneless (optional but recommended)
 
 Since v19.2, prestations-ng does not need zone.js anymore: the state of its components is held by signals, which
@@ -1558,6 +1563,10 @@ then uninstall zone.js:
 npm uninstall zone.js
 ```
 
+`zone.js` stays in your `package-lock.json` as an optional peer dependency of `@angular/core`: this is expected. Check
+instead that the build of your application no longer outputs a `polyfills` chunk (unless you still have other
+polyfills, e.g. `@angular/localize/init`).
+
 #### Check your components
 
 Without zone.js, Angular refreshes a component only when it is notified that something changed:
@@ -1601,8 +1610,10 @@ Pay attention to:
     ngOnInit(): void {
         super.ngOnInit();
         this.sessionInfoWithApplicationService.prefillForm((info) => {
-            this.form.email = info?.email ?? null;
-            this.changeDetectorRef.markForCheck();
+            if (this.form) {
+                this.form.email = info?.email ?? null;
+                this.changeDetectorRef.markForCheck();
+            }
         });
     }
     ```

package/fesm2022/dsivd-prestations-ng.mjs

@@ -3867,7 +3867,10 @@ class FoehnFeedbackNotificationComponent {
             .post(`api/feedbacknotification/queryparams/${reference}`, fbu, {
             responseType: 'text',
         })
-            .pipe(map((cryptedUrlParams) => `${feedBackFormBaseUrl}?q=${encodeURIComponent(cryptedUrlParams)}`));
+            .pipe(map((cryptedUrlParams) => `${feedBackFormBaseUrl}?q=${encodeURIComponent(cryptedUrlParams)}`), catchError((e) => {
+            console.error('Unable to get the feedback url, returning null', e);
+            return of(null);
+        }));
     }
     getCategory(sessionInfoData, etapeInfo) {
         if (sessionInfoData?.categories) {