@dsivd/prestations-ng 19.1.1 → 19.2.0-beta.1

package/CHANGELOG.md

@@ -6,6 +6,13 @@
 
 ---
 
+## [19.2.0] - should be aligned with prestations-be 19.2.x
+
+### Changed
+
+Library now runs as strict mode, which may cause some errors to appear in your project after updating.
+Please check the [UPGRADING_V19.md](UPGRADING_V19.md) guide for more information.
+
 ## [19.1.1]
 
 ### Fixed
@@ -13,12 +20,12 @@
 - [foehn-input-phone.component.ts](projects/prestations-ng/src/foehn-input/foehn-input-phone.component.ts)
     - fixed help texts to be aligned with ch.vd.cyber.prestationsbe.validation.PhoneNumberValidator (prestations-be)
     - dictionary keys have changed to be more explicit :
-      - foehn-input-phone.STANDARD_HELPTEXT_SWISS_FIX_AND_MOBILE
-      - foehn-input-phone.STANDARD_HELPTEXT_SWISS_FIX_ONLY
-      - foehn-input-phone.STANDARD_HELPTEXT_SWISS_MOBILE_ONLY
-      - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_FIX_AND_MOBILE
-      - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_FIX_ONLY
-      - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_MOBILE_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_SWISS_FIX_AND_MOBILE
+        - foehn-input-phone.STANDARD_HELPTEXT_SWISS_FIX_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_SWISS_MOBILE_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_FIX_AND_MOBILE
+        - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_FIX_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_MOBILE_ONLY
 
 ## [19.1.0] - should be aligned with prestations-be 19.1.x
 

package/GOOD_PRACTICES.md

@@ -95,29 +95,25 @@ Ce qu'il ne faut **pas** faire :
 
 ```html
 <h1>...</h1>
-    <h3>...</h3>
-        <h2>...</h2>
-            <h6>...</h6>
-            ...
-        ...
-    ...
+<h3>...</h3>
+<h2>...</h2>
+<h6>...</h6>
+... ... ...
 ```
 
 Ce qu'il **faut** faire :
 
 ```html
 <h1>...</h1>
-    <section>
-        <h2>...</h2>
-            <h3>...</h3>
-                <h4>...</h4>
-                ...
-            ...
-    </section>
-        <h2>...</h2>
-        ...
-    <section>
-    ...
+<section>
+    <h2>...</h2>
+    <h3>...</h3>
+    <h4>...</h4>
+    ... ...
+</section>
+<h2>...</h2>
+...
+<section>...</section>
 ```
 
 Quelques attributs HTML utiles :
@@ -216,32 +212,36 @@ Exemple :
 
 ```html
 <ul>
-  <li>un artichaut</li>
-  <li>Les trucs pour le gâteau
-  <!-- On voit que </li> n'est pas là -->
-    <ul>
-      <li>trois œufs</li>
-      <li>La génoise
-      <!-- Là on ouvre une autre liste -->
+    <li>un artichaut</li>
+    <li>
+        Les trucs pour le gâteau
+        <!-- On voit que </li> n'est pas là -->
         <ul>
-          <li>100g de sucre</li>
-          <li>un œuf</li>
-          <li>150g de farine</li>
+            <li>trois œufs</li>
+            <li>
+                La génoise
+                <!-- Là on ouvre une autre liste -->
+                <ul>
+                    <li>100g de sucre</li>
+                    <li>un œuf</li>
+                    <li>150g de farine</li>
+                </ul>
+            </li>
+            <!-- On ferme la liste la plus imbriquée -->
+            <li>200g de chocolat</li>
         </ul>
-      </li> <!-- On ferme la liste la plus imbriquée -->
-      <li>200g de chocolat</li>
-    </ul>
-  <!-- On ferme la liste imbriquée avec </li> -->
-  </li>
-  <li>De l'essuie-tout</li>
-  <li>A faire dans l'ordre pour une belle vaisselle
-    <ol>
-      <li>Remplir le lave vaisselle</li>
-      <li>Mettre une pastille pour lave vaisselle</li>
-      <li>Fermer la porte du lave vaisselle</li>
-      <li>Lancer le lave vaisselle</li>
-    </ol>
-  </li>
+        <!-- On ferme la liste imbriquée avec </li> -->
+    </li>
+    <li>De l'essuie-tout</li>
+    <li>
+        A faire dans l'ordre pour une belle vaisselle
+        <ol>
+            <li>Remplir le lave vaisselle</li>
+            <li>Mettre une pastille pour lave vaisselle</li>
+            <li>Fermer la porte du lave vaisselle</li>
+            <li>Lancer le lave vaisselle</li>
+        </ol>
+    </li>
 </ul>
 ```
 
@@ -262,18 +262,18 @@ Exemple :
 
 ```html
 <form>
-  <fieldset>
-    <legend>Choose your favorite monster</legend>
+    <fieldset>
+        <legend>Choose your favorite monster</legend>
 
-    <input type="radio" id="kraken" name="monster" value="K" />
-    <label for="kraken">Kraken</label><br />
+        <input type="radio" id="kraken" name="monster" value="K" />
+        <label for="kraken">Kraken</label><br />
 
-    <input type="radio" id="sasquatch" name="monster" value="S" />
-    <label for="sasquatch">Sasquatch</label><br />
+        <input type="radio" id="sasquatch" name="monster" value="S" />
+        <label for="sasquatch">Sasquatch</label><br />
 
-    <input type="radio" id="mothman" name="monster" value="M" />
-    <label for="mothman">Mothman</label>
-  </fieldset>
+        <input type="radio" id="mothman" name="monster" value="M" />
+        <label for="mothman">Mothman</label>
+    </fieldset>
 </form>
 ```
 
@@ -331,7 +331,10 @@ avec du texte pour les non-voyants.
         // ... vos composants foehn-* utilisés dans le template
     ],
 })
-export class PageOneComponent extends AbstractPageComponent<BusinessForm> implements OnInit {
+export class PageOneComponent
+    extends AbstractPageComponent<BusinessForm>
+    implements OnInit
+{
     ngOnInit(): void {
         super.ngOnInit();
         // point (2) : ajoutera le titre h1
@@ -361,7 +364,10 @@ export class PageOneComponent extends AbstractPageComponent<BusinessForm> implem
         <div class="row">
             <div class="col-md-8">
                 <!-- point (5) : toujours avoir un <h2> en premier dans votre page -->
-                <h2>{{ 'La_clé_du_dictionnaire_de_votre_titre_H2_ici' | fromDictionary }}</h2>
+                <h2>
+                    {{ 'La_clé_du_dictionnaire_de_votre_titre_H2_ici' |
+                    fromDictionary }}
+                </h2>
 
                 <!-- [VOS COMPOSANTS FOEHN ICI] -->
 
@@ -390,13 +396,21 @@ export const routes: Routes = [
         component: PageWrapperComponent,
         data: { root: true },
         children: [
-            { path: '', component: PageOneComponent, canActivate: [GesdemLoaderGuard] },
+            {
+                path: '',
+                component: PageOneComponent,
+                canActivate: [GesdemLoaderGuard],
+            },
             { path: '404', component: FoehnNotfoundComponent },
             { path: 'erreur', component: GesdemErrorComponent },
             {
                 path: ':reference',
                 children: [
-                    { path: 'page-1', component: PageOneComponent, data: { order: 1 } },
+                    {
+                        path: 'page-1',
+                        component: PageOneComponent,
+                        data: { order: 1 },
+                    },
                     // {...},
                     // ...
                     { path: 'erreur', component: GesdemErrorComponent },
@@ -431,7 +445,9 @@ export const routes: Routes = [
             {
                 path: 'welcome',
                 loadChildren: () =>
-                    import('./modules/welcome/welcome.routes').then((m) => m.welcome_routes),
+                    import('./modules/welcome/welcome.routes').then(
+                        (m) => m.welcome_routes,
+                    ),
             },
             {
                 path: 'inscription',
@@ -443,7 +459,11 @@ export const routes: Routes = [
             // {...},
             // ...
             // recovery link should redirect to /inscription/reference
-            { path: ':reference', redirectTo: 'inscription/:reference', pathMatch: 'full' },
+            {
+                path: ':reference',
+                redirectTo: 'inscription/:reference',
+                pathMatch: 'full',
+            },
             { path: '', redirectTo: 'welcome', pathMatch: 'full' },
             { path: '404', component: FoehnNotfoundComponent },
             { path: '**', redirectTo: '/404', pathMatch: 'full' },
@@ -475,12 +495,20 @@ export const inscription_routes: Routes = [
         path: '',
         data: { root: true },
         children: [
-            { path: '', component: PageOneComponent, canActivate: [GesdemLoaderGuard] },
+            {
+                path: '',
+                component: PageOneComponent,
+                canActivate: [GesdemLoaderGuard],
+            },
             { path: 'erreur', component: GesdemErrorComponent },
             {
                 path: ':reference',
                 children: [
-                    { path: 'page-1', component: PageOneComponent, data: { order: 1 } },
+                    {
+                        path: 'page-1',
+                        component: PageOneComponent,
+                        data: { order: 1 },
+                    },
                     // {...},
                     // ...
                     { path: 'erreur', component: GesdemErrorComponent },
@@ -599,7 +627,11 @@ export class InputDateComponent extends FoehnInputComponent<number[]> {
 
     // point (8)
     getValidValue(): number[] | null | undefined {
-        if (this.isEmpty(this.day) && this.isEmpty(this.month) && this.isEmpty(this.year)) {
+        if (
+            this.isEmpty(this.day) &&
+            this.isEmpty(this.month) &&
+            this.isEmpty(this.year)
+        ) {
             if (this.model_ !== undefined) {
                 return null;
             }
@@ -607,7 +639,11 @@ export class InputDateComponent extends FoehnInputComponent<number[]> {
             return undefined;
         }
 
-        return [this.toNumber(this.year), this.toNumber(this.month), this.toNumber(this.day)];
+        return [
+            this.toNumber(this.year),
+            this.toNumber(this.month),
+            this.toNumber(this.day),
+        ];
     }
 
     // ...code
@@ -694,15 +730,17 @@ Chaque `foehn-input-*` utilisé dans votre vue doit :
     >
         <!-- (facultatif) Seulement si vous souhaitez afficher un label/legend global à votre composant -->
         @if (!!label()) {
-            <legend
-                [class.visually-hidden]="isLabelSrOnly()"
-                [class.vd-p]="!isLabelSrOnly()"
+        <legend
+            [class.visually-hidden]="isLabelSrOnly()"
+            [class.vd-p]="!isLabelSrOnly()"
+        >
+            <span [innerHTML]="label()"></span>
+            @if (!required() && !hideNotRequiredExtraLabel()) {
+            <span aria-hidden="true"
+                >{{ 'foehn-input.optional' | fromDictionary }}</span
             >
-                <span [innerHTML]="label()"></span>
-                @if (!required() && !hideNotRequiredExtraLabel()) {
-                    <span aria-hidden="true">{{ 'foehn-input.optional' | fromDictionary }}</span>
-                }
-            </legend>
+            }
+        </legend>
         }
 
         <!-- (obligatoire) -->
@@ -710,11 +748,11 @@ Chaque `foehn-input-*` utilisé dans votre vue doit :
 
         <!-- (facultatif) Seulement si vous souhaitez pouvoir afficher un helpText global au composant -->
         @if (helpText()) {
-            <small
-                [attr.id]="buildId() + 'Help'"
-                class="text-secondary"
-                [innerHTML]="helpText()"
-            ></small>
+        <small
+            [attr.id]="buildId() + 'Help'"
+            class="text-secondary"
+            [innerHTML]="helpText()"
+        ></small>
         }
 
         <!-- ...vos foehn-input-* ici -->
@@ -769,13 +807,18 @@ Voici un exemple de page de formulaire contenant cette méthode (1) :
         // ... vos composants foehn-*
     ],
 })
-export class VotrePageComponent extends AbstractPageComponent<BusinessForm> implements OnInit {
+export class VotrePageComponent
+    extends AbstractPageComponent<BusinessForm>
+    implements OnInit
+{
     // vos propres dépendances : inject() au lieu du constructor
     private readonly metaService = inject(MetaService);
 
     ngOnInit(): void {
         super.ngOnInit();
-        this.setPageTitle(this._dictionaryService.getKeySync('votre-page.title'));
+        this.setPageTitle(
+            this._dictionaryService.getKeySync('votre-page.title'),
+        );
     }
 
     newForm(): BusinessForm {
@@ -889,37 +932,38 @@ devra lui aussi remonter l'événement.
     tabindex="-1"
 >
     @if (label() && type() !== 'hidden') {
-        <label
-            [attr.for]="buildChildId()"
-            [class]="'form-label ' + (isLabelSrOnly() ? 'visually-hidden' : (labelStyleModifier() ?? ''))"
+    <label
+        [attr.for]="buildChildId()"
+        [class]="'form-label ' + (isLabelSrOnly() ? 'visually-hidden' : (labelStyleModifier() ?? ''))"
+    >
+        {{ label() }} @if (!required() && !hideNotRequiredExtraLabel()) {
+        <span aria-hidden="true"
+            >{{ 'foehn-input.optional' | fromDictionary }}</span
         >
-            {{ label() }}
-            @if (!required() && !hideNotRequiredExtraLabel()) {
-                <span aria-hidden="true">{{ 'foehn-input.optional' | fromDictionary }}</span>
-            }
-        </label>
+        }
+    </label>
     }
 
     <foehn-validation-alerts [component]="this" />
 
     @if (helpText()) {
-        <small
-            [attr.id]="buildChildId() + 'Help'"
-            class="form-text text-secondary"
-            [innerHTML]="helpText()"
-        ></small>
+    <small
+        [attr.id]="buildChildId() + 'Help'"
+        class="form-text text-secondary"
+        [innerHTML]="helpText()"
+    ></small>
     }
 
     <!-- (1) votre boucle @for + track (identifiant unique) -->
     @for (vehicule of vehicules; track vehicule.id; let i = $index) {
-        <!-- (2) votre composant réutilisable -->
-        <app-vehicule-item
-            [name]="name() + '[' + i + ']'"
-            [(model)]="vehicule"
-            (modelChange)="updateVehiculesList($event, i)"
-            (userInput)="handleUserInput($event, i)"
-            (removedVehicule)="handleRemovedVehicule(i)"
-        />
+    <!-- (2) votre composant réutilisable -->
+    <app-vehicule-item
+        [name]="name() + '[' + i + ']'"
+        [(model)]="vehicule"
+        (modelChange)="updateVehiculesList($event, i)"
+        (userInput)="handleUserInput($event, i)"
+        (removedVehicule)="handleRemovedVehicule(i)"
+    />
     }
 
     <button class="btn btn-primary mt-2" (click)="addVehicule()">
@@ -992,7 +1036,11 @@ l'événement de suppression (2).
     />
     <!-- (1) Utilisation de votre liste - (2) Appel de la méthode qui sauvegardera les données dans GESDEM afin de rafraîchir les erreurs -->
 
-    <foehn-navigation id="navigation" (onPrevious)="previous()" (onNext)="send()" />
+    <foehn-navigation
+        id="navigation"
+        (onPrevious)="previous()"
+        (onNext)="send()"
+    />
 </foehn-form>
 ```
 
@@ -1003,7 +1051,10 @@ formulaire et ainsi rafraîchir l'index.
 @Component({
     // ...
 })
-export class DemandePageComponent extends AbstractPageComponent<BusinessForm> implements OnInit {
+export class DemandePageComponent
+    extends AbstractPageComponent<BusinessForm>
+    implements OnInit
+{
     // ...code
 
     handleRemovedVehicule(): void {
@@ -1066,10 +1117,7 @@ export class BusinessForm {
     name="identification.lastName"
 />
 
-<foehn-boolean-checkbox
-    [(model)]="form.acceptCookies"
-    name="acceptCookies"
-/>
+<foehn-boolean-checkbox [(model)]="form.acceptCookies" name="acceptCookies" />
 <!-- 1 niveau de profondeur -->
 ```
 

package/UPGRADING_V18.md

@@ -458,6 +458,7 @@ npm install @angular/cli@19 -g
 ng update typescript@5.5
 ng update @dsivd/prestations-ng@18
 ```
+
 NB: You might need to use the --force option.
 
 When asked the question "Select the migrations that you'd like to run", accept "provide-initializer" by hitting "Space" key then "Enter".

package/UPGRADING_V19.md

@@ -11,6 +11,9 @@ From here on, we are in the root folder of your project, for example ~/git/cybsd
 
 ### Spring Boot 4
 
+NB : if the following instructions (jdk25 + latest parent + openrewrite) are not working fine, you can also try to
+do in the reverse order : in jdk21 do the rewrite commands, then switch to jdk25 and latest parent.
+
 You can switch to Java 25 `jdk25` + change in IntelliJ: right-click on your project > Open Module Settings > Project > set "SDK" to `jdk25` from devtools and "Language
 level" to `25` in "Modules"
 
@@ -78,6 +81,17 @@ if you use ldap, you should replace `spring-ldap-core` by `spring-boot-starter-l
 </dependency>
 ```
 
+### ORACLE
+
+if you use oracle, you should replace `ojdbc10` by `ojdbc17` in your `pom.xml` and let the spring boot parent set the version
+
+```xml
+<dependency>
+    <groupId>com.oracle.database.jdbc</groupId>
+    <artifactId>ojdbc17</artifactId>
+</dependency>
+```
+
 ### Jackson migration
 
 With Spring Boot 4, Jackson 3 is now used instead of Jackson 2, so we need to replace the previous Jackson 2 classes.
@@ -857,7 +871,7 @@ ng generate @angular/core:signal-input-migration --insert-todos
 [Angular migration guide: migrating to Vitest](https://angular.dev/guide/testing/migrating-to-vitest)
 
 ```bash
-npm install --save-dev vitest jsdom
+npm install --save-dev vitest@4.0 jsdom
 ```
 
 In your `angular.json` file, remove `"zone.js/dist/zone-error"` from `"allowedCommonJsDependencies"`
@@ -1396,7 +1410,7 @@ npm uninstall @angular/animations
 
 ### Add missing `^` or `~` in `package.json` devDependencies
 
-Check you devDependencies in your `package.json` file and add `^` in front of every version number if missing excepted for `typescript` where you should add `~`. Then run:
+Check you devDependencies in your `package.json` file and add `^` in front of every version number if missing excepted for `typescript` and `vitest` where you should add `~`. Then run:
 
 ```bash
 npm install
@@ -1416,6 +1430,25 @@ When using `IntelliJ`, you can run code inspection on your project to fix deprec
 - IntelliJ window menu, go to: `Code > Analyze code > Run inspection by name...` (or **Ctrl+Alt+Maj+i**) and type `Deprecated symbol used`.
 - Or select your project in your project panel and `right click` on it then `Analyze > Run inspection by name...` (or **Ctrl+Alt+Maj+i**) and type `Deprecated symbol used`.
 
+### Strict mode (optional when migrating large projects but recommended)
+
+- In your `tsconfig.json` file, add `"strict": true` in `compilerOptions` and remove `alwaysStrict`, `noImplicitThis`, `strictBindCallApply` and `strictFunctionTypes` as they are already included in `strict` mode.
+- In your `tsconfig.json` file, remove `useDefineForClassFields` from `compilerOptions`.
+
+Now fix your project until no more errors:
+
+```bash
+npx tsc -b --noEmit
+```
+
+and finally run the following commands to build, test and start your application:
+
+```bash
+npm run build
+npm run test
+npm start
+```
+
 ### Last but not least, check if your application is working!!!
 
 #### Be sure your application gets a fresh start
@@ -1465,3 +1498,11 @@ See [getImtPortailApplications](https://dsigit.etat-de-vaud.ch/outils/git/projec
 
 Enroll your project in Renovate bot to automatically update your dependencies.
 See [Mend Renovate CE](https://dgnsiwiki.etat-de-vaud.ch/outils/dgnsiwiki/x/7QFDgg) for more information.
+
+update renovate.json :
+
+```json
+{
+    "extends": ["local>PEE/renovate-config"]
+}
+```

package/eslint/signal-names.mjs

@@ -153,6 +153,67 @@ const reExportedModulesOf = (sourceFile) =>
     .filter((statement) => ts.isExportDeclaration(statement) && statement.moduleSpecifier)
     .map((statement) => statement.moduleSpecifier.text);
 
+const classDeclarationsOf = (sourceFile, className) =>
+  className
+    ? [findClass(sourceFile, className)].filter(Boolean)
+    : sourceFile.statements.filter(ts.isClassDeclaration);
+
+const isBarrelMiss = (className, classDeclarations) =>
+  Boolean(className) && classDeclarations.length === 0;
+
+const collectFromReExports = (sourceFile, path, className, kinds, visited) => {
+  for (const specifier of reExportedModulesOf(sourceFile)) {
+    const target = resolveModule(specifier, path);
+    if (target) {
+      collect(target, className, kinds, visited);
+    }
+  }
+};
+
+const addMemberKindIfEligible = (member, kinds) => {
+  if (!member.name || !ts.isIdentifier(member.name)) {
+    return;
+  }
+  const kind = kindOfMember(member);
+  // A subclass overriding a member wins: it is collected first.
+  if (kind && !kinds.has(member.name.text)) {
+    kinds.set(member.name.text, kind);
+  }
+};
+
+const collectMemberKinds = (classDeclaration, kinds) => {
+  for (const member of classDeclaration.members) {
+    addMemberKindIfEligible(member, kinds);
+  }
+};
+
+const baseTargetOf = (sourceFile, path, classDeclaration) => {
+  const baseName = extendedClassNameOf(classDeclaration);
+  if (!baseName) {
+    return undefined;
+  }
+
+  // Declaration bundles are flattened: the base class often sits in the same file.
+  if (findClass(sourceFile, baseName)) {
+    return { path, className: baseName };
+  }
+
+  const imported = importOf(sourceFile, baseName);
+  if (!imported) {
+    return undefined;
+  }
+
+  const target = resolveModule(imported.specifier, path);
+  return target ? { path: target, className: imported.exportedName } : undefined;
+};
+
+const collectBase = (sourceFile, path, classDeclaration, kinds, visited) => {
+  const target = baseTargetOf(sourceFile, path, classDeclaration);
+  if (target) {
+    collect(target.path, target.className, kinds, visited);
+  }
+};
+
 const collect = (path, className, kinds, visited) => {
   const key = `${path}::${className ?? "*"}`;
   if (visited.has(key)) {
@@ -165,47 +226,17 @@ const collect = (path, className, kinds, visited) => {
     return;
   }
 
-  const classDeclarations = className
-    ? [findClass(sourceFile, className)].filter(Boolean)
-    : sourceFile.statements.filter(ts.isClassDeclaration);
+  const classDeclarations = classDeclarationsOf(sourceFile, className);
 
   // A barrel: the class is only re-exported from here.
-  if (className && classDeclarations.length === 0) {
-    for (const specifier of reExportedModulesOf(sourceFile)) {
-      const target = resolveModule(specifier, path);
-      if (target) {
-        collect(target, className, kinds, visited);
-      }
-    }
+  if (isBarrelMiss(className, classDeclarations)) {
+    collectFromReExports(sourceFile, path, className, kinds, visited);
     return;
   }
 
   for (const classDeclaration of classDeclarations) {
-    for (const member of classDeclaration.members) {
-      if (!member.name || !ts.isIdentifier(member.name)) {
-        continue;
-      }
-      const kind = kindOfMember(member);
-      // A subclass overriding a member wins: it is collected first.
-      if (kind && !kinds.has(member.name.text)) {
-        kinds.set(member.name.text, kind);
-      }
-    }
-
-    const baseName = extendedClassNameOf(classDeclaration);
-    if (!baseName) {
-      continue;
-    }
-    // Declaration bundles are flattened: the base class often sits in the same file.
-    if (findClass(sourceFile, baseName)) {
-      collect(path, baseName, kinds, visited);
-      continue;
-    }
-    const imported = importOf(sourceFile, baseName);
-    const target = imported && resolveModule(imported.specifier, path);
-    if (target) {
-      collect(target, imported.exportedName, kinds, visited);
-    }
+    collectMemberKinds(classDeclaration, kinds);
+    collectBase(sourceFile, path, classDeclaration, kinds, visited);
   }
 };