@dsivd/prestations-ng 19.0.6 → 19.0.8-beta.1

package/eslint/configs/ts-base.mjs

@@ -1,6 +1,6 @@
 // Registers the plugin without enabling any rule. Meant to be used through
-// `tsRecommended`, inside the `extends` of a block that already targets `**/*.ts`
-// and sets the TypeScript parser.
+// `tsRules` or `tsRecommended`, inside the `extends` of a block that already
+// targets `**/*.ts` and sets the TypeScript parser.
 const tsBase = (plugin) => ({
     name: 'prestations-ng/ts-base',
     plugins: {

package/eslint/configs/ts-recommended.mjs

@@ -1,11 +1,141 @@
-import tsBase from './ts-base.mjs';
+import eslint from '@eslint/js';
+import rxjs from '@smarttools/eslint-plugin-rxjs';
+import angular from 'angular-eslint';
+import importX from 'eslint-plugin-import-x';
+import simpleImportSort from 'eslint-plugin-simple-import-sort';
+import tseslint from 'typescript-eslint';
 
+import tsRules from './ts-rules.mjs';
+
+/**
+ * The house TypeScript preset: the shared baselines, this library's own rules, and the
+ * conventions every prestations-ng project follows.
+ *
+ * Meant for the `extends` of a `**\/*.ts` block. It brings its own parser and plugins,
+ * so do not spread `angular.configs.tsRecommended` alongside it — declaring the same
+ * plugin twice from two different copies makes ESLint fail outright.
+ */
 const tsRecommended = (plugin) => [
-    tsBase(plugin),
+    eslint.configs.recommended,
+    ...tseslint.configs.recommended, // covers: no-explicit-any, ban-ts-comment,
+    //   no-unused-expressions, no-var, no-unused-vars…
+    ...tseslint.configs.stylistic, // covers: array-type, consistent-type-assertions,
+    //   dot-notation, no-inferrable-types (default options),
+    //   no-empty-function (error), prefer-for-of,
+    //   prefer-function-type…
+    ...angular.configs.tsRecommended, // covers: prefer-inject, no-empty-lifecycle-method,
+    //   use-lifecycle-interface…
+    ...tsRules(plugin),
     {
         name: 'prestations-ng/ts-recommended',
+        plugins: {
+            rxjs,
+            'simple-import-sort': simpleImportSort,
+            'import-x': importX,
+        },
         rules: {
-            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+            // ── @angular-eslint ──────────────────────────────────────────────
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'app',
+                    style: 'kebab-case',
+                },
+            ],
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: 'app',
+                    style: 'camelCase',
+                },
+            ],
+            '@angular-eslint/no-uncalled-signals': ['error'],
+            '@angular-eslint/prefer-signal-model': ['error'],
+            '@angular-eslint/prefer-signals': ['error'],
+
+            // ── @typescript-eslint ───────────────────────────────────────────
+            '@typescript-eslint/explicit-function-return-type': [
+                'error',
+                {
+                    allowExpressions: true,
+                    allowTypedFunctionExpressions: true,
+                    allowHigherOrderFunctions: true,
+                    allowDirectConstAssertionInArrowFunctions: true,
+                },
+            ],
+            '@typescript-eslint/explicit-member-accessibility': [
+                'error',
+                { accessibility: 'no-public' },
+            ],
+            '@typescript-eslint/member-ordering': 'error',
+            '@typescript-eslint/no-base-to-string': 'warn',
+            // stylistic enables no-inferrable-types with default options (ignoreParameters: false);
+            // override here to allow typed parameters explicitly
+            '@typescript-eslint/no-inferrable-types': [
+                'error',
+                { ignoreParameters: true },
+            ],
+            // stylistic sets no-empty-function to error; downgrade to warn
+            '@typescript-eslint/no-empty-function': 'warn',
+            '@typescript-eslint/prefer-includes': 'warn',
+            '@typescript-eslint/return-await': ['error', 'never'],
+            '@typescript-eslint/typedef': ['error', { parameter: true }],
+            '@typescript-eslint/unified-signatures': 'error',
+            // off here — @typescript-eslint/no-shadow handles it correctly for TS
+            'no-shadow': 'off',
+            '@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
+            '@typescript-eslint/no-unused-vars': [
+                'error',
+                {
+                    varsIgnorePattern: '^_',
+                    argsIgnorePattern: '^_',
+                    caughtErrorsIgnorePattern: '^_',
+                },
+            ],
+
+            // ── eslint core ──────────────────────────────────────────────────
+            'arrow-body-style': 'error',
+            'arrow-parens': ['error', 'as-needed'],
+            curly: 'error',
+            eqeqeq: ['error', 'always'],
+            'guard-for-in': 'error',
+            'no-bitwise': 'error',
+            'no-caller': 'error',
+            'no-console': ['error', { allow: ['log', 'warn', 'error'] }],
+            'no-eval': 'error',
+            'no-extra-boolean-cast': 'off',
+            'no-multiple-empty-lines': 'error',
+            'no-new-wrappers': 'error',
+            'no-restricted-imports': [
+                'error',
+                { paths: ['rxjs/Rx', 'primeng/primeng', 'primeng'] },
+            ],
+            'no-return-assign': 'error',
+            'no-throw-literal': 'error',
+            'no-undef-init': 'error',
+            'no-useless-concat': 'error',
+            'object-shorthand': ['error', 'always', { avoidQuotes: true }],
+            'one-var': ['error', 'never'],
+            'prefer-arrow-callback': 'error',
+            'prefer-template': 'error',
+            radix: 'error',
+
+            // ── rxjs ─────────────────────────────────────────────────────────
+            'rxjs/no-implicit-any-catch': ['error', { allowExplicitAny: true }],
+            'rxjs/no-sharereplay': 'off',
+
+            // ── import-x ─────────────────────────────────────────────────────
+            'import-x/no-cycle': ['warn', { maxDepth: 3, ignoreExternal: true }],
+            'import-x/no-deprecated': 'warn',
+            'import-x/first': 'error',
+            'import-x/newline-after-import': 'error',
+            'import-x/no-duplicates': 'error',
+
+            // ── simple-import-sort ───────────────────────────────────────────
+            'simple-import-sort/imports': 'error',
+            'simple-import-sort/exports': 'error',
         },
     },
 ];

package/eslint/configs/ts-rules.mjs

@@ -0,0 +1,14 @@
+import tsBase from './ts-base.mjs';
+
+// Only the rules written by this library. `tsRecommended` includes it, alongside the
+// house style; use this layer directly to opt out of the latter.
+const tsRules = (plugin) => [
+    tsBase(plugin),
+    {
+        name: 'prestations-ng/ts-rules',
+        rules: {
+            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+        },
+    },
+];
+export default tsRules;

package/eslint/index.mjs

@@ -1,15 +1,21 @@
 import templateRecommended from './configs/template-recommended.mjs';
+import templateRules from './configs/template-rules.mjs';
 import tsRecommended from './configs/ts-recommended.mjs';
+import tsRules from './configs/ts-rules.mjs';
 import rules from './rules/index.mjs';
 
 const plugin = {
-  meta: { name: '@dsivd/prestations-ng' },
-  rules,
+    meta: { name: '@dsivd/prestations-ng' },
+    rules,
 };
 
 const configs = {
-  tsRecommended: tsRecommended(plugin),
-  templateRecommended: templateRecommended(plugin),
+    // The house presets: baselines, this library's rules, and the shared conventions.
+    tsRecommended: tsRecommended(plugin),
+    templateRecommended: templateRecommended(plugin),
+    // Only this library's own rules, for a project that supplies its own style.
+    tsRules: tsRules(plugin),
+    templateRules: templateRules(plugin),
 };
 
 export { configs, plugin, rules };