@dsivd/prestations-ng 19.0.6 → 19.0.7

package/CHANGELOG.md

@@ -6,14 +6,21 @@
 
 ---
 
-## [Unreleased]
+## [19.0.7]
 
 ### Added
 
 - ESLint plugin: **shareable configs**, documented in [ESLINT_PLUGIN.md](ESLINT_PLUGIN.md)
     - add `configs.tsRecommended` and `configs.templateRecommended` to the `extends` of your
-      `**/*.ts` and `**/*.html` blocks — see [UPGRADING_V19.md](UPGRADING_V19.md). Nothing
-      else is needed: no `plugins` declaration, no rule list.
+      `**/*.ts` and `**/*.html` blocks — see [UPGRADING_V19.md](UPGRADING_V19.md). They carry
+      the whole shared setup: the `eslint`, `typescript-eslint` and `angular-eslint`
+      baselines, the house conventions, and the rules below. Nothing else is needed: no
+      `plugins` declaration, no rule list.
+    - `configs.tsRules` and `configs.templateRules` enable only the rules written here, for a
+      project that supplies its own style
+    - 🚨 do **not** also spread `angular.configs.tsRecommended` or
+      `angular.configs.templateRecommended`: they are already included, and declaring the
+      same plugin twice makes ESLint fail outright
     - 🚨 **Prerequisite**: `lintFilePatterns` in your `angular.json` must include
       `src/**/*.html`, otherwise the template rules never run
     - 🚨 **A rule added to these configs makes your lint fail on `npm update`.** This is

package/CONTRIBUTING.md

@@ -131,8 +131,9 @@ below mandatory:
 
 1. Write the rule in `projects/prestations-ng/src/eslint/rules/<rule-name>.mjs`
 2. Register it in `rules/index.mjs`, keyed by its public kebab-case name
-3. Enable it in `configs/ts-recommended.mjs`, `configs/template-recommended.mjs`, or both
-   depending on what it inspects
+3. Enable it in `configs/ts-rules.mjs`, `configs/template-rules.mjs`, or both depending on
+   what it inspects — the `*-recommended.mjs` presets pick those layers up. A change to a
+   shared convention rather than to a rule of ours goes into `configs/ts-recommended.mjs`.
 4. Test it in `rules/__tests__/<rule-name>.test.mjs` — use the `@angular-eslint/template-parser`
    for a template rule
 5. Run `npm run test:eslint`, then `npm run lint:js` on the whole repository: a rule that

package/ESLINT_PLUGIN.md

@@ -1,8 +1,9 @@
 # ESLint plugin
 
 `@dsivd/prestations-ng` ships an ESLint plugin with rules that catch signal misuses the
-Angular compiler lets through. It is published as a subpath of the library, so the rules
-follow the version of the library.
+Angular compiler lets through, plus the lint setup shared by every project built on the
+library. It is published as a subpath of the library, so both follow the version of the
+library.
 
 ## Setup
 
@@ -17,18 +18,18 @@ import prestationsNg from '@dsivd/prestations-ng/eslint';
 export default tseslint.config(
     {
         files: ['**/*.ts'],
-        extends: [
-            ...angular.configs.tsRecommended,
-            ...prestationsNg.configs.tsRecommended,
-        ],
+        extends: [...prestationsNg.configs.tsRecommended],
+        languageOptions: {
+            parserOptions: {
+                projectService: true,
+                tsconfigRootDir: import.meta.dirname,
+            },
+        },
         processor: angular.processInlineTemplates,
     },
     {
         files: ['**/*.html'],
-        extends: [
-            ...angular.configs.templateRecommended,
-            ...prestationsNg.configs.templateRecommended,
-        ],
+        extends: [...prestationsNg.configs.templateRecommended],
     },
 );
 ```
@@ -37,17 +38,38 @@ That is all. You do **not** declare `plugins`, and you do **not** list the rules
 from the config. Inline templates written in a `@Component` are covered too, through
 `angular.processInlineTemplates`.
 
+> 🚨 **Do not spread `angular.configs.tsRecommended` or `angular.configs.templateRecommended`
+> alongside these configs.** They already include them. Declaring the same plugin twice from
+> two different copies makes ESLint fail outright, before linting anything.
+
 > 🚨 **Prerequisite**: `lintFilePatterns` in your `angular.json` must include
 > `src/**/*.html`. Without it `ng lint` never opens your templates, and the template rules
 > silently never run.
 
-| Config                        | Target      | Rules                                                          |
+## The configs
+
+| Config                        | Target      | Contents                                                       |
 | ----------------------------- | ----------- | -------------------------------------------------------------- |
-| `configs.tsRecommended`       | `**/*.ts`   | `no-direct-signal-mutation`                                    |
-| `configs.templateRecommended` | `**/*.html` | `no-direct-signal-mutation`, `no-uninvoked-signal-in-template` |
+| `configs.tsRecommended`       | `**/*.ts`   | the baselines, the house style, and `tsRules`                   |
+| `configs.templateRecommended` | `**/*.html` | the baselines, the house style, and `templateRules`             |
+| `configs.tsRules`             | `**/*.ts`   | `no-direct-signal-mutation`                                    |
+| `configs.templateRules`       | `**/*.html` | `no-direct-signal-mutation`, `no-uninvoked-signal-in-template` |
+
+The `*Recommended` presets are what a project normally extends. On top of the rules written
+here they bring:
 
-`no-direct-signal-mutation` appears in both: the rule carries one visitor for TypeScript
-and one for the Angular template AST, and each fires on its own kind of file.
+- the baselines — `eslint.configs.recommended`, `typescript-eslint` recommended and
+  stylistic, `angular-eslint` recommended, and for templates its accessibility set;
+- the house style — naming and selector conventions, import ordering
+  (`simple-import-sort`, `import-x`), rxjs conventions, and the signal rules of
+  `angular-eslint` (`no-uncalled-signals`, `prefer-signals`, `prefer-signal-model`).
+
+Use `tsRules` / `templateRules` instead when a project supplies its own style and only wants
+the rules of this library. They register the plugin and nothing else, so you keep control of
+the baselines — and stay responsible for keeping them aligned.
+
+`no-direct-signal-mutation` appears in both targets: the rule carries one visitor for
+TypeScript and one for the Angular template AST, and each fires on its own kind of file.
 
 ## What happens when you update the library
 
@@ -62,10 +84,7 @@ your own `rules` block. It is applied after the shared config, so it wins:
 ```ts
 {
     files: ['**/*.html'],
-    extends: [
-        ...angular.configs.templateRecommended,
-        ...prestationsNg.configs.templateRecommended,
-    ],
+    extends: [...prestationsNg.configs.templateRecommended],
     rules: {
         // decided by this project, survives library updates
         '@dsivd/prestations-ng/no-direct-signal-mutation': ['off'],
@@ -162,13 +181,15 @@ found without declaring anything.
 | `[(value)]="mySignal"`                                       | a writable signal is two-way bound **without** parentheses, Angular calls `.set()` itself |
 | `#ref`, `@for` items, `@if … as`, `@let`, `let-x`, `$index`… | template-local names shadow the class members                                             |
 
-## Also worth enabling
+## The TypeScript counterpart
 
 `@angular-eslint/no-uncalled-signals` covers the same class of bug **in TypeScript**, using
 the real type checker — far more reliable than what a template rule can do. It cannot run on
 templates: it requires type information, which a `.html` file has no program for. The two
 are complementary, not redundant.
 
+`configs.tsRecommended` already enables it. With `configs.tsRules` you enable it yourself:
+
 ```ts
 '@angular-eslint/no-uncalled-signals': 'error',
 ```

package/UPGRADING_V19.md

@@ -1085,13 +1085,10 @@ rm .eslintrc.json
 
 ```ts
 // @ts-check
-import eslint from '@eslint/js';
+import prettier from 'eslint-config-prettier';
 import tseslint from 'typescript-eslint';
 import angular from 'angular-eslint';
-import rxjs from '@smarttools/eslint-plugin-rxjs';
-import simpleImportSort from 'eslint-plugin-simple-import-sort';
-import prettier from 'eslint-config-prettier';
-import importX from 'eslint-plugin-import-x';
+
 import prestationsNg from '@dsivd/prestations-ng/eslint';
 
 export default tseslint.config(
@@ -1102,152 +1099,20 @@ export default tseslint.config(
     // ─── TypeScript ────────────────────────────────────────────────────────────
     {
         files: ['**/*.ts'],
-        extends: [
-            eslint.configs.recommended,
-            ...tseslint.configs.recommended, // covers: no-explicit-any, ban-ts-comment,
-            //   no-unused-expressions, no-var, no-unused-vars…
-            ...tseslint.configs.stylistic, // covers: array-type, consistent-type-assertions,
-            //   dot-notation, no-inferrable-types (default options),
-            //   no-empty-function (error), prefer-for-of,
-            //   prefer-function-type…
-            ...angular.configs.tsRecommended, // covers: prefer-inject, no-empty-lifecycle-method,
-            //   use-lifecycle-interface…
-            ...prestationsNg.configs.tsRecommended, // covers: no-direct-signal-mutation
-        ],
+        extends: [...prestationsNg.configs.tsRecommended],
         languageOptions: {
             parserOptions: {
                 projectService: true,
                 tsconfigRootDir: import.meta.dirname,
             },
         },
-        plugins: {
-            rxjs,
-            'simple-import-sort': simpleImportSort,
-            'import-x': importX,
-        },
         processor: angular.processInlineTemplates,
-        rules: {
-            // ── @angular-eslint ──────────────────────────────────────────────
-            '@angular-eslint/component-selector': [
-                'error',
-                {
-                    type: 'element',
-                    prefix: 'app',
-                    style: 'kebab-case',
-                },
-            ],
-            '@angular-eslint/directive-selector': [
-                'error',
-                {
-                    type: 'attribute',
-                    prefix: 'app',
-                    style: 'camelCase',
-                },
-            ],
-            '@angular-eslint/no-uncalled-signals': ['error'],
-            '@angular-eslint/prefer-signal-model': ['error'],
-            '@angular-eslint/prefer-signals': ['error'],
-
-            // ── @typescript-eslint ───────────────────────────────────────────
-            '@typescript-eslint/explicit-function-return-type': [
-                'error',
-                {
-                    allowExpressions: true,
-                    allowTypedFunctionExpressions: true,
-                    allowHigherOrderFunctions: true,
-                    allowDirectConstAssertionInArrowFunctions: true,
-                },
-            ],
-            '@typescript-eslint/explicit-member-accessibility': [
-                'error',
-                { accessibility: 'no-public' },
-            ],
-            '@typescript-eslint/member-delimiter-style': 'error',
-            '@typescript-eslint/member-ordering': 'error',
-            '@typescript-eslint/no-base-to-string': 'warn',
-            // stylistic enables no-inferrable-types with default options (ignoreParameters: false);
-            // override here to allow typed parameters explicitly
-            '@typescript-eslint/no-inferrable-types': [
-                'error',
-                { ignoreParameters: true },
-            ],
-            // stylistic sets no-empty-function to error; downgrade to warn
-            '@typescript-eslint/no-empty-function': 'warn',
-            '@typescript-eslint/prefer-includes': 'warn',
-            '@typescript-eslint/return-await': ['error', 'never'],
-            '@typescript-eslint/typedef': ['error', { parameter: true }],
-            '@typescript-eslint/unified-signatures': 'error',
-            // off here — @typescript-eslint/no-shadow handles it correctly for TS
-            'no-shadow': 'off',
-            '@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
-            '@typescript-eslint/no-unused-vars': [
-                'error',
-                {
-                    varsIgnorePattern: '^_',
-                    argsIgnorePattern: '^_',
-                    caughtErrorsIgnorePattern: '^_',
-                },
-            ],
-
-            // ── eslint core ──────────────────────────────────────────────────
-            'arrow-body-style': 'error',
-            'arrow-parens': ['error', 'as-needed'],
-            curly: 'error',
-            eqeqeq: ['error', 'always'],
-            'guard-for-in': 'error',
-            'no-bitwise': 'error',
-            'no-caller': 'error',
-            'no-console': ['error', { allow: ['log', 'warn', 'error'] }],
-            'no-eval': 'error',
-            'no-extra-boolean-cast': 'off',
-            'no-multiple-empty-lines': 'error',
-            'no-new-wrappers': 'error',
-            'no-restricted-imports': [
-                'error',
-                { paths: ['rxjs/Rx', 'primeng/primeng', 'primeng'] },
-            ],
-            'no-return-assign': 'error',
-            'no-throw-literal': 'error',
-            'no-undef-init': 'error',
-            'no-useless-concat': 'error',
-            'object-shorthand': ['error', 'always', { avoidQuotes: true }],
-            'one-var': ['error', 'never'],
-            'prefer-arrow-callback': 'error',
-            'prefer-template': 'error',
-            radix: 'error',
-
-            // ── rxjs ─────────────────────────────────────────────────────────
-            'rxjs/no-implicit-any-catch': ['error', { allowExplicitAny: true }],
-            'rxjs/no-sharereplay': 'off',
-
-            // ── import-x ─────────────────────────────────────────────────────
-            'import-x/no-cycle': [
-                'warn',
-                { maxDepth: 3, ignoreExternal: true },
-            ],
-            'import-x/no-deprecated': 'warn',
-            'import-x/first': 'error',
-            'import-x/newline-after-import': 'error',
-            'import-x/no-duplicates': 'error',
-
-            // ── simple-import-sort ───────────────────────────────────────────
-            'simple-import-sort/imports': 'error',
-            'simple-import-sort/exports': 'error',
-        },
     },
 
     // ─── HTML templates ────────────────────────────────────────────────────────
     {
         files: ['**/*.html'],
-        extends: [
-            ...angular.configs.templateRecommended,
-            ...angular.configs.templateAccessibility,
-            ...prestationsNg.configs.templateRecommended, // covers no-direct-signal-mutation, no-uninvoked-signal-in-template
-        ],
-        rules: {
-            '@angular-eslint/template/no-negated-async': 'off',
-            '@angular-eslint/template/button-has-type': 'error',
-        },
+        extends: [...prestationsNg.configs.templateRecommended],
     },
 
     // ─── Prettier (must be last — disables formatting rules) ───────────────────
@@ -1255,19 +1120,31 @@ export default tseslint.config(
 );
 ```
 
+That is the whole file. The two `*Recommended` configs come from the library and carry
+everything: the `eslint`, `typescript-eslint` and `angular-eslint` baselines, the template
+accessibility set, the naming and import conventions, and the rules written by the library
+itself. You declare no `plugins` and list no rule.
+
+The packages installed above are still required — the library's config imports them from your
+`node_modules` rather than shipping its own copies. For the same reason, do **not** spread
+`angular.configs.tsRecommended` or `angular.configs.templateRecommended` yourself: they are
+already included, and declaring the same plugin twice from two different copies makes ESLint
+fail outright.
+
 #### prestations-ng ESLint rules
 
 The library ships **shareable custom configs** that are auto-updatable with the library version. Two
 rules are enabled today — `no-direct-signal-mutation` and `no-uninvoked-signal-in-template` — and both
-are documented in [the plugin guide](ESLINT_PLUGIN.md).
+are documented in [the plugin guide](ESLINT_PLUGIN.md), alongside the leaner `tsRules` / `templateRules`
+configs for a project that supplies its own style.
 
 One consequence to keep in mind:
 
-- A rule added in a later version of the library lands in the config, so `npm update` **will
-  make your lint fail** on the offending code. That is the point — it is how a practice is
-  rolled out to every project. Each addition is listed in the [CHANGELOG](CHANGELOG.md), and
-  a rule you cannot fix right away can be turned off in your own `rules` block, which is
-  applied after the shared config:
+- A rule added — or tightened — in a later version of the library lands in the config, so
+  `npm update` **will make your lint fail** on the offending code. That is the point — it is
+  how a practice is rolled out to every project. Each addition is listed in the
+  [CHANGELOG](CHANGELOG.md), and a rule you cannot fix right away can be turned off in your
+  own `rules` block, which is applied after the shared config:
 
     ```ts
     rules: {

package/eslint/configs/template-base.mjs

@@ -1,6 +1,6 @@
 // Registers the plugin without enabling any rule. Meant to be used through
-// `templateRecommended`, inside the `extends` of a block that already targets
-// `**/*.html` and sets the Angular template parser.
+// `templateRules` or `templateRecommended`, inside the `extends` of a block that
+// already targets `**/*.html` and sets the Angular template parser.
 const templateBase = (plugin) => ({
     name: 'prestations-ng/template-base',
     plugins: {

package/eslint/configs/template-recommended.mjs

@@ -1,14 +1,23 @@
-import templateBase from './template-base.mjs';
+import angular from 'angular-eslint';
 
+import templateRules from './template-rules.mjs';
+
+/**
+ * The house Angular template preset: the recommended and accessibility baselines, this
+ * library's own rules, and the conventions every prestations-ng project follows.
+ *
+ * Meant for the `extends` of a `**\/*.html` block. It brings its own parser and plugins,
+ * so do not spread `angular.configs.templateRecommended` alongside it.
+ */
 const templateRecommended = (plugin) => [
-    templateBase(plugin),
+    ...angular.configs.templateRecommended,
+    ...angular.configs.templateAccessibility,
+    ...templateRules(plugin),
     {
         name: 'prestations-ng/template-recommended',
         rules: {
-            // Also in `tsRecommended`: the rule carries both an ESTree and an Angular
-            // template visitor, and each fires on its own kind of file.
-            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
-            '@dsivd/prestations-ng/no-uninvoked-signal-in-template': 'error',
+            '@angular-eslint/template/no-negated-async': 'off',
+            '@angular-eslint/template/button-has-type': 'error',
         },
     },
 ];

package/eslint/configs/template-rules.mjs

@@ -0,0 +1,17 @@
+import templateBase from './template-base.mjs';
+
+// Only the rules written by this library. `templateRecommended` includes it, alongside
+// the house style; use this layer directly to opt out of the latter.
+const templateRules = (plugin) => [
+    templateBase(plugin),
+    {
+        name: 'prestations-ng/template-rules',
+        rules: {
+            // Also in `tsRules`: the rule carries both an ESTree and an Angular
+            // template visitor, and each fires on its own kind of file.
+            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+            '@dsivd/prestations-ng/no-uninvoked-signal-in-template': 'error',
+        },
+    },
+];
+export default templateRules;

package/eslint/configs/ts-base.mjs

@@ -1,6 +1,6 @@
 // Registers the plugin without enabling any rule. Meant to be used through
-// `tsRecommended`, inside the `extends` of a block that already targets `**/*.ts`
-// and sets the TypeScript parser.
+// `tsRules` or `tsRecommended`, inside the `extends` of a block that already
+// targets `**/*.ts` and sets the TypeScript parser.
 const tsBase = (plugin) => ({
     name: 'prestations-ng/ts-base',
     plugins: {

package/eslint/configs/ts-recommended.mjs

@@ -1,11 +1,141 @@
-import tsBase from './ts-base.mjs';
+import eslint from '@eslint/js';
+import rxjs from '@smarttools/eslint-plugin-rxjs';
+import angular from 'angular-eslint';
+import importX from 'eslint-plugin-import-x';
+import simpleImportSort from 'eslint-plugin-simple-import-sort';
+import tseslint from 'typescript-eslint';
 
+import tsRules from './ts-rules.mjs';
+
+/**
+ * The house TypeScript preset: the shared baselines, this library's own rules, and the
+ * conventions every prestations-ng project follows.
+ *
+ * Meant for the `extends` of a `**\/*.ts` block. It brings its own parser and plugins,
+ * so do not spread `angular.configs.tsRecommended` alongside it — declaring the same
+ * plugin twice from two different copies makes ESLint fail outright.
+ */
 const tsRecommended = (plugin) => [
-    tsBase(plugin),
+    eslint.configs.recommended,
+    ...tseslint.configs.recommended, // covers: no-explicit-any, ban-ts-comment,
+    //   no-unused-expressions, no-var, no-unused-vars…
+    ...tseslint.configs.stylistic, // covers: array-type, consistent-type-assertions,
+    //   dot-notation, no-inferrable-types (default options),
+    //   no-empty-function (error), prefer-for-of,
+    //   prefer-function-type…
+    ...angular.configs.tsRecommended, // covers: prefer-inject, no-empty-lifecycle-method,
+    //   use-lifecycle-interface…
+    ...tsRules(plugin),
     {
         name: 'prestations-ng/ts-recommended',
+        plugins: {
+            rxjs,
+            'simple-import-sort': simpleImportSort,
+            'import-x': importX,
+        },
         rules: {
-            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+            // ── @angular-eslint ──────────────────────────────────────────────
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'app',
+                    style: 'kebab-case',
+                },
+            ],
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: 'app',
+                    style: 'camelCase',
+                },
+            ],
+            '@angular-eslint/no-uncalled-signals': ['error'],
+            '@angular-eslint/prefer-signal-model': ['error'],
+            '@angular-eslint/prefer-signals': ['error'],
+
+            // ── @typescript-eslint ───────────────────────────────────────────
+            '@typescript-eslint/explicit-function-return-type': [
+                'error',
+                {
+                    allowExpressions: true,
+                    allowTypedFunctionExpressions: true,
+                    allowHigherOrderFunctions: true,
+                    allowDirectConstAssertionInArrowFunctions: true,
+                },
+            ],
+            '@typescript-eslint/explicit-member-accessibility': [
+                'error',
+                { accessibility: 'no-public' },
+            ],
+            '@typescript-eslint/member-ordering': 'error',
+            '@typescript-eslint/no-base-to-string': 'warn',
+            // stylistic enables no-inferrable-types with default options (ignoreParameters: false);
+            // override here to allow typed parameters explicitly
+            '@typescript-eslint/no-inferrable-types': [
+                'error',
+                { ignoreParameters: true },
+            ],
+            // stylistic sets no-empty-function to error; downgrade to warn
+            '@typescript-eslint/no-empty-function': 'warn',
+            '@typescript-eslint/prefer-includes': 'warn',
+            '@typescript-eslint/return-await': ['error', 'never'],
+            '@typescript-eslint/typedef': ['error', { parameter: true }],
+            '@typescript-eslint/unified-signatures': 'error',
+            // off here — @typescript-eslint/no-shadow handles it correctly for TS
+            'no-shadow': 'off',
+            '@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
+            '@typescript-eslint/no-unused-vars': [
+                'error',
+                {
+                    varsIgnorePattern: '^_',
+                    argsIgnorePattern: '^_',
+                    caughtErrorsIgnorePattern: '^_',
+                },
+            ],
+
+            // ── eslint core ──────────────────────────────────────────────────
+            'arrow-body-style': 'error',
+            'arrow-parens': ['error', 'as-needed'],
+            curly: 'error',
+            eqeqeq: ['error', 'always'],
+            'guard-for-in': 'error',
+            'no-bitwise': 'error',
+            'no-caller': 'error',
+            'no-console': ['error', { allow: ['log', 'warn', 'error'] }],
+            'no-eval': 'error',
+            'no-extra-boolean-cast': 'off',
+            'no-multiple-empty-lines': 'error',
+            'no-new-wrappers': 'error',
+            'no-restricted-imports': [
+                'error',
+                { paths: ['rxjs/Rx', 'primeng/primeng', 'primeng'] },
+            ],
+            'no-return-assign': 'error',
+            'no-throw-literal': 'error',
+            'no-undef-init': 'error',
+            'no-useless-concat': 'error',
+            'object-shorthand': ['error', 'always', { avoidQuotes: true }],
+            'one-var': ['error', 'never'],
+            'prefer-arrow-callback': 'error',
+            'prefer-template': 'error',
+            radix: 'error',
+
+            // ── rxjs ─────────────────────────────────────────────────────────
+            'rxjs/no-implicit-any-catch': ['error', { allowExplicitAny: true }],
+            'rxjs/no-sharereplay': 'off',
+
+            // ── import-x ─────────────────────────────────────────────────────
+            'import-x/no-cycle': ['warn', { maxDepth: 3, ignoreExternal: true }],
+            'import-x/no-deprecated': 'warn',
+            'import-x/first': 'error',
+            'import-x/newline-after-import': 'error',
+            'import-x/no-duplicates': 'error',
+
+            // ── simple-import-sort ───────────────────────────────────────────
+            'simple-import-sort/imports': 'error',
+            'simple-import-sort/exports': 'error',
         },
     },
 ];

package/eslint/configs/ts-rules.mjs

@@ -0,0 +1,14 @@
+import tsBase from './ts-base.mjs';
+
+// Only the rules written by this library. `tsRecommended` includes it, alongside the
+// house style; use this layer directly to opt out of the latter.
+const tsRules = (plugin) => [
+    tsBase(plugin),
+    {
+        name: 'prestations-ng/ts-rules',
+        rules: {
+            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+        },
+    },
+];
+export default tsRules;

package/eslint/index.mjs

@@ -1,15 +1,21 @@
 import templateRecommended from './configs/template-recommended.mjs';
+import templateRules from './configs/template-rules.mjs';
 import tsRecommended from './configs/ts-recommended.mjs';
+import tsRules from './configs/ts-rules.mjs';
 import rules from './rules/index.mjs';
 
 const plugin = {
-  meta: { name: '@dsivd/prestations-ng' },
-  rules,
+    meta: { name: '@dsivd/prestations-ng' },
+    rules,
 };
 
 const configs = {
-  tsRecommended: tsRecommended(plugin),
-  templateRecommended: templateRecommended(plugin),
+    // The house presets: baselines, this library's rules, and the shared conventions.
+    tsRecommended: tsRecommended(plugin),
+    templateRecommended: templateRecommended(plugin),
+    // Only this library's own rules, for a project that supplies its own style.
+    tsRules: tsRules(plugin),
+    templateRules: templateRules(plugin),
 };
 
 export { configs, plugin, rules };

package/package.json

@@ -40,7 +40,7 @@
   "ng-update": {
     "migrations": "./schematics/migration-collection.json"
   },
-  "version": "19.0.6",
+  "version": "19.0.7",
   "module": "fesm2022/dsivd-prestations-ng.mjs",
   "typings": "types/dsivd-prestations-ng.d.ts",
   "exports": {

package/src/eslint/configs/__tests__/configs.test.mjs

@@ -1,3 +1,4 @@
+import { builtinRules } from 'eslint/use-at-your-own-risk';
 import { describe, expect, it } from 'vitest';
 
 import prestationsNg, { configs, plugin, rules } from '../../index.mjs';
@@ -6,65 +7,129 @@ const PLUGIN_KEY = '@dsivd/prestations-ng';
 
 const configNames = Object.keys(configs);
 
-// Rule ids enabled by a config, whatever its severity.
+// Configs that only register this library's rules, and the presets built on top of them.
+const RULE_LAYERS = ['tsRules', 'templateRules'];
+const PRESETS = [
+    ['tsRecommended', 'tsRules'],
+    ['templateRecommended', 'templateRules'],
+];
+
+const isOff = (severity) =>
+    severity === 'off' ||
+    severity === 0 ||
+    (Array.isArray(severity) && (severity[0] === 'off' || severity[0] === 0));
+
+// Rule ids a config turns on. Ids set to 'off' are excluded: ESLint accepts those even
+// when the rule does not exist, which is precisely the escape hatch consumers rely on.
 const enabledIdsOf = (config) =>
-  config.flatMap((entry) => Object.keys(entry.rules ?? {}));
+    config.flatMap((entry) =>
+        Object.entries(entry.rules ?? {})
+            .filter(([, severity]) => !isOff(severity))
+            .map(([id]) => id),
+    );
+
+const ownIdsOf = (config) =>
+    enabledIdsOf(config).filter((id) => id.startsWith(`${PLUGIN_KEY}/`));
+
+const pluginsOf = (config) =>
+    Object.assign({}, ...config.map((entry) => entry.plugins ?? {}));
+
+// An id is either `plugin-key/rule` (possibly nested, as in `@angular-eslint/template/x`)
+// or a bare core rule.
+const ruleExists = (id, plugins) => {
+    for (const [key, declared] of Object.entries(plugins)) {
+        if (id.startsWith(`${key}/`)) {
+            return Boolean(declared.rules?.[id.slice(key.length + 1)]);
+        }
+    }
+    return builtinRules.has(id);
+};
 
 describe('eslint configs', () => {
-  it('should expose one config per lint target', () => {
-    expect(configNames).toEqual(['tsRecommended', 'templateRecommended']);
-  });
+    it('should expose a rule layer and a preset per lint target', () => {
+        expect(configNames).toEqual([
+            'tsRecommended',
+            'templateRecommended',
+            'tsRules',
+            'templateRules',
+        ]);
+    });
 
-  it.each(configNames)('%s should register the plugin first', (name) => {
-    const [base, ...rest] = configs[name];
+    it.each(RULE_LAYERS)('%s should register the plugin first', (name) => {
+        const [base, ...rest] = configs[name];
 
-    expect(base.plugins).toEqual({ [PLUGIN_KEY]: plugin });
-    expect(base.rules).toBeUndefined();
-    expect(rest.every((entry) => entry.plugins === undefined)).toBe(true);
-  });
+        expect(base.plugins).toEqual({ [PLUGIN_KEY]: plugin });
+        expect(base.rules).toBeUndefined();
+        expect(rest.every((entry) => entry.plugins === undefined)).toBe(true);
+    });
 
-  it.each(configNames)('%s should name every entry', (name) => {
-    for (const entry of configs[name]) {
-      expect(entry.name).toMatch(/^prestations-ng\//);
-    }
-  });
-
-  // A config referencing a rule that does not exist breaks the lint of every
-  // consuming project at once, so it must never reach a release.
-  it.each(configNames)('%s should only enable existing rules', (name) => {
-    for (const id of enabledIdsOf(configs[name])) {
-      expect(id.startsWith(`${PLUGIN_KEY}/`)).toBe(true);
-      expect(rules).toHaveProperty(id.slice(PLUGIN_KEY.length + 1));
-    }
-  });
+    it.each(RULE_LAYERS)('%s should carry no third-party rule', (name) => {
+        expect(enabledIdsOf(configs[name])).toEqual(ownIdsOf(configs[name]));
+    });
 
-  it('should enable every rule in at least one config', () => {
-    const enabled = new Set(configNames.flatMap((n) => enabledIdsOf(configs[n])));
+    it.each(configNames)('%s should name its own entries', (name) => {
+        const own = configs[name].filter((entry) =>
+            entry.name?.startsWith('prestations-ng/'),
+        );
 
-    for (const ruleName of Object.keys(rules)) {
-      expect(enabled).toContain(`${PLUGIN_KEY}/${ruleName}`);
-    }
-  });
+        expect(own.length).toBeGreaterThan(0);
+    });
 
-  it('should keep the template-only rule out of the TypeScript config', () => {
-    expect(enabledIdsOf(configs.tsRecommended)).not.toContain(
-      `${PLUGIN_KEY}/no-uninvoked-signal-in-template`,
+    // A config referencing a rule that does not exist breaks the lint of every consuming
+    // project at once, so it must never reach a release. `builtinRules` is an unstable
+    // ESLint export, but it is the only way to check core rule ids.
+    it.each(configNames)('%s should only enable existing rules', (name) => {
+        const plugins = pluginsOf(configs[name]);
+
+        for (const id of enabledIdsOf(configs[name])) {
+            expect(ruleExists(id, plugins), `unknown rule ${id}`).toBe(true);
+        }
+    });
+
+    // Two entries declaring the same plugin key from different copies is a hard ESLint
+    // failure, so the preset must register ours exactly once.
+    it.each(configNames)('%s should register the plugin once', (name) => {
+        const declarations = configs[name]
+            .map((entry) => entry.plugins?.[PLUGIN_KEY])
+            .filter(Boolean);
+
+        expect(declarations).toEqual([plugin]);
+    });
+
+    it.each(PRESETS)('%s should build on %s', (preset, layer) => {
+        expect(ownIdsOf(configs[preset])).toEqual(ownIdsOf(configs[layer]));
+    });
+
+    it('should enable every rule in at least one config', () => {
+        const enabled = new Set(configNames.flatMap((n) => ownIdsOf(configs[n])));
+
+        for (const ruleName of Object.keys(rules)) {
+            expect(enabled).toContain(`${PLUGIN_KEY}/${ruleName}`);
+        }
+    });
+
+    it.each(['tsRecommended', 'tsRules'])(
+        '%s should keep the template-only rule out',
+        (name) => {
+            expect(enabledIdsOf(configs[name])).not.toContain(
+                `${PLUGIN_KEY}/no-uninvoked-signal-in-template`,
+            );
+        },
     );
-  });
 });
 
 describe('eslint plugin', () => {
-  it('should be named after the npm package', () => {
-    expect(plugin.meta.name).toBe(PLUGIN_KEY);
-  });
-
-  it('should mirror the named exports on the default export', () => {
-    expect(prestationsNg).toEqual({ configs, plugin, rules });
-  });
-
-  it.each(Object.entries(rules))('%s should be a usable rule', (_, rule) => {
-    expect(typeof rule.create).toBe('function');
-    expect(Object.keys(rule.meta.messages).length).toBeGreaterThan(0);
-    expect(rule.meta.type).toBe('problem');
-  });
+    it('should be named after the npm package', () => {
+        expect(plugin.meta.name).toBe(PLUGIN_KEY);
+    });
+
+    it('should mirror the named exports on the default export', () => {
+        expect(prestationsNg).toEqual({ configs, plugin, rules });
+    });
+
+    it.each(Object.entries(rules))('%s should be a usable rule', (_, rule) => {
+        expect(typeof rule.create).toBe('function');
+        expect(Object.keys(rule.meta.messages).length).toBeGreaterThan(0);
+        expect(rule.meta.type).toBe('problem');
+    });
 });

package/src/eslint/configs/template-base.mjs

@@ -1,6 +1,6 @@
 // Registers the plugin without enabling any rule. Meant to be used through
-// `templateRecommended`, inside the `extends` of a block that already targets
-// `**/*.html` and sets the Angular template parser.
+// `templateRules` or `templateRecommended`, inside the `extends` of a block that
+// already targets `**/*.html` and sets the Angular template parser.
 const templateBase = (plugin) => ({
     name: 'prestations-ng/template-base',
     plugins: {

package/src/eslint/configs/template-recommended.mjs

@@ -1,14 +1,23 @@
-import templateBase from './template-base.mjs';
+import angular from 'angular-eslint';
 
+import templateRules from './template-rules.mjs';
+
+/**
+ * The house Angular template preset: the recommended and accessibility baselines, this
+ * library's own rules, and the conventions every prestations-ng project follows.
+ *
+ * Meant for the `extends` of a `**\/*.html` block. It brings its own parser and plugins,
+ * so do not spread `angular.configs.templateRecommended` alongside it.
+ */
 const templateRecommended = (plugin) => [
-    templateBase(plugin),
+    ...angular.configs.templateRecommended,
+    ...angular.configs.templateAccessibility,
+    ...templateRules(plugin),
     {
         name: 'prestations-ng/template-recommended',
         rules: {
-            // Also in `tsRecommended`: the rule carries both an ESTree and an Angular
-            // template visitor, and each fires on its own kind of file.
-            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
-            '@dsivd/prestations-ng/no-uninvoked-signal-in-template': 'error',
+            '@angular-eslint/template/no-negated-async': 'off',
+            '@angular-eslint/template/button-has-type': 'error',
         },
     },
 ];

package/src/eslint/configs/template-rules.mjs

@@ -0,0 +1,17 @@
+import templateBase from './template-base.mjs';
+
+// Only the rules written by this library. `templateRecommended` includes it, alongside
+// the house style; use this layer directly to opt out of the latter.
+const templateRules = (plugin) => [
+    templateBase(plugin),
+    {
+        name: 'prestations-ng/template-rules',
+        rules: {
+            // Also in `tsRules`: the rule carries both an ESTree and an Angular
+            // template visitor, and each fires on its own kind of file.
+            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+            '@dsivd/prestations-ng/no-uninvoked-signal-in-template': 'error',
+        },
+    },
+];
+export default templateRules;

package/src/eslint/configs/ts-base.mjs

@@ -1,6 +1,6 @@
 // Registers the plugin without enabling any rule. Meant to be used through
-// `tsRecommended`, inside the `extends` of a block that already targets `**/*.ts`
-// and sets the TypeScript parser.
+// `tsRules` or `tsRecommended`, inside the `extends` of a block that already
+// targets `**/*.ts` and sets the TypeScript parser.
 const tsBase = (plugin) => ({
     name: 'prestations-ng/ts-base',
     plugins: {

package/src/eslint/configs/ts-recommended.mjs

@@ -1,11 +1,141 @@
-import tsBase from './ts-base.mjs';
+import eslint from '@eslint/js';
+import rxjs from '@smarttools/eslint-plugin-rxjs';
+import angular from 'angular-eslint';
+import importX from 'eslint-plugin-import-x';
+import simpleImportSort from 'eslint-plugin-simple-import-sort';
+import tseslint from 'typescript-eslint';
 
+import tsRules from './ts-rules.mjs';
+
+/**
+ * The house TypeScript preset: the shared baselines, this library's own rules, and the
+ * conventions every prestations-ng project follows.
+ *
+ * Meant for the `extends` of a `**\/*.ts` block. It brings its own parser and plugins,
+ * so do not spread `angular.configs.tsRecommended` alongside it — declaring the same
+ * plugin twice from two different copies makes ESLint fail outright.
+ */
 const tsRecommended = (plugin) => [
-    tsBase(plugin),
+    eslint.configs.recommended,
+    ...tseslint.configs.recommended, // covers: no-explicit-any, ban-ts-comment,
+    //   no-unused-expressions, no-var, no-unused-vars…
+    ...tseslint.configs.stylistic, // covers: array-type, consistent-type-assertions,
+    //   dot-notation, no-inferrable-types (default options),
+    //   no-empty-function (error), prefer-for-of,
+    //   prefer-function-type…
+    ...angular.configs.tsRecommended, // covers: prefer-inject, no-empty-lifecycle-method,
+    //   use-lifecycle-interface…
+    ...tsRules(plugin),
     {
         name: 'prestations-ng/ts-recommended',
+        plugins: {
+            rxjs,
+            'simple-import-sort': simpleImportSort,
+            'import-x': importX,
+        },
         rules: {
-            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+            // ── @angular-eslint ──────────────────────────────────────────────
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'app',
+                    style: 'kebab-case',
+                },
+            ],
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: 'app',
+                    style: 'camelCase',
+                },
+            ],
+            '@angular-eslint/no-uncalled-signals': ['error'],
+            '@angular-eslint/prefer-signal-model': ['error'],
+            '@angular-eslint/prefer-signals': ['error'],
+
+            // ── @typescript-eslint ───────────────────────────────────────────
+            '@typescript-eslint/explicit-function-return-type': [
+                'error',
+                {
+                    allowExpressions: true,
+                    allowTypedFunctionExpressions: true,
+                    allowHigherOrderFunctions: true,
+                    allowDirectConstAssertionInArrowFunctions: true,
+                },
+            ],
+            '@typescript-eslint/explicit-member-accessibility': [
+                'error',
+                { accessibility: 'no-public' },
+            ],
+            '@typescript-eslint/member-ordering': 'error',
+            '@typescript-eslint/no-base-to-string': 'warn',
+            // stylistic enables no-inferrable-types with default options (ignoreParameters: false);
+            // override here to allow typed parameters explicitly
+            '@typescript-eslint/no-inferrable-types': [
+                'error',
+                { ignoreParameters: true },
+            ],
+            // stylistic sets no-empty-function to error; downgrade to warn
+            '@typescript-eslint/no-empty-function': 'warn',
+            '@typescript-eslint/prefer-includes': 'warn',
+            '@typescript-eslint/return-await': ['error', 'never'],
+            '@typescript-eslint/typedef': ['error', { parameter: true }],
+            '@typescript-eslint/unified-signatures': 'error',
+            // off here — @typescript-eslint/no-shadow handles it correctly for TS
+            'no-shadow': 'off',
+            '@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
+            '@typescript-eslint/no-unused-vars': [
+                'error',
+                {
+                    varsIgnorePattern: '^_',
+                    argsIgnorePattern: '^_',
+                    caughtErrorsIgnorePattern: '^_',
+                },
+            ],
+
+            // ── eslint core ──────────────────────────────────────────────────
+            'arrow-body-style': 'error',
+            'arrow-parens': ['error', 'as-needed'],
+            curly: 'error',
+            eqeqeq: ['error', 'always'],
+            'guard-for-in': 'error',
+            'no-bitwise': 'error',
+            'no-caller': 'error',
+            'no-console': ['error', { allow: ['log', 'warn', 'error'] }],
+            'no-eval': 'error',
+            'no-extra-boolean-cast': 'off',
+            'no-multiple-empty-lines': 'error',
+            'no-new-wrappers': 'error',
+            'no-restricted-imports': [
+                'error',
+                { paths: ['rxjs/Rx', 'primeng/primeng', 'primeng'] },
+            ],
+            'no-return-assign': 'error',
+            'no-throw-literal': 'error',
+            'no-undef-init': 'error',
+            'no-useless-concat': 'error',
+            'object-shorthand': ['error', 'always', { avoidQuotes: true }],
+            'one-var': ['error', 'never'],
+            'prefer-arrow-callback': 'error',
+            'prefer-template': 'error',
+            radix: 'error',
+
+            // ── rxjs ─────────────────────────────────────────────────────────
+            'rxjs/no-implicit-any-catch': ['error', { allowExplicitAny: true }],
+            'rxjs/no-sharereplay': 'off',
+
+            // ── import-x ─────────────────────────────────────────────────────
+            'import-x/no-cycle': ['warn', { maxDepth: 3, ignoreExternal: true }],
+            'import-x/no-deprecated': 'warn',
+            'import-x/first': 'error',
+            'import-x/newline-after-import': 'error',
+            'import-x/no-duplicates': 'error',
+
+            // ── simple-import-sort ───────────────────────────────────────────
+            'simple-import-sort/imports': 'error',
+            'simple-import-sort/exports': 'error',
         },
     },
 ];

package/src/eslint/configs/ts-rules.mjs

@@ -0,0 +1,14 @@
+import tsBase from './ts-base.mjs';
+
+// Only the rules written by this library. `tsRecommended` includes it, alongside the
+// house style; use this layer directly to opt out of the latter.
+const tsRules = (plugin) => [
+    tsBase(plugin),
+    {
+        name: 'prestations-ng/ts-rules',
+        rules: {
+            '@dsivd/prestations-ng/no-direct-signal-mutation': 'error',
+        },
+    },
+];
+export default tsRules;

package/src/eslint/index.mjs

@@ -1,15 +1,21 @@
 import templateRecommended from './configs/template-recommended.mjs';
+import templateRules from './configs/template-rules.mjs';
 import tsRecommended from './configs/ts-recommended.mjs';
+import tsRules from './configs/ts-rules.mjs';
 import rules from './rules/index.mjs';
 
 const plugin = {
-  meta: { name: '@dsivd/prestations-ng' },
-  rules,
+    meta: { name: '@dsivd/prestations-ng' },
+    rules,
 };
 
 const configs = {
-  tsRecommended: tsRecommended(plugin),
-  templateRecommended: templateRecommended(plugin),
+    // The house presets: baselines, this library's rules, and the shared conventions.
+    tsRecommended: tsRecommended(plugin),
+    templateRecommended: templateRecommended(plugin),
+    // Only this library's own rules, for a project that supplies its own style.
+    tsRules: tsRules(plugin),
+    templateRules: templateRules(plugin),
 };
 
 export { configs, plugin, rules };