@dsivd/prestations-ng 19.0.5 → 19.0.6-beta.2

package/package.json

@@ -40,7 +40,7 @@
   "ng-update": {
     "migrations": "./schematics/migration-collection.json"
   },
-  "version": "19.0.5",
+  "version": "19.0.6-beta.2",
   "module": "fesm2022/dsivd-prestations-ng.mjs",
   "typings": "types/dsivd-prestations-ng.d.ts",
   "exports": {

package/src/eslint/rules/__tests__/no-direct-signal-mutation.test.mjs

@@ -42,6 +42,10 @@ describe('no-direct-signal-mutation', () => {
         'let x = value',
         'const obj = { prop: value }',
         'array[0] = value',
+        'pendingFilesByFormKey.get(formKey).files = []',
+        'this.pendingFilesByFormKey.get(formKey).url = baseUrl',
+        'const autocompleteComponent = viewChild("auto"); autocompleteComponent().inputElement().nativeElement.hidden = true',
+        'component.inputElement().nativeElement.value = ""',
 
         // Method chaining without assignment
         'model().update((v) => v).subscribe()',
@@ -72,10 +76,6 @@ describe('no-direct-signal-mutation', () => {
           code: "this.model().deeply.nested.property = value",
           errors: [{ messageId: 'directMutation' }],
         },
-        {
-          code: "obj.getter().property = value",
-          errors: [{ messageId: 'directMutation' }],
-        },
         {
           code: "model().property += value",
           errors: [{ messageId: 'directMutation' }],

package/src/eslint/rules/no-direct-signal-mutation.mjs

@@ -19,13 +19,23 @@ export default {
   },
 
   create(context) {
+    const sourceCode = context.sourceCode;
+    const viewQueryFactoryNames = new Set([
+      "viewChild",
+      "viewChildren",
+      "contentChild",
+      "contentChildren",
+    ]);
+    const viewQueryAccessorNames = collectViewQueryAccessorNames(sourceCode.ast);
+
     return {
       AssignmentExpression(node) {
-        // Check if left side is a member expression with a call expression
-        if (
-          node.left.type === "MemberExpression" &&
-          isCallExpression(node.left.object)
-        ) {
+        if (node.left.type !== "MemberExpression") {
+          return;
+        }
+
+        const rootCallExpression = getFirstCallExpression(node.left.object);
+        if (rootCallExpression && isSignalLikeRootCall(rootCallExpression)) {
           context.report({
             node,
             messageId: "directMutation",
@@ -34,19 +44,132 @@ export default {
       },
     };
 
+    function isSignalLikeRootCall(node) {
+      if (node.arguments.length !== 0) {
+        return false;
+      }
+
+      // model().prop = ... (local signal-like accessor)
+      if (node.callee.type === "Identifier") {
+        return !viewQueryAccessorNames.has(node.callee.name);
+      }
+
+      // this.model().prop = ... (component/service signal accessor)
+      // component.model().prop = ... should not be assumed to be a signal read.
+      if (node.callee.type === "MemberExpression") {
+        if (node.callee.object?.type !== "ThisExpression") {
+          return false;
+        }
+        return !isViewQueryAccessorCall(node.callee);
+      }
+
+      return false;
+    }
+
+    function isViewQueryAccessorCall(callee) {
+      const calledName = getCalledName(callee);
+      return calledName ? viewQueryAccessorNames.has(calledName) : false;
+    }
+
+    function getCalledName(callee) {
+      if (!callee) {
+        return null;
+      }
+      if (callee.type === "Identifier") {
+        return callee.name;
+      }
+      if (
+        callee.type === "MemberExpression" &&
+        !callee.computed &&
+        callee.property.type === "Identifier"
+      ) {
+        return callee.property.name;
+      }
+      return null;
+    }
+
     /**
-     * Recursively check if a node is a call expression.
-     * Handles: func().prop, obj.func().prop, this.func().prop, etc.
+     * Finds the first/root function call used as the base of a mutation chain.
+     * Examples:
+     * - model().property = x         => model()
+     * - this.model().deep.prop = x   => this.model()
+     * - this.query().el().x = y      => this.query()
      */
-    function isCallExpression(node) {
-      if (!node) return false;
-      if (node.type === "CallExpression") {
-        return true;
+    function getFirstCallExpression(node) {
+      if (!node) {
+        return null;
       }
       if (node.type === "MemberExpression") {
-        return isCallExpression(node.object);
+        return getFirstCallExpression(node.object);
+      }
+      if (node.type === "CallExpression") {
+        if (node.callee.type === "MemberExpression") {
+          const nestedCall = getFirstCallExpression(node.callee.object);
+          return nestedCall || node;
+        }
+        return node;
+      }
+      return null;
+    }
+
+    function collectViewQueryAccessorNames(ast) {
+      const names = new Set();
+
+      walkAst(ast, (node) => {
+        if (
+          node.type === "VariableDeclarator" &&
+          node.id?.type === "Identifier" &&
+          isViewQueryFactoryCall(node.init)
+        ) {
+          names.add(node.id.name);
+          return;
+        }
+
+        if (
+          (node.type === "PropertyDefinition" || node.type === "ClassProperty") &&
+          node.key?.type === "Identifier" &&
+          isViewQueryFactoryCall(node.value)
+        ) {
+          names.add(node.key.name);
+        }
+      });
+
+      return names;
+    }
+
+    function isViewQueryFactoryCall(node) {
+      return (
+        node?.type === "CallExpression" &&
+        node.callee?.type === "Identifier" &&
+        viewQueryFactoryNames.has(node.callee.name)
+      );
+    }
+
+    function walkAst(node, visitor, visited = new WeakSet()) {
+      if (!node || typeof node !== "object") {
+        return;
+      }
+      if (visited.has(node)) {
+        return;
+      }
+      visited.add(node);
+
+      visitor(node);
+
+      for (const key of Object.keys(node)) {
+        // ESLint AST nodes include cyclic parent references.
+        if (key === "parent") {
+          continue;
+        }
+        const child = node[key];
+        if (Array.isArray(child)) {
+          for (const element of child) {
+            walkAst(element, visitor, visited);
+          }
+        } else {
+          walkAst(child, visitor, visited);
+        }
       }
-      return false;
     }
   },
 };

package/types/dsivd-prestations-ng.d.ts

@@ -1889,7 +1889,7 @@ declare class ComponentError {
 }
 
 declare class FoehnValidationAlertsComponent {
-    component: _angular_core.InputSignal<FoehnInputComponent<any>>;
+    readonly component: _angular_core.InputSignal<FoehnInputComponent<any>>;
     readonly shouldErrorsBeLive: _angular_core.InputSignal<boolean>;
     private validationHandlerService;
     get errorMessages(): FormError[];
@@ -2088,7 +2088,7 @@ declare class FoehnListComponent implements OnChanges {
     readonly previousLabel: _angular_core.InputSignal<string>;
     readonly nextLabel: _angular_core.InputSignal<string>;
     readonly trackByFn: _angular_core.InputSignal<(index: number, _item: unknown) => number>;
-    templateVariable: _angular_core.Signal<TemplateRef<any>>;
+    readonly templateVariable: _angular_core.Signal<TemplateRef<any>>;
     readonly pageChange: _angular_core.OutputEmitterRef<PageChangeEvent>;
     currentPage: number;
     filteredList: unknown[];
@@ -2137,7 +2137,7 @@ declare class FoehnTableComponent extends FoehnInputComponent<unknown[]> impleme
     readonly columnsConfiguration: _angular_core.ModelSignal<FoehnTableColumnConfiguration<unknown>[]>;
     readonly itemsPerPage: _angular_core.InputSignal<number>;
     readonly fixedPageCount: _angular_core.InputSignal<number>;
-    readonly sort: _angular_core.InputSignal<TableSort>;
+    readonly sort: _angular_core.ModelSignal<TableSort>;
     readonly title: _angular_core.InputSignal<string>;
     readonly totalElements: _angular_core.InputSignal<number>;
     readonly titleSrOnly: _angular_core.InputSignal<boolean>;
@@ -2145,7 +2145,6 @@ declare class FoehnTableComponent extends FoehnInputComponent<unknown[]> impleme
     readonly nextLabel: _angular_core.InputSignal<string>;
     readonly tableClass: _angular_core.InputSignal<string>;
     readonly trackByFn: _angular_core.InputSignal<TrackByFunction<unknown>>;
-    readonly sortChange: _angular_core.OutputEmitterRef<TableSort>;
     readonly pageChange: _angular_core.OutputEmitterRef<FoehnTablePageChangeEvent>;
     readonly rowClick: _angular_core.OutputEmitterRef<RowElement>;
     currentPage: number;
@@ -2164,7 +2163,7 @@ declare class FoehnTableComponent extends FoehnInputComponent<unknown[]> impleme
     manageRowClick(rowElem: HTMLTableRowElement, item: unknown): void;
     private buildFilteredList;
     static ɵfac: _angular_core.ɵɵFactoryDeclaration<FoehnTableComponent, never>;
-    static ɵcmp: _angular_core.ɵɵComponentDeclaration<FoehnTableComponent, "foehn-table", never, { "columnsConfiguration": { "alias": "columnsConfiguration"; "required": false; "isSignal": true; }; "itemsPerPage": { "alias": "itemsPerPage"; "required": false; "isSignal": true; }; "fixedPageCount": { "alias": "fixedPageCount"; "required": false; "isSignal": true; }; "sort": { "alias": "sort"; "required": false; "isSignal": true; }; "title": { "alias": "title"; "required": false; "isSignal": true; }; "totalElements": { "alias": "totalElements"; "required": false; "isSignal": true; }; "titleSrOnly": { "alias": "titleSrOnly"; "required": false; "isSignal": true; }; "previousLabel": { "alias": "previousLabel"; "required": false; "isSignal": true; }; "nextLabel": { "alias": "nextLabel"; "required": false; "isSignal": true; }; "tableClass": { "alias": "tableClass"; "required": false; "isSignal": true; }; "trackByFn": { "alias": "trackByFn"; "required": false; "isSignal": true; }; }, { "columnsConfiguration": "columnsConfigurationChange"; "sortChange": "sortChange"; "pageChange": "pageChange"; "rowClick": "rowClick"; }, never, ["*"], true, never>;
+    static ɵcmp: _angular_core.ɵɵComponentDeclaration<FoehnTableComponent, "foehn-table", never, { "columnsConfiguration": { "alias": "columnsConfiguration"; "required": false; "isSignal": true; }; "itemsPerPage": { "alias": "itemsPerPage"; "required": false; "isSignal": true; }; "fixedPageCount": { "alias": "fixedPageCount"; "required": false; "isSignal": true; }; "sort": { "alias": "sort"; "required": false; "isSignal": true; }; "title": { "alias": "title"; "required": false; "isSignal": true; }; "totalElements": { "alias": "totalElements"; "required": false; "isSignal": true; }; "titleSrOnly": { "alias": "titleSrOnly"; "required": false; "isSignal": true; }; "previousLabel": { "alias": "previousLabel"; "required": false; "isSignal": true; }; "nextLabel": { "alias": "nextLabel"; "required": false; "isSignal": true; }; "tableClass": { "alias": "tableClass"; "required": false; "isSignal": true; }; "trackByFn": { "alias": "trackByFn"; "required": false; "isSignal": true; }; }, { "columnsConfiguration": "columnsConfigurationChange"; "sort": "sortChange"; "pageChange": "pageChange"; "rowClick": "rowClick"; }, never, ["*"], true, never>;
 }
 
 declare class RegisterNgModelService {
@@ -3660,7 +3659,7 @@ declare class FoehnFeedbackNotificationComponent {
     goodIconName: _fortawesome_fontawesome_common_types.IconDefinition;
     mediumIconName: _fortawesome_fontawesome_common_types.IconDefinition;
     badIconName: _fortawesome_fontawesome_common_types.IconDefinition;
-    expanded: _angular_core.WritableSignal<boolean>;
+    readonly expanded: _angular_core.WritableSignal<boolean>;
     isScrollEnded: boolean;
     visible: Observable<boolean>;
     goodUrl: Observable<string>;