@dsivd/prestations-ng 19.0.0-beta.11 → 19.0.0-beta.12

package/UPGRADING_V19.md

@@ -77,7 +77,7 @@ Replace `com.fasterxml.jackson.databind.ObjectMapper` with `tools.jackson.databi
 - `ch.vd.cyberadminbe.jms` has been moved to `ch.vd.cyber.backofficebe.jms`
 - `ch.vd.cyberadminbe.security` has been moved to `ch.vd.cyber.backofficebe.security`
 - `ch.vd.cyberadminbe.editique` has been moved to `ch.vd.cyber.backofficebe.editique`
-- `cyberadminbe.config.CyberAdminBeEsbHttpConfig` has renamed to `backofficebe.config.BoCommonEsbHttpConfig`
+- `cyberadminbe.config.CyberAdminBeEsbHttpConfig` has been renamed to `backofficebe.config.BoCommonEsbHttpConfig`
 
 ### BO : Brave Tracer
 
@@ -133,7 +133,7 @@ public class MyListener extends EsbMessageListenerWithTracingPropagation {
 }
 ```
 
-finally, if you have mock issues with your integration tests, you can use `ch.vd.cyber.backofficebe.jms.JmsTestUtils.mockTracingPropagation(final Tracer tracerMock, final Propagator propagatorMock)`
+Finally, if you have mock issues with your integration tests, you can use `ch.vd.cyber.backofficebe.jms.JmsTestUtils.mockTracingPropagation(final Tracer tracerMock, final Propagator propagatorMock)`
 
 ### BO : ESB Integration
 
@@ -152,11 +152,11 @@ Run your application with this dependency :
 </dependency>
 ```
 
-Look for logs that indicate property you should migrate (watch for WARN logs of class PropertiesMigrationListener), update them and remove the dependency
+Look for logs that indicate properties you should migrate (watch for WARN logs of class PropertiesMigrationListener), update them and remove the dependency
 
 ### BO using jpa repositories
 
-As we also have jdbc in the classpath, to avoid having dozens of log like "Spring Data JDBC - Could not safely
+As we also have jdbc in the classpath, to avoid having dozens of logs like "Spring Data JDBC - Could not safely
 identify store assignment for repository candidate interface", add the property in your application.properties :
 
 spring.data.jdbc.repositories.enabled=false
@@ -188,9 +188,9 @@ For the commands in this guide, it is supposed that you are in the `front` folde
 The main feature in `prestations-ng` v19 is the update of the `@angular/*` peer dependencies
 to `^21.2.14`, using `node 22+` to build, `npm 10+` for package manager and `Foehn 2+ (Bootstrap 5+)` for our design system.
 
-A lot of breaking because our library has migrated to **standalone** components, **signals** and **inject function** instead of constructor injection parameters.
+A lot of breaking changes because our library has migrated to **standalone** components, **signals** and **inject function** instead of constructor injection parameters.
 
-> 🚨 **Read carefully following [PITFALLS](ANGULAR_SIGNALS.md#common_pitfalls), especially points 4, 6 & 8**
+> 🚨 **Read carefully the following [PITFALLS](ANGULAR_SIGNALS.md#common_pitfalls), especially points 4, 6 & 8**
 
 ### Migrate to ESLint
 
@@ -241,6 +241,10 @@ Be sure to use a node version 22+ in your terminal:
 node -v
 ```
 
+##### IntelliJ node version
+
+Change IntelliJ node version to 22+ by going to `File > Settings > Languages & Frameworks > TypeScript` and selecting a node version 22+ in `Node runtime`.
+
 #### Continue with Angular 20 migration
 
 ```bash
@@ -352,7 +356,7 @@ ng update ngx-matomo-client@9
 
 ### Now fix your project before continuing
 
-**IMPORTANT: Fix your project because our new prestations-ng v19+ is standalone, uses signals instead of observables and inject function instead of constructor injection parameter.**
+**IMPORTANT: Fix your project because our new prestations-ng v19+ is standalone, uses signals instead of observables and inject function instead of constructor injection parameters.**
 
 - Only keep `modules` relative to your application such as `AppRoutingModule`.
 - Remove all other imports of **modules** and make sure you are using the new **standalone components** by adding them directly from your HTML file "alt+enter".
@@ -881,7 +885,7 @@ rm karma.conf.js
 - search for `karma.conf.js` in your project and remove all references to it.
 - search for `protractor.conf.js` in your project and remove them if they still exist.
 
-Then run following command to migrate from jasmine to vitest:
+Then run the following command to migrate from jasmine to vitest:
 
 ```bash
 ng g @schematics/angular:refactor-jasmine-vitest
@@ -1280,7 +1284,44 @@ mv ./.husky ../.husky
 git add -A
 ```
 
-- You can manually run formatting commands as well:
+- In your `package.json`, modify `prepare` script to run husky from the parent folder:
+
+```diff
+- "prepare": "husky"
++ "prepare": "cd .. && husky"
+```
+
+Then run:
+
+```bash
+npm install
+```
+
+You should see in your project root folder `.husky` a new folder `_`.
+
+#### Husky pre-commit hook for multi-project repository
+
+- when having a multi-project repository, modify `.husky/pre-commit` file with following content to make sure husky is running in the right folder:
+
+```bash
+projects=$(git diff --cached --name-only --diff-filter=ACMR | awk -F'/' '{print $1}' | sort -u)
+
+for project in $projects; do
+  if [ -d "$project/front" ]; then
+    echo "➡️  lint-staged pour $project/front"
+    (cd "$project/front" && npx lint-staged) || exit 1
+  fi
+done
+```
+
+and move it to the root folder of your repository. Then change your `package.json` by modifying `prepare` script to run husky from the parent folder:
+
+```diff
+- "prepare": "husky"
++ "prepare": "cd ../.. && husky"
+```
+
+#### Manually run formatting commands
 
 ```bash
 npm run format:prettier
@@ -1378,7 +1419,7 @@ Finally check if your tests run well :
 npm run test
 ```
 
-> 🚨 **Read carefully following [PITFALLS](ANGULAR_SIGNALS.md#common_pitfalls), especially points 4, 6 & 8 and check again your application**
+> 🚨 **Read carefully the following [PITFALLS](ANGULAR_SIGNALS.md#common_pitfalls), especially points 4, 6 & 8 and check again your application**
 
 ### Release your application using `jenkins-libs`
 

package/package.json

@@ -40,7 +40,7 @@
   "ng-update": {
     "migrations": "./schematics/migration-collection.json"
   },
-  "version": "19.0.0-beta.11",
+  "version": "19.0.0-beta.12",
   "module": "fesm2022/dsivd-prestations-ng.mjs",
   "typings": "types/dsivd-prestations-ng.d.ts",
   "exports": {