@dsivd/prestations-ng 19.0.0-beta-9 → 19.0.0-beta.10

package/UPGRADING_V19.md

@@ -81,7 +81,7 @@ Replace `com.fasterxml.jackson.databind.ObjectMapper` with `tools.jackson.databi
 
 ### BO : Brave Tracer
 
-If you are using Brave Tracer (search `brace.Tracer` in the code, usually in backoffices), you need to replace it with
+If you are using Brave Tracer (search `brave.Tracer` in the code, usually in backoffices), you need to replace it with
 OpenTelemetry by adding the following dependencies (already included by `ch.vd.cyber:starter-bo-jdbc-jms` and `ch.vd.cyber:starter-prestation`):
 
 ```xml
@@ -102,7 +102,8 @@ And replace `brave.Tracer` imports by `io.micrometer.tracing.Tracer`;
 
 This base class has been moved from `ch.vd.cyber.sdk:cyberadmin-be` to `ch.vd.cyber.sdk:backoffice-be`
 and renamed `EsbMessageListenerWithTracingPropagation`.
-the constructor has also been updated :
+
+The constructor has also been updated :
 
 ```java
 import ch.vd.cyberadminbe.jms.EsbMessageListenerWithSleuthIntegration;
@@ -132,7 +133,7 @@ public class MyListener extends EsbMessageListenerWithTracingPropagation {
 }
 ```
 
-finally, if you have mock issues with you integration tests, you can use `ch.vd.cyber.backofficebe.jms.JmsTestUtils.mockTracingPropagation(final Tracer tracerMock, final Propagator propagatorMock)`
+finally, if you have mock issues with your integration tests, you can use `ch.vd.cyber.backofficebe.jms.JmsTestUtils.mockTracingPropagation(final Tracer tracerMock, final Propagator propagatorMock)`
 
 ### BO : ESB Integration
 
@@ -155,7 +156,7 @@ Look for logs that indicate property you should migrate (watch for WARN logs of
 
 ### BO using jpa repositories
 
-As we also have jdbc in the classpath, to avoid having dozens of log like "Spring Data JDBC - Could not safely 
+As we also have jdbc in the classpath, to avoid having dozens of log like "Spring Data JDBC - Could not safely
 identify store assignment for repository candidate interface", add the property in your application.properties :
 
 spring.data.jdbc.repositories.enabled=false
@@ -182,7 +183,7 @@ Take a look at Sonar to see other things that you can improve or ignore.
 
 ## PRESTATIONS-NG
 
-For the commands in this guide, it is supposed that your are in the `front` folder of your project.
+For the commands in this guide, it is supposed that you are in the `front` folder of your project.
 
 The main feature in `prestations-ng` v19 is the update of the `@angular/*` peer dependencies
 to `^21.2.14`, using `node 22+` to build, `npm 10+` for package manager and `Foehn 2+ (Bootstrap 5+)` for our design system.
@@ -207,8 +208,6 @@ Remove your `resolutions` in `package.json` before starting : if you have `resol
 
 In the next commands, commit before each ng update.
 
-Unlink `@dsivd/prestations-ng` by running `yarn unlink @dsivd/prestations-ng` in your `front` folder if you have linked it before.
-
 ```bash
 npm install
 npm install @angular/cli@19 -g
@@ -216,33 +215,6 @@ ng update @angular/core@19 @angular/cli@19
 ng update @dsivd/prestations-ng@18
 ```
 
-```bash
-npm install @angular/cli@20 -g
-ng update @angular/core@20 @angular/cli@20
-```
-
-When asked the question "Select the migrations that you'd like to run",
-
-accept **"use-application-builder"** by hitting "Space" key then "Enter".
-
-When asked the question "Select the migrations that you'd like to run",
-
-accept **"control-flow-migration"** by hitting "Space" key.
-
-accept **"router-current-navigation"** by hitting "Space" key.
-
-Then press "Enter" key.
-
-**IMPORTANT: Search for every `@for` in your project and check that `track` statement is present and has a unique identifier**
-
-**NB: When using `@angular/cdk` in your project**
-
-```bash
-ng update @angular/cdk@20
-```
-
-### Running with node 22+
-
 #### Switch to node 22+
 
 ##### If you are using our `slave-apps`
@@ -269,6 +241,33 @@ Be sure to use a node version 22+ in your terminal:
 node -v
 ```
 
+#### Continue with Angular 20 migration
+
+```bash
+npm install @angular/cli@20 -g
+ng update @angular/core@20 @angular/cli@20
+```
+
+- When asked "Select the migrations that you'd like to run",
+    - accept **"use-application-builder"** by hitting "Space" key
+    - hit "Enter" key
+- When asked "Select the migrations that you'd like to run",
+    - accept **"control-flow-migration"** by hitting "Space" key
+    - hit "Down arrow" key
+    - accept **"router-current-navigation"** by hitting "Space" key
+    - hit "Enter" key
+
+**IMPORTANT: Search for every `@for` in your project and check that `track` statement is present and has a unique identifier.
+When a unique identifier is not possible, use `track $index`.**
+
+**NB: When using `@angular/cdk` in your project**
+
+```bash
+ng update @angular/cdk@20
+```
+
+### Running with node 22+
+
 #### In your project
 
 Update your `package.json` file to specify the node engine:
@@ -307,17 +306,17 @@ npm install @angular/cli@21 -g
 ng update @dsivd/prestations-ng@latest
 ```
 
-When asked again the question "Select the migrations that you'd like to run",
-
-accept **"router-current-navigation"** by hitting "Space" key then "Enter".
+- When asked again "Select the migrations that you'd like to run"
+    - accept **"router-current-navigation"** by hitting "Space" key
+    - hit "Enter" key
 
 ```bash
 ng update @angular/cli@21
 ```
 
-When asked the question "Select the migrations that you'd like to run",
-
-accept **"use-application-builder"** by hitting "Space" key then "Enter".
+- When asked "Select the migrations that you'd like to run"
+    - accept **"use-application-builder"** by hitting "Space" key
+    - hit "Enter" key
 
 ```bash
 npm install @types/node@22 ts-node@10
@@ -348,18 +347,15 @@ ng update ngx-matomo-client@9
 ```
 
 - In your `.eslintrc.json`, remove `"/src/main.ts",` from `ignorePatterns`.
-
 - In `main.ts`, replace `platformBrowserDynamic` by `platformBrowser`.
-
 - When using `<foehn-list-summary` component, replace `list` by `model`.
 
 ### Now fix your project before continuing
 
 **IMPORTANT: Fix your project because our new prestations-ng v19+ is standalone, uses signals instead of observables and inject function instead of constructor injection parameter.**
 
-Remove all your `@dsivd/prestations-ng` imports of modules and make sure you are using the new standalone components instead by adding them directly from your html file "alt+enter".
-
-Check every `constructor` in your project, and remove useless `constructor` parameters that are not used anymore (like `ActivatedRoute` in components extending `AbstractPageComponent`).
+- Remove all your `@dsivd/prestations-ng` imports of modules and make sure you are using the new standalone components instead by adding them directly from your html file "alt+enter".
+- Check every `constructor` in your project, and remove useless `constructor` parameters that are not used anymore (like `ActivatedRoute` in components extending `AbstractPageComponent`).
 
 Run the following command until you have no more errors.
 
@@ -385,11 +381,13 @@ ng generate @angular/core:inject
 ✔ Do you want optional inject calls to be non-nullable? Enable this option if you want the return type to be identical to @Optional(), at the expense of worse
 type safety. **Yes**
 
-Go through every file that has changed and fix what is broken.
+Then:
+
+- Go through every file that has changed and fix what is broken.
+- Reorder public / private and remove unused imports so ESLINT is happy again.
 
-Reorder public / private and remove unused imports so ESLINT is happy again.
+Little example of cleaning when extending `AbstractPageComponent`:
 
-For example, when extending `AbstractPageComponent`:
 Before:
 
 ```ts
@@ -548,7 +546,7 @@ You may have some other modules that are maybe lazy-loaded. Just be sure that al
 ng generate @angular/core:route-lazy-loading
 ```
 
-Here is a example when doing it manually because schematic above does not work as intended:
+Here is an example when doing it manually because schematic above does not work as intended:
 
 Your `app.routing.ts` file should look something like this:
 
@@ -615,9 +613,8 @@ ng generate @angular/core:ngclass-to-class
 
 ✔ Should the migration also migrate space-separated keys? **Yes**
 
-Check every file that has changed and fix what is broken.
-
-Check remaining `ngClass` usage in your project and replace it with class bindings.
+- Check every file that has changed and fix what is broken.
+- Check remaining `ngClass` usage in your project and replace it with class bindings.
 
 **Be aware that `[class]` replaces all element classes. When you have static classes, concatenate them with dynamic ones.**
 
@@ -683,9 +680,8 @@ ng generate @angular/core:ngstyle-to-style
 
 ✔ Should the migration also migrate object references? **No**
 
-Check every file that has changed and fix what is broken.
-
-Check remaining `ngStyle` usage in your project and replace it with style bindings.
+- Check every file that has changed and fix what is broken.
+- Check remaining `ngStyle` usage in your project and replace it with style bindings.
 
 ### Convert CommonModule usage to standalone imports
 
@@ -703,7 +699,7 @@ ng generate @angular/core:common-to-standalone
 
 ✔ Which directory do you want to migrate? **./**
 
-Check every file that has changed and fix what is broken.
+- Check every file that has changed and fix what is broken.
 
 ### Migrate @HostListener
 
@@ -762,11 +758,9 @@ ng generate @angular/core:signal-queries-migration --insert-todos
 
 ✔ Do you want to migrate as much as possible, even if it may break your build? **No**
 
-Check every file that has changed and fix what is broken.
-
-Check every remaining `@ViewChild`, `@ViewChildren`, `@ContentChild`, and `@ContentChildren` usage in your project and replace them with signal queries.
-
-Check every **TODO** comment added by the migration and fix them.
+- Check every file that has changed and fix what is broken.
+- Check every remaining `@ViewChild`, `@ViewChildren`, `@ContentChild`, and `@ContentChildren` usage in your project and replace them with signal queries.
+- Check every **TODO** comment added by the migration and fix them.
 
 ### Migrate to output functions
 
@@ -808,11 +802,9 @@ ng generate @angular/core:signal-input-migration --insert-todos
 
 ✔ Do you want to migrate as much as possible, even if it may break your build? **No**
 
-Check every file that has changed and fix what is broken.
-
-Check every remaining `@Input` usage in your project and replace them with input signals.
-
-Check every **TODO** comment added by the migration and fix them.
+- Check every file that has changed and fix what is broken.
+- Check every remaining `@Input` usage in your project and replace them with input signals.
+- Check every **TODO** comment added by the migration and fix them.
 
 ### Migrate to vitest
 
@@ -884,8 +876,8 @@ npm uninstall @types/jasmine @types/jasminewd2
 rm karma.conf.js
 ```
 
-Now search for `karma.conf.js` in your project and remove all references to it.
-Now search for `protractor.conf.js` in your project and remove them if they still exist.
+- search for `karma.conf.js` in your project and remove all references to it.
+- search for `protractor.conf.js` in your project and remove them if they still exist.
 
 Then run following command to migrate from jasmine to vitest:
 
@@ -1031,9 +1023,8 @@ Remove your old `.eslintrc.json` file in your `front` folder:
 rm .eslintrc.json
 ```
 
-Now search for `.eslintrc.json` in your project and remove them.
-
-Then add a new `eslint.config.mjs` file with the following content:
+- search for `.eslintrc.json` in your project and remove them.
+- add a new `eslint.config.mjs` file with the following content:
 
 ```ts
 // @ts-check
@@ -1201,9 +1192,9 @@ export default tseslint.config(
 );
 ```
 
-#### Delete `typing.d.ts`
+#### Delete `typings.d.ts`
 
-In `front/src/`, remove the file `typing.d.ts` if it is still there.
+In `front/src/`, remove the file `typings.d.ts` if it is still there.
 
 #### Update your tsconfig\*.json files
 
@@ -1287,14 +1278,14 @@ mv ./.husky ../.husky
 git add -A
 ```
 
-- You can manually run formating commands as well:
+- You can manually run formatting commands as well:
 
 ```bash
 npm run format:prettier
 npm run lint
 ```
 
-Fix your `meta.service.ts` but replacing:
+Fix your `meta.service.ts` by replacing:
 
 Before:
 

package/package.json

@@ -40,7 +40,7 @@
   "ng-update": {
     "migrations": "./schematics/migration-collection.json"
   },
-  "version": "19.0.0-beta-9",
+  "version": "19.0.0-beta.10",
   "module": "fesm2022/dsivd-prestations-ng.mjs",
   "typings": "types/dsivd-prestations-ng.d.ts",
   "exports": {