@dsivd/prestations-ng 18.3.13 → 18.3.15-beta.1

package/CHANGELOG.md

@@ -6,6 +6,38 @@
 
 ---
 
+## [18.3.15]
+
+### Updated
+
+- [foehn-navigation.component.html](projects/prestations-ng/src/foehn-navigation/foehn-navigation/foehn-navigation.component.html)
+- [foehn-simple-navigation.component.html](projects/prestations-ng/src/foehn-navigation/foehn-simple-navigation/foehn-simple-navigation.component.html)
+    - while the page targeted by "next", "transmit" or "previous" is loading for more than 200 ms (e.g. lazy loaded route), the clicked button displays a spinner with the new `loadingLabel` input (dictionary key `foehn-navigation.loading.label`, "Chargement...") and the navigation buttons are disabled (`aria-disabled`; clicks are ignored from the start of the navigation); a `role="status"` region announces the loading to screen readers
+- [foehn-navigation.service.ts](projects/prestations-ng/src/foehn-navigation/foehn-navigation.service.ts)
+    - new method `pendingNavigationDirection()`: direction of the navigation started with `next()` or `previous()` until it ends, `null` otherwise
+
+### Fixed
+
+- [abstract-page-component.ts](projects/prestations-ng/src/abstract-page-component.ts)
+    - fixed a second click on "next" or "transmit" while the next page is loading (lazy loaded route, resolver, async guard) saving again and skipping the next page: `send()`, `sendAndTransmit()` and `transmit()` are now ignored until the navigation to the next page ends
+    - new protected method `navigateToNextPage()`: pages overriding `onFormSent()` should call it instead of `this._navigation.next()` to get this protection
+- [abstract-page-from-menu.component.ts](projects/prestations-ng/src/foehn-menu-prestation/abstract-page-from-menu.component.ts)
+    - same fix when returning to the parent page
+
+## [18.3.14]
+
+### Fixed
+
+- [foehn-input-phone.component.ts](projects/prestations-ng/src/foehn-input/foehn-input-phone.component.ts)
+    - fixed help texts to be aligned with ch.vd.cyber.prestationsbe.validation.PhoneNumberValidator (prestations-be)
+    - dictionary keys have changed to be more explicit :
+        - foehn-input-phone.STANDARD_HELPTEXT_SWISS_FIX_AND_MOBILE
+        - foehn-input-phone.STANDARD_HELPTEXT_SWISS_FIX_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_SWISS_MOBILE_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_FIX_AND_MOBILE
+        - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_FIX_ONLY
+        - foehn-input-phone.STANDARD_HELPTEXT_INTERNATIONAL_MOBILE_ONLY
+
 ## [18.3.13]
 
 ### Fixed

package/UPGRADING_V19.md

@@ -11,8 +11,8 @@ From here on, we are in the root folder of your project, for example ~/git/cybsd
 
 ### Spring Boot 4
 
-You can switch to Java 25 `jdk25` + change in IntelliJ: right-click on your project > Open Module Settings > Project > set "SDK" to `jdk25` from devtools and "Language 
-  level" to `25` in "Modules"
+You can switch to Java 25 `jdk25` + change in IntelliJ: right-click on your project > Open Module Settings > Project > set "SDK" to `jdk25` from devtools and "Language
+level" to `25` in "Modules"
 
 Use the latest application-parent v15+ in your `pom.xml`.
 
@@ -53,6 +53,7 @@ If the following plugin with Lombok path was added by the recipe, remove this pl
 ```
 
 If the code uses `AutoConfigureMockMvc`, add:
+
 ```xml
 <dependency>
     <groupId>org.springframework.boot</groupId>
@@ -60,9 +61,10 @@ If the code uses `AutoConfigureMockMvc`, add:
     <scope>test</scope>
 </dependency>
 ```
+
 And replace the old `AutoConfigureMockMvc` import which is not recognized anymore by the new one.
 
-If we use in pom.xml Spring/Hibernate dependencies (like hibernate-jpamodelgen), check the Spring Boot 4 migration 
+If we use in pom.xml Spring/Hibernate dependencies (like hibernate-jpamodelgen), check the Spring Boot 4 migration
 guide to see if it has been replaced by another library: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Migration-Guide
 
 ### Jackson migration
@@ -72,14 +74,16 @@ Replace `com.fasterxml.jackson.databind.ObjectMapper` with `tools.jackson.databi
 
 ### Brave Tracer
 
-If you are using Brave Tracer (search `brace.Tracer` in the code, usually in backoffices), you need to replace it with 
+If you are using Brave Tracer (search `brace.Tracer` in the code, usually in backoffices), you need to replace it with
 OpenTelemetry by adding the following dependency:
+
 ```xml
 <dependency>
     <groupId>org.springframework.boot</groupId>
     <artifactId>spring-boot-micrometer-tracing-brave</artifactId>
 </dependency>
 ```
+
 And replace `brave.Tracer` imports by `io.micrometer.tracing.Tracer`;
 
 ### Property migration
@@ -100,8 +104,8 @@ Look for logs that indicate property you should migrate (watch for WARN logs of
 
 Spring boot 4 doesn't support calling a controller with a trailing slash, fix the url called (/api/ping != /api/ping**/**)
 
-
 ### Clean Sonar code smells
+
 You can use the following OpenRewrite recipes to clean Sonar code smells. It is recommended to do it after the migration to avoid mixing the migration changes with code cleaning changes, and to make it easier to review.
 
 ```bash

package/abstract-page-component.d.ts

@@ -38,6 +38,7 @@ export declare abstract class AbstractPageComponent<T extends I18nForm> implemen
     private _currentLangSubscription;
     private _transmitConcurrentSafe;
     private _gesdemSaveSubscription;
+    private _isNavigatingToNextPage;
     private readonly _registerNgModelService;
     constructor(activatedRoute: ActivatedRoute);
     ngOnInit(): void;
@@ -50,6 +51,14 @@ export declare abstract class AbstractPageComponent<T extends I18nForm> implemen
     protected setPageTitle(pageTitle: string): void;
     protected setPageTitleAsync(pageTitle: Observable<string>): void;
     protected onFormSent(goToNextPage: boolean): void;
+    /**
+     * Navigates to the next page and ignores send(), sendAndTransmit() and transmit() until the navigation ends.
+     *
+     * The current page stays displayed and clickable while the next one is activated (e.g. lazy loaded route,
+     * resolver or async guard): a second click on "next" would save again, then navigate once more from the
+     * next page and skip it.
+     */
+    protected navigateToNextPage(): Promise<void>;
     private checkHasPendingsFilesBeforeTransmit;
     private gotToTop;
     abstract newForm(): T;