@dsivd/prestations-ng 18.0.4 → 18.0.5

package/CHANGELOG.md

@@ -6,6 +6,13 @@
 
 ---
 
+## [18.0.5]
+
+### Updated
+
+- [foehn-input-email.component.ts](projects/prestations-ng/src/foehn-input/foehn-input-email.component.ts)
+    - Do not override `helpModal` and `standardHelpText` if already set as input
+
 ## [18.0.4]
 
 ### Added
@@ -13,7 +20,7 @@
 - [default-dictionary.ts](projects/prestations-ng/src/sdk-dictionary/default-dictionary.ts)
     - added key `foehn-input-email.standard-connected-help-text`
 
-### Update
+### Updated
 
 - [.browserslistrc](src/.browserslistrc)
     - added step by step for upgrading browsers list

package/UPGRADING_V18.md

@@ -32,26 +32,6 @@ ng update @angular/core@18 @angular/cli@18
 
 When asked the question "Select the migrations that you'd like to run", accept "use-application-builder" by hitting "Space" key then "Enter".
 
-#### Fix provideHttpClient withXsrfConfiguration
-
-Modify your `app.module.ts` and add:
-`{
-    cookieName: 'XSRF-TOKEN',
-    headerName: 'X-XSRF-TOKEN'
-}`
-to `withXsrfConfiguration()`.
-
-```diff
-providers: [
-    META_SERVICE_PROVIDER,
--   provideHttpClient(withXsrfConfiguration()),
-+   provideHttpClient(withXsrfConfiguration({
-+       cookieName: 'XSRF-TOKEN',
-+       headerName: 'X-XSRF-TOKEN'
-+   })),
-]
-```
-
 #### Add an empty "browser" to your output path in angular.json
 
 ```diff
@@ -163,7 +143,7 @@ In your `proxy.conf.json` file:
 }
 ```
 
-#### NgHttpLoader migration as standalone
+#### NgHttpLoader migration as standalone + Fix provideHttpClient withXsrfConfiguration
 
 In your `app.module.ts` file:
 
@@ -181,8 +161,14 @@ In your `app.module.ts` file:
 -       NgHttpLoaderModule.forRoot(),
 +       NgHttpLoaderComponent,
     ], providers: [
-        provideHttpClient(
-+           withInterceptors([pendingRequestsInterceptor$]),
+-        provideHttpClient(withXsrfConfiguration()),
++        provideHttpClient(
++            withInterceptors([pendingRequestsInterceptor$]),
++            withXsrfConfiguration({
++                cookieName: 'XSRF-TOKEN',
++                headerName: 'X-XSRF-TOKEN'
++            })
++        ),
     ]
 })
 ```
@@ -416,7 +402,7 @@ see https://dsigit.etat-de-vaud.ch/outils/git/projects/PEE/repos/imt-charts/brow
 You can use this openrewrite recipe to simplify the migration (run with java 11)
 
 ```bash
-mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_4 -Drewrite.exportDatatables=true -Pnof,noft
+mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_4 -Pnof,noft
 ```
 
 Fix application.properties :
@@ -501,6 +487,7 @@ with these properties :
 
 ### APPLICATION-PARENT
 
+- set parent version to `14.x.x`
 - remove property `java.version` (already set to `21` in the parent)
 - if existing, remove exclusion `spring-cloud-starter-netflix-eureka-client` from `starter-prestation`
 - remove dependency `spring-boot-starter-validation` (already in `starter-prestation`)
@@ -616,6 +603,18 @@ buildAppPipelinePodmanUT([
 ])
 ```
 
+### Code cleanup
+
+You can use these openrewrite recipes to clean your code :
+
+```bash
+mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.JUnit5BestPractices
+mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-static-analysis:RELEASE -Drewrite.activeRecipes=org.openrewrite.staticanalysis.CommonStaticAnalysis
+mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.activeRecipes=org.openrewrite.java.RemoveUnusedImports
+```
+
+Finally, take a look at sonar
+
 ### Debugging tips
 
 Spring boot 3 doesn't support calling a controller with a trailing slash, fix the url called (/api/ping != /api/ping**/**)

package/fesm2022/dsivd-prestations-ng.mjs

@@ -11139,6 +11139,11 @@ class FoehnInputEmailComponent extends FoehnInputStringComponent {
     constructor(dictionaryService) {
         super();
         this.dictionaryService = dictionaryService;
+    }
+    ngOnInit() {
+        super.ngOnInit();
+        this.type = 'email';
+        this.autocomplete = 'email';
         this.languageChangeSubscription = this.dictionaryService
             .getCurrentLanguageCode()
             .pipe(switchMap(() => combineLatest([
@@ -11148,19 +11153,20 @@ class FoehnInputEmailComponent extends FoehnInputStringComponent {
         ])))
             // eslint-disable-next-line rxjs-angular/prefer-async-pipe
             .subscribe(([modalTitle, modalContent, standardHelpText]) => {
-            this.helpModal = {
-                title: modalTitle,
-                body: modalContent,
-                modalSize: 'modal-xs'
-            };
-            this.standardHelpText = standardHelpText;
+            if (this.helpModal === undefined) {
+                // Do not override if already set
+                this.helpModal = {
+                    title: modalTitle,
+                    body: modalContent,
+                    modalSize: 'modal-xs'
+                };
+            }
+            if (this.standardHelpText === undefined) {
+                // Do not override if already set
+                this.standardHelpText = standardHelpText;
+            }
         });
     }
-    ngOnInit() {
-        super.ngOnInit();
-        this.type = 'email';
-        this.autocomplete = 'email';
-    }
     ngOnDestroy() {
         super.ngOnDestroy();
         this.languageChangeSubscription?.unsubscribe();