@dsivd/prestations-ng 18.0.0-beta.2 → 18.0.0-beta.20

package/CHANGELOG.md

@@ -19,6 +19,21 @@
 - [foehn-table.component.ts](projects/prestations-ng/src/foehn-table/foehn-table.component.ts)
     - `[list]` attribut has been removed. Use `[model]` instead.
 
+## [17.10.10]
+
+### Fixed
+
+- [redirect.component.ts](projects/prestations-ng/src/sdk-redirect/redirect.component.ts)
+    - fixed interval destruction
+    - now use `window.location.reload()` instead of `window.location.href = ''`
+
+## [17.10.9]
+
+### Fixed
+
+- [foehn-autocomplete.component.ts](projects/prestations-ng/src/foehn-autocomplete/foehn-autocomplete.component.ts)
+    - Added a `setTimeout` to avoid having a value displayed on screen when NULL is set
+
 ## [17.10.8]
 
 ### Fixed
@@ -2936,18 +2951,17 @@ data: {
 - [foehn-input-address.component.html](projects/prestations-ng/src/foehn-address/foehn-input-address.component.html)
 
     - added some inputs to affect the presence of (facultatif) on every label :
-
-                      -   `@Input() countryRequired = true`
-                      -   `@Input() swissNpaLocalityRequired = true`
-                      -   `@Input() streetRequired = true`
-                      -   `@Input() streetNumberRequired = false`
-                      -   `@Input() foreignZipCodeRequired = true`
-                      -   `@Input() foreignLocalityRequired = true`
-                      -   `@Input() foreignStreetRequired = true`
-                      -   `@Input() foreignStreetNumberRequired = false`
-                      -   `@Input() postOfficeBoxTextRequired = false`
-                      -   `@Input() addressLine1Required = false`
-                      -   `@Input() addressLine2Required = false
+        - `@Input() countryRequired = true`
+        - `@Input() swissNpaLocalityRequired = true`
+        - `@Input() streetRequired = true`
+        - `@Input() streetNumberRequired = false`
+        - `@Input() foreignZipCodeRequired = true`
+        - `@Input() foreignLocalityRequired = true`
+        - `@Input() foreignStreetRequired = true`
+        - `@Input() foreignStreetNumberRequired = false`
+        - `@Input() postOfficeBoxTextRequired = false`
+        - `@Input() addressLine1Required = false`
+        - `@Input() addressLine2Required = false`
 
 ## [11.1.4]
 
@@ -3443,7 +3457,7 @@ not dead
 
 ### Updated
 
-- [public_api.ts](projects/prestations-ng/src/public_api.ts)
+- [public-api.ts](projects/prestations-ng/src/public-api.ts)
     - Add FoehnPageCounterComponent export
 - `@fortawesome/free-solid-svg-icons` and `@fortawesome/fontawesome-free` libraries to 5.11.2
 
@@ -5167,8 +5181,8 @@ If you've added an "Obligatoire" label somewhere in your prestation, please chan
     </foehn-list>
     `
     ```
-                    - itemsPerPage is 10, if none provided
-                    - trackBy is done on index, if no trackBy function is provided
+    - itemsPerPage is 10, if none provided
+    - trackBy is done on index, if no trackBy function is provided
 
 ## [7.20.0] - 2018.08.29
 

package/ESLINT_MIGRATION_GUIDE.md

@@ -92,7 +92,6 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
         '/karma.conf.js',
         '/.eslintrc.json',
         '/tsconfig*.json',
-        '/src/tsconfig*.json',
         '/src/main.ts',
         '/src/typings.d.ts'
     ],
@@ -371,7 +370,7 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
         {
             files: ['src/**/*.spec.ts', 'src/**/*.d.ts'],
             parserOptions: {
-                project: 'src/tsconfig.spec.json'
+                project: 'tsconfig.spec.json'
             },
             extends: ['plugin:jasmine/recommended'],
             plugins: ['jasmine'],

package/UPGRADING_V18.md

@@ -22,6 +22,7 @@ Remove your `resolutions` in `package.json` before starting : if you have `resol
 In the next commands, commit before each ng update.
 
 ```bash
+npm install
 ng update @angular/core@17 @angular/cli@17
 ng update @dsivd/prestations-ng@17
 
@@ -30,7 +31,10 @@ ng update @angular/core@18 @angular/cli@18
 ```
 
 When asked the question "Select the migrations that you'd like to run", accept "use-application-builder" by hitting "Space" key then "Enter".
-Then fix provideHttpClient withXsrfConfiguration by modifying your `app.module.ts` and adding:
+
+#### Fix provideHttpClient withXsrfConfiguration
+
+Modify your `app.module.ts` and add:
 `{
     cookieName: 'XSRF-TOKEN',
     headerName: 'X-XSRF-TOKEN'
@@ -48,10 +52,34 @@ providers: [
 ]
 ```
 
+#### Add an empty "browser" to your output path in angular.json
+
+```diff
+{
+  "projects": {
+    "[YOUR_PROJECT_NAME]": {
+      "architect": {
+        "build": {
+          "options": {
+            "outputPath": {
+-             "base": "dist"
++             "base": "dist",
++             "browser": ""
+            }
+```
+
+Continue with your migration:
+
 ```bash
 ng update @fortawesome/angular-fontawesome@0.15 --force
 ```
 
+**NB: When using `@angular/cdk` in your project**
+
+```bash
+ng update @angular/cdk@18
+```
+
 ### Updating to Angular 19
 
 `prestations-ng` **v18+** now supports **Angular v19**.
@@ -78,7 +106,23 @@ When asked the question "Select the migrations that you'd like to run", accept "
 
 ```bash
 ng update @angular-eslint/builder@19
+```
+
+**NB: When using `@angular/cdk` in your project**
+
+```bash
+ng update @angular/cdk@19
+```
+
+**NB: When using `ngx-matomo-client` in your project**
+
+```bash
+ng update ngx-matomo-client@7
+```
+
+Continue with your migration:
 
+```bash
 npm install --save-dev jasmine@5
 
 ng update karma@6.4 karma-chrome-launcher@3.2 karma-coverage@2.2 karma-jasmine@5.1 karma-jasmine-html-reporter@2.1
@@ -87,16 +131,38 @@ npm install --save-dev @typescript-eslint/utils@7 @typescript-eslint/types@7
 
 ng update @angular-eslint/eslint-plugin@19 @angular-eslint/eslint-plugin-template@19 @angular-eslint/template-parser@19
 ng update @typescript-eslint/eslint-plugin@7 @typescript-eslint/parser@7
-ng update eslint-plugin-import eslint-plugin-jasmine eslint-plugin-jsdoc eslint-plugin-rxjs-angular
+ng update eslint-plugin-import eslint-plugin-jasmine eslint-plugin-rxjs-angular eslint-plugin-simple-import-sort
 ng update eslint@8
 ng update eslint-plugin-rxjs
 ng update @types/jasmine@5 @types/node@20 ts-node@10
 
 npm remove eslint-plugin-jsdoc
 
+npm remove puppeteer
+npm install --save-dev puppeteer
+
 npm update
 ```
 
+#### Fix proxy.conf.json
+
+In your `proxy.conf.json` file:
+
+- remove `/*` at the end of your api url
+- remove `"changeOrigin": true`
+
+```diff
+- "/pub/101102/api/*": {
++ "/pub/101102/api": {
+    "target": "http://localhost:16400",
+-   "changeOrigin": true,
+    "secure": false,
+    "pathRewrite": {
+        "^/api": ""
+    }
+}
+```
+
 #### NgHttpLoader migration as standalone
 
 In your `app.module.ts` file:
@@ -104,19 +170,148 @@ In your `app.module.ts` file:
 - Remove `import { NgHttpLoaderModule } from 'ng-http-loader';`
 - Remove `NgHttpLoaderModule.forRoot()` from `imports` in `@NgModule(...)`
 - Add `NgHttpLoaderComponent` to `imports` in `@NgModule(...)`
+- Add `withInterceptors([pendingRequestsInterceptor$])` to `providers` in `@NgModule(...)`
 
 ```diff
 - import { NgHttpLoaderModule } from 'ng-http-loader';
-+ import { NgHttpLoaderComponent } from 'ng-http-loader';
++ import { NgHttpLoaderComponent, pendingRequestsInterceptor$ } from 'ng-http-loader';
 
 @NgModule({
     imports: [
 -       NgHttpLoaderModule.forRoot(),
 +       NgHttpLoaderComponent,
-    ],
+    ], providers: [
+        provideHttpClient(
++           withInterceptors([pendingRequestsInterceptor$]),
+    ]
+})
+```
+
+#### ImageCropper migration as standalone (if you are using it in your project)
+
+- Remove `import { ImageCropperModule } from 'ngx-image-cropper';`
+- Remove `ImageCropperModule` from `imports` in `@NgModule(...)`
+- Add `ImageCropperComponent` to `imports` in `@NgModule(...)`
+
+```diff
+- import { ImageCropperModule } from 'ngx-image-cropper';
++ import { ImageCropperComponent } from 'ngx-image-cropper';
+
+@NgModule({
+    imports: [
+-       ImageCropperModule,
++       ImageCropperComponent,
+    ]
+})
+```
+
+#### Matomo migration as standalone (if you are using it in your project)
+
+In your `app.module.ts` file:
+
+- Remove `import { MatomoInitializationMode, MatomoModule } from 'ngx-matomo-client';`
+- Remove `MatomoModule.forRoot({mode: MatomoInitializationMode.AUTO_DEFERRED})` from `imports` in `@NgModule(...)`
+- Add `provideMatomo` to `imports` in `@NgModule(...)`
+- Add `provideMatomo({ mode: 'deferred' })` to `providers` in `@NgModule(...)`
+
+```diff
+- import { MatomoInitializationMode, MatomoInitializerService, MatomoModule } from 'ngx-matomo-client';
++ import { MatomoInitializerService, provideMatomo } from 'ngx-matomo-client';
+
+@NgModule({
+    imports: [
+-       MatomoModule.forRoot({mode: MatomoInitializationMode.AUTO_DEFERRED}),
+    ], providers: [
++       provideMatomo({ mode: 'deferred' })
+    ]
 })
 ```
 
+#### Move and update your tsconfig\*.json files
+
+- Move your `tsconfig.app.json` and `tsconfig.spec.json` from `src` to `front` (if not already done)
+- Replace your `tsconfig.json` content with:
+
+```json
+{
+    "compileOnSave": false,
+    "compilerOptions": {
+        "outDir": "./dist/out-tsc",
+        "noImplicitOverride": true,
+        "noPropertyAccessFromIndexSignature": false,
+        "noImplicitReturns": true,
+        "noFallthroughCasesInSwitch": true,
+        "skipLibCheck": true,
+        "esModuleInterop": true,
+        "sourceMap": true,
+        "declaration": false,
+        "experimentalDecorators": true,
+        "moduleResolution": "bundler",
+        "importHelpers": true,
+        "target": "ES2022",
+        "module": "ES2022",
+        "paths": {
+            "@dsivd/prestations-ng": ["./node_modules/@dsivd/prestations-ng"]
+        }
+    },
+    "include": ["src/**/*"],
+    "angularCompilerOptions": {
+        "enableI18nLegacyMessageIdFormat": false,
+        "strictInjectionParameters": true,
+        "strictInputAccessModifiers": true
+    }
+}
+```
+
+- Replace your `tsconfig.app.json` content with:
+
+```json
+{
+    "extends": "./tsconfig.json",
+    "compilerOptions": {
+        "outDir": "./out-tsc/app",
+        "types": []
+    },
+    "files": ["src/main.ts"],
+    "include": ["src/**/*.d.ts"]
+}
+```
+
+- Replace your `tsconfig.spec.json` content with:
+
+```json
+{
+    "extends": "./tsconfig.json",
+    "compilerOptions": {
+        "outDir": "./out-tsc/spec",
+        "types": ["jasmine", "node"]
+    },
+    "include": ["src/**/*.spec.ts", "src/**/*.d.ts"]
+}
+```
+
+#### Fix your angular.json file
+
+Because your `tsconfig.app.json` and `tsconfig.spec.json` have been moved, you need to change the path in your `angular.json` file by removing `src/`
+
+```diff
+"projects": {
+    "[YOUR_APPLICATION_NAME]": {
+      "architect": {
+        "build": {
+            "options": {
+-              "tsConfig": "src/tsconfig.app.json",
++              "tsConfig": "tsconfig.app.json",
+            }
+        },
+        "test": {
+          "builder": "@angular-devkit/build-angular:karma",
+          "options": {
+-           "tsConfig": "src/tsconfig.spec.json",
++           "tsConfig": "tsconfig.spec.json",
+          }
+```
+
 #### Browsers list update
 
 Run update schematic:
@@ -183,6 +378,8 @@ npm install
 
 #### Build and launch your application
 
+**NB: You will most probably need to fix some compilation errors such as adding `override` when needed**
+
 ```bash
 npm run build
 npm start
@@ -195,6 +392,13 @@ Finally check if your tests run well :
 npm run test
 ```
 
+**NB: If you are having trouble finding puppeteer ChromiumHeadless binary**
+
+```bash
+npx puppeteer browsers install chrome
+npm run test
+```
+
 If there is a message complaining about HttpErrorResponse & NG0205: Injector has already been destroyed,
 in your `app.component.spec.ts` file, add `HttpClientTestingModule` to `TestBed.configureTestingModule` in `beforeEach(waitForAsync` function
 
@@ -202,6 +406,145 @@ in your `app.component.spec.ts` file, add `HttpClientTestingModule` to `TestBed.
 
 From here on, we are back in the root folder of your project
 
+### Openshift
+
+Since spring boot 3 has a minimal jdk version of 17, you now have to deploy you application in an openshift cluster.
+see https://dsigit.etat-de-vaud.ch/outils/git/projects/PEE/repos/imt-charts/browse/README.MD
+
+### Spring boot 3
+
+You can use this openrewrite recipe to simplify the migration (run with java 11)
+
+```bash
+mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_4 -Drewrite.exportDatatables=true -Pnof,noft
+```
+
+After that, you should continue based on your current parent :
+
+### SPRING-BOOT-STARTER-PARENT
+
+- remove this profile `<id>devex.in</id>` and its properties (`<devex*`)
+- set property `java.version` to `21`
+- set property `build.nofront` to `false`
+- set property `skipTests` to `false`
+- set property `commons-lang3.version` to `3.17.0`
+- set property `commons-io.version` to `2.19.0`
+- set property `commons-text.version` to `1.13.1`
+- set property `prestations-be.version` to `18.x.y`
+- remove plugin `maven-assembly-plugin` and its properties (`<assembly.xxx`)
+- remove dependency `spring-cloud-starter-netflix-eureka-client`
+- remove dependency `javax.el` and its property (`<javax.el.version>`)
+
+If you used `org.jvnet.jaxb2.maven2:maven-jaxb2-plugin`, you should replace it with `org.jvnet.jaxb:jaxb-maven-plugin`
+
+```
+<plugin>
+    <groupId>org.jvnet.jaxb</groupId>
+    <artifactId>jaxb-maven-plugin</artifactId>
+    <version>${jaxb-maven-plugin.version}</version>
+    <configuration>
+        <strict>false</strict> <!-- see https://github.com/highsource/maven-jaxb2-plugin/wiki/Catalogs-in-Strict-Mode -->
+        <schemaDirectory>${basedir}/src/main/resources/xsd/</schemaDirectory>
+        <args>
+            <arg>-extension</arg>
+            <arg>-Xvalue-constructor</arg>
+            <arg>-XsimpleEquals</arg>
+            <arg>-XsimpleHashCode</arg>
+            <arg>-Xinheritance</arg>
+        </args>
+    </configuration>
+    <executions>
+        <execution>
+            <goals>
+                <goal>generate</goal>
+            </goals>
+            <configuration>
+                <schemaIncludes>
+                    <include>backoffice.xsd</include>
+                </schemaIncludes>
+            </configuration>
+        </execution>
+    </executions>
+    <dependencies>
+        <dependency>
+            <groupId>org.jvnet.jaxb</groupId>
+            <artifactId>jaxb-plugins</artifactId>
+            <version>${jaxb-plugins.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.jvnet.jaxb2_commons</groupId>
+            <artifactId>jaxb2-namespace-prefix</artifactId>
+            <version>${jaxb2-namespace-prefix.version}</version>
+        </dependency>
+    </dependencies>
+</plugin>
+```
+
+with these properties :
+
+```
+<jaxb-maven-plugin.version>4.0.8</jaxb-maven-plugin.version>
+<jaxb-plugins.version>3.0.0</jaxb-plugins.version>
+<jaxb2-namespace-prefix.version>2.0</jaxb2-namespace-prefix.version>
+```
+
+### APPLICATION-PARENT
+
+- remove property `java.version` (already set to `21` in the parent)
+- if existing, remove exclusion `spring-cloud-starter-netflix-eureka-client` from `starter-prestation`
+- remove dependency `spring-boot-starter-validation` (already in `starter-prestation`)
+- remove devex properties
+
+If you used `org.jvnet.jaxb2.maven2:maven-jaxb2-plugin`, you should replace it with `org.jvnet.jaxb:jaxb-maven-plugin`
+
+```
+ <plugin>
+    <groupId>org.jvnet.jaxb</groupId>
+    <artifactId>jaxb-maven-plugin</artifactId>
+    <executions>
+        <execution>
+            <goals>
+                <goal>generate</goal>
+            </goals>
+            <configuration>
+                <schemaIncludes>
+                    <include>backoffice.xsd</include>
+                </schemaIncludes>
+            </configuration>
+        </execution>
+    </executions>
+</plugin>
+```
+
+### clean / build your project
+
+- remove the annotation `@EnableEurekaClient`
+- remove the property `eureka.client.enabled`
+- remove the property `eureka.client.serviceUrl.defaultZone` (in you configuration repository)
+- replace deprecated annotation `@MockBean` with `@MockitoBean`
+- remove deprecated field constructor `Validator validator` from `AbstractSdkController`
+- use `SdkControllerTest.getValidator()` instead of creating a `LocalValidatorFactoryBean` to build your ``
+
+build your project with java 21 :
+
+```
+mvn -U clean install -Pnof,noft
+```
+
+### Property migration
+
+run you application with this dependency :
+
+```
+<dependency>
+    <groupId>org.springframework.boot</groupId>
+    <artifactId>spring-boot-properties-migrator</artifactId>
+    <scope>runtime</scope>
+</dependency>
+```
+
+look for logs that indicate property you should migrate, update them and remove the dependency
+
 ### Captcha configuration
 
 - As stated in the migration guide from v16 to v17, Cybercache is responsible of the captcha turnstile verify call.
@@ -216,3 +559,52 @@ From here on, we are back in the root folder of your project
 Cookie storage is kept as before, therefore you can keep cookie related properties that starts with `recaptcha.cookie.YYY` in your properties.
 
 See [Skeleton](https://dsigit.etat-de-vaud.ch/outils/git/projects/CYBSDK/repos/skeleton/pull-requests/708/overview) for a working example
+
+### HIBERNATE
+
+## Sequences
+
+Hibernate doesn't use the default sequence anymore, you can keep using it by replacing
+
+```
+@GeneratedValue(strategy = GenerationType.SEQUENCE)
+```
+
+with
+
+```
+@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "hibernate_sequence")
+@SequenceGenerator(name = "hibernate_sequence", allocationSize = 1)
+```
+
+## Dates mapping
+
+replace `@Type(LocalDateTimeUserType.class)` by `@Convert(converter = LocalDateTimeConverter.class)`
+replace `@Type(LocalDateUserType.class)` by `@Convert(converter = LocalDateConverter.class)`
+
+## H2
+
+If you had a fixe H2 version for testing, you should upgrade to the latest version by removing :
+
+```
+<h2.version>1.4.200</h2.version>
+```
+
+### Jenkins files for Unit tests
+
+buildPipeline is not supported anymore, replace the content of jenkins>UT>JenkinsFile with :
+
+```
+@Library('devsup-library') _
+
+buildAppPipelinePodmanUT([
+        name  : 'the name of your application',
+        label : 'your slaves lable',
+        jdk   : '21',
+        node  : '20'
+])
+```
+
+### Debugging tips
+
+Spring boot 3 doesn't support calling a controller with a trailing slash, fix the url called (/api/ping != /api/ping**/**)