@dsivd/prestations-ng 18.0.0-beta.1 → 18.0.0-beta.3

package/CHANGELOG.md

@@ -2937,17 +2937,17 @@ data: {
 
     - added some inputs to affect the presence of (facultatif) on every label :
 
-                    -   `@Input() countryRequired = true`
-                    -   `@Input() swissNpaLocalityRequired = true`
-                    -   `@Input() streetRequired = true`
-                    -   `@Input() streetNumberRequired = false`
-                    -   `@Input() foreignZipCodeRequired = true`
-                    -   `@Input() foreignLocalityRequired = true`
-                    -   `@Input() foreignStreetRequired = true`
-                    -   `@Input() foreignStreetNumberRequired = false`
-                    -   `@Input() postOfficeBoxTextRequired = false`
-                    -   `@Input() addressLine1Required = false`
-                    -   `@Input() addressLine2Required = false
+                        -   `@Input() countryRequired = true`
+                        -   `@Input() swissNpaLocalityRequired = true`
+                        -   `@Input() streetRequired = true`
+                        -   `@Input() streetNumberRequired = false`
+                        -   `@Input() foreignZipCodeRequired = true`
+                        -   `@Input() foreignLocalityRequired = true`
+                        -   `@Input() foreignStreetRequired = true`
+                        -   `@Input() foreignStreetNumberRequired = false`
+                        -   `@Input() postOfficeBoxTextRequired = false`
+                        -   `@Input() addressLine1Required = false`
+                        -   `@Input() addressLine2Required = false
 
 ## [11.1.4]
 
@@ -5167,8 +5167,8 @@ If you've added an "Obligatoire" label somewhere in your prestation, please chan
     </foehn-list>
     `
     ```
-                  - itemsPerPage is 10, if none provided
-                  - trackBy is done on index, if no trackBy function is provided
+                      - itemsPerPage is 10, if none provided
+                      - trackBy is done on index, if no trackBy function is provided
 
 ## [7.20.0] - 2018.08.29
 

package/ESLINT_MIGRATION_GUIDE.md

@@ -114,13 +114,7 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
                 project: ['tsconfig.json'],
                 createDefaultProgram: true
             },
-            plugins: [
-                'import',
-                'jsdoc',
-                'rxjs',
-                'rxjs-angular',
-                'simple-import-sort'
-            ],
+            plugins: ['import', 'rxjs', 'rxjs-angular', 'simple-import-sort'],
             extends: [
                 'plugin:@angular-eslint/recommended',
                 'plugin:@angular-eslint/template/process-inline-templates',
@@ -129,8 +123,7 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
                 'plugin:import/recommended',
                 'plugin:import/errors',
                 'plugin:import/warnings',
-                'plugin:import/typescript',
-                'plugin:jsdoc/recommended'
+                'plugin:import/typescript'
             ],
             rules: {
                 /* @angular-eslint */
@@ -355,13 +348,7 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
                 'simple-import-sort/exports': 'error',
                 'import/first': 'error',
                 'import/newline-after-import': 'error',
-                'import/no-duplicates': 'error',
-                /* @jsdoc */
-                'jsdoc/check-alignment': 'error',
-                'jsdoc/check-indentation': 'error',
-                'jsdoc/no-types': 'error',
-                'jsdoc/require-param-type': 'off',
-                'jsdoc/require-returns-type': 'off'
+                'import/no-duplicates': 'error'
             }
         },
         // HTML

package/UPGRADING_V18.md

@@ -29,10 +29,27 @@ npm install @angular/cli@18 -g
 ng update @angular/core@18 @angular/cli@18
 ```
 
-When asked the question "Select the migrations that you'd like to run", accept "use-application-builder" by hitting "Space" key then "Enter"
+When asked the question "Select the migrations that you'd like to run", accept "use-application-builder" by hitting "Space" key then "Enter".
+Then fix provideHttpClient withXsrfConfiguration by modifying your `app.module.ts` and adding:
+`{
+    cookieName: 'XSRF-TOKEN',
+    headerName: 'X-XSRF-TOKEN'
+}`
+to `withXsrfConfiguration()`.
+
+```diff
+providers: [
+    META_SERVICE_PROVIDER,
+-   provideHttpClient(withXsrfConfiguration()),
++   provideHttpClient(withXsrfConfiguration({
++       cookieName: 'XSRF-TOKEN',
++       headerName: 'X-XSRF-TOKEN'
++   })),
+]
+```
 
 ```bash
-ng update @fortawesome/angular-fontawesome@0.15
+ng update @fortawesome/angular-fontawesome@0.15 --force
 ```
 
 ### Updating to Angular 19
@@ -47,17 +64,30 @@ Just FYI if you are curious about the details, you can find the Angular update g
 
 ```bash
 npm install @angular/cli@19 -g
-ng update @angular/core@19 @angular/cli@19 --force
-ng update @dsivd/prestations-ng@latest
 ng update typescript@5.5
-ng update rxjs@7
+ng update @dsivd/prestations-ng@latest
+```
+
+When asked the question "Select the migrations that you'd like to run", accept "provide-initializer" by hitting "Space" key then "Enter".
+
+```bash
+ng update @angular/cli@19
+```
+
+When asked the question "Select the migrations that you'd like to run", accept "use-application-builder" by hitting "Space" key then "Enter".
+
+```bash
 ng update @angular-eslint/builder@19
 
+npm install --save-dev jasmine@5
+
+ng update karma@6.4 karma-chrome-launcher@3.2 karma-coverage@2.2 karma-jasmine@5.1 karma-jasmine-html-reporter@2.1
+
 npm install --save-dev @typescript-eslint/utils@7 @typescript-eslint/types@7
 
 ng update @angular-eslint/eslint-plugin@19 @angular-eslint/eslint-plugin-template@19 @angular-eslint/template-parser@19
 ng update @typescript-eslint/eslint-plugin@7 @typescript-eslint/parser@7
-ng update eslint-plugin-import eslint-plugin-jasmine eslint-plugin-jsdoc eslint-plugin-rxjs-angular
+ng update eslint-plugin-import eslint-plugin-jasmine eslint-plugin-rxjs-angular
 ng update eslint@8
 ng update eslint-plugin-rxjs
 ng update @types/jasmine@5 @types/node@20 ts-node@10
@@ -67,6 +97,26 @@ npm remove eslint-plugin-jsdoc
 npm update
 ```
 
+#### NgHttpLoader migration as standalone
+
+In your `app.module.ts` file:
+
+- Remove `import { NgHttpLoaderModule } from 'ng-http-loader';`
+- Remove `NgHttpLoaderModule.forRoot()` from `imports` in `@NgModule(...)`
+- Add `NgHttpLoaderComponent` to `imports` in `@NgModule(...)`
+
+```diff
+- import { NgHttpLoaderModule } from 'ng-http-loader';
++ import { NgHttpLoaderComponent } from 'ng-http-loader';
+
+@NgModule({
+    imports: [
+-       NgHttpLoaderModule.forRoot(),
++       NgHttpLoaderComponent,
+    ],
+})
+```
+
 #### Browsers list update
 
 Run update schematic:
@@ -82,6 +132,25 @@ You will have to fix the json file after the copy as it won't copy the double qu
 
 Then run
 
+```bash
+npm run lint
+```
+
+Fix manually all errors **Components, Directives and Pipes should not opt out of standalone @angular-eslint/prefer-standalone** by either:
+
+- Transforming your component into a `standalone` component by changing `standalone: false` into `standalone: true` (recommended by angular)
+- Adding `// eslint-disable-next-line @angular-eslint/prefer-standalone` above `standalone: false`
+
+Then run again:
+
+```bash
+npm run lint
+```
+
+To be sure you haven't forgotten any.
+
+Finally, run:
+
 ```bash
 ng lint --fix=true
 ```

package/fesm2022/dsivd-prestations-ng.mjs

@@ -189,25 +189,8 @@ class ApplicationInfoService {
         this.pulling_ = this.http
             .get(APP_INFO_API_URL)
             .pipe(shareReplay(1));
-        // In most prestation, we're interested in the first etape info.
-        this.firstEtapeInfo_ = this.pulling_.pipe(filter(appInfo => !!appInfo && !!appInfo.etapeInfos), map(({ etapeInfos }) => {
-            // Checks whether the server returns a first key, otherwise fails the
-            // observable to ensure that client applications don't try to use this value
-            // and are able to implement fallback strategies.
-            const firstKey = Object.keys(etapeInfos)[0];
-            if (!firstKey) {
-                throw new Error('There must be at least one key in the etapeInfos');
-            }
-            return etapeInfos[firstKey];
-        }));
-        this.currentEtapeInfo_ = combineLatest([
-            this.foehnPageService.onEtapeIdChange(),
-            this.pulling_
-        ]).pipe(map(([etapeId, applicationInfo]) => applicationInfo.etapeInfos[etapeId]), shareReplay(1));
-        this.pulling_.subscribe((ai) => this.setApplicationInfo(ai));
-    }
-    get data() {
-        return this.pulling_.pipe(tap(appInfo => {
+        // Cache the data observable to prevent recreation
+        this.data_ = this.pulling_.pipe(tap(appInfo => {
             if (!!appInfo.configuration.portail.baseVdChUrl?.length) {
                 // already set by the backend
                 return;
@@ -225,7 +208,27 @@ class ApplicationInfoService {
                     appInfo.configuration.portail.baseVdChUrl =
                         'https://www.vd.ch';
             }
+        }), shareReplay(1) // Share the result
+        );
+        // In most prestation, we're interested in the first etape info.
+        this.firstEtapeInfo_ = this.pulling_.pipe(filter(appInfo => !!appInfo && !!appInfo.etapeInfos), map(({ etapeInfos }) => {
+            // Checks whether the server returns a first key, otherwise fails the
+            // observable to ensure that client applications don't try to use this value
+            // and are able to implement fallback strategies.
+            const firstKey = Object.keys(etapeInfos)[0];
+            if (!firstKey) {
+                throw new Error('There must be at least one key in the etapeInfos');
+            }
+            return etapeInfos[firstKey];
         }));
+        this.currentEtapeInfo_ = combineLatest([
+            this.foehnPageService.onEtapeIdChange(),
+            this.pulling_
+        ]).pipe(map(([etapeId, applicationInfo]) => applicationInfo.etapeInfos[etapeId]), shareReplay(1));
+        this.pulling_.subscribe((ai) => this.setApplicationInfo(ai));
+    }
+    get data() {
+        return this.data_;
     }
     get firstEtapeInfo() {
         return this.firstEtapeInfo_;
@@ -9357,7 +9360,7 @@ class DatePickerHelper {
         this.DATE_STRING_FORMAT = 'YYYY-MM-DD';
         this.DATE_READABLE_FORMAT = 'D MMMM YYYY';
         this._displayedMonthYear = new BehaviorSubject(null);
-        this.loadLocale = (language) => import(`dayjs/locale/${language}`).then(() => dayjs.locale(language));
+        this.loadLocale = (language) => import(/* @vite-ignore */ `dayjs/locale/${language}`).then(() => dayjs.locale(language));
     }
     get displayedMonthYear() {
         return this._displayedMonthYear.asObservable();