@dsivd/prestations-ng 17.0.0-beta.2 → 17.0.0-beta.20

package/CHANGELOG.md

@@ -14,6 +14,86 @@
 
     -   Added migration guide
 
+-   [gesdem-handler.service.ts](projects/prestations-ng/src/gesdem/gesdem-handler.service.ts)
+
+    -   set `?updateOnly=false` to `api/validated` when saving from first page
+
+-   [foehn-table.component.ts](projects/prestations-ng/src/foehn-table/foehn-table.component.ts)
+
+    -   added `@Input() title: string;` to set a title (caption) to the table
+    -   added `@Input() titleSrOnly: boolean;` when set to `true`, only screen readers will see the table title
+
+-   [foehn-feedback-notification.component.ts](projects/prestations-ng/src/foehn-feedback-notification/foehn-feedback-notification.component.ts)
+
+    -   Component used to redirect to users feedback prestation by sending first feedback answer
+    -   By default, it is added to [gesdem-confirmation.component.ts](projects/prestations-ng/src/gesdem-confirmation/gesdem-confirmation.component.ts)
+    -   Can be activated through `Catalogue de prestations`
+
+-   [gesdem-action-recovery-registration.component.ts](projects/prestations-ng/src/gesdem-action-recovery/gesdem-action-recovery-registration/gesdem-action-recovery-registration.component.ts)
+
+    -   by default the form errors are not displayed when registering for recovery
+    -   you can change that by setting the new `@Input() dispatchFormErrors:boolean` to `true`
+
+## [16.6.2]
+
+### Fixed
+
+-   [foehn-page-counter.component.ts](projects/prestations-ng/src/foehn-page/foehn-page-counter.component.ts)
+    -   Changed wording in default dictionary. Now displays `Page X sur Y`.
+
+## [16.6.0] - must be aligned with prestations-be
+
+### Fixed
+
+-   [gesdem-error-handler.service.ts](projects/prestations-ng/src/gesdem/gesdem-error-handler.service.ts)
+
+    -   do not redirect to error page if iamExpiredInterceptorService has caught that IAM session is expired
+
+### Added
+
+-   [foehn-footer.component.ts](projects/prestations-ng/src/foehn-footer/foehn-footer.component.ts)
+    -   display the app version in the green bar at the bottom of the page
+
+## [16.5.6]
+
+### Fixed
+
+-   [iam-expired-interceptor.service.ts](projects/prestations-ng/src/sdk-redirect/iam-expired-interceptor.service.ts)
+-   handle `BENEFICIARY_REQUIRED` exception globally
+
+## [16.5.5]
+
+### Added
+
+-   [foehn-input-address.component.ts](projects/prestations-ng/src/foehn-address/foehn-input-address.component.ts)
+-   added `@Input() withDefaultCountry = true;`, can be set to `false` to prevent the component of setting a default country.
+
+## [16.5.4]
+
+### Added
+
+-   [foehn-input-time.component.html](projects/prestations-ng/src/foehn-input-time/foehn-input-time.component.html)
+
+    -   added `allowLeadingZero` to true to allowed leading 0 in hours and minutes
+
+-   [ApplicationInfo](projects/prestations-ng/src/sdk-appinfo/application-info.ts)
+
+    -   added `baseVdChUrl?: string` to `ApplicationInfo.Configuration.Portail`
+    -   with default value by environnement
+    -   use in `BreadcrumbEventService` and `GesdemConfirmationComponent`
+
+### Fixed
+
+-   [redirect.component.ts](projects/prestations-ng/src/sdk-redirect/redirect.component.ts)
+    -   fixed redirect url when IAM ACV session is expired
+
+## [16.5.3]
+
+### Added
+
+-   [foehn-error-pill-component.html](projects/prestations-ng/src/foehn-menu-prestation/foehn-error-pill/foehn-error-pill.component.html)
+    -   added dictionary keys `foehn-error-pill.incomplete` and `foehn-error-pill.complete` for pills. Defaults are already added in prestations-ng.
+
 ## [16.5.1] - must be aligned with prestations-be (16.5.1+)
 
 ### Added

package/ESLINT_MIGRATION_GUIDE.md

@@ -376,7 +376,8 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
                     {
                         code: 200
                     }
-                ]
+                ],
+                '@angular-eslint/template/button-has-type': 'error'
             }
         },
         // Jasmine

package/UPGRADING_V17.md

@@ -1,40 +1,100 @@
 # PRESTAKIT : Upgrading from v16 to v17
 
+For the commands in this guide, it is supposed that your are in the `front` folder of your project.
+
 ## PRESTATIONS-NG
 
 The main feature in `prestations-ng` v17 is the update of the `@angular/*` peer dependencies
-to `^17.2.4`, using `node 20+` to build, `npm 10+` for package manager and `Foehn 2+ (Bootstrap 5+)`.
+to `^17.2.4`, using `node 20+` to build, `npm 10+` for package manager and `Foehn 2+ (Bootstrap 5+)` for our design system.
 
 ### Migrating to ESLint
 
-Follow [our migration guide](ESLINT_MIGRATION_GUIDE.md) to migrate your project from TSLint to ESLint
+(NB : you can skip this step if you already have a `front/eslintrc.json` file, it means it is already done.)
+Follow [our migration guide](ESLINT_MIGRATION_GUIDE.md) to migrate your project from TSLint to ESLint.
 
-### Package manager NPM
+### Package manager NPM instead of YARN
 
 We now recommend using `npm` instead of `yarn`.
-You can search for `yarn` in your project and replace it by `npm run`.
 
 **NB: Don't need `run` when running `npm` for https://docs.npmjs.com/cli/v10/commands**
 
+-   When using `prestations-ng` as a link, you need to run (you can do it in any case, it won't harm and like this you are sure):
+
+```bash
+yarn unlink @dsivd/prestations-ng
+yarn install --force
+```
+
+-   Delete `yarn.lock` file and `yarn-error.log` (if you have one).
+-   You can search for `yarn` in your project and replace it by `npm run` (do not take into account `.browserslistrc` as it will be replaced).
+
+```bash
+find . -type f ! -name '.browserslistrc' -exec sed -i 's/yarn/npm run/g' {} +
+```
+
+-   Then run:
+
+```bash
+npm install
+git add -A
+```
+
+If you have vulnerabilities, you can run:
+
+```bash
+npm update
+```
+
+NB: be patient...
+
+### Updating to Angular 16
+
+[https://update.angular.io/?l=3&v=15.0-16.0](https://update.angular.io/?l=3&v=15.0-16.0)
+
+**NB: Commit before continuing so your repository is clean.**
+
+Remove your `resolutions` in `package.json` before starting : if you have `resolutions` in `package.json`, remove manually the section.
+In the next commands, commit before each ng update.
+
+```bash
+ng update @angular/core@15 @angular/cli@15
+ng update @dsivd/prestations-ng@16
+
+npm install @angular/cli@16 -g
+ng update @angular/core@16 @angular/cli@16
+```
+
 ### Running with node 20+
 
 #### Switch to node 20+
 
 ##### If you are using our `slave-apps`
 
-Be sure to update your `slave-apps` git repository and source your bashrc (or whatever env file you're using) so you will be using node20 by default, verify by executing :
+Be sure to update your `slave-apps` git repository and source your `.bashrc` (or whatever file you're using).
+
+Verify your node version in your terminal by executing:
 
 ```bash
 node -v
 ```
 
+**NB: If version is still v16+ by default, type `node20` in your terminal to switch to node v20+**
+
+```bash
+node20
+```
+
 ##### If you are NOT using our `slave-apps`
 
-Be sure to use a node version 20+ and use the same command as above.
+Be sure to use a node version 20+ in your terminal:
+
+```bash
+node -v
+```
 
 #### In your project
 
-Update your `package.json` to specify node engine
+Update your `package.json` file to specify the node engine:
 
 ```json
 {
@@ -46,8 +106,8 @@ Update your `package.json` to specify node engine
 
 #### Update your jenkins files
 
-Add `nodeVersion: 20` to use node 20.
-Add `nodeLabel: 'rhel8pee'` to use a RedHat 8 which support node 20
+-   Add `nodeVersion: 20` to use node 20
+-   Add `nodeLabel: 'rhel8pee'` to use a RedHat 8 which support node 20
 
 ##### UT folder
 
@@ -76,45 +136,51 @@ def args = [
 ]
 ```
 
-### Updating Angular
+### Updating to Angular 17
 
-`prestations-ng` **v17+** now supports **Angular v17**. You can follow the Angular update guide
-at this address:
+`prestations-ng` **v17+** now supports **Angular v17**.
 
--   [https://update.angular.io/?l=3&v=15.0-16.0](https://update.angular.io/?l=3&v=15.0-16.0)
--   [https://update.angular.io/?l=3&v=16.0-17.0](https://update.angular.io/?l=3&v=16.0-17.0)
+Just FYI if you are curious about the details, you can find the Angular update guide at this address [https://update.angular.io/?l=3&v=16.0-17.0](https://update.angular.io/?l=3&v=16.0-17.0).
 
-#### When having migrated to ESLint
+#### Update your `front/.gitignore` file
 
-```bash
-# Remove your resolutions in package.json before starting
-ng update @angular/core@15 @angular/cli@15
+Add `/.nx/cache`
 
-yarn global add @angular/cli@16
-ng update @angular/core@16 @angular/cli@16
+#### When having migrated to ESLint
 
-yarn global add @angular/cli@17
-ng update @angular/core@17 @angular/cli@17
-ng update typescript@5.3
+```bash
+npm install @angular/cli@17 -g
+ng update @angular/core@17 @angular/cli@17 --force
+ng update @dsivd/prestations-ng@latest
 ng update rxjs@7
 ng update @angular-eslint/builder@17
 ng update @angular-eslint/eslint-plugin@17 @angular-eslint/eslint-plugin-template@17 @angular-eslint/template-parser@17
 ng update @typescript-eslint/eslint-plugin@7 @typescript-eslint/parser@7
 ng update eslint-plugin-import eslint-plugin-jasmine eslint-plugin-jsdoc eslint-plugin-rxjs-angular
-ng update eslint
-ng update eslint-plugin-rxjs@7
+ng update eslint@8
+ng update eslint-plugin-rxjs
 ng update \
     @types/jasmine@5 \
     @types/node@20 \
     ts-node@10
-ng update @dsivd/prestations-ng@latest
+
+npm remove puppeteer
+npm install puppeteer@~22.7.1 --save-dev
 
 npm update
 ```
 
+#### Browsers list update
+
+Run update schematic:
+
+```bash
+ng g @dsivd/prestations-ng:replace-browsers-list
+```
+
 #### Migration to Foehn 2 and Boostrap 5
 
-##### Running migration schematic
+Run migration schematic:
 
 ```bash
 ng g @dsivd/prestations-ng:foehn2-bootstrap5-migration
@@ -122,18 +188,21 @@ ng g @dsivd/prestations-ng:foehn2-bootstrap5-migration
 
 **NB: Be aware that you will have to check every changes made to your repository to be sure everything is fine.**
 
-You will need to check manually your Java `dictionary.properties` for any HTML styling (search for: `class=`)
-You will need to check manually your TypeScript (`.ts`) files for any dynamique CSS classes or tests (`.spec.ts`)
+You will need to check manually your:
+
+-   Java `dictionary.properties` for any HTML styling (search for: `class=`)
+-   TypeScript (`.ts`) files for any dynamique CSS classes or tests (`.spec.ts`)
 
 ##### More information here
 
--   Visite https://getbootstrap.com/docs/5.0/migration/ for Bootstrap 5 migration
--   Visite https://github.com/twbs/bootstrap/issues/32753 for the list of class changes in Bootstrap 5
--   Visite https://github.com/DSI-VD/foehn/blob/master/CHANGELOG.md for Foehn 2 migration
+-   https://getbootstrap.com/docs/5.0/migration/ for Bootstrap 5 migration.
+-   https://github.com/twbs/bootstrap/issues/32753 for the list of class changes in Bootstrap 5.
+-   https://github.com/DSI-VD/foehn/blob/master/CHANGELOG.md for Foehn 2 migration.
 
 ### Update ".eslintrc.json" file if your project was already migrated to ESLint
 
-Replace your current `.eslintrc.json` file by the one found in [ESLINT_MIGRATION.GUIDE](ESLINT_MIGRATION_GUIDE.md#customizing_eslint__inspired_from_otia_and_prestations-ng_s_files_for_rules_)
+**NB: Replace your current `.eslintrc.json` file by the one found in [ESLINT_MIGRATION.GUIDE](ESLINT_MIGRATION_GUIDE.md#customizing_eslint__inspired_from_otia_and_prestations-ng_s_files_for_rules_).**
+You will have to fix the json file after the copy as it won't copy the double quotes around the properties. (ask IntelliJ to do it for you, alt-enter, Wrap with double quotes -> fix all compliance with json standard ...)
 
 Then run
 
@@ -141,14 +210,43 @@ Then run
 ng lint --fix=true
 ```
 
-and finally fix manually remaining errors
+and finally fix manually remaining errors. When encountering following warning in your `*.spec.ts`:
+
+**`warning  Deprecated: Use provideRouter or RouterModule/RouterModule.forRoot instead`**
+
+replace `RouterTestingModule` by `RouterModule.forRoot([])`
+
+### Cloudflare (`app.module.ts`)
+
+Need to remove `CAPTCHA_URL_TOKEN` override
+
+```diff
+@NgModule({
+    providers: [
+        META_SERVICE_PROVIDER,
+-       {
+-           provide: CAPTCHA_URL_TOKEN,
+-           useValue: 'https://challenges.cloudflare.com/turnstile/v0/api.js?onload=reCaptchaLoad&render=explicit&compat=recaptcha'
+-       },
+    ]
+})
+```
+
+### gesdem-action-recovery-registration
+
+If you use the `<gesdem-action-recovery-registration>` component in a page which includes some `<foehn-error-pill>` or `<foehn-menu-item>` (i.e. e-vaudtax, pocama, any form with a menu)
+you should set `dispatchFormErrors` to `true` :
+
+-   `<gesdem-action-recovery-registration [dispatchFormErrors]="true"><gesdem-action-recovery-registration>`
+
+Otherwise the pills wil be set to "Renseigné" after a recovery registration even if some errors remains.
 
 ### Language deprecations
 
 When using `intellij`, you can run code inspection on your project to fix manually deprecations. Two ways:
 
--   Intellij window menu, go to: `Code > Analyze code > Run inspection by name...` (or **Ctrl+Alt+Maj+i**) and type `Deprecated symbol used`
--   Or select your project in your project panel and `right click` on it then `Analyze > Run inspection by name...` (or **Ctrl+Alt+Maj+i**) and type `Deprecated symbol used`
+-   Intellij window menu, go to: `Code > Analyze code > Run inspection by name...` (or **Ctrl+Alt+Maj+i**) and type `Deprecated symbol used`.
+-   Or select your project in your project panel and `right click` on it then `Analyze > Run inspection by name...` (or **Ctrl+Alt+Maj+i**) and type `Deprecated symbol used`.
 
 ### Last but not least, check if your application is working!!!
 
@@ -163,8 +261,257 @@ npm install
 #### Build and launch your application
 
 ```bash
-npm build
+npm run build
 npm start
 ```
 
-Your are good to go if no errors are remaining!
+Your are good if no errors are remaining!
+Finally check if your tests run well :
+
+```bash
+npm run test
+```
+
+If there is a message complaining about HttpErrorResponse & NG0205: Injector has already been destroyed,
+in your `app.component.spec.ts` file, add `HttpClientTestingModule` to `TestBed.configureTestingModule` in `beforeEach(waitForAsync` function
+
+## PRESTATIONS-BE
+
+From here on, we are back in the root folder of your project
+
+### application.properties
+
+```diff
+recaptcha.cookie.path=${base.href}
+- recaptcha.verify-url=https://challenges.cloudflare.com/turnstile/v0/siteverify
+```
+
+### pom.xml
+
+#### With application parent
+
+##### Use new application-parent
+
+```diff
+<parent>
+    <groupId>ch.vd.cyber.parent</groupId>
+    <artifactId>application-parent</artifactId>
+-    <version>12.x.x</version>
++    <version>13.x.x</version>
+    <relativePath/>
+</parent>
+```
+
+##### Cleanup pom.xml
+
+Then remove following plugin:
+
+```diff
+-<plugin>
+-   <groupId>org.codehaus.mojo</groupId>
+-   <artifactId>exec-maven-plugin</artifactId>
+-   <version>${exec-maven-plugin.version}</version>
+-   <configuration>
+-       <workingDirectory>${basedir}/front</workingDirectory>
+-   </configuration>
+-   <executions>
+-        <execution>
+-            <id>exec-yarn-install</id>
+-            <phase>prepare-package</phase>
+-            <configuration>
+-                <executable>${yarn.executable}</executable>
+-                <arguments>
+-                    <argument>--pure-lockfile</argument>
+-                </arguments>
+-                <skip>${build.nofront}</skip>
+-            </configuration>
+-            <goals>
+-                <goal>exec</goal>
+-            </goals>
+-        </execution>
+-        <execution>
+-            <id>exec-ngcli-lint</id>
+-            <phase>prepare-package</phase>
+-            <configuration>
+-                <executable>${yarn.executable}</executable>
+-                <arguments>
+-                    <argument>run</argument>
+-                    <argument>lint</argument>
+-                </arguments>
+-                <skip>${skipTests}</skip>
+-            </configuration>
+-            <goals>
+-                <goal>exec</goal>
+-            </goals>
+-        </execution>
+-        <execution>
+-            <id>exec-ngcli-test</id>
+-            <phase>prepare-package</phase>
+-            <configuration>
+-                <executable>${yarn.executable}</executable>
+-                <arguments>
+-                    <argument>run</argument>
+-                    <argument>test</argument>
+-                </arguments>
+-                <skip>${skipTests}</skip>
+-            </configuration>
+-            <goals>
+-                <goal>exec</goal>
+-            </goals>
+-        </execution>
+-        <execution>
+-            <id>exec-ngcli-build</id>
+-            <phase>prepare-package</phase>
+-            <configuration>
+-                <executable>${yarn.executable}</executable>
+-                <arguments>
+-                    <argument>run</argument>
+-                    <argument>build</argument>
+-                </arguments>
+-                <skip>${build.nofront}</skip>
+-            </configuration>
+-            <goals>
+-                <goal>exec</goal>
+-           </goals>
+-       </execution>
+-   </executions>
+-</plugin>
+```
+
+If it is an Angular application but you have other configurations to build the front, add -Dskip-build-angular-front-npm in .mvn/maven-config at the same level as the pom.xml.
+
+#### Without application parent
+
+```diff
+<properties>
+-   <prestations-be.version>16.x.x</prestations-be.version>
++   <prestations-be.version>17.x.x</prestations-be.version>
+</properties
+```
+
+Remove plugin executing some `yarn` (See `With application parent`) and replace by following plugin :
+
+```xml
+<plugins>
+    <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>exec-maven-plugin</artifactId>
+        <version>${exec-maven-plugin.version}</version>
+        <configuration>
+            <workingDirectory>${front.srcPath}</workingDirectory>
+        </configuration>
+        <executions>
+            <execution>
+                <id>exec-npm-install</id>
+                <phase>prepare-package</phase>
+                <configuration>
+                    <executable>${npm.executable}</executable>
+                    <arguments>
+                         <argument>install</argument>
+                        <argument>--pure-lockfile</argument>
+                    </arguments>
+                    <skip>${build.nofront}</skip>
+                </configuration>
+                <goals>
+                    <goal>exec</goal>
+                </goals>
+            </execution>
+            <execution>
+                <id>exec-ngcli-lint</id>
+                <phase>prepare-package</phase>
+                <configuration>
+                    <executable>${npm.executable}</executable>
+                    <arguments>
+                        <argument>run</argument>
+                        <argument>lint</argument>
+                    </arguments>
+                    <skip>${skipTests}</skip>
+                </configuration>
+                <goals>
+                    <goal>exec</goal>
+                </goals>
+            </execution>
+            <execution>
+                <id>exec-ngcli-test</id>
+                <phase>prepare-package</phase>
+                <configuration>
+                    <executable>${npm.executable}</executable>
+                    <arguments>
+                        <argument>run</argument>
+                        <argument>test</argument>
+                    </arguments>
+                    <skip>${skipTests}</skip>
+                </configuration>
+                <goals>
+                    <goal>exec</goal>
+                </goals>
+            </execution>
+            <execution>
+                <id>exec-ngcli-build</id>
+                <phase>prepare-package</phase>
+                <configuration>
+                    <executable>${npm.executable}</executable>
+                    <arguments>
+                        <argument>run</argument>
+                        <argument>build</argument>
+                    </arguments>
+                    <skip>${build.nofront}</skip>
+                </configuration>
+                <goals>
+                    <goal>exec</goal>
+                </goals>
+            </execution>
+        </executions>
+    </plugin>
+    <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-resources-plugin</artifactId>
+        <version>${maven-resources-plugin.version}</version>
+        <configuration>
+            <encoding>${project.build.sourceEncoding}</encoding>
+        </configuration>
+        <executions>
+            <execution>
+                <id>copy-ngcli-dist</id>
+                <phase>prepare-package</phase>
+                <goals>
+                    <goal>copy-resources</goal>
+                </goals>
+                <configuration>
+                    <outputDirectory>${basedir}/target/classes/static</outputDirectory>
+                    <resources>
+                        <resource>
+                            <directory>${front.distPath}</directory>
+                            <filtering>false</filtering>
+                        </resource>
+                    </resources>
+                </configuration>
+            </execution>
+            <execution>
+                <id>copy-config</id>
+                <phase>prepare-package</phase>
+                <goals>
+                    <goal>copy-resources</goal>
+                </goals>
+                <configuration>
+                    <outputDirectory>${project.build.directory}/classes</outputDirectory>
+                    <resources>
+                        <resource>
+                            <directory>${project.build.directory}/unfiltered-config</directory>
+                            <filtering>true</filtering>
+                        </resource>
+                    </resources>
+                </configuration>
+            </execution>
+        </executions>
+    </plugin>
+</plugins>
+```
+
+Finally, run
+
+```bash
+mvn clean install
+```
+
+Hopefully, you should see a successful build.