@dsivd/prestations-ng 16.0.0-beta2 → 16.0.0-beta3

package/ESLINT_MIGRATION_GUIDE.md

@@ -71,10 +71,10 @@ After:
 }
 ``` 
 
-## Adding `import` ,`jasmine` ,`jsdoc` ,`prefer-arrow` ,`rxjs` and `rxjs-angular` as plugins
+## Adding `import` ,`jasmine` ,`jsdoc` ,`simple-import-sort` ,`rxjs` and `rxjs-angular` as plugins
 
 ```bash
-yarn add eslint-plugin-import eslint-plugin-jasmine eslint-plugin-jsdoc eslint-plugin-prefer-arrow eslint-plugin-rxjs eslint-plugin-rxjs-angular --dev
+yarn add eslint-plugin-import eslint-plugin-jasmine eslint-plugin-jsdoc eslint-plugin-simple-import-sort eslint-plugin-rxjs eslint-plugin-rxjs-angular --dev
 ```
 
 ## Customizing ESLint (inspired from OTIA and prestations-ng's files for rules)
@@ -97,11 +97,10 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
         "/package.json",
         "/angular.json",
         "/karma.conf.js",
+        "/.eslintrc.json",
         "/tsconfig*.json",
-        "/src/test.ts",
+        "/src/tsconfig*.json",
         "/src/main.ts",
-        "/src/polyfills.ts",
-        "/src/environments/*.ts",
         "/src/typings.d.ts"
     ],
     "reportUnusedDisableDirectives": true,
@@ -133,7 +132,6 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
             "plugins": [
                 "import",
                 "jsdoc",
-                "prefer-arrow",
                 "rxjs",
                 "rxjs-angular",
                 "simple-import-sort"
@@ -334,7 +332,7 @@ You can replace the content of your `.eslintrc.json` with the following `json`.
                 "jsdoc/newline-after-description": "error",
                 "jsdoc/no-types": "error",
                 "jsdoc/require-param-type": "off",
-                "jsdoc/require-returns-type": "off",
+                "jsdoc/require-returns-type": "off"
             }
         },
         // HTML

package/UPGRADING_V16.md

@@ -34,12 +34,163 @@ ng update \
     ts-node@10
 ng update @dsivd/prestations-ng@latest
 
-yarn add eslint-import-resolver-typescript --dev
 yarn remove eslint-plugin-prefer-arrow
+yarn add eslint-plugin-simple-import-sort --dev
+yarn add eslint-import-resolver-typescript --dev
 # Remove your resolutions in package.json before executing 'yarn upgrade'
 yarn upgrade
 ```
 
+## Update "package.json" file to replace tilde(~) by caret(^) on following dependencies to be aligned with prestations-ng library
+
+- core-js
+- dayjs
+- ng-http-loader
+- ngx-image-cropper
+- rxjs
+- zone.js
+
+Then run an update
+
+```bash
+yarn install
+```
+
+## Update ".eslintrc.json" file if your project was already migrated to ESLint
+
+Replace your current `.eslintrc.json file` by the one found in [ESLINT_MIGRATION.GUIDE](ESLINT_MIGRATION_GUIDE.md#customizing_eslint__inspired_from_otia_and_prestations-ng_s_files_for_rules_)
+
+## Use node 16 for your build
+
+Open your `jenkins` folder and update your jenkins files
+Define a variable if it does not already exist and add `nodeVersion: 16` then pass it on to the build
+
+### UT folder
+```groovy
+def args = [
+    nodeVersion: 16
+]
+
+stage('Build pipeline') {
+    buildPipeline(args)
+}
+```
+
+### devex > snap folder
+```groovy
+def buildArgs = [
+    nodeVersion     : 16
+]
+
+stage('Snap2Devex Skeleton') {
+    snap2Devex(buildArgs)
+}
+```
+
+### devex > stable folder
+```groovy
+def args = [
+    nodeVersion     : 16
+]
+
+stage('Stable2Devex') {
+    stable2Devex(args)
+}
+```
+
+## Cleanup your project due to CLI improvements
+
+See section "CLI improvements" in angular's blog (https://blog.angular.io/angular-v15-is-now-available-df7be7f2f4c8)
+
+### Remove files/folder from your project
+
+- delete `polyfills.ts` file
+- delete `test.ts` file
+- delete `environments` folder
+
+### Update your `angular.json` file
+```diff
+{
+    "projects": {
+        "[YOUR_PROJECT_NAME]": {
+            "architect": {
+                "build": {
+                    "options": {
+-                       "polyfills": "src/polyfills.ts",
++                       "polyfills": [
++                           "zone.js"
++                       ],  
+                    },
+                    "configurations": {
+                        "production": {
+-                           "fileReplacements": [
+-                               {
+-                                   "replace": "src/environments/environment.ts",
+-                                   "with": "src/environments/environment.prod.ts"
+-                               }
+-                           ]
+                        }
+                    }
+                },
+                "test": {
+                    "options": {
+-                       "main": "src/test.ts",
+-                       "polyfills": "src/polyfills.ts",
++                       "polyfills": [
++                           "zone.js",
++                           "zone.js/testing"
++                       ],
+                    }
+                }
+            }
+        }
+    }
+}
+```
+### Update your `tsconfig.app.json` file
+```diff
+{
+    "files": [
+        "main.ts",
+-       "polyfills.ts"
+    ],
+}
+```
+
+### Update your `tsconfig.spec.json` file
+```diff
+{
+-   "files": [
+-       "test.ts",
+-       "polyfills.ts"
+-   ],
+}
+```
+
+## Update `allowedCommonJsDependencies` in your `angular.json` file to add `dayjs`
+
+```diff
+{
+    "projects": {
+        "[YOUR_PROJECT_NAME]": {
+            "architect": {
+                "build": {
+                    "options": {
+                        "allowedCommonJsDependencies": [
+                            "core-js/modules/es.array.includes",
+                            "iban",
+-                           "zone.js/dist/zone-error"
++                           "zone.js/dist/zone-error",
++                           "dayjs"
+                        ],  
+                    },
+                }
+            }
+        }
+    }
+}
+```
+
 ## Deprecated features
 
 ### All components extending FoehnCheckableGroupComponent such as foehn-autocomplete, foehn-checkbox, foehn-radio, foehn-select or your custom components

package/package.json

@@ -37,7 +37,7 @@
   "ng-update": {
     "migrations": "./schematics/migration-collection.json"
   },
-  "version": "16.0.0-beta2",
+  "version": "16.0.0-beta3",
   "module": "fesm2015/dsivd-prestations-ng.mjs",
   "es2020": "fesm2020/dsivd-prestations-ng.mjs",
   "esm2020": "esm2020/dsivd-prestations-ng.mjs",