@dsivd/prestations-ng 14.5.17-beta1 → 14.5.19

package/CHANGELOG.md

@@ -25,17 +25,22 @@ A change is considered **breaking** if you have to change your code or update yo
     -   adding a new constructor argument in one of our service is OK, if you just have to update your constructor's signature and your call to `super(...)`
 
 ---
+## [14.5.19]
+### Added
+    -   [foehn-confirm-modal.component.html](projects/prestations-ng/src/foehn-confirm-modal/foehn-confirm-modal.component.html)
+        - Add closeable on FoehnConfirmModalContent. Default value is true. If false, modal has to be closed by the yes and no buttons. 
 
-## [14.5.17]
+## [14.5.18]
+### Fixed
 
-### Updated
+- [object.helper.ts](projects/prestations-ng/src/helpers/object.helper.ts)
+  - Fix isEqual method for arrays. The issue was if first array has same objects but less items.
+  - This issue impacts foehn-select, foehn-list and foehn-table
+  
 
-- [session-info.service.ts](projects/prestations-ng/src/sdk-session-info/session-info.service.ts)
-    - `SessionInfoData` data getter now depends on `neverConnected` attribute to avoid unnecessary calls to sessionInfo api (PRESTAKIT-364).
-    - To retrieve `SessionInfoData` data from api url, you need to explicitly set `neverConnected` attribute to `false`.
+## [14.5.17]
 
-- [foehn-page.component.ts](projects/prestations-ng/src/foehn-page/foehn-page.component.ts)
-    - `@Input() neverConnected` is now set to `false` by default to retrieve `SessionInfoData` data for backwards compatibility purposes.
+### Updated
 
 - [support-alert.service.ts](projects/prestations-ng/src/sdk-support-alert/support-alert.service.ts)
     - removed `setRefreshIntervalInSeconds(refreshIntervalsInSeconds: number)`, support alerts are now refreshed on every NavigationStart event from the Angular Router, but at most every 3 minutes.

package/bundles/dsivd-prestations-ng.umd.js

@@ -867,79 +867,52 @@
 
     var SESSION_INFO_API_URL = 'api/sessionInfo/data';
     var SessionInfo = /** @class */ (function () {
-        function SessionInfo(http, growlService, ngZone) {
+        function SessionInfo(http) {
             this.http = http;
-            this.growlService = growlService;
-            this.ngZone = ngZone;
-            this.neverConnected_ = new rxjs.BehaviorSubject(undefined);
         }
         Object.defineProperty(SessionInfo.prototype, "data", {
             get: function () {
                 var _this = this;
-                return this.neverConnected_.asObservable().pipe(operators.tap(function () {
-                    if (_this.timeoutLogError) {
-                        clearTimeout(_this.timeoutLogError);
-                    }
-                }), operators.switchMap(function (neverConnected) {
-                    if (neverConnected !== false) {
-                        if (neverConnected === undefined) {
-                            _this.logErrorNeverConnectedIsNotSet();
-                        }
-                        if (!_this.onMicroTaskEmptyPulling_) {
-                            // Need 'onMicrotaskEmpty' to avoid 'ExpressionChangedAfterItHasBeenCheckedError'
-                            _this.onMicroTaskEmptyPulling_ = _this.ngZone.onMicrotaskEmpty.pipe(operators.first(), operators.map(function () { return null; }), operators.shareReplay(1));
-                        }
-                        return _this.onMicroTaskEmptyPulling_;
-                    }
-                    else {
-                        if (!_this.pulling_) {
-                            _this.pulling_ = _this.http
-                                .get(SESSION_INFO_API_URL)
-                                .pipe(operators.catchError(function () {
-                                var message = 'Impossible de récupérer les informations de la personne connectée';
-                                _this.growlService.addWithType(GrowlType.DANGER, message);
-                                return rxjs.of(null);
-                            }), operators.map(function (r) {
-                                if (r) {
-                                    return (_this.sessionData = r);
-                                }
-                                return null;
-                            }), operators.shareReplay(1));
-                        }
-                        return _this.pulling_;
+                if (this.neverConnected_) {
+                    return rxjs.of(null);
+                }
+                else {
+                    if (!this.pulling_) {
+                        this.pulling_ = this.http
+                            .get(SESSION_INFO_API_URL)
+                            .pipe(operators.map(function (r) {
+                            if (r) {
+                                return (_this.sessionData = r);
+                            }
+                            return null;
+                        }), operators.shareReplay(1));
                     }
-                }));
+                    return this.pulling_;
+                }
             },
             enumerable: false,
             configurable: true
         });
         Object.defineProperty(SessionInfo.prototype, "neverConnected", {
             get: function () {
-                return this.neverConnected_.getValue();
+                return this.neverConnected_;
             },
             set: function (neverConnected) {
-                this.neverConnected_.next(neverConnected);
+                this.neverConnected_ = neverConnected;
             },
             enumerable: false,
             configurable: true
         });
-        SessionInfo.prototype.logErrorNeverConnectedIsNotSet = function () {
-            // Use of setTimeout to avoid unnecessary error log
-            this.timeoutLogError = setTimeout(function () {
-                console.error("Error: 'neverConnected' is not set. " +
-                    'Find more at https://dsi-vd.github.io/prestations-ng/CHANGELOG.md#_14_5_16_');
-            }, 2000);
-        };
         return SessionInfo;
     }());
-    SessionInfo.ɵfac = i0__namespace.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, deps: [{ token: i1__namespace.HttpClient }, { token: GrowlBrokerService }, { token: i0__namespace.NgZone }], target: i0__namespace.ɵɵFactoryTarget.Injectable });
+    SessionInfo.ɵfac = i0__namespace.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, deps: [{ token: i1__namespace.HttpClient }], target: i0__namespace.ɵɵFactoryTarget.Injectable });
     SessionInfo.ɵprov = i0__namespace.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, providedIn: 'root' });
     i0__namespace.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: SessionInfo, decorators: [{
                 type: i0.Injectable,
                 args: [{
                         providedIn: 'root'
                     }]
-            }], ctorParameters: function () { return [{ type: i1__namespace.HttpClient }, { type: GrowlBrokerService }, { type: i0__namespace.NgZone }]; } });
+            }], ctorParameters: function () { return [{ type: i1__namespace.HttpClient }]; } });
 
     var GesdemHandlerService = /** @class */ (function () {
         function GesdemHandlerService(http, growlService, validationHandlerService, router, route, errorHandlerService, sessionInfo) {
@@ -3289,14 +3262,12 @@
             else {
                 this._validationHandlerService.shouldDisplayErrors(true);
             }
-            this.sendForFormConcurrentSafe
-                .pipe(operators.first())
-                .subscribe(function () { return _this.onFormSent(goToNextPage); });
+            this.sendForFormConcurrentSafe.subscribe(function () { return _this.onFormSent(goToNextPage); });
         };
         AbstractPageComponent.prototype.transmit = function () {
             var _this = this;
             this._validationHandlerService.shouldDisplayErrors(true);
-            this.transmitConcurrentSafe.pipe(operators.first()).subscribe(function () {
+            this.transmitConcurrentSafe.subscribe(function () {
                 if (!_this._gesdemService.lastResponse.errors.length) {
                     _this._gesdemEventService.formTransmittedSubject.next(_this._gesdemService.lastResponse);
                     _this._navigation.next();
@@ -4873,18 +4844,19 @@
                 value2 &&
                 typeof value1 === 'object' &&
                 typeof value2 === 'object') {
-                var matches_1 = function (obj, source) { return Object.keys(source).every(function (key) {
-                    if (obj.hasOwnProperty(key)) {
-                        if (obj[key] &&
-                            source[key] &&
-                            typeof obj[key] === 'object' &&
-                            typeof source[key] === 'object') {
-                            return matches_1(obj[key], source[key]);
+                var matches_1 = function (obj, source) { return Object.keys(source).length === Object.keys(obj).length &&
+                    Object.keys(source).every(function (key) {
+                        if (obj.hasOwnProperty(key)) {
+                            if (obj[key] &&
+                                source[key] &&
+                                typeof obj[key] === 'object' &&
+                                typeof source[key] === 'object') {
+                                return matches_1(obj[key], source[key]);
+                            }
+                            return obj[key] === source[key];
                         }
-                        return obj[key] === source[key];
-                    }
-                    return false;
-                }); };
+                        return false;
+                    }); };
                 return matches_1(value1, value2);
             }
             return value1 === value2;
@@ -5740,7 +5712,7 @@
         return FoehnConfirmModalComponent;
     }());
     FoehnConfirmModalComponent.ɵfac = i0__namespace.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: FoehnConfirmModalComponent, deps: [{ token: FoehnConfirmModalService }], target: i0__namespace.ɵɵFactoryTarget.Component });
-    FoehnConfirmModalComponent.ɵcmp = i0__namespace.ɵɵngDeclareComponent({ minVersion: "12.0.0", version: "12.2.4", type: FoehnConfirmModalComponent, selector: "foehn-confirm-modal", ngImport: i0__namespace, template: "<foehn-modal\n    [modalHeaderText]=\"modalContent.title || 'Confirmation'\"\n    modalSize=\"modal-md\"\n    [isModalVisible]=\"isVisible\"\n    (isModalVisibleChange)=\"updateVisibilityStatus($event)\"\n    *ngIf=\"content | async as modalContent\"\n>\n    <p [innerHTML]=\"modalContent.htmlContent\"></p>\n\n    <div modal-footer>\n        <div class=\"d-flex justify-content-end mr-2 mb-2 mt-2\">\n            <button\n                id=\"confirmButton\"\n                class=\"btn btn-secondary\"\n                (click)=\"cancel()\"\n            >\n                {{ modalContent.cancelButtonLabel || 'Annuler' }}\n            </button>\n            <button\n                id=\"cancelButton\"\n                class=\"btn btn-primary ml-3\"\n                (click)=\"ok()\"\n            >\n                {{ modalContent.okButtonLabel || 'Confirmer' }}\n            </button>\n        </div>\n    </div>\n</foehn-modal>\n", components: [{ type: FoehnModalComponent, selector: "foehn-modal", inputs: ["id", "name", "modalSize", "modalBodyText", "modalHeaderText", "modalFooterText", "closeable", "modalTriggerHtmlElement", "isModalVisible"], outputs: ["isModalVisibleChange"] }], directives: [{ type: i3__namespace.NgIf, selector: "[ngIf]", inputs: ["ngIf", "ngIfThen", "ngIfElse"] }], pipes: { "async": i3__namespace.AsyncPipe } });
+    FoehnConfirmModalComponent.ɵcmp = i0__namespace.ɵɵngDeclareComponent({ minVersion: "12.0.0", version: "12.2.4", type: FoehnConfirmModalComponent, selector: "foehn-confirm-modal", ngImport: i0__namespace, template: "<foehn-modal\n    [modalHeaderText]=\"modalContent.title || 'Confirmation'\"\n    modalSize=\"modal-md\"\n    [isModalVisible]=\"isVisible\"\n    (isModalVisibleChange)=\"updateVisibilityStatus($event)\"\n    [closeable]=\"\n        modalContent.closeable !== null && modalContent.closeable !== undefined\n            ? modalContent.closeable\n            : true\n    \"\n    *ngIf=\"content | async as modalContent\"\n>\n    <p [innerHTML]=\"modalContent.htmlContent\"></p>\n\n    <div modal-footer>\n        <div class=\"d-flex justify-content-end mr-2 mb-2 mt-2\">\n            <button\n                id=\"confirmButton\"\n                class=\"btn btn-secondary\"\n                (click)=\"cancel()\"\n            >\n                {{ modalContent.cancelButtonLabel || 'Annuler' }}\n            </button>\n            <button\n                id=\"cancelButton\"\n                class=\"btn btn-primary ml-3\"\n                (click)=\"ok()\"\n            >\n                {{ modalContent.okButtonLabel || 'Confirmer' }}\n            </button>\n        </div>\n    </div>\n</foehn-modal>\n", components: [{ type: FoehnModalComponent, selector: "foehn-modal", inputs: ["id", "name", "modalSize", "modalBodyText", "modalHeaderText", "modalFooterText", "closeable", "modalTriggerHtmlElement", "isModalVisible"], outputs: ["isModalVisibleChange"] }], directives: [{ type: i3__namespace.NgIf, selector: "[ngIf]", inputs: ["ngIf", "ngIfThen", "ngIfElse"] }], pipes: { "async": i3__namespace.AsyncPipe } });
     i0__namespace.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "12.2.4", ngImport: i0__namespace, type: FoehnConfirmModalComponent, decorators: [{
                 type: i0.Component,
                 args: [{
@@ -5766,7 +5738,6 @@
             this.sessionInfo = sessionInfo;
             this.foehnPageModalService = foehnPageModalService;
             this.sdkDictionaryService = sdkDictionaryService;
-            this.neverConnected = false;
             this.supportAlertEnabled = true;
             this.userConnectedAsDisplayed = true;
             this.confirmLeavingAlert = {
@@ -9587,9 +9558,7 @@
                     }]
             }] });
 
-    var hasInputChanged$1 = function (change) { return !(!change ||
-        !change.currentValue ||
-        ObjectHelper.isEqual(change.previousValue, change.currentValue)); };
+    var hasInputChanged$1 = function (change) { return change && !ObjectHelper.isEqual(change.previousValue, change.currentValue); };
     var FoehnListComponent = /** @class */ (function () {
         function FoehnListComponent() {
             this.itemsPerPage = 10;
@@ -9747,9 +9716,7 @@
         return PageChangeEvent;
     }());
 
-    var hasInputChanged = function (change) { return !(!change ||
-        !change.currentValue ||
-        ObjectHelper.isEqual(change.previousValue, change.currentValue)); };
+    var hasInputChanged = function (change) { return change && !ObjectHelper.isEqual(change.previousValue, change.currentValue); };
     var FoehnTableComponent = /** @class */ (function () {
         function FoehnTableComponent() {
             this.itemsPerPage = 10;